From ef81994585fea0a3ad0dd2df7a58692890b1c5ff Mon Sep 17 00:00:00 2001 From: Merge Sim Date: Sat, 5 Sep 2026 15:15:22 -0700 Subject: [PATCH] docs(native-chat): correct a test title, simplify the alias, escape the path MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Review pass 4 came back clean; these are its three nits, all zero-behaviour. The read-restore test titled its fixture "a compacted remnant … has no log beside it", which is false — `rewriteJournalLog` always rewrote `log.jsonl`, so a compacted directory has both files. The fixture is still worth having as the log-is-gone case; only the title was wrong, a framing left over from before the source comment was corrected to the measured argument. `JournalDisclosure` is just `JournalRepairDisclosure`; two indexed accesses said the same thing at more length. The transcript path is interpolated into text that renders through `CommentMarkdown`, so a home directory containing underscores would have emphasised a segment of it. Backticked. The path still linkifies — the file-link plugin handles `inlineCode` nodes as well as text. --- .../agent-session-journal/journal-file-format-remnant.ts | 2 +- .../native-chat/agent-session-journal/journal-store-open.ts | 5 +---- .../structured-agent-session-read-restore.test.ts | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/main/native-chat/agent-session-journal/journal-file-format-remnant.ts b/src/main/native-chat/agent-session-journal/journal-file-format-remnant.ts index a2d24800c62..69dcc04bf64 100644 --- a/src/main/native-chat/agent-session-journal/journal-file-format-remnant.ts +++ b/src/main/native-chat/agent-session-journal/journal-file-format-remnant.ts @@ -53,7 +53,7 @@ export function journalFileFormatRemnantDisclosure(input: { `This chat's history was saved in an older format Orca no longer reads, so it starts ` + `empty. The session still points at the same ${formatAgentTypeLabel(input.agent)} ` + `conversation — send a message to pick up where you left off. The original ` + - `transcript is on the session's host at ${input.transcriptPath}` + `transcript is on the session's host at \`${input.transcriptPath}\`` ) } } diff --git a/src/main/native-chat/agent-session-journal/journal-store-open.ts b/src/main/native-chat/agent-session-journal/journal-store-open.ts index 0aaf699302c..721e5f4ba7f 100644 --- a/src/main/native-chat/agent-session-journal/journal-store-open.ts +++ b/src/main/native-chat/agent-session-journal/journal-store-open.ts @@ -9,10 +9,7 @@ import { journalRepairDisclosure, type JournalRepairDisclosure } from './journal /** What any of this file's disclosures hands the store — a repair's, or the * pre-SQLite notice's. Same shape, and neither is only a repair. */ -type JournalDisclosure = { - identity: JournalRepairDisclosure['identity'] - body: JournalRepairDisclosure['body'] -} +type JournalDisclosure = JournalRepairDisclosure export async function ensureJournalDir(journalDir: string): Promise { await mkdir(journalDir, { recursive: true }) diff --git a/src/main/native-chat/agent-session-wire/structured-agent-session-read-restore.test.ts b/src/main/native-chat/agent-session-wire/structured-agent-session-read-restore.test.ts index e4cdc4bc526..34e3fb8a4cf 100644 --- a/src/main/native-chat/agent-session-wire/structured-agent-session-read-restore.test.ts +++ b/src/main/native-chat/agent-session-wire/structured-agent-session-read-restore.test.ts @@ -85,7 +85,7 @@ describe('a session whose journal is still the pre-SQLite format', () => { expect(restored!.hasProviderChild).toBe(false) }) - it('is published for a compacted remnant too, which has no log beside it', async () => { + it('is published for a remnant whose log is gone', async () => { await writeRemnant('snapshot.json') const restored = await restoreStructuredAgentSessionRead(store, journalRoot, SESSION_ID)