mirror of
https://github.com/stablyai/orca.git
synced 2026-10-19 16:03:26 +00:00
fix(windows): close teardown review gaps
This commit is contained in:
@@ -32,7 +32,6 @@ on:
|
||||
- 'src/main/providers/**'
|
||||
- 'src/main/pty/**'
|
||||
- 'src/preload/**'
|
||||
- 'src/relay/**'
|
||||
- 'src/renderer/src/components/terminal/**'
|
||||
- 'src/renderer/src/components/terminal-pane/**'
|
||||
- 'src/renderer/src/lib/pane-manager/**'
|
||||
@@ -60,8 +59,8 @@ jobs:
|
||||
timeout-minutes: 30
|
||||
env:
|
||||
NODE_OPTIONS: --max-old-space-size=4096
|
||||
# Why: failed native connect cleanup is testable without shipping fault
|
||||
# injection in production node-pty builds.
|
||||
# Why: native connect/Job allocation cleanup is testable without shipping
|
||||
# fault injection in production node-pty builds.
|
||||
GYP_DEFINES: node_pty_test_faults=1
|
||||
|
||||
steps:
|
||||
@@ -86,14 +85,6 @@ jobs:
|
||||
- name: Install dependencies
|
||||
run: pnpm install --frozen-lockfile
|
||||
|
||||
- name: Run real Windows SSH relay Job integration
|
||||
shell: pwsh
|
||||
run: |
|
||||
node config/scripts/ensure-native-runtime.mjs --runtime=node
|
||||
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
|
||||
pnpm exec vitest run src/relay/windows-agent-job.integration.test.ts --config config/vitest.config.ts
|
||||
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
|
||||
|
||||
- name: Verify generated node-pty projects retain Spectre mitigation
|
||||
shell: pwsh
|
||||
run: |
|
||||
@@ -116,13 +107,16 @@ jobs:
|
||||
pnpm exec electron-vite build --mode e2e
|
||||
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
|
||||
|
||||
- name: Run patched node-pty failed-connect cleanup regressions
|
||||
- name: Run patched node-pty capability and cleanup regressions
|
||||
env:
|
||||
ELECTRON_RUN_AS_NODE: '1'
|
||||
NODE_PTY_REQUIRE_TEST_FAULTS: '1'
|
||||
run: >-
|
||||
pnpm exec electron
|
||||
node_modules/node-pty/lib/conptyConnectFailure.test.js
|
||||
shell: pwsh
|
||||
run: |
|
||||
pnpm exec electron node_modules/node-pty/lib/conptyConnectFailure.test.js
|
||||
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
|
||||
pnpm exec electron node_modules/node-pty/lib/conptyJobTerminationFailure.test.js
|
||||
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
|
||||
|
||||
- name: Run Windows terminal restart regressions
|
||||
env:
|
||||
|
||||
Reference in New Issue
Block a user