From f181b3365cb29df5b074746a3d3eb438f1c0e031 Mon Sep 17 00:00:00 2001 From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Date: Mon, 27 Jul 2026 16:49:47 -0700 Subject: [PATCH] style: trim review comments to the one-line house rule Both explained the change adequately in two lines; the extra lines were worked examples, not information. --- .../editor/rich-markdown-editor-click-routing.test.ts | 5 ++--- src/renderer/src/components/settings/browser-search.ts | 7 ++----- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/renderer/src/components/editor/rich-markdown-editor-click-routing.test.ts b/src/renderer/src/components/editor/rich-markdown-editor-click-routing.test.ts index abd447bf485..943d75af8bd 100644 --- a/src/renderer/src/components/editor/rich-markdown-editor-click-routing.test.ts +++ b/src/renderer/src/components/editor/rich-markdown-editor-click-routing.test.ts @@ -14,9 +14,8 @@ beforeEach(() => { openHttpLinkMock.mockReset() }) -// Why: the preview half of this same decision is pinned with an identical options -// shape in markdown-preview-links.test.ts — the two together keep the editor and -// preview of one file from routing a link two different ways. +// Why: markdown-preview-links.test.ts pins the preview half with the same options +// shape, so together they stop one file's link routing two ways. function clickExternalLinkWithShift(sourceOwner: HttpLinkSourceOwner, isMac = true): boolean { const href = 'https://example.com/docs' const view = { diff --git a/src/renderer/src/components/settings/browser-search.ts b/src/renderer/src/components/settings/browser-search.ts index 8e656ca3cbb..47b61c6f3fe 100644 --- a/src/renderer/src/components/settings/browser-search.ts +++ b/src/renderer/src/components/settings/browser-search.ts @@ -16,11 +16,8 @@ function getDefaultBrowserShortcutPlatform(): BrowserShortcutPlatform { } } -// Why: the modifier sentence moved to the nested "Hold Shift to open in …" row. -// Once that row can invert the routing, no single sentence here is true in every -// state — "always uses your system browser" breaks when inverting is on, and -// "opens a link the other way" breaks in the default state where it is off. The -// chord is now stated only by the child row, which knows the live destination. +// Why: no fixed modifier sentence is true in every state once inverting exists, so +// the nested row states the chord instead — it knows the live destination. export function getBrowserLinkRoutingDescription(): string { return "Open http(s) links in Orca's built-in browser — from the terminal, markdown, and the editor." }