From f83c1b80c278c3df2bba7cebe1fdcf4261cfe52a Mon Sep 17 00:00:00 2001 From: Jinwoo-H Date: Mon, 11 May 2026 03:37:08 -0400 Subject: [PATCH] comment(ssh-relay): TODO link to #1693 for VS Code-style pre-bundled node-pty Co-authored-by: Orca --- src/main/ssh/ssh-relay-deploy.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/main/ssh/ssh-relay-deploy.ts b/src/main/ssh/ssh-relay-deploy.ts index 747582d4713..9f4c1954b0d 100644 --- a/src/main/ssh/ssh-relay-deploy.ts +++ b/src/main/ssh/ssh-relay-deploy.ts @@ -219,6 +219,11 @@ async function uploadRelay( // be compiled on the remote host against its Node.js version and OS. We // write a minimal package.json + run `npm install node-pty` in the relay // directory so `require('node-pty')` resolves to the local node_modules. +// +// TODO(#1693): VS Code ships per-platform tarballs with node-pty pre-built +// from CI and skips `npm install` on the remote entirely. That approach +// eliminates the whole class of bugs around npm/compiler/network failures +// on the remote. Worth doing once we're past the immediate fix. async function installNativeDeps(conn: SshConnection, remoteDir: string): Promise { const nodePath = await resolveRemoteNodePath(conn) // Why: node's bin directory must be in PATH for npm's child processes.