From ff1d66e75335ba8addbcbea3da5dfbeb6ca83e80 Mon Sep 17 00:00:00 2001 From: Neil <4138956+nwparker@users.noreply.github.com> Date: Sun, 6 Sep 2026 09:22:42 -0700 Subject: [PATCH] test: declare SSH client dependency and narrow browser fixture routing --- .github/workflows/e2e.yml | 2 ++ config/scripts/pr-e2e-source-routing.mjs | 2 +- config/scripts/ssh-browser-e2e-routing.test.mjs | 3 +++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index e01d82430ef..e000cdab4ba 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -368,6 +368,8 @@ jobs: - uses: ./.github/actions/install-node-dependencies with: native-runtime: node + - name: Install SSH client + run: sudo apt-get update && sudo apt-get install -y openssh-client - name: Run Docker SSH browser network route journeys env: ORCA_BACKGROUND_LAUNCH: '1' diff --git a/config/scripts/pr-e2e-source-routing.mjs b/config/scripts/pr-e2e-source-routing.mjs index c060ea415e4..4b1c1930892 100644 --- a/config/scripts/pr-e2e-source-routing.mjs +++ b/config/scripts/pr-e2e-source-routing.mjs @@ -18,7 +18,7 @@ export const PR_E2E_SOURCE_ROUTES = [ specs: ['tests/e2e/ssh-browser-network-execution-route.docker.unit.test.ts'], matches: (file) => file === 'tests/e2e/ssh-browser-network-execution-route.docker.unit.test.ts' || - /^tests\/e2e\/helpers\/docker-ssh-relay-[\w-]+\.ts$/.test(file) || + /^tests\/e2e\/helpers\/docker-ssh-relay-(?:image|target)\.ts$/.test(file) || (isProductSource(file) && /^src\/main\/(?:browser\/(?:ssh-browser-network-execution-route|browser-network-deferred-socket|browser-network-execution-route|system-ssh-socks-client-socket)|ssh\/system-ssh-dynamic-forward-process)\.ts$/.test( file diff --git a/config/scripts/ssh-browser-e2e-routing.test.mjs b/config/scripts/ssh-browser-e2e-routing.test.mjs index a261dbc29df..0b46131cf14 100644 --- a/config/scripts/ssh-browser-e2e-routing.test.mjs +++ b/config/scripts/ssh-browser-e2e-routing.test.mjs @@ -58,4 +58,7 @@ it('executes both Docker network routes in a Node job with their opt-in enabled' expect(selectPrE2eSpecs([changed])).toContain(spec) } expect(selectPrE2eSpecs(['src/renderer/src/components/Unrelated.tsx'])).not.toContain(spec) + expect(selectPrE2eSpecs(['tests/e2e/helpers/docker-ssh-relay-terminal-tabs.ts'])).not.toContain( + spec + ) })