From ff61a7b44adfec90b49efe2bb9d6c34822df7f84 Mon Sep 17 00:00:00 2001 From: Jinwoo-H Date: Sun, 13 Sep 2026 19:56:13 -0400 Subject: [PATCH] test(mobile): record teardown observations as a cleanup checkpoint Each checkpoint clones the effects array, so a rejection or state write produced by dispose, the transport teardown or the final flush landed after the recording was built and never reached a golden. An unmount leak is exactly what this oracle exists to catch, so teardown now runs on the recorded path and anything it observes becomes a checkpoint with id `cleanup`. State is captured before dispose, since the operation is gone afterwards. Six scenarios were dropping observations, across five goldens: projectRowDetailError, projectMutating, hostLabelById, hostPlatform, workspaceAgent, workspaceAgentOverridden, creatingKey, selectedAgent, agentOverridden and error. Those five gain a cleanup checkpoint; the other 68 goldens change by their header line only, so no existing observation moved. Also fixes the README's own formatting, which failed `format:check`. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb --- mobile/rpc-foundation/goldens/b1.json | 2 +- mobile/rpc-foundation/goldens/b2.json | 2 +- mobile/rpc-foundation/goldens/b3.json | 2 +- .../interruptions-inventory-lifecycle.json | 2 +- ...ions-settings-bot-overrides-fulfilled.json | 2 +- .../goldens/inventory-lifecycle.json | 2 +- .../goldens/inventory-repeat-query.json | 2 +- .../rpc-foundation/goldens/lifecycle-b3.json | 2 +- .../lifecycle-inventory-lifecycle.json | 2 +- ...ycle-settings-bot-overrides-fulfilled.json | 2 +- ...cle-settings-task-hydration-fulfilled.json | 2 +- ...-settings-workspace-context-fulfilled.json | 2 +- .../goldens/matrix-legacy-inventory.json | 2 +- .../goldens/matrix-linear-detail-barrier.json | 2 +- .../matrix-project-explicit-false.json | 65 +++- .../goldens/matrix-settings-agent-read.json | 2 +- .../goldens/matrix-settings-best-effort.json | 2 +- .../matrix-settings.bot-overrides.json | 2 +- .../matrix-settings.home-providers.json | 2 +- .../matrix-settings.repo-metadata.json | 197 ++++++++++- .../matrix-settings.resume-metadata.json | 2 +- .../matrix-settings.task-hydration.json | 2 +- .../matrix-settings.task-workspace.json | 45 ++- .../matrix-settings.workspace-context.json | 2 +- .../matrix-settings.workspace-submit.json | 311 +++++++++++++++++- .../goldens/probe-new-tab-both-refused.json | 2 +- .../probe-new-tab-null-sibling-refused.json | 2 +- ...probe-new-tab-refused-sibling-rejects.json | 2 +- ...probe-new-tab-rejects-sibling-refused.json | 2 +- .../rpc-foundation/goldens/schedules-b3.json | 2 +- ...les-settings-home-providers-fulfilled.json | 2 +- .../schedules-settings-new-tab-ssh.json | 2 +- ...ules-settings-repo-metadata-fulfilled.json | 160 ++++++++- ...es-settings-resume-metadata-fulfilled.json | 2 +- ...les-settings-task-hydration-fulfilled.json | 2 +- ...-settings-workspace-context-fulfilled.json | 2 +- .../settings-bot-overrides-fulfilled.json | 2 +- ...ettings-bot-overrides-refresh-refused.json | 2 +- .../settings-bot-overrides-refused.json | 2 +- ...ettings-bot-overrides-transport-error.json | 2 +- .../goldens/settings-home-coalesced.json | 2 +- .../settings-home-providers-fulfilled.json | 2 +- ...ings-home-providers-refuse-after-data.json | 2 +- .../settings-home-providers-refused.json | 2 +- ...ttings-home-providers-transport-error.json | 2 +- .../goldens/settings-new-tab-refused.json | 2 +- .../goldens/settings-new-tab-ssh.json | 2 +- .../settings-new-tab-transport-error.json | 2 +- .../goldens/settings-repo-cache-expiry.json | 2 +- .../settings-repo-metadata-fulfilled.json | 2 +- ...tings-repo-metadata-refuse-after-data.json | 2 +- .../settings-repo-metadata-refused.json | 2 +- .../settings-repo-metadata-single-host.json | 2 +- ...ettings-repo-metadata-transport-error.json | 2 +- .../settings-resume-metadata-fulfilled.json | 2 +- ...ngs-resume-metadata-refuse-after-data.json | 2 +- .../settings-resume-metadata-refused.json | 2 +- ...tings-resume-metadata-transport-error.json | 2 +- .../settings-task-hydration-fulfilled.json | 2 +- ...ings-task-hydration-refuse-after-data.json | 2 +- .../settings-task-hydration-refused.json | 2 +- ...ttings-task-hydration-transport-error.json | 2 +- .../settings-task-workspace-fulfilled.json | 2 +- .../settings-task-workspace-refused.json | 2 +- ...ttings-task-workspace-transport-error.json | 2 +- .../goldens/settings-task-write.json | 2 +- .../settings-workspace-context-fulfilled.json | 2 +- ...s-workspace-context-refuse-after-data.json | 2 +- .../settings-workspace-context-refused.json | 2 +- ...ngs-workspace-context-transport-error.json | 2 +- .../settings-workspace-submit-fulfilled.json | 2 +- .../settings-workspace-submit-refused.json | 2 +- ...ings-workspace-submit-transport-error.json | 2 +- .../src/test-support/rpc-recording/README.md | 31 +- .../rpc-recording/run-recording.ts | 52 +-- 75 files changed, 886 insertions(+), 111 deletions(-) diff --git a/mobile/rpc-foundation/goldens/b1.json b/mobile/rpc-foundation/goldens/b1.json index e051120d933..0344c71b950 100644 --- a/mobile/rpc-foundation/goldens/b1.json +++ b/mobile/rpc-foundation/goldens/b1.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/b2.json b/mobile/rpc-foundation/goldens/b2.json index b7d8db684c6..8412ef48472 100644 --- a/mobile/rpc-foundation/goldens/b2.json +++ b/mobile/rpc-foundation/goldens/b2.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/b3.json b/mobile/rpc-foundation/goldens/b3.json index 7e7dbf6dac6..d1af48b1abb 100644 --- a/mobile/rpc-foundation/goldens/b3.json +++ b/mobile/rpc-foundation/goldens/b3.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/interruptions-inventory-lifecycle.json b/mobile/rpc-foundation/goldens/interruptions-inventory-lifecycle.json index ec9f767c36c..60ac45fad6f 100644 --- a/mobile/rpc-foundation/goldens/interruptions-inventory-lifecycle.json +++ b/mobile/rpc-foundation/goldens/interruptions-inventory-lifecycle.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/interruptions-settings-bot-overrides-fulfilled.json b/mobile/rpc-foundation/goldens/interruptions-settings-bot-overrides-fulfilled.json index 3c659c882bc..cc1beeba9c5 100644 --- a/mobile/rpc-foundation/goldens/interruptions-settings-bot-overrides-fulfilled.json +++ b/mobile/rpc-foundation/goldens/interruptions-settings-bot-overrides-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/inventory-lifecycle.json b/mobile/rpc-foundation/goldens/inventory-lifecycle.json index d3c6a0104d1..210eb26de72 100644 --- a/mobile/rpc-foundation/goldens/inventory-lifecycle.json +++ b/mobile/rpc-foundation/goldens/inventory-lifecycle.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/inventory-repeat-query.json b/mobile/rpc-foundation/goldens/inventory-repeat-query.json index 327fde371d3..37da87d52b6 100644 --- a/mobile/rpc-foundation/goldens/inventory-repeat-query.json +++ b/mobile/rpc-foundation/goldens/inventory-repeat-query.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/lifecycle-b3.json b/mobile/rpc-foundation/goldens/lifecycle-b3.json index 13bbe3f6acb..c52b3647409 100644 --- a/mobile/rpc-foundation/goldens/lifecycle-b3.json +++ b/mobile/rpc-foundation/goldens/lifecycle-b3.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/lifecycle-inventory-lifecycle.json b/mobile/rpc-foundation/goldens/lifecycle-inventory-lifecycle.json index c616c2245af..b4b7fd222f2 100644 --- a/mobile/rpc-foundation/goldens/lifecycle-inventory-lifecycle.json +++ b/mobile/rpc-foundation/goldens/lifecycle-inventory-lifecycle.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/lifecycle-settings-bot-overrides-fulfilled.json b/mobile/rpc-foundation/goldens/lifecycle-settings-bot-overrides-fulfilled.json index 3370db50551..48f149fc2b1 100644 --- a/mobile/rpc-foundation/goldens/lifecycle-settings-bot-overrides-fulfilled.json +++ b/mobile/rpc-foundation/goldens/lifecycle-settings-bot-overrides-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/lifecycle-settings-task-hydration-fulfilled.json b/mobile/rpc-foundation/goldens/lifecycle-settings-task-hydration-fulfilled.json index 4a149581289..bdced1aee1a 100644 --- a/mobile/rpc-foundation/goldens/lifecycle-settings-task-hydration-fulfilled.json +++ b/mobile/rpc-foundation/goldens/lifecycle-settings-task-hydration-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/lifecycle-settings-workspace-context-fulfilled.json b/mobile/rpc-foundation/goldens/lifecycle-settings-workspace-context-fulfilled.json index e477e7b33a4..fbe3dc01917 100644 --- a/mobile/rpc-foundation/goldens/lifecycle-settings-workspace-context-fulfilled.json +++ b/mobile/rpc-foundation/goldens/lifecycle-settings-workspace-context-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/matrix-legacy-inventory.json b/mobile/rpc-foundation/goldens/matrix-legacy-inventory.json index 8700d9063c3..2eef55c749e 100644 --- a/mobile/rpc-foundation/goldens/matrix-legacy-inventory.json +++ b/mobile/rpc-foundation/goldens/matrix-legacy-inventory.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/matrix-linear-detail-barrier.json b/mobile/rpc-foundation/goldens/matrix-linear-detail-barrier.json index 490fc003de8..80aaac19917 100644 --- a/mobile/rpc-foundation/goldens/matrix-linear-detail-barrier.json +++ b/mobile/rpc-foundation/goldens/matrix-linear-detail-barrier.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/matrix-project-explicit-false.json b/mobile/rpc-foundation/goldens/matrix-project-explicit-false.json index 10226f0a890..d8c8b900b3d 100644 --- a/mobile/rpc-foundation/goldens/matrix-project-explicit-false.json +++ b/mobile/rpc-foundation/goldens/matrix-project-explicit-false.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, @@ -282,6 +282,59 @@ "itemType": "ISSUE" } }, + "602c739007cd": [ + { + "name": "projectMutating", + "value": true + }, + { + "name": "projectRowDetailError", + "value": "Connection closed" + }, + { + "name": "projectMutating", + "value": false + } + ], + "699c2c3a725a": [ + { + "name": "github.project.updateIssueBySlug#1", + "args": [ + { + "name": "method", + "value": "github.project.updateIssueBySlug" + }, + { + "name": "params", + "value": { + "host": "github.enterprise.test", + "number": 1, + "owner": "owner", + "repo": "repo", + "updates": { + "addLabels": ["recorded"] + } + } + }, + { + "name": "options", + "value": { + "timeoutMs": 30000 + } + } + ], + "settlement": { + "status": "rejected", + "startedAt": 0, + "settledAt": 0, + "error": { + "category": "Error", + "message": "Connection closed", + "isRpcDeliveryUnknown": true + } + } + } + ], "6dfef4ef572b": { "mount": { "status": "fulfilled", @@ -757,6 +810,16 @@ "effects": "3b9a7724526d" } }, + { + "id": "b2.prelude:cleanup", + "observation": { + "sender": "699c2c3a725a", + "payloads": "0318f81a142b", + "settlements": "6dfef4ef572b", + "state": "0c4dced3e005", + "effects": "602c739007cd" + } + }, { "id": "b2.normal:settled", "observation": { diff --git a/mobile/rpc-foundation/goldens/matrix-settings-agent-read.json b/mobile/rpc-foundation/goldens/matrix-settings-agent-read.json index 44be19d7177..7d25a4a4ae9 100644 --- a/mobile/rpc-foundation/goldens/matrix-settings-agent-read.json +++ b/mobile/rpc-foundation/goldens/matrix-settings-agent-read.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/matrix-settings-best-effort.json b/mobile/rpc-foundation/goldens/matrix-settings-best-effort.json index 36237ece50a..c12a0601155 100644 --- a/mobile/rpc-foundation/goldens/matrix-settings-best-effort.json +++ b/mobile/rpc-foundation/goldens/matrix-settings-best-effort.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/matrix-settings.bot-overrides.json b/mobile/rpc-foundation/goldens/matrix-settings.bot-overrides.json index 2787a9def71..5a6b7446347 100644 --- a/mobile/rpc-foundation/goldens/matrix-settings.bot-overrides.json +++ b/mobile/rpc-foundation/goldens/matrix-settings.bot-overrides.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/matrix-settings.home-providers.json b/mobile/rpc-foundation/goldens/matrix-settings.home-providers.json index 28ac0ff6d0b..f30f4879ba6 100644 --- a/mobile/rpc-foundation/goldens/matrix-settings.home-providers.json +++ b/mobile/rpc-foundation/goldens/matrix-settings.home-providers.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/matrix-settings.repo-metadata.json b/mobile/rpc-foundation/goldens/matrix-settings.repo-metadata.json index 274dad79284..123969a2307 100644 --- a/mobile/rpc-foundation/goldens/matrix-settings.repo-metadata.json +++ b/mobile/rpc-foundation/goldens/matrix-settings.repo-metadata.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, @@ -361,6 +361,43 @@ } } ], + "564017ad6e41": [ + { + "name": "repoColorsByName", + "value": [ + ["Local", "#6366f1"], + ["Remote", "#f97316"] + ] + }, + { + "name": "repoIconsByName", + "value": [] + }, + { + "name": "repoIdsByName", + "value": [ + ["Local", "repo-1"], + ["Remote", "repo-2"] + ] + }, + { + "name": "repoHostIdByRepoId", + "value": [ + ["repo-1", "local"], + ["repo-2", "ssh:ssh-1"] + ] + }, + { + "name": "hostLabelById", + "value": [["ssh:ssh-1", "SSH"]] + }, + { + "name": "hostPlatform", + "value": { + "$rpc": "null" + } + } + ], "6134b73f18d0": { "repoColorsByName": [ ["Local", "#6366f1"], @@ -1323,6 +1360,154 @@ } } ], + "d86984df7ae5": [ + { + "name": "repo.list#1", + "args": [ + { + "name": "method", + "value": "repo.list" + }, + { + "name": "params", + "value": { + "$rpc": "absent" + } + }, + { + "name": "options", + "value": { + "$rpc": "absent" + } + } + ], + "settlement": { + "status": "fulfilled", + "startedAt": 0, + "settledAt": 0, + "value": { + "id": "frame-1", + "ok": true, + "result": { + "repos": [ + { + "connectionId": { + "$rpc": "null" + }, + "displayName": "Local", + "id": "repo-1" + }, + { + "connectionId": "ssh-1", + "displayName": "Remote", + "id": "repo-2" + } + ] + } + } + } + }, + { + "name": "ssh.listTargetSummaries#1", + "args": [ + { + "name": "method", + "value": "ssh.listTargetSummaries" + }, + { + "name": "params", + "value": { + "$rpc": "absent" + } + }, + { + "name": "options", + "value": { + "$rpc": "absent" + } + } + ], + "settlement": { + "status": "fulfilled", + "startedAt": 0, + "settledAt": 0, + "value": { + "id": "frame-2", + "ok": true, + "result": { + "targets": [ + { + "id": "ssh-1", + "label": "SSH" + } + ] + } + } + } + }, + { + "name": "settings.get#1", + "args": [ + { + "name": "method", + "value": "settings.get" + }, + { + "name": "params", + "value": { + "$rpc": "absent" + } + }, + { + "name": "options", + "value": { + "$rpc": "absent" + } + } + ], + "settlement": { + "status": "rejected", + "startedAt": 0, + "settledAt": 0, + "error": { + "category": "Error", + "message": "Connection closed", + "isRpcDeliveryUnknown": true + } + } + }, + { + "name": "host.platform#1", + "args": [ + { + "name": "method", + "value": "host.platform" + }, + { + "name": "params", + "value": { + "$rpc": "absent" + } + }, + { + "name": "options", + "value": { + "$rpc": "absent" + } + } + ], + "settlement": { + "status": "rejected", + "startedAt": 0, + "settledAt": 0, + "error": { + "category": "Error", + "message": "Connection closed", + "isRpcDeliveryUnknown": true + } + } + } + ], "dda2a4a55813": [ { "name": "repo.list#1", @@ -1689,6 +1874,16 @@ "effects": "3d1e2998e81c" } }, + { + "id": "settings-repo-metadata-fulfilled.prelude:cleanup", + "observation": { + "sender": "d86984df7ae5", + "payloads": "83ef5f7039bf", + "settlements": "2bf0f26c9185", + "state": "6134b73f18d0", + "effects": "564017ad6e41" + } + }, { "id": "settings-repo-metadata-fulfilled.normal:settled", "observation": { diff --git a/mobile/rpc-foundation/goldens/matrix-settings.resume-metadata.json b/mobile/rpc-foundation/goldens/matrix-settings.resume-metadata.json index 1fc9ced9ef3..1ef12d48a13 100644 --- a/mobile/rpc-foundation/goldens/matrix-settings.resume-metadata.json +++ b/mobile/rpc-foundation/goldens/matrix-settings.resume-metadata.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/matrix-settings.task-hydration.json b/mobile/rpc-foundation/goldens/matrix-settings.task-hydration.json index 4d5878c370b..fef1db3a4de 100644 --- a/mobile/rpc-foundation/goldens/matrix-settings.task-hydration.json +++ b/mobile/rpc-foundation/goldens/matrix-settings.task-hydration.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/matrix-settings.task-workspace.json b/mobile/rpc-foundation/goldens/matrix-settings.task-workspace.json index adfa5c669ef..0f99d420035 100644 --- a/mobile/rpc-foundation/goldens/matrix-settings.task-workspace.json +++ b/mobile/rpc-foundation/goldens/matrix-settings.task-workspace.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, @@ -517,6 +517,39 @@ } } ], + "d0feb81f9400": [ + { + "name": "settings.get#1", + "args": [ + { + "name": "method", + "value": "settings.get" + }, + { + "name": "params", + "value": { + "$rpc": "absent" + } + }, + { + "name": "options", + "value": { + "$rpc": "absent" + } + } + ], + "settlement": { + "status": "rejected", + "startedAt": 0, + "settledAt": 0, + "error": { + "category": "Error", + "message": "Connection closed", + "isRpcDeliveryUnknown": true + } + } + } + ], "d5df3f6b123a": { "creating": { "$rpc": "null" @@ -587,6 +620,16 @@ "effects": "b05ebf557542" } }, + { + "id": "settings-task-workspace-fulfilled.prelude:cleanup", + "observation": { + "sender": "d0feb81f9400", + "payloads": "9e493785145e", + "settlements": "6dfef4ef572b", + "state": "7abdfe20af50", + "effects": "236832733364" + } + }, { "id": "settings-task-workspace-fulfilled.normal:settled", "observation": { diff --git a/mobile/rpc-foundation/goldens/matrix-settings.workspace-context.json b/mobile/rpc-foundation/goldens/matrix-settings.workspace-context.json index af3e9b1802f..1168087cdc0 100644 --- a/mobile/rpc-foundation/goldens/matrix-settings.workspace-context.json +++ b/mobile/rpc-foundation/goldens/matrix-settings.workspace-context.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/matrix-settings.workspace-submit.json b/mobile/rpc-foundation/goldens/matrix-settings.workspace-submit.json index 30c9f610c25..58c3ecf4ff3 100644 --- a/mobile/rpc-foundation/goldens/matrix-settings.workspace-submit.json +++ b/mobile/rpc-foundation/goldens/matrix-settings.workspace-submit.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, @@ -398,6 +398,167 @@ "$rpc": "undefined" } }, + "7d3f625823b0": [ + { + "name": "settings.get#1", + "args": [ + { + "name": "method", + "value": "settings.get" + }, + { + "name": "params", + "value": { + "$rpc": "absent" + } + }, + { + "name": "options", + "value": { + "$rpc": "absent" + } + } + ], + "settlement": { + "status": "fulfilled", + "startedAt": 0, + "settledAt": 0, + "value": { + "id": "frame-1", + "ok": true, + "result": { + "error": "refused" + } + } + } + }, + { + "name": "worktree.create#1", + "args": [ + { + "name": "method", + "value": "worktree.create" + }, + { + "name": "params", + "value": { + "createdWithAgent": "claude", + "displayName": "recorded", + "displayNameKind": "user", + "name": "recorded", + "repo": "id:repo-1", + "setupDecision": "inherit", + "startupAgent": "claude" + } + }, + { + "name": "options", + "value": { + "timeoutMs": 600000 + } + } + ], + "settlement": { + "status": "rejected", + "startedAt": 0, + "settledAt": 0, + "error": { + "category": "Error", + "message": "Connection closed", + "isRpcDeliveryUnknown": true + } + } + } + ], + "804e01fabd3a": [ + { + "name": "settings.get#1", + "args": [ + { + "name": "method", + "value": "settings.get" + }, + { + "name": "params", + "value": { + "$rpc": "absent" + } + }, + { + "name": "options", + "value": { + "$rpc": "absent" + } + } + ], + "settlement": { + "status": "fulfilled", + "startedAt": 0, + "settledAt": 0, + "value": { + "id": "frame-1", + "ok": true, + "result": { + "error": "inner refused", + "ok": false + } + } + } + }, + { + "name": "worktree.create#1", + "args": [ + { + "name": "method", + "value": "worktree.create" + }, + { + "name": "params", + "value": { + "createdWithAgent": "claude", + "displayName": "recorded", + "displayNameKind": "user", + "name": "recorded", + "repo": "id:repo-1", + "setupDecision": "inherit", + "startupAgent": "claude" + } + }, + { + "name": "options", + "value": { + "timeoutMs": 600000 + } + } + ], + "settlement": { + "status": "rejected", + "startedAt": 0, + "settledAt": 0, + "error": { + "category": "Error", + "message": "Connection closed", + "isRpcDeliveryUnknown": true + } + } + } + ], + "979a2540cb0d": [ + { + "name": "error", + "value": "" + }, + { + "name": "runtimeSettings", + "value": { + "$rpc": "undefined" + } + }, + { + "name": "error", + "value": "Connection closed" + } + ], "9c753d3a11f2": [ { "name": "settings.get#1", @@ -516,6 +677,114 @@ } } ], + "d0feb81f9400": [ + { + "name": "settings.get#1", + "args": [ + { + "name": "method", + "value": "settings.get" + }, + { + "name": "params", + "value": { + "$rpc": "absent" + } + }, + { + "name": "options", + "value": { + "$rpc": "absent" + } + } + ], + "settlement": { + "status": "rejected", + "startedAt": 0, + "settledAt": 0, + "error": { + "category": "Error", + "message": "Connection closed", + "isRpcDeliveryUnknown": true + } + } + } + ], + "e0e544213c3c": [ + { + "name": "settings.get#1", + "args": [ + { + "name": "method", + "value": "settings.get" + }, + { + "name": "params", + "value": { + "$rpc": "absent" + } + }, + { + "name": "options", + "value": { + "$rpc": "absent" + } + } + ], + "settlement": { + "status": "fulfilled", + "startedAt": 0, + "settledAt": 0, + "value": { + "id": "frame-1", + "ok": true, + "result": { + "error": { + "message": "inner refused" + }, + "ok": false + } + } + } + }, + { + "name": "worktree.create#1", + "args": [ + { + "name": "method", + "value": "worktree.create" + }, + { + "name": "params", + "value": { + "createdWithAgent": "claude", + "displayName": "recorded", + "displayNameKind": "user", + "name": "recorded", + "repo": "id:repo-1", + "setupDecision": "inherit", + "startupAgent": "claude" + } + }, + { + "name": "options", + "value": { + "timeoutMs": 600000 + } + } + ], + "settlement": { + "status": "rejected", + "startedAt": 0, + "settledAt": 0, + "error": { + "category": "Error", + "message": "Connection closed", + "isRpcDeliveryUnknown": true + } + } + } + ], "f117d93cf44a": { "mount": { "status": "fulfilled", @@ -644,6 +913,16 @@ "effects": "c0cb3df4feef" } }, + { + "id": "settings-workspace-submit-fulfilled.prelude:cleanup", + "observation": { + "sender": "d0feb81f9400", + "payloads": "9e493785145e", + "settlements": "6dfef4ef572b", + "state": "13c996e4ec2b", + "effects": "0e315dbfe7a8" + } + }, { "id": "settings-workspace-submit-fulfilled.normal:settled", "observation": { @@ -684,6 +963,16 @@ "effects": "450706871c5d" } }, + { + "id": "settings-workspace-submit-fulfilled.inner-ok-missing:cleanup", + "observation": { + "sender": "7d3f625823b0", + "payloads": "20a67073e822", + "settlements": "6dfef4ef572b", + "state": "7b1c9637063f", + "effects": "979a2540cb0d" + } + }, { "id": "settings-workspace-submit-fulfilled.inner-false-string-error:settled", "observation": { @@ -694,6 +983,16 @@ "effects": "450706871c5d" } }, + { + "id": "settings-workspace-submit-fulfilled.inner-false-string-error:cleanup", + "observation": { + "sender": "804e01fabd3a", + "payloads": "20a67073e822", + "settlements": "6dfef4ef572b", + "state": "7b1c9637063f", + "effects": "979a2540cb0d" + } + }, { "id": "settings-workspace-submit-fulfilled.inner-false-object-error:settled", "observation": { @@ -704,6 +1003,16 @@ "effects": "450706871c5d" } }, + { + "id": "settings-workspace-submit-fulfilled.inner-false-object-error:cleanup", + "observation": { + "sender": "e0e544213c3c", + "payloads": "20a67073e822", + "settlements": "6dfef4ef572b", + "state": "7b1c9637063f", + "effects": "979a2540cb0d" + } + }, { "id": "settings-workspace-submit-fulfilled.outer-refused:settled", "observation": { diff --git a/mobile/rpc-foundation/goldens/probe-new-tab-both-refused.json b/mobile/rpc-foundation/goldens/probe-new-tab-both-refused.json index 4a1bcc6ee5c..5fbdf03a794 100644 --- a/mobile/rpc-foundation/goldens/probe-new-tab-both-refused.json +++ b/mobile/rpc-foundation/goldens/probe-new-tab-both-refused.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/probe-new-tab-null-sibling-refused.json b/mobile/rpc-foundation/goldens/probe-new-tab-null-sibling-refused.json index dfafc38a44d..f429e95c568 100644 --- a/mobile/rpc-foundation/goldens/probe-new-tab-null-sibling-refused.json +++ b/mobile/rpc-foundation/goldens/probe-new-tab-null-sibling-refused.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/probe-new-tab-refused-sibling-rejects.json b/mobile/rpc-foundation/goldens/probe-new-tab-refused-sibling-rejects.json index 769359b4bef..a0fd3b26d17 100644 --- a/mobile/rpc-foundation/goldens/probe-new-tab-refused-sibling-rejects.json +++ b/mobile/rpc-foundation/goldens/probe-new-tab-refused-sibling-rejects.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/probe-new-tab-rejects-sibling-refused.json b/mobile/rpc-foundation/goldens/probe-new-tab-rejects-sibling-refused.json index 4682299fc80..53bb06cae5b 100644 --- a/mobile/rpc-foundation/goldens/probe-new-tab-rejects-sibling-refused.json +++ b/mobile/rpc-foundation/goldens/probe-new-tab-rejects-sibling-refused.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/schedules-b3.json b/mobile/rpc-foundation/goldens/schedules-b3.json index 6a4fc1f4849..d99eadb3bd7 100644 --- a/mobile/rpc-foundation/goldens/schedules-b3.json +++ b/mobile/rpc-foundation/goldens/schedules-b3.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/schedules-settings-home-providers-fulfilled.json b/mobile/rpc-foundation/goldens/schedules-settings-home-providers-fulfilled.json index 7bba06780db..46abc7f6e8b 100644 --- a/mobile/rpc-foundation/goldens/schedules-settings-home-providers-fulfilled.json +++ b/mobile/rpc-foundation/goldens/schedules-settings-home-providers-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/schedules-settings-new-tab-ssh.json b/mobile/rpc-foundation/goldens/schedules-settings-new-tab-ssh.json index 4739b4ae754..8428c1ebf89 100644 --- a/mobile/rpc-foundation/goldens/schedules-settings-new-tab-ssh.json +++ b/mobile/rpc-foundation/goldens/schedules-settings-new-tab-ssh.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/schedules-settings-repo-metadata-fulfilled.json b/mobile/rpc-foundation/goldens/schedules-settings-repo-metadata-fulfilled.json index 9825dd49f93..48534091d84 100644 --- a/mobile/rpc-foundation/goldens/schedules-settings-repo-metadata-fulfilled.json +++ b/mobile/rpc-foundation/goldens/schedules-settings-repo-metadata-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, @@ -170,6 +170,154 @@ } } ], + "0f1d92eb06c4": [ + { + "name": "repo.list#1", + "args": [ + { + "name": "method", + "value": "repo.list" + }, + { + "name": "params", + "value": { + "$rpc": "absent" + } + }, + { + "name": "options", + "value": { + "$rpc": "absent" + } + } + ], + "settlement": { + "status": "fulfilled", + "startedAt": 0, + "settledAt": 0, + "value": { + "id": "frame-1", + "ok": true, + "result": { + "repos": [ + { + "connectionId": { + "$rpc": "null" + }, + "displayName": "Local", + "id": "repo-1" + }, + { + "connectionId": "ssh-1", + "displayName": "Remote", + "id": "repo-2" + } + ] + } + } + } + }, + { + "name": "ssh.listTargetSummaries#1", + "args": [ + { + "name": "method", + "value": "ssh.listTargetSummaries" + }, + { + "name": "params", + "value": { + "$rpc": "absent" + } + }, + { + "name": "options", + "value": { + "$rpc": "absent" + } + } + ], + "settlement": { + "status": "fulfilled", + "startedAt": 0, + "settledAt": 0, + "value": { + "id": "frame-2", + "ok": true, + "result": { + "targets": [ + { + "id": "ssh-1", + "label": "SSH" + } + ] + } + } + } + }, + { + "name": "settings.get#1", + "args": [ + { + "name": "method", + "value": "settings.get" + }, + { + "name": "params", + "value": { + "$rpc": "absent" + } + }, + { + "name": "options", + "value": { + "$rpc": "absent" + } + } + ], + "settlement": { + "status": "rejected", + "startedAt": 0, + "settledAt": 0, + "error": { + "category": "Error", + "message": "settings.get#1 rejected", + "isRpcDeliveryUnknown": true + } + } + }, + { + "name": "host.platform#1", + "args": [ + { + "name": "method", + "value": "host.platform" + }, + { + "name": "params", + "value": { + "$rpc": "absent" + } + }, + { + "name": "options", + "value": { + "$rpc": "absent" + } + } + ], + "settlement": { + "status": "rejected", + "startedAt": 0, + "settledAt": 0, + "error": { + "category": "Error", + "message": "Connection closed", + "isRpcDeliveryUnknown": true + } + } + } + ], "17f4e5897116": [ { "name": "repo.list#1", @@ -1723,6 +1871,16 @@ "effects": "3d1e2998e81c" } }, + { + "id": "settings-repo-metadata-fulfilled.reject-peer-pending:cleanup", + "observation": { + "sender": "0f1d92eb06c4", + "payloads": "83ef5f7039bf", + "settlements": "2bf0f26c9185", + "state": "6134b73f18d0", + "effects": "564017ad6e41" + } + }, { "id": "settings-repo-metadata-fulfilled.timeout:settled", "observation": { diff --git a/mobile/rpc-foundation/goldens/schedules-settings-resume-metadata-fulfilled.json b/mobile/rpc-foundation/goldens/schedules-settings-resume-metadata-fulfilled.json index a74af3aa35e..bd4cce845c8 100644 --- a/mobile/rpc-foundation/goldens/schedules-settings-resume-metadata-fulfilled.json +++ b/mobile/rpc-foundation/goldens/schedules-settings-resume-metadata-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/schedules-settings-task-hydration-fulfilled.json b/mobile/rpc-foundation/goldens/schedules-settings-task-hydration-fulfilled.json index 47de59572eb..0dfa7f0b9b7 100644 --- a/mobile/rpc-foundation/goldens/schedules-settings-task-hydration-fulfilled.json +++ b/mobile/rpc-foundation/goldens/schedules-settings-task-hydration-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/schedules-settings-workspace-context-fulfilled.json b/mobile/rpc-foundation/goldens/schedules-settings-workspace-context-fulfilled.json index 8cc06b8d9ca..ad378d8f431 100644 --- a/mobile/rpc-foundation/goldens/schedules-settings-workspace-context-fulfilled.json +++ b/mobile/rpc-foundation/goldens/schedules-settings-workspace-context-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-bot-overrides-fulfilled.json b/mobile/rpc-foundation/goldens/settings-bot-overrides-fulfilled.json index fd72a795eac..0afca96ea2b 100644 --- a/mobile/rpc-foundation/goldens/settings-bot-overrides-fulfilled.json +++ b/mobile/rpc-foundation/goldens/settings-bot-overrides-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-bot-overrides-refresh-refused.json b/mobile/rpc-foundation/goldens/settings-bot-overrides-refresh-refused.json index 88b9541c640..5b26acf9b1d 100644 --- a/mobile/rpc-foundation/goldens/settings-bot-overrides-refresh-refused.json +++ b/mobile/rpc-foundation/goldens/settings-bot-overrides-refresh-refused.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-bot-overrides-refused.json b/mobile/rpc-foundation/goldens/settings-bot-overrides-refused.json index 08afd134980..f827872fefe 100644 --- a/mobile/rpc-foundation/goldens/settings-bot-overrides-refused.json +++ b/mobile/rpc-foundation/goldens/settings-bot-overrides-refused.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-bot-overrides-transport-error.json b/mobile/rpc-foundation/goldens/settings-bot-overrides-transport-error.json index b61ddd7615f..1c0ab39dff0 100644 --- a/mobile/rpc-foundation/goldens/settings-bot-overrides-transport-error.json +++ b/mobile/rpc-foundation/goldens/settings-bot-overrides-transport-error.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-home-coalesced.json b/mobile/rpc-foundation/goldens/settings-home-coalesced.json index b4a6ae89594..063367ed3e9 100644 --- a/mobile/rpc-foundation/goldens/settings-home-coalesced.json +++ b/mobile/rpc-foundation/goldens/settings-home-coalesced.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-home-providers-fulfilled.json b/mobile/rpc-foundation/goldens/settings-home-providers-fulfilled.json index bb3dab86275..4d5ac77a9a6 100644 --- a/mobile/rpc-foundation/goldens/settings-home-providers-fulfilled.json +++ b/mobile/rpc-foundation/goldens/settings-home-providers-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-home-providers-refuse-after-data.json b/mobile/rpc-foundation/goldens/settings-home-providers-refuse-after-data.json index 09579e5e2f3..c3c771b5a17 100644 --- a/mobile/rpc-foundation/goldens/settings-home-providers-refuse-after-data.json +++ b/mobile/rpc-foundation/goldens/settings-home-providers-refuse-after-data.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-home-providers-refused.json b/mobile/rpc-foundation/goldens/settings-home-providers-refused.json index 705c9143a53..6872911769e 100644 --- a/mobile/rpc-foundation/goldens/settings-home-providers-refused.json +++ b/mobile/rpc-foundation/goldens/settings-home-providers-refused.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-home-providers-transport-error.json b/mobile/rpc-foundation/goldens/settings-home-providers-transport-error.json index 5ca78604e66..afc62fa9701 100644 --- a/mobile/rpc-foundation/goldens/settings-home-providers-transport-error.json +++ b/mobile/rpc-foundation/goldens/settings-home-providers-transport-error.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-new-tab-refused.json b/mobile/rpc-foundation/goldens/settings-new-tab-refused.json index 633a787fde6..171947ca870 100644 --- a/mobile/rpc-foundation/goldens/settings-new-tab-refused.json +++ b/mobile/rpc-foundation/goldens/settings-new-tab-refused.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-new-tab-ssh.json b/mobile/rpc-foundation/goldens/settings-new-tab-ssh.json index 56ff620aa23..862075a82f3 100644 --- a/mobile/rpc-foundation/goldens/settings-new-tab-ssh.json +++ b/mobile/rpc-foundation/goldens/settings-new-tab-ssh.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-new-tab-transport-error.json b/mobile/rpc-foundation/goldens/settings-new-tab-transport-error.json index bc2536b2ab4..e5ce7fd6632 100644 --- a/mobile/rpc-foundation/goldens/settings-new-tab-transport-error.json +++ b/mobile/rpc-foundation/goldens/settings-new-tab-transport-error.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-repo-cache-expiry.json b/mobile/rpc-foundation/goldens/settings-repo-cache-expiry.json index 41a23e08bf2..1128badc426 100644 --- a/mobile/rpc-foundation/goldens/settings-repo-cache-expiry.json +++ b/mobile/rpc-foundation/goldens/settings-repo-cache-expiry.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-repo-metadata-fulfilled.json b/mobile/rpc-foundation/goldens/settings-repo-metadata-fulfilled.json index 473f9980d30..33cca15185d 100644 --- a/mobile/rpc-foundation/goldens/settings-repo-metadata-fulfilled.json +++ b/mobile/rpc-foundation/goldens/settings-repo-metadata-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-repo-metadata-refuse-after-data.json b/mobile/rpc-foundation/goldens/settings-repo-metadata-refuse-after-data.json index 0da7e0638b9..2601c91fed6 100644 --- a/mobile/rpc-foundation/goldens/settings-repo-metadata-refuse-after-data.json +++ b/mobile/rpc-foundation/goldens/settings-repo-metadata-refuse-after-data.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-repo-metadata-refused.json b/mobile/rpc-foundation/goldens/settings-repo-metadata-refused.json index 8078df3f7bc..1a8d427af83 100644 --- a/mobile/rpc-foundation/goldens/settings-repo-metadata-refused.json +++ b/mobile/rpc-foundation/goldens/settings-repo-metadata-refused.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-repo-metadata-single-host.json b/mobile/rpc-foundation/goldens/settings-repo-metadata-single-host.json index 4f21feaaa95..23178bf2e99 100644 --- a/mobile/rpc-foundation/goldens/settings-repo-metadata-single-host.json +++ b/mobile/rpc-foundation/goldens/settings-repo-metadata-single-host.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-repo-metadata-transport-error.json b/mobile/rpc-foundation/goldens/settings-repo-metadata-transport-error.json index cfcaae498a4..d2268971b66 100644 --- a/mobile/rpc-foundation/goldens/settings-repo-metadata-transport-error.json +++ b/mobile/rpc-foundation/goldens/settings-repo-metadata-transport-error.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-resume-metadata-fulfilled.json b/mobile/rpc-foundation/goldens/settings-resume-metadata-fulfilled.json index ce06ff37993..acf263e29ba 100644 --- a/mobile/rpc-foundation/goldens/settings-resume-metadata-fulfilled.json +++ b/mobile/rpc-foundation/goldens/settings-resume-metadata-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-resume-metadata-refuse-after-data.json b/mobile/rpc-foundation/goldens/settings-resume-metadata-refuse-after-data.json index 024d0449942..3a632dea86c 100644 --- a/mobile/rpc-foundation/goldens/settings-resume-metadata-refuse-after-data.json +++ b/mobile/rpc-foundation/goldens/settings-resume-metadata-refuse-after-data.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-resume-metadata-refused.json b/mobile/rpc-foundation/goldens/settings-resume-metadata-refused.json index 0480893c472..fe0dfc2c00d 100644 --- a/mobile/rpc-foundation/goldens/settings-resume-metadata-refused.json +++ b/mobile/rpc-foundation/goldens/settings-resume-metadata-refused.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-resume-metadata-transport-error.json b/mobile/rpc-foundation/goldens/settings-resume-metadata-transport-error.json index 179e232874b..7d59788a4fb 100644 --- a/mobile/rpc-foundation/goldens/settings-resume-metadata-transport-error.json +++ b/mobile/rpc-foundation/goldens/settings-resume-metadata-transport-error.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-task-hydration-fulfilled.json b/mobile/rpc-foundation/goldens/settings-task-hydration-fulfilled.json index f669b1925b3..cf88d853e5d 100644 --- a/mobile/rpc-foundation/goldens/settings-task-hydration-fulfilled.json +++ b/mobile/rpc-foundation/goldens/settings-task-hydration-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-task-hydration-refuse-after-data.json b/mobile/rpc-foundation/goldens/settings-task-hydration-refuse-after-data.json index cff0e606fc8..fe2d40f01d4 100644 --- a/mobile/rpc-foundation/goldens/settings-task-hydration-refuse-after-data.json +++ b/mobile/rpc-foundation/goldens/settings-task-hydration-refuse-after-data.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-task-hydration-refused.json b/mobile/rpc-foundation/goldens/settings-task-hydration-refused.json index aadceeeebcd..89aa4a1b63f 100644 --- a/mobile/rpc-foundation/goldens/settings-task-hydration-refused.json +++ b/mobile/rpc-foundation/goldens/settings-task-hydration-refused.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-task-hydration-transport-error.json b/mobile/rpc-foundation/goldens/settings-task-hydration-transport-error.json index 593f879f575..65583586322 100644 --- a/mobile/rpc-foundation/goldens/settings-task-hydration-transport-error.json +++ b/mobile/rpc-foundation/goldens/settings-task-hydration-transport-error.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-task-workspace-fulfilled.json b/mobile/rpc-foundation/goldens/settings-task-workspace-fulfilled.json index 757325ef129..005f93cd174 100644 --- a/mobile/rpc-foundation/goldens/settings-task-workspace-fulfilled.json +++ b/mobile/rpc-foundation/goldens/settings-task-workspace-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-task-workspace-refused.json b/mobile/rpc-foundation/goldens/settings-task-workspace-refused.json index c1e07ad92df..79597eeeab3 100644 --- a/mobile/rpc-foundation/goldens/settings-task-workspace-refused.json +++ b/mobile/rpc-foundation/goldens/settings-task-workspace-refused.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-task-workspace-transport-error.json b/mobile/rpc-foundation/goldens/settings-task-workspace-transport-error.json index b0817c09391..c0f129916b9 100644 --- a/mobile/rpc-foundation/goldens/settings-task-workspace-transport-error.json +++ b/mobile/rpc-foundation/goldens/settings-task-workspace-transport-error.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-task-write.json b/mobile/rpc-foundation/goldens/settings-task-write.json index cdd9017916e..65f0ae895c1 100644 --- a/mobile/rpc-foundation/goldens/settings-task-write.json +++ b/mobile/rpc-foundation/goldens/settings-task-write.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-workspace-context-fulfilled.json b/mobile/rpc-foundation/goldens/settings-workspace-context-fulfilled.json index ff919e065b3..63cd32714d7 100644 --- a/mobile/rpc-foundation/goldens/settings-workspace-context-fulfilled.json +++ b/mobile/rpc-foundation/goldens/settings-workspace-context-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-workspace-context-refuse-after-data.json b/mobile/rpc-foundation/goldens/settings-workspace-context-refuse-after-data.json index becefc807ea..c9229582970 100644 --- a/mobile/rpc-foundation/goldens/settings-workspace-context-refuse-after-data.json +++ b/mobile/rpc-foundation/goldens/settings-workspace-context-refuse-after-data.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-workspace-context-refused.json b/mobile/rpc-foundation/goldens/settings-workspace-context-refused.json index fd1bb610d2c..e29f1d4cfed 100644 --- a/mobile/rpc-foundation/goldens/settings-workspace-context-refused.json +++ b/mobile/rpc-foundation/goldens/settings-workspace-context-refused.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-workspace-context-transport-error.json b/mobile/rpc-foundation/goldens/settings-workspace-context-transport-error.json index aa771c8e20e..8d0cf1556d1 100644 --- a/mobile/rpc-foundation/goldens/settings-workspace-context-transport-error.json +++ b/mobile/rpc-foundation/goldens/settings-workspace-context-transport-error.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-workspace-submit-fulfilled.json b/mobile/rpc-foundation/goldens/settings-workspace-submit-fulfilled.json index 5cd37e5b819..058b7b70ae3 100644 --- a/mobile/rpc-foundation/goldens/settings-workspace-submit-fulfilled.json +++ b/mobile/rpc-foundation/goldens/settings-workspace-submit-fulfilled.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-workspace-submit-refused.json b/mobile/rpc-foundation/goldens/settings-workspace-submit-refused.json index f2f262d757a..be51bb8fa8c 100644 --- a/mobile/rpc-foundation/goldens/settings-workspace-submit-refused.json +++ b/mobile/rpc-foundation/goldens/settings-workspace-submit-refused.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/rpc-foundation/goldens/settings-workspace-submit-transport-error.json b/mobile/rpc-foundation/goldens/settings-workspace-submit-transport-error.json index 9aa5345764c..04f6755ffe7 100644 --- a/mobile/rpc-foundation/goldens/settings-workspace-submit-transport-error.json +++ b/mobile/rpc-foundation/goldens/settings-workspace-submit-transport-error.json @@ -5,7 +5,7 @@ "runnerVersion": 1, "baseline": "aba77d5babfeb3988a8ad39a16a1bc5af86ebf80", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", - "recorderSha256": "7e0a108ee845d832862a65830eb318f7d8970ce4abf4a974898fc4a33fbf459d", + "recorderSha256": "70e4ea4590f92a02dd93cf9212d0160f9bc194fbd59eee746c917e9dc42c5718", "platform": "darwin", "scenarioVersion": 1, "projectionVersion": 2, diff --git a/mobile/src/test-support/rpc-recording/README.md b/mobile/src/test-support/rpc-recording/README.md index 2859b6820d0..93e193998ff 100644 --- a/mobile/src/test-support/rpc-recording/README.md +++ b/mobile/src/test-support/rpc-recording/README.md @@ -230,25 +230,18 @@ The original settings slice coverage maps nine host-RPC callers in instruction. Later manifest additions require new scenarios and remain uncovered until those recordings land. This runner does not certify native storage or transport skew. -## Cleanup observations are not recorded (known gap) +## The cleanup checkpoint -Every checkpoint `structuredClone`s the effects array, so anything appended after the final -checkpoint — during `dispose()`, the transport teardown, or the last `scheduler.flush()` — lands -after the recording was built and never reaches a golden. `run-recording.ts` now warns when this -happens instead of dropping it silently. +Teardown runs on the recorded path, not only in `finally`. Each checkpoint clones the effects +array, so a rejection or state write produced by `dispose()`, the transport teardown or the final +`scheduler.flush()` used to land after the recording was built and never reached a golden — and an +unmount leak is exactly what this oracle exists to catch. -Six scenarios trip it today, and the dropped names are not noise: +When teardown observes anything, it becomes a checkpoint with id `cleanup`. `state` is captured +before dispose, because the operation is gone afterwards. -| Scenario | Dropped observations | -|---|---| -| `b2.prelude` | `projectRowDetailError`, `projectMutating` | -| `settings-repo-metadata-fulfilled.prelude` | `hostLabelById`, `hostPlatform` | -| `settings-repo-metadata-fulfilled.reject-peer-pending` | `hostLabelById`, `hostPlatform` | -| `settings-task-workspace-fulfilled.prelude` | `workspaceAgent`, `workspaceAgentOverridden`, `error`, `creatingKey` | -| `settings-workspace-submit-fulfilled` | `error` | -| `settings-workspace-submit-fulfilled.prelude` | `selectedAgent`, `agentOverridden`, `error` | - -A rejection or state write on unmount is exactly what this oracle should catch, so this is a real -hole, not a nuisance. Closing it means either recording a cleanup checkpoint or folding these into -the final one — both change what every golden contains, which is a deliberate change of its own -rather than something to slip in here. +Five goldens carry one today, covering six scenarios whose dropped observations were not noise: +`projectRowDetailError`, `projectMutating`, `hostLabelById`, `hostPlatform`, `workspaceAgent`, +`workspaceAgentOverridden`, `creatingKey`, `selectedAgent`, `agentOverridden` and `error`. A +scenario that stops leaking loses its checkpoint, which is a visible golden diff rather than a +silent improvement. diff --git a/mobile/src/test-support/rpc-recording/run-recording.ts b/mobile/src/test-support/rpc-recording/run-recording.ts index 18225dd067b..2aa0b80f1da 100644 --- a/mobile/src/test-support/rpc-recording/run-recording.ts +++ b/mobile/src/test-support/rpc-recording/run-recording.ts @@ -32,6 +32,13 @@ export async function runRecording( let mounted: MountedOperation | undefined const ids = new Set() let advanced = 0 + let cleaned = false + const teardown = async (): Promise => { + cleaned = true + await mounted?.dispose() + transport.dispose() + await scheduler.flush() + } try { mounted = mount({ client: transport.client, effect }) for (const step of scenario.steps) { @@ -87,32 +94,39 @@ export async function runRecording( if (!recording.checkpoints.length) { throw new Error(`No checkpoints: ${scenario.id}`) } + // Why cleanup runs here and not only in `finally`: each checkpoint clones `effects`, so a + // rejection or state write produced by dispose, transport teardown or the final flush landed + // after the recording was built and never reached a golden. Unmount leaks are exactly what + // this oracle exists to catch, so teardown happens on the recorded path and anything it + // observes becomes its own checkpoint. `state` is captured before dispose because the + // operation is gone afterwards. + const beforeCleanup = effects.length + const stateAtCleanup = captureValue(mounted.state()) + await teardown() + if (effects.length !== beforeCleanup) { + recording.checkpoints.push({ + id: 'cleanup', + observation: { + // oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: a structured clone of recorded requests is recorded data. + sender: structuredClone(transport.requests) as unknown as RecordedValue, + payloads: structuredClone(transport.payloads), + // oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: a structured clone of recorded settlements is recorded data. + settlements: structuredClone(settlements) as unknown as RecordedValue, + state: stateAtCleanup, + effects: structuredClone(effects) + } + }) + } return recording } finally { - // Why the count: every checkpoint already structuredClone'd `effects`, so anything cleanup - // appends lands after the recording was built and would be silently absent from it. A - // rejection thrown by dispose or a detached effect is exactly what this oracle exists to - // catch, so surface it instead of dropping it. - const beforeCleanup = effects.length try { - await mounted?.dispose() - transport.dispose() - await scheduler.flush() + if (!cleaned) { + await teardown() + } } finally { stopUnhandled() scheduler.stop() } - if (effects.length !== beforeCleanup) { - // Known and unresolved: six scenarios land here today (see the README's cleanup-observation - // note). Warning rather than throwing keeps the gap visible without asserting a shape for - // these observations, which would change every golden. Deciding that is its own change. - console.warn( - `[rpc-recording] cleanup observations dropped from ${scenario.id}: ${effects - .slice(beforeCleanup) - .map((entry) => entry.name) - .join(', ')}` - ) - } } }