From ffbcf5730147837567ec04a0d67cd641154aba82 Mon Sep 17 00:00:00 2001 From: Jinwoo-H Date: Tue, 15 Sep 2026 18:16:16 -0400 Subject: [PATCH] test(rpc-recording): re-record the worktree catalog goldens over main's engine digest #20874 re-digested `recorderSha256` on all 509 goldens, so the six goldens mounted through the worktree catalog adapter had to be recorded again from the pin rather than merged. Bodies and `adapterSha256` are unchanged from the pre-merge recording. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb --- ...rktree.catalog-snapshot-worktree.ps-1.json | 66 ++++++++++++++----- ...x-worktree.home-catalog-worktree.ps-1.json | 2 +- ...red-names-worktree.listretirednames-1.json | 2 +- .../goldens/worktree-catalog-snapshot.json | 37 +++++++---- .../goldens/worktree-home-catalog.json | 2 +- .../goldens/worktree-retired-names.json | 2 +- 6 files changed, 78 insertions(+), 33 deletions(-) diff --git a/mobile/rpc-foundation/goldens/matrix-worktree.catalog-snapshot-worktree.ps-1.json b/mobile/rpc-foundation/goldens/matrix-worktree.catalog-snapshot-worktree.ps-1.json index 13dd944295b..6d6fc8fd4d2 100644 --- a/mobile/rpc-foundation/goldens/matrix-worktree.catalog-snapshot-worktree.ps-1.json +++ b/mobile/rpc-foundation/goldens/matrix-worktree.catalog-snapshot-worktree.ps-1.json @@ -6,7 +6,7 @@ "baseline": "c6a72169843ececf3a21da370ac50c5c5a4e6462", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", "recorderSha256": "e044443e01f282566a5e0eff110d0861d2a1047ca8d8696a2e7ff914f51957f3", - "adapterSha256": "6119d409e1958877e4a04b3901f94a3609ac0420f5ca02af20eb8dae5cbf3408", + "adapterSha256": "4e942ddfbaa0ba6bfc2993969276987f6528ac53765d125e99a830e261f93a8e", "scenarioSha256": "95ca47f382997c412da974e564a46b1ae0c20d6e0f3ca14258d33c8d8b51a160", "platform": "darwin", "scenarioVersion": 1, @@ -112,12 +112,19 @@ "admitted": "unadmitted", "fetched": "unfetched" }, - "2d40d1d38104": { - "name": "unhandled-rejection", + "3ef9b57ea9ad": { + "status": "fulfilled", + "startedAt": 0, + "settledAt": 0, "value": { - "category": "Error", - "isRpcDeliveryUnknown": false, - "message": "Unsupported observation: function" + "kind": "response", + "pending": { + "admission": { + "kind": "invalid" + }, + "client": "logical-client", + "hostId": "host-1" + } } }, "4262ba495b1b": { @@ -258,6 +265,29 @@ "status": "pending", "startedAt": 0 }, + "9948855e8b8d": { + "status": "fulfilled", + "startedAt": 0, + "settledAt": 0, + "value": { + "kind": "response", + "pending": { + "admission": { + "kind": "full", + "snapshotId": "snapshot-1", + "worktrees": [ + { + "displayName": "One", + "repo": "Repo", + "worktreeId": "w-1" + } + ] + }, + "client": "logical-client", + "hostId": "host-1" + } + } + }, "a0fab6bf1fb0": { "name": "worktree.ps#1", "args": [ @@ -584,10 +614,10 @@ "sender": ["227f9e3de4fa"], "payloads": ["a87f1f91dc98"], "settlements": { - "fetch": "9270aeb7d9c6" + "fetch": "9948855e8b8d" }, "state": "ab1a9ba6301c", - "effects": ["2d40d1d38104"] + "effects": [] } }, { @@ -596,10 +626,10 @@ "sender": ["ad584cc963bb"], "payloads": ["a87f1f91dc98"], "settlements": { - "fetch": "9270aeb7d9c6" + "fetch": "3ef9b57ea9ad" }, "state": "50c4271e912d", - "effects": ["2d40d1d38104"] + "effects": [] } }, { @@ -608,10 +638,10 @@ "sender": ["b670d230caf2"], "payloads": ["a87f1f91dc98"], "settlements": { - "fetch": "9270aeb7d9c6" + "fetch": "3ef9b57ea9ad" }, "state": "50c4271e912d", - "effects": ["2d40d1d38104"] + "effects": [] } }, { @@ -620,10 +650,10 @@ "sender": ["4262ba495b1b"], "payloads": ["a87f1f91dc98"], "settlements": { - "fetch": "9270aeb7d9c6" + "fetch": "3ef9b57ea9ad" }, "state": "50c4271e912d", - "effects": ["2d40d1d38104"] + "effects": [] } }, { @@ -632,10 +662,10 @@ "sender": ["5a288976750e"], "payloads": ["a87f1f91dc98"], "settlements": { - "fetch": "9270aeb7d9c6" + "fetch": "3ef9b57ea9ad" }, "state": "50c4271e912d", - "effects": ["2d40d1d38104"] + "effects": [] } }, { @@ -644,10 +674,10 @@ "sender": ["f5d207eddd1d"], "payloads": ["a87f1f91dc98"], "settlements": { - "fetch": "9270aeb7d9c6" + "fetch": "3ef9b57ea9ad" }, "state": "50c4271e912d", - "effects": ["2d40d1d38104"] + "effects": [] } }, { diff --git a/mobile/rpc-foundation/goldens/matrix-worktree.home-catalog-worktree.ps-1.json b/mobile/rpc-foundation/goldens/matrix-worktree.home-catalog-worktree.ps-1.json index 37ab03ed7db..8c60558fb45 100644 --- a/mobile/rpc-foundation/goldens/matrix-worktree.home-catalog-worktree.ps-1.json +++ b/mobile/rpc-foundation/goldens/matrix-worktree.home-catalog-worktree.ps-1.json @@ -6,7 +6,7 @@ "baseline": "c6a72169843ececf3a21da370ac50c5c5a4e6462", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", "recorderSha256": "e044443e01f282566a5e0eff110d0861d2a1047ca8d8696a2e7ff914f51957f3", - "adapterSha256": "6119d409e1958877e4a04b3901f94a3609ac0420f5ca02af20eb8dae5cbf3408", + "adapterSha256": "4e942ddfbaa0ba6bfc2993969276987f6528ac53765d125e99a830e261f93a8e", "scenarioSha256": "fa0e28a167a5fba6fe7ffebb9f4ad28dd413d601c07116a24a7781d156f54beb", "platform": "darwin", "scenarioVersion": 1, diff --git a/mobile/rpc-foundation/goldens/matrix-worktree.retired-names-worktree.listretirednames-1.json b/mobile/rpc-foundation/goldens/matrix-worktree.retired-names-worktree.listretirednames-1.json index 502777725c9..30b10d5044b 100644 --- a/mobile/rpc-foundation/goldens/matrix-worktree.retired-names-worktree.listretirednames-1.json +++ b/mobile/rpc-foundation/goldens/matrix-worktree.retired-names-worktree.listretirednames-1.json @@ -6,7 +6,7 @@ "baseline": "c6a72169843ececf3a21da370ac50c5c5a4e6462", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", "recorderSha256": "e044443e01f282566a5e0eff110d0861d2a1047ca8d8696a2e7ff914f51957f3", - "adapterSha256": "6119d409e1958877e4a04b3901f94a3609ac0420f5ca02af20eb8dae5cbf3408", + "adapterSha256": "4e942ddfbaa0ba6bfc2993969276987f6528ac53765d125e99a830e261f93a8e", "scenarioSha256": "d321d6c17e67ae90f6ceefb775495ff765a86a35423ed33a212e71ec5e9e94aa", "platform": "darwin", "scenarioVersion": 1, diff --git a/mobile/rpc-foundation/goldens/worktree-catalog-snapshot.json b/mobile/rpc-foundation/goldens/worktree-catalog-snapshot.json index 5c2b51fcc0d..702559ab303 100644 --- a/mobile/rpc-foundation/goldens/worktree-catalog-snapshot.json +++ b/mobile/rpc-foundation/goldens/worktree-catalog-snapshot.json @@ -6,7 +6,7 @@ "baseline": "c6a72169843ececf3a21da370ac50c5c5a4e6462", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", "recorderSha256": "e044443e01f282566a5e0eff110d0861d2a1047ca8d8696a2e7ff914f51957f3", - "adapterSha256": "6119d409e1958877e4a04b3901f94a3609ac0420f5ca02af20eb8dae5cbf3408", + "adapterSha256": "4e942ddfbaa0ba6bfc2993969276987f6528ac53765d125e99a830e261f93a8e", "scenarioSha256": "d2947158840576cbd0f0604ed3d37b0f446c63c6d439b4d1b7def7fe8524523d", "platform": "darwin", "scenarioVersion": 1, @@ -60,18 +60,33 @@ "admitted": "unadmitted", "fetched": "unfetched" }, - "2d40d1d38104": { - "name": "unhandled-rejection", - "value": { - "category": "Error", - "isRpcDeliveryUnknown": false, - "message": "Unsupported observation: function" - } - }, "9270aeb7d9c6": { "status": "pending", "startedAt": 0 }, + "9948855e8b8d": { + "status": "fulfilled", + "startedAt": 0, + "settledAt": 0, + "value": { + "kind": "response", + "pending": { + "admission": { + "kind": "full", + "snapshotId": "snapshot-1", + "worktrees": [ + { + "displayName": "One", + "repo": "Repo", + "worktreeId": "w-1" + } + ] + }, + "client": "logical-client", + "hostId": "host-1" + } + } + }, "a87f1f91dc98": { "name": "worktree.ps#1", "json": "{\"id\":\"frame-1\",\"deviceToken\":\"recording-device\",\"method\":\"worktree.ps\",\"params\":{\"limit\":10000,\"afterSnapshotId\":null,\"supportsWorktreeVisibilitySourceDefaults\":true}}" @@ -153,10 +168,10 @@ "sender": ["227f9e3de4fa"], "payloads": ["a87f1f91dc98"], "settlements": { - "fetch": "9270aeb7d9c6" + "fetch": "9948855e8b8d" }, "state": "ab1a9ba6301c", - "effects": ["2d40d1d38104"] + "effects": [] } } ] diff --git a/mobile/rpc-foundation/goldens/worktree-home-catalog.json b/mobile/rpc-foundation/goldens/worktree-home-catalog.json index e5911016ce1..1c67c864d4e 100644 --- a/mobile/rpc-foundation/goldens/worktree-home-catalog.json +++ b/mobile/rpc-foundation/goldens/worktree-home-catalog.json @@ -6,7 +6,7 @@ "baseline": "c6a72169843ececf3a21da370ac50c5c5a4e6462", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", "recorderSha256": "e044443e01f282566a5e0eff110d0861d2a1047ca8d8696a2e7ff914f51957f3", - "adapterSha256": "6119d409e1958877e4a04b3901f94a3609ac0420f5ca02af20eb8dae5cbf3408", + "adapterSha256": "4e942ddfbaa0ba6bfc2993969276987f6528ac53765d125e99a830e261f93a8e", "scenarioSha256": "4749bb3b871275ba08f026f9b6bcfd383605f443e7bba70a7f89175b91db6fa5", "platform": "darwin", "scenarioVersion": 1, diff --git a/mobile/rpc-foundation/goldens/worktree-retired-names.json b/mobile/rpc-foundation/goldens/worktree-retired-names.json index a08834120f1..96ac4484933 100644 --- a/mobile/rpc-foundation/goldens/worktree-retired-names.json +++ b/mobile/rpc-foundation/goldens/worktree-retired-names.json @@ -6,7 +6,7 @@ "baseline": "c6a72169843ececf3a21da370ac50c5c5a4e6462", "lockfileSha256": "788c1234b38a61fc882fca292341fce6690deee9cc6695673b0575cf2c4cf571", "recorderSha256": "e044443e01f282566a5e0eff110d0861d2a1047ca8d8696a2e7ff914f51957f3", - "adapterSha256": "6119d409e1958877e4a04b3901f94a3609ac0420f5ca02af20eb8dae5cbf3408", + "adapterSha256": "4e942ddfbaa0ba6bfc2993969276987f6528ac53765d125e99a830e261f93a8e", "scenarioSha256": "2faa07ee5f12b3ed584117359d3b7aeb9c78a04e8fc49e753372f8c3927a3740", "platform": "darwin", "scenarioVersion": 1,