Commit Graph
3741 Commits
Author SHA1 Message Date
Neil 2819cdc081 feat(terminal): opt-in OSC 52 clipboard writes from TUIs (#952)
xterm.js ships with no OSC 52 handler, so tmux, Neovim, fzf, and ripgrep
running inside Orca — locally or over SSH — silently fail to copy to the
system clipboard. Add an opt-in handler gated behind a new setting
`terminalAllowOsc52Clipboard` (default off because untrusted output
piped into the terminal can silently overwrite the clipboard).

Implementation mirrors the DEC 2031 wiring from PR #896: extract parsing
into a pure helper (parseOsc52) with a full unit-test suite, register
the handler in onPaneCreated and dispose it symmetrically in
onPaneClosed, and read the gate from settingsRef at fire time so the
toggle takes effect without recreating panes.

Clipboard *queries* (Pd = "?") are intentionally dropped — answering
them would leak the user's clipboard to any process writing to the
PTY — along with malformed payloads, oversized payloads (>128KB),
and payloads using unknown selection letters.
2026-04-22 14:45:26 -07:00
Brennan Benson 89b85b828b feat(nav): workspace back/forward navigation (#945) 2026-04-22 13:40:38 -07:00
Kelvin AmoabaandNeil 9a8d716aca feat(terminal): broadcast theme changes to PTYs via DEC mode 2031 (#896)
* feat(terminal): broadcast theme changes to PTYs via DEC mode 2031

Claude Code's /theme auto reads Orca's background via OSC 11 at startup
(xterm.js answers that natively), so claude matches the terminal on
launch. But when Orca's theme flips mid-session, claude had no signal:
Orca never told running TUIs anything changed, so auto-theme stayed
stuck wherever it started.

This wires the DEC private mode 2031 + CSI 997 protocol that Neovim,
tmux, Kitty, and Ghostty use. A TUI sends CSI ?2031h to subscribe;
when the theme flips, the terminal pushes CSI ?997;1n (dark) or
CSI ?997;2n (light). The TUI then re-queries OSC 11 and repaints.

- Per-pane subscription flag and last-emitted mode live on TerminalPane.
- The CSI ?2031 h/l handlers are installed in onPaneCreated before the
  PTY attaches so the child's initial subscribe is captured, and an
  immediate push on enable seeds the current mode without a query.
- applyTerminalAppearance only emits CSI 997 when the resolved mode
  actually flipped, so font/size/opacity tweaks that re-run the same
  effect don't spam subscribed TUIs.

* refactor(terminal): extract mode 2031 helpers and add spam-gate tests

Pull the CSI 997 sequence builder and the subscribe/flip gate out of
applyTerminalAppearance so the appearance path and the subscribe-time
seed path in the lifecycle hook share one source of truth. Annotate the
?h / ?l parser handlers to make it explicit they observe (return false)
rather than suppress — compound DEC sequences like `?25;2031h` must
still flow to xterm's built-in handler. Adds unit coverage for the
no-op-on-no-flip gate, reconnect path, and per-pane tracking.

---------

Co-authored-by: Neil <4138956+nwparker@users.noreply.github.com>
2026-04-22 12:06:30 -07:00
Jinwoo Hong c8dd14be23 fix(ui): enable scroll-wheel in CommandList inside Dialog (#948) 2026-04-22 12:04:05 -07:00
Jinwoo Hong 7c717e2903 fix(ssh): register relay roots on connect and retry file explorer load (#946) 2026-04-22 11:42:22 -07:00
Jinwoo Hong 6feb93ab78 fix(terminal): guard PTY native calls against dead-process Napi::Error crash (#916) 2026-04-22 11:16:43 -07:00
Jinjing 245b29d604 refactor(editor): render front-matter banner inside rich editor shell (#943)
Pass FrontMatterBanner as headerSlot into RichMarkdownEditor so it renders
between the toolbar and the editor surface, keeping formatting controls at
the top of the pane.
2026-04-22 11:05:48 -07:00
Jinjing 0bbf2d7a8f feat: cross-repo issues view in new workspace page (#942)
* feat: cross-repo issues view with multi-repo selection

- Add multi-repo selection via RepoMultiCombobox with persisted defaultRepoSelection setting (null = sticky-all)
- Stamp repoId on GitHubWorkItem at the renderer fetch boundary; merge items from all selected repos with per-repo failure tracking
- Extract task-query helpers (tokenize/strip/parseTaskQuery) to src/shared and add unit tests
- Refactor NewWorkspacePage row to <div role=button> to allow nested interactive elements without invalid-HTML hydration errors
- fix(repo-combobox): toggle all-repos selection on repeat click

* fix(tasks): route Use CTA to item's own repo in cross-repo view

handleUseWorkItem previously referenced a removed 'repoId' state; use item.repoId so launching from a merged cross-repo list targets the correct repo.

* test(e2e): add tasks page smoke test
2026-04-22 10:58:18 -07:00
Jinjing 46423cede7 fix(quick-open): don't clear Cmd+P input on unrelated store updates (#941)
* fix(quick-open): don't clear Cmd+P input on unrelated store updates

The file-load effect depended on excludePaths, a new array reference
produced on any worktreesByRepo update. Each such update re-ran the
effect and called setQuery(''), wiping input the user was typing.
Split the open-reset into its own effect keyed on `visible`.

* fix(quick-open): remove manual scroll-to-top that fought user scroll

The rAF scrollTo(0,0) ran on every query/visible change, which meant
scrolling down and then typing (or any re-render that touched the
effect) snapped the list back up. The clipping issue it was papering
over is already solved by CommandList's p-2 padding, and cmdk's own
scrollIntoView handles keeping the selected item visible.

* fix(quick-open): stop refetching on unrelated worktreesByRepo updates

The excludePaths memo returned a new array reference on every
worktreesByRepo mutation, even when neither the active worktree's
path nor its siblings changed. That re-ran the file-load effect,
cleared files, and blinked the list on focus/scroll. Memoize on a
stable joined-string key instead.
2026-04-22 10:11:20 -07:00
Neil 7ae95cd3d0 fix(terminal): layout-aware default for macOS Option-as-Alt (#903) (#909) 2026-04-22 00:32:11 -07:00
Jinjing 5b8e933904 feat(tab-bar): add quick-launch CLI buttons (#933)
Introduce a dedicated detected-agents store slice that replaces the
module-scoped detect-agents-cached cache, with a shared useDetectedAgents
hook driving AgentsPane, composer, and the new QuickLaunchButton in
TabBar. Extracts launchAgentInNewTab helper to share the startup-command
path used by the tab bar's + button.
2026-04-21 23:14:22 -07:00
Neil 51eabf9011 fix(browser): make address bar Enter match typed intent, not Google Search (#932)
Previously the dropdown's last row was always a "[input] — Google Search"
fallback, which the auto-select-first effect highlighted when no history
matched. Enter then navigated to Google even for URL-like inputs like
"www.example.com" — opposite of Chrome/Firefox behavior.

Now the top row mirrors what normalizeBrowserNavigationUrl would do:
for URL-like input it's the typed URL (Open URL), for bare queries it's
the search. The synthetic row is suppressed when a history row already
targets the same URL.
2026-04-21 23:08:11 -07:00
Jinwoo Hong 7a64ee3a11 Revert "fix(terminal): add proportional scroll fallback for sidebar resize (#901)" (#930)
This reverts commit 2ab2db9132.
2026-04-22 00:44:37 -04:00
Jinwoo Hong 2ab2db9132 fix(terminal): add proportional scroll fallback for sidebar resize (#901) 2026-04-21 21:28:56 -07:00
Brennan Benson f724510f4e fix(markdown): improve task-list checkbox contrast in dark mode (#927) 2026-04-21 18:57:39 -07:00
Neil 3a38e7207a fix(terminal): open .html/.htm paths directly in the embedded browser (#925)
Cmd/Ctrl+click on an HTML file path in the terminal now renders the page
in a new browser tab instead of loading its source into Monaco. Mirrors
PR #908's "Open Preview to the Side" entry point and matches how we
already route http(s) URLs into Orca's browser.

The hover tooltip now shows a distinct "open in browser" hint for HTML
paths so the different behavior is discoverable.
2026-04-21 18:39:31 -07:00
Neil 4192d9db26 fix(tasks): rename NewWorkspacePage to TaskPage and give it a proper titlebar (#921)
* fix(tasks): rename NewWorkspacePage to TaskPage and unblock Close on collapsed sidebar

Rename the full-page work-item view to TaskPage (file, component, store
actions, and the `activeView` literal) so the name matches the surface the
user sees. Also fix a regression where the page's Close button was
unreachable in workspace view with the sidebar collapsed — the floating
titlebar-left strip (traffic lights + sidebar toggle + agent badge)
overlapped the Close button, leaving the user stuck. Mirror the
TabGroupPanel fix by reserving `var(--collapsed-sidebar-header-width)` of
left padding on the Close row, which App.tsx already keeps in sync with the
live measured width of that floating header.

* fix(tasks): give TaskPage its own 42px titlebar and drop Close below it

Rather than cramming the Close button into the same horizontal band that
App.tsx uses for the floating traffic-lights/sidebar-toggle strip, give
TaskPage its own 42px "Tasks" titlebar (matching the sidebar header and
tab rows) and move the Close (X) button into a dedicated row below it.
The titlebar is drag-region so the window stays movable from this band.
Skipped in non-workspace mode where App.tsx already owns the full-width
titlebar, to avoid a duplicate band.

* fix(tasks): keep sidebar-expand toggle visible over TaskPage titlebar

When the left sidebar is collapsed, App.tsx floats the titlebar-left strip
(traffic lights, sidebar-expand toggle, agent badge) over the top-left of
the page at z-10. TaskPage's own 42px strip sat at the same stacking level
and painted later in DOM, so its solid background hid the expand toggle.
Split the strip: keep the reserved region transparent so the floating
controls show through, and only paint bg/border on the remainder. The
floating titlebar-left already carries the matching bg + border-bottom,
so the two segments still read as one continuous band.

* fix(tasks): let clicks reach sidebar toggle under TaskPage titlebar

The reserved spacer in TaskPage's titlebar strip sits on top of App.tsx's
floating titlebar-left (which hosts the sidebar-expand toggle and agent
badge). Two things were swallowing clicks meant for the toggle:

1. The outer strip carried WebkitAppRegion='drag', so Electron treated the
   whole 42px row as window-drag — even the transparent reserved region.
2. The transparent div itself absorbed pointer events before they reached
   the underlying toggle.

Scope the drag region to just the painted "Tasks" segment, and mark the
reserved spacer pointer-events-none with an explicit no-drag override.

* fix(tasks): stop TaskPage wrapper from blocking sidebar-expand toggle

The TaskPage's inner column had z-10, the same z-index as App.tsx's
floating titlebar-left cluster (traffic lights, sidebar toggle, agent
badge) that hovers in the top-left when the sidebar is collapsed. Tie
on z-index + later in DOM meant TaskPage painted over titlebar-left,
so clicks on the reserved spacer region fell through pointer-events-none
into the wrapper behind the spacer rather than reaching the toggle.

Dropping z-10 from the inner column lets titlebar-left paint above the
page content and receive clicks cleanly, without changing the visual
layout.
2026-04-21 18:11:19 -07:00
Jinjing 76b69baa2c fix(sidebar): make Pinned section visually distinct (#924)
Add a Pin icon to the Pinned header and introduce a sibling "All"
header (with LayoutList icon) for unpinned items when groupBy='none',
replacing the faint divider so the two sections read as peer groups
instead of a single continuous list.
2026-04-21 18:07:02 -07:00
Neil ed32ca2c21 fix(worktrees): fail loudly when no default base ref is resolvable (#922) 2026-04-21 17:40:27 -07:00
Jinjing 55d15f44b4 fix(composer): larger fonts, Enter-to-advance in new-workspace dialog (#920)
Bumps labels to text-xs and inputs to text-sm/h-9 so fields aren't
cramped in the Cmd+N composer. Enter on the Workspace Name field now
moves focus to the Agent combobox; Enter on the Agent trigger (closed)
submits via new optional onTriggerEnter prop, guarded by createDisabled.
2026-04-21 16:47:32 -07:00
Neil a086eae06b fix(settings): trigger RC channel and hidden-experimental via plain Shift (#919) 2026-04-21 16:41:46 -07:00
Brennan Benson b32996d50f fix: clarify Sleep tooltip to mention browser tabs (#915) 2026-04-21 16:27:06 -07:00
Jinwoo Hong 995b2affaf fix(editor): focus find input on Cmd+F when search is already open (#910) 2026-04-21 16:22:04 -07:00
Neil 4fd5d95a41 fix(tasks): drop redundant title-adjacent type icon on work-item rows (#918) 2026-04-21 16:20:29 -07:00
Neil ab2f831d1b fix(sidebar): make pinned-group divider visible in both themes (#917) 2026-04-21 16:16:20 -07:00
Neil b1e84b6e18 Derive quick-create agent from props instead of syncing via effect (#914) 2026-04-21 16:07:27 -07:00
Brennan Benson 5700f3dfee feat(terminal): Ctrl+Left/Right word-nav on Windows/Linux (#857) 2026-04-21 15:56:01 -07:00
Neil 369ddb6fe6 Simplify new workspace quick-create and wire Use button to direct launch (#913)
* Refine workspace composer controls

* Working repo autofocus

* after selects

* Simplify workspace quick create dialog

* Refine quick create form focus flow

* autofocus fix

* normal dialog

* base dialogs

* Wire Use button to launch workspace directly

Skips the composer modal for the common case: creates the workspace,
activates it, launches the default agent, and pastes the work-item URL
into the agent's input as a reviewable draft. Falls back to the modal
when setupRunPolicy is 'ask' or no compatible agent is detected.

* Stretch combobox dropdowns to trigger width

Repository and Agent rows in the quick-create dialog now span the full
dialog width like the Workspace Name input, and their dropdown popovers
inherit the trigger width so the entries align edge-to-edge with the
trigger instead of clipping to a fixed 288/320px.
2026-04-21 15:55:18 -07:00
Neil 35f5fe72e6 feat(editor): open HTML preview to the side (#908) 2026-04-21 15:52:28 -07:00
Jinjing c83d2ebbf8 feat(settings): add dedicated Agent Browser Use setup in Browser pane (#907)
* feat(settings): add dedicated Agent Browser Use setup in Browser pane

Adds a guided 3-step onboarding card (enable Orca CLI, install skill,
import cookies) to the Browser settings pane with a local enable toggle,
search-query integration, and a shortcut to the Session & Cookies block
for multi-profile users.

* fix(settings): scope browser-use completion to default profile and gate skill toggle

Track step-3 completion from the default profile only, since that is the
profile agents use. Disable the "I ran it" toggle when the CLI step is
incomplete so the visual gating matches behavior.
2026-04-21 15:38:36 -07:00
Jinwoo Hong 2b226ce234 fix(browser): place CLI-created tabs in the active browser tab's group (#904) 2026-04-21 15:10:27 -07:00
Brennan Benson 2da6159a25 fix(diff-notes): rename to "Note", highlight saved card, Enter submits (#902) 2026-04-21 12:52:57 -07:00
Brennan Benson c9e150b4c3 fix(sidebar): focus newly-added non-git folder in workspace (#894) 2026-04-21 12:19:24 -07:00
Jinwoo Hong 657f87d69e fix(sidebar): collapsed group overlap on restart (#898) 2026-04-21 11:35:24 -07:00
Jinjing 89954334a3 fix: route Cmd/Ctrl+N through main-process shortcut allowlist (#895)
Ensures the new-workspace composer opens even when focus is inside a
contentEditable surface (markdown rich editor) or a browser-guest
webContents, both of which bypass the renderer's window-level keydown.
2026-04-21 10:32:31 -07:00
Jinwoo Hong 4a90181ffb feat(browser): search suggestion in address bar dropdown (#893) 2026-04-21 10:04:56 -07:00
Jinwoo Hong 5f3055fb3f feat(browser): duplicate tab, search engine, address bar history fix (#892) 2026-04-21 09:52:40 -07:00
Neil d66d86645d feat(settings): Cmd+Shift affordances for RC channel and hidden experimental (#887)
Cmd+Shift-click "Check for Updates" (menu or Settings > General) opts
into the RC release channel by switching the feed to the github provider
with allowPrerelease=true for the rest of the process.

Cmd+Shift-click the Experimental sidebar entry reveals a "Hidden
experimental" group with an orange-tinted header and a disabled
placeholder toggle — the slot for future unfinished/staff-only options.

Also reword the Experimental description to something less alarmist:
"New features that are still taking shape. Give them a try."
2026-04-21 00:07:02 -07:00
DrakontiaandCopilot 53f911ddc3 Support GitHub Copilot CLI agent detection (#866)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-20 23:44:37 -07:00
Jinwoo Hong 633204babd fix(editor): apply dark scrollbar styling to rich markdown editor (#886) 2026-04-20 23:00:18 -07:00
Brennan Benson 933d59f165 diff-comments: copy-only flow in Source Control (#884) 2026-04-20 21:50:31 -07:00
Kelvin Amoaba bf21a028b9 feat: add terminal line height setting (#712)
Add a configurable line height multiplier (1-3) to terminal appearance
settings under Typography, persisted and applied to all terminal panes.
2026-04-20 21:23:43 -07:00
Jinwoo Hong 7a9bc4ef6d feat: computer use via agent-browser CDP bridge (#856) 2026-04-20 20:56:14 -07:00
Jinjing 3a58a829f9 feat(editor): export active markdown to PDF (#882)
Adds File > Export as PDF... menu item (Cmd+Shift+E) and an overflow
menu entry that renders the active markdown preview through a sandboxed
Electron BrowserWindow and writes it to disk via printToPDF.

- New main-side IPC handler (src/main/ipc/export.ts) and html-to-pdf
  helper that loads a CSP-locked HTML document in a sandboxed, context-
  isolated window with javascript enabled only for image-ready polling.
- Renderer helpers clone the rendered markdown subtree, inline all
  computed styles through a curated allowlist, and ship the resulting
  HTML fragment over IPC.
- Ref-counted listener registration so split-pane layouts install
  exactly one IPC subscription and survive panel churn.
2026-04-20 19:41:12 -07:00
Neil 3bbe9ed712 fix(editor): restore syntax highlighting for .tsx and .jsx files (#878) 2026-04-20 19:22:31 -07:00
Jinjing b3f99b5ae1 fix: preserve selection during external markdown edits and sidebar interactions (#880)
* fix: preserve selection during external markdown edits and prevent blocked worktree switching

* fix: correct TypeScript types for usePreserveSectionDuringExternalEdit and add missing dependency
2026-04-20 18:54:52 -07:00
Jinwoo Hong ff16ab1565 feat(stats): add share button to usage panes (#874) 2026-04-20 18:54:16 -07:00
Jinwoo Hong 25971cd32d fix(terminal): preserve scroll position during split pane drag resize (#865) 2026-04-20 18:53:20 -07:00
Jinjing 3a0fa521be feat(editor): support clicking anchor links to jump to headings (#879)
Anchor-only links (#heading) now scroll to the matching heading in both
the markdown preview and rich editor. Preview uses rehype-slug to stamp
heading ids; the rich editor walks headings with the same stateful
GithubSlugger for parity (including duplicate-heading suffixes).
2026-04-20 18:35:28 -07:00
Brennan Benson b3361569b4 fix(tabs): raise selected tab contrast so it stands out from hover (#877) 2026-04-20 17:30:07 -07:00