mirror of
https://github.com/stablyai/orca.git
synced 2026-11-16 02:47:34 +00:00
mobile-diff-github-layout
15
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
0da741a22f |
test: remove 988 low-value tests (#39797)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com> |
||
|
|
c99e71b315 | refactor: group renderer runtime resource owners (#39571) | ||
|
|
00e25b55b2 |
Show one actionable error when an agent launch cannot prepare its workspace (#37220)
* fix: report agent launch failures once with actionable recovery * fix: keep terminal launch controls shown but waiting while the host connects Replace per-row pending metadata with one derived terminal-readiness flag on the agent menu model, kept out of picker identity keys. Terminal buttons and rows stay mounted and disabled while SSH or a paired server is still connecting; chat and Configure stay usable, and the terminal default is not changed. Repo targets with no workspace yet read the repo host's facts. Invalid Source Control arguments keep their existing actionable message. * fix: keep launch readiness and failure ownership consistent across pickers and fallbacks A host that is still connecting now declines a terminal launch silently at the launcher, including shortcuts and fallbacks, instead of reporting a failure. A terminal fallback refused behind a visible chat reports through that chat's notice rather than a second toast. The agent picker stays usable while only a terminal waits; an armed terminal rechecks readiness on Enter; a configured chat option no longer inherits the terminal's waiting state; waiting terminal controls say why. Invalid CLI arguments name the actual problem for every caller, the no-agent shortcut message is restored, and prospective repo readiness no longer rescans repos on unrelated store writes. * fix: keep the handoff dialog open when a host-waiting launch opens nothing A session continuation launched through the host's admission now waits for that launch to settle before reporting the handoff. When the host declines the chat and its terminal fallback is declined while the host is still connecting, nothing opens, so the dialog stays open for a retry instead of closing with no session and no message. * fix: let the handoff dialog close while its session is starting Cancel, Escape and outside clicks now close the Hand Off dialog even while a start is in flight; Start stays disabled with its spinner. Closing aborts agent detection if it is still running, and a dialog closed during detection starts nothing. A launch already sent settles on its own and reports through its existing owners. The in-flight start belongs to the request it was made for, so a late finish never closes, completes or blocks a dialog reopened since. * test: replace type assertions in launch refusal tests with typed fixtures * refactor: name the setup panel's launch helper launchSurface * perf: resolve a picker's terminal host only when ownership changes The terminal readiness check rebuilt the target's ownership chain and ran the full OS resolver on every store write, for every mounted picker. Each picker now keeps its target host and re-resolves it only when an ownership slice changes; other writes read just that host's connection and contact facts. Local hosts read nothing. The launcher's own pending decline uses the same host pieces from execution-host-facts, so the rule has one copy. * perf: word a declined chat's fallback failure without re-saving launches Wording the failed chat's notice after its terminal fallback was refused re-saved every retained launch record, though the wording itself is never saved. Listeners now hear about it without a save; lifecycle changes still save. The refused-fallback test moves to its own file and counts saves at two sizes. * test: narrow refused launch outcomes where tests read the opened tab launchAgentInNewTab now returns a refusal instead of a tab when the launcher declines, so tests that read the opened tab's surface or completion narrow it first. Fixes the web typecheck. * fix: keep Configure usable and show one reason on a waiting agent row While the host connected, each New Chat agent row was marked aria-disabled, so its Configure button read as disabled to assistive tech and keyboard. The row now only blocks its launch and points to its "Connecting…" reason. A row shows one reason, the one that stops its launch now, and the agent name keeps its width so it is not cut to a single letter. * test: cover distinct repo targets and host freshness in the picker perf contract Pickers for workspaces not created yet now count repo reads cold and after another host's row is republished, at two scales with a repeated-target control, and assert no unaffected renders. Two freshness controls follow the cached host: an owner moving from local to a connecting SSH host and back, and a paired server that is still checking versus verified with its OS. * fix: mark a waiting agent launch unavailable while Configure and chat stay usable An agent row's launch item also held its Configure button (New Chat) or its start-in-chat button (the + menu). Disabling the row while the host connected disabled those too; leaving it enabled made the waiting launch read as available and then do nothing. The launch item and those controls are now siblings. While the host connects the launch item is marked unavailable, dimmed and described "Connecting…", and stays focusable so arrow keys still reach the controls beside it. Configure and chat keep their own state. A chat started from Configure or the chat button goes through the row's guarded launch and closes the menu, without choosing the waiting item. * fix: release the agent row button's press listeners when a press is cancelled Each press on the button beside an agent row added a window listener that only a pointerup removed, so cancelled touches and closed menus left them behind. A press now owns one handler that removes both listeners on release, cancel, the next press or the row closing; drag release onto the button still chooses it. * fix: give the agent launch row item its own menu item variant The launch item beside Configure or the chat button restyled the shared menu item (transparent focus, dimmed while unavailable), which the design system gate rejects. That treatment is now the menu item's launch-row variant; the rendered rows are unchanged. * fix: route the menu's terminal host by owner and repair the e2e and ja checks The menu's terminal readiness now reads workspace records through the workspace record selectors and picks a not-yet-created workspace's repo by the host it names, without the focused-host fallback; with no host named it settles only when the id has one row, which reads the same. Its cached host is re-checked when the settings slice changes instead of reading the focus setting. E2E unit tests narrow refused launch outcomes, and the two new ja strings write Agent as the rest of the catalog does. * test: count a launch as opened only when it returned a surface A refused launch now returns its refusal instead of null, so the parity check asks whether a surface opened. * perf: keep menu readiness on the workspace's owner and index the twin fallback Terminal readiness re-resolved every mounted menu's host on any settings write, and an unstamped worktree whose project is listed both here and by a paired server walked the whole repo catalog to resolve. Readiness now resolves an existing workspace's host from its resource owner only, never the focused default a row-less setup terminal is created on, so settings writes leave it alone. The shared-project check reads that project's rows from the existing per-snapshot repo index instead of the whole catalog. Setup terminals and every route keep their behavior. * test: assert which readiness pickers render on each detected-twin update The detected-twin perf contract now checks render deltas per update: a catalog republication renders no picker, and stamping the first workspace with a checking server, then that server reporting its OS, renders only that workspace's pickers. * test: give the structured chat fixture's owner stub the menu's resource host The fixture replaces the whole worktree owner module with a stub, so the menu readiness check's new resource-host export was missing and the picker path threw before launching. The stub now answers both exports with the scenario's owner host. * Keep launch failures with one action owner on current menus * Align Start work regression with its remote launch target * Narrow refused launch outcomes in current contract tests * Assert notified refusals in existing launch regressions * Assert the refused keyboard launch receipt * Narrow successful web runtime launches in tests * Keep agent menu labels left aligned * Keep merged launch reporting within existing checks * Keep direct launch argument reads within the file limit |
||
|
|
b0ac9ae521 | refactor: organize native chat composer and conversation owners (#39534) | ||
|
|
4d33cd22cc | refactor: group native chat session reads and delivery by owner (#39526) | ||
|
|
c231b5d7da | refactor: place renderer store state with defining feature owners (#39508) | ||
|
|
23808bb73f |
refactor(renderer): organize host and terminal owners and remove forwarding shells (#39320)
* refactor(renderer): organize host and terminal implementation owners * fix(refactor): align active adoption reliability references * refactor(terminal): remove forwarding shells and stale mocks * fix(renderer): consolidate direct owner imports * fix(refactor): route incoming issue trust type to its owner * test(runtime): give independent status viewers separate pairing tickets * style(refactor): normalize rebased terminal mock formatting |
||
|
|
3228095e97 |
refactor(renderer): organize launch, workspace, browser and search owners (#38845)
* refactor(renderer): group launch, workspace, and browser owners * fix(renderer): restore workspace name Enter focus to agent picker |
||
|
|
1bec35aa3a |
fix(chat): keep pending workspace composers ready (#37954)
* fix(chat): keep pending workspace composers ready * test(chat): cover refusal after immediate chat opening |
||
|
|
21857c7424 |
Continue in Chat UI refuses before closing the terminal when another terminal runs the conversation (#37397)
* fix(native-chat): let createSupport ask whether another terminal runs a resumed conversation A resume's createSupport can now carry resumeFrom (behind agent-session.structured.resume-writer-admission.v1, since older hosts' strict params reject it). The host runs the same writer check create runs, leaving out the panes the client will close first (matched by key or by the PTY they resolve to; a shared tmux/OpenCode server is never left out), and probes the candidates together so a bounded client wait is not spent on one probe after another. The host's English refusal says "another chat" only when it names one. The resume params move to their own module to keep the params file under its line limit. Tracked in STA-13440. * fix(native-chat): refuse a resume before anything closes or opens when another terminal runs it Continue in Chat UI asks the host before closing the terminal, naming the panes the close takes; when another terminal runs the conversation it says so in one toast and leaves the terminal open with no chat. Session History's Resume in New Chat (and any other resume launch) asks through the launch admission and, on that refusal, opens no placeholder tab: its caller's one toast is the only notice. A local admission that times out still never leads to a close. Older hosts without the capability keep today's flow. The launch admission's toasts move to their own module to keep that file under its line limit. Tracked in STA-13440. * fix(native-chat): say why a resumed chat failed when a terminal holds it or its history is missing A failed start refused because a terminal's agent still runs the conversation (no chat named as holder) now reads the existing "already running this conversation in another terminal" words instead of a bare "Chat could not be started.". A transcript the host could not find yet gets the same history words an unreadable one already had. This covers the create-time backstop: a terminal started between the pre-check and create, or an older host without the pre-check. Tracked in STA-13440. * fix(native-chat): keep exporting ResumeSource from the session params module * fix(native-chat): keep a terminal open when its host's resume check could not be confirmed A failed capability read was taken as an older host, so the resume question was left out, the host admitted, and the terminal closed before create refused the conversation another terminal runs. An unread capability now leaves the resume unanswered; a host that reports an older capability list keeps its path. * fix(native-chat): say "another terminal" only where the refusal's owner is still known The write failure drops the refusal's owner, so a chat-owned conflict on a send, mutation or phone notice read as a terminal. Only the failed start, which keeps the raw refusal, now records that no chat was named; everywhere else keeps the generic wording. * perf(native-chat): resolve panes in the writer check only when some are left out Every create, resume and acquire check resolved each matching row's pane to its PTY, even with no panes to leave out, and each unresolved key scanned every terminal. With nothing to leave out no pane is resolved now; with some, one identity read context serves every key. * test(native-chat): pin createSupport's resume refusal to create's, and History's one notice Runs the real createSupport handler on a runtime whose status store proves another terminal live: leaving out the source pane admits, otherwise it refuses with create's code and details. The Session History replacement keeps its chat and toasts once when the host refuses before anything opens. * fix(native-chat): translate the "another terminal runs this conversation" toast It is now the only notice when Continue in Chat is refused before the terminal closes, and only English carried it, so every other language showed English. * fix(native-chat): withhold an unread resume capability only where a terminal closes next Reading an unknown capability as unreachable refused Session History and /resume launches on a paired host that main admits and create completes. The host question now asks the plain question on an unread capability and says so on its answer; only Continue in Chat, which closes the terminal next, treats that answer as not admitted, from the same read that chose the request. * test(native-chat): count the writer check's terminal reads with a typed map The perf contract counted iteration through a proxy, which the type-aware lint rejects. It now counts record reads on a Map subclass; a scan of every terminal per row still shows up as rows times terminals. * test(native-chat): read the writer-check fixtures without type assertions The changed-code gate rejects casts. The perf contract builds real terminal records through the identity fixture, and the createSupport parity test reads create's refusal through the shared refusal parser. * fix(native-chat): declare the refusal holder that failed-start cause words read The failed chat's notice passes its launch failure, with the holder its refusal named, through the cause parts to the words that tell a chat from a terminal. Those functions now declare that field instead of carrying it undeclared, which the typecheck rejected for a literal in the test. * perf(native-chat): probe a conversation's writers a few at a time and stop at a holder The writer check started a process probe for every matching row at once and kept them all running after the first live holder refused. It now picks the rows in one synchronous pass, probes at most eight at a time through the shared bounded pool, and starts no probe once a holder refused. * test(native-chat): pin the writer check's single terminal look on the real runtime The scale contract built its own resolver, so a host that made an identity read per pane, or passed none, still passed. It now runs the runtime's own writer check over recorded terminals and counts read contexts and per-key terminal scans: one context and no scans with panes to leave out, none without. |
||
|
|
5cca72e605 |
test: remove 33 low-value tests and obsolete benchmark runner (#37441)
* test: remove 33 low-value tests and obsolete benchmark runner * test: remove import left unused by test deletion |
||
|
|
c8c092599b | refactor: group renderer session launch owners (#37018) | ||
|
|
12edee3ac6 |
Choose default models and effort for agents (#36210)
* Add host-owned model and effort defaults to agent settings * Unify terminal defaults and raw argument precedence * Keep agent model defaults typed through creation * Preserve quick-create prompt through preparation * fix: complete execution-host preference boundary and CI contracts * Preserve raw options until a replacement is emitted * Complete launch choice ownership and consumer contracts * Align launch contracts with compiler boundaries and consolidate proof * Name exported fixture mocks and verify ordered chip removal * Preserve typed choices across compound legacy publication edits * Preserve non-emitted composed launch choices through legacy edits * Preserve rollback omissions and settle agent launches before success * Carry terminal draft ownership through launch completion * Keep inline draft delivery independent of terminal projection * test: consolidate launch ownership contracts * test: check web launch fixture array types * test: align launch fixtures and conformity records * test: import the shell-ready marker from its declaring module * test: give caller routing the web host tab's completion contract |
||
|
|
f06f737802 |
Unify Source Control action permissions and card layout (#30449)
* Source control actions start chats and terminals on their saved model A "start an agent" action's model lived only in free-text CLI arguments, which a native chat never reads, so AI Fix opened a chat on the default model. Each action now saves a structured model and effort that both routes apply: chat create options, or the agent's own flags in a terminal (winning over the same flag in CLI arguments). Desktop, dialog, fix-checks and mobile launches carry it; Settings rows get Model/Effort selects and the CLI arguments field says it is terminal-only. Tracked in STA-11102. * Name the model in the repository override note * Type the dialog's model hand-off; keep Agent in English in Japanese copy * fix: preserve action chat model choices through launch * Preserve action selection ownership across chat launches * Keep terminal host contract fixtures aligned with preflight * fix: wait for action Settings agent inventory * fix: consolidate direct agent routing imports * fix: use standard action option labels * fix: align action launch contracts with shared types * fix: sync action option localization metadata * test: provide action Settings inventory in mounted fixtures * Keep action options row height stable while loading * Let each Source Control action choose its chat permission mode An action's saved chat choice may now carry a permission mode, with or without a model; "Same as new chats" saves nothing. A model is replaced only when the action names one, so a permission-only choice keeps the chat's remembered model and options. * fix(native-chat): leave older hosts their own permission mode and keep action options readable - An action's saved permission mode is sent only to hosts that advertise agentSession.create.options-mode.v1. Older hosts get no mode, in create options or a later setOption, so the chat starts on that host's new-chat default, as a phone launch to such a host already does. Hosts from 1.4.225 to 1.4.227 refused a mode their tables lacked (OpenCode, Grok, OMP), leaving the action unable to start. - Settings action rows give Model and Permissions full rows in the options column so saved values are readable; the loading placeholder reserves the same rows. - Remove two unused locale keys; fix two stale comments. - Tests: the older-host create carries no permission mode; a permission mode picked alone keeps the remembered model on an acquired create. * fix(settings): reserve one options row while loading an action with nothing saved Terminal and permissions-only rows no longer shrink when loading ends; a chat agent with a model list may grow by its Model row once known. * fix(native-chat): keep the create options mode a checked literal type * fix(settings): share verified action option fields * fix(settings): keep action selectors on standard typography * Keep the launch files under their length limits after the main merge The structured route imports its result types where they are defined, and the two older-host action-launch tests share one setup helper. * One action settings section for chat and terminal launches A Source Control action's Model, model options and Permissions now apply whether it opens a chat or a terminal; terminals receive them as the agent's own flags, and a repository's own CLI arguments keep the flags it sets. Extra CLI arguments stay terminal-only. * fix(source-control-ai): one terminal projection for saved action choices Ask in a terminal now states its permission instead of leaving it to the user's own config: Claude and Grok pass --permission-mode default, Codex passes -a on-request -s read-only -c approvals_reviewer="user" (the interactive CLI has no untrusted policy, so a read-only sandbox is what asks before edits). Agents whose CLI has no flag for a mode show the existing "Applies to chats only" hint. The strict launch-preferences projection now requires the launch agent at every caller, composes model ids through the resolver's own step, carries a mode only where the agent's terminal has a flag for it, and the local string wire keeps booleans as 'true'/'false', so Cursor Thinking/Fast reach the terminal and an OpenCode permission-only choice is not refused. The argument parser knows flag arity, so removing a boolean permission flag keeps other options' values, following positionals and '--'. Pre-admission and executor share one terminal admission check on the options the terminal will receive. Customize with Save launches the recipe as it will resolve once saved; legacy partial repository overrides are edited as the complete recipe they resolve to. Empty Extra CLI arguments start collapsed. * fix(source-control-ai): an edited repository action saves complete Every Settings edit of a repository action (agent, model, permission, prompt or arguments) now starts from the complete recipe the action resolves to, whether its stored override is owned or a legacy partial. The resolved agent selection is kept (never an agent only detected to run a default), an explicit null args clear stays null, and empty args stay empty instead of being dropped. Clearing the last preference therefore means the action agent's own defaults rather than re-inheriting Global. The action text draft is lossless: unset or cleared prompt and args stay so until the user types, and the inputs show them as empty, so saving a prompt no longer writes empty args that suppress the agent's default flags. Untouched sibling actions are not rewritten by the edit. * fix(settings): style the Extra CLI arguments toggle through Button's own variant and size CI's changed-code quality check refuses restyle classes on Button and CollapsibleContent. Use the ghost variant at size xs with a margin, and put the content spacing on a plain inner wrapper. * fix: keep saved action and restart launch recipes consistent * fix: describe inherited arguments and chat-only permissions accurately * test: check repository action settings fixture type * test: map saved action options into terminal compiler inputs * fix: retain saved action controls during agent detection * fix(i18n): retire obsolete Portuguese action labels * test: align folder launch fallback mock with outcome export * fix: carry resolved connector launch intent and mode together * test: pin shared action launch branches to recorded agent output * test: preserve saved source control choices through detection and migration * test: align launch fixtures with integrated result contract * test: retain recipe and restart contracts after main integration * Unify Source Control action permission settings * Keep native Ask copy with its owning change * Preserve action drafts and old-host permission intent * Consume rejected Source Control action saves * Follow the moved Settings persistence fixture * Keep permission integration contracts in the cross-version test project * Include the action permission inheritance label in English catalogs * Align launch contracts with shared permission recipes * Keep Source Control action controls within their Settings columns * Use primitive variants for compact action settings controls * Show action arguments only for terminal defaults and widen recipe rows * Apply terminal-only action arguments visibility to repository overrides * Align action permission control with model controls * Use shared settings label for action permissions * Hide action model controls until argument migration ships |
||
|
|
23798eff7c |
Let chats follow the agent permission setting (#32334)
* feat(agents): store each agent's permission itself instead of typing flags into Arguments Terminals and new chats read one stored choice per agent (Use the agent's own settings, Ask for approval, Accept edits, Approve for me, Full access). Orca adds the flag at launch; Arguments hold only the user's own text. A one-time move lifts Orca's flags out of saved Arguments. Older clients still see and write the flag as part of Arguments; the host translates. * fix(agents): say the all-agents switch resets agents set separately; keep primitives unstyled * test(agents): the one-time move returns every launch-profile field * Fix permission carrier ownership and surface-specific defaults * Preserve uncertain permission operands and name the option inventory * Check env entries without indexing typed agent maps * Combine Chat permission capability imports * Use folder execution-host platform for permission environment * Preserve launch map replacement and acknowledge permission saves * Keep permission feedback fallbacks statically discoverable * Provide preload platform to Agents settings render tests * Preserve Gemini approval arguments under Full access * fix(settings): retain complete environment edits through save outcomes * fix(settings): narrow local failure scope and preserve host messages * fix(settings): retire argument drafts after acknowledged saves * fix(settings): keep Goose environment editable after reset * fix(settings): show resolved arguments for legacy hosts * Preserve pending environment resets and bound launch settings work * Use agent permission choices for new chats * Let Claude resolve chat permissions from its own settings * Keep optional settings fallback in repository metadata reads * Consolidate permission report imports * Update permission choice contracts for own settings * Read repository visibility defaults through the raw settings fixtures * Match existing translated Agents settings labels * Update readback and legacy host test expectations * Align Chat behavior tests with host permission capability * Fix permission compatibility and host-owned descriptions * Prepare whole Environment edits and retire unchanged drafts * Handle null explicitly in permission report decoder * Keep Environment settings transitions in an acyclic module * Update raw settings reader test fixtures * Place test fixture safety notes on assertion starts * test: pin permission settings work and recovery contracts * test: type permission settings work fixtures * test: cover migrated permission inputs and captured CLI grammar * Publish permission reports and reuse host capability state * Combine mobile option state React imports * Honor mobile status feed capability for permission reports * test: preserve typed permissions in WSL Claude restarts * Correct permission report child and fixture type contracts * Delegate older-host chats to explicitly selected own settings * Avoid rebuilding live ACP option catalogs * test(chat): place cross-boundary permission contracts in integration project * Preserve existing chat capability gates and complete report test fixtures * fix(chat): preserve newer Claude startup permission reports * test(chat): clarify startup report fixture provenance * Show reported permission modes in chat menus * Keep reported permissions available after chat mode picks * Remove obsolete guard from concrete permission selection * Report the installed approval policy for ACP chat menus * test: keep accepted mobile mutation fixture on current fence * test: cover installed ACP approval report for own chats * test: align capability scaling contract with concrete permission menus * Ship required permission help in English runtime catalog * Adapt permission persistence test to shared menu |