Commit Graph
20622 Commits
Author SHA1 Message Date
OrcaWinandOrcaWin 2b2a87dc20 test: remove 31 low-value performance, SSH and image tests (#39994)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 14:13:41 -08:00
OrcaWinandOrcaWin 8a7dcae3b9 test(e2e): update five stale or racy terminal and agent specs (#39982)
- profile-state restart: runNow now returns the saved pending row (#38217)
- codex account switch: click the backdrop clear of the sidebar seam strip (#38288)
- claude sidebar agent view: drop the removed subagent indicator check (#34558)
- IME preedit continuity: refit after changing the font, like font zoom
- agent send picker: bind local fixture panes to a live PTY so reattach keeps them

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 14:12:02 -08:00
OrcaWinandOrcaWin 9d80e39bee fix(terminal): keep subpixel text on the retained replay frame (#39981)
Since the xterm 6.1.0-beta.336 rows stopped clipping with overflow:hidden,
Chromium draws the transparent replay copy over the opacity-0 screen with
grayscale antialiasing while the live screen keeps LCD text, so glyphs
shimmered for the replay hold on subpixel-AA systems. Paint the copy with
the terminal's opaque background so it keeps LCD text.

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 14:11:48 -08:00
OrcaWinandOrcaWin 774950d55d test: remove 18 low-value SSH and managed-server tests (#39979)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 14:00:20 -08:00
OrcaWinandOrcaWin c20c91a017 chore(ratchets): point the sync fs baseline at the moved agent-hooks files (#39986)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 13:59:42 -08:00
Neil 65412f3f6d refactor: organize browser extension requests and rule owners (#39975)
* refactor: organize browser extension request and rule owners

* refactor: retain browser extension type-reference directives

* chore: follow concrete owners in sync filesystem baseline
2026-11-08 13:54:02 -08:00
Brennan Benson c463effa5a test(perf): render and identity contracts for agent status, sidebar, tab strip and chat (#39954)
* test(perf): render and identity contracts for agent status, sidebar, tab strip and chat

Twelve operation, render and identity contracts at the production seams of
the hottest UI paths, each driven at N and 10N with one hardcoded bound and
shown to fail with its regression restored. Registers them in the contract
list and fixes the perf workflow's path filter, which had drifted to 12 of
19 contracts. Removes test-only production exports nothing reads.

* test(perf): prove composer typing lands; drop dead rebuild counter

Review: the composer contract never checked the draft reached the composer,
and its transcript control could not fail; the live-index rebuild counter
and a bucket constant had no readers after the test exports went.
2026-11-08 13:34:29 -08:00
Brennan Benson 1d28b8882c chore(ratchets): fail PRs that add sync fs calls on Electron main or new setInterval polls (#39930)
* chore(ratchets): count sync fs calls on Electron main and setInterval calls

Sync fs on main and fixed-cadence intervals that never settle were two of the
most common perf fix classes since September, and no gate counted them. Both
ratchets grandfather today's uses per file and fail when a file's count grows.

* chore(ratchets): count every sync fs export, src/shared and node:timers intervals

Review: the allow-list missed descriptor/copy APIs, src/shared helpers run on
main too, and setInterval imported from node:timers escaped the timer count.

* chore(ratchets): keep hosted setInterval calls beside a named timer import

Review: a named node:timers import zeroed window/globalThis calls too, a
destructured require was counted twice, and collector edits didn't select
the timer ratchet in check:changed.

* chore(ratchets): charge calls through an alias, not the alias binding

Decider ruling B on review finding C6: binding a plain alias of a gated call
counted as a use, so an alias refactor failed every collector-based ratchet.
Conditional/fallback aliases and exported bindings stay charged.

* chore(ratchets): count bare setInterval only when nothing local shadows it

Review: the timer ratchet kept its own narrower binding resolver, so alias
and namespace-destructure forms of an imported setInterval counted twice.
Module bindings are the shared collector's; a bare call is the global only
when the file declares no setInterval binding.

* chore(ratchets): resolve bare setInterval calls per scope

Decider ruling A: the file-wide shadow rule let an unrelated parameter or type
declaration named setInterval hide every global poll in the file. Each bare
call now resolves through a single-file TypeScript checker (noLib, noResolve)
and counts when it binds to nothing declared in the file.

* chore(ratchets): write the timer baseline exactly as --prune does

* chore(ratchets): charge global timer aliases and bracket access

CodeRabbit: `const schedule = setInterval; schedule(poll)` and
`window['setInterval'](poll)` counted zero. Count value references to the
global timer (per scope) instead of only direct calls.

* chore(ratchets): charge shorthand timer escapes; skip writes, typeof and JSX tags

Review: `{ setInterval }` of the global counted 0, while assignments to it,
parenthesized typeof probes and a <setInterval/> tag counted 1.

* chore(ratchets): charge compound assignments to the global timer

Review: `||=` and `??=` read setInterval before writing it, so only a
plain `=` target is write-only.

* chore(ratchets): regenerate baselines for files main moved

main's SSH reorganisation moved counted files under src/main/ssh and
src/main/managed-server; counts are unchanged except one sync fs call main
removed.
2026-11-08 13:34:07 -08:00
OrcaWinandOrcaWin 77926605e0 test: remove 2 low-value vault and restart tests (#39970)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 13:31:21 -08:00
Brennan Benson 2d1298f0d6 Open agent setup with the current model highlighted (#39923)
* Open agent setup with the current model highlighted

* Start setup on the current model only when it is a rendered, non-Arguments row; remount once defaults settle

* Return the setup highlight to the current model when a model search is cleared

* Scope setup highlight navigation to one event and scroll the restored model into view

* Scope setup highlight navigation to the event's phases and reveal the start model when it arrives
2026-11-08 13:29:33 -08:00
Neil b5e38ad9c6 refactor: organize agent hook installation and server owners (#39969)
* refactor: organize agent hook installation and server owners

* refactor: align hook mock registries and packaged entries
2026-11-08 13:23:03 -08:00
OrcaWinandOrcaWin 29c7295620 test: remove 15 low-value SSH tests (#39968)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 13:14:55 -08:00
Kelvin Amoaba da8162e3b9 fix(native-chat): send queued messages after resuming a chat interrupted by a restart (#39965) 2026-11-08 21:03:11 +00:00
OrcaWinandOrcaWin 9308ad03be test: remove 21 low-value CLI and GitHub tests (#39963)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 12:59:35 -08:00
2652059825 perf(notebook): bound retained output from noisy cells (#39888)
A cell that streams hundreds of MiB of output used to grow the renderer
heap without limit and freeze the window. Each cell now keeps the first
2 MiB of stream text, 16 MiB of total output and 2000 outputs, then adds
one notice and drops later output. The first error and the first result
each get a separate bounded allowance, so the error summary still shows.
A display update that does not fit is rejected and the previous display
is kept. clear_output, with or without wait, resets the budget.

markRunCommitted and forgetFinishedRuns move to ipynb-kernel-runs.ts so
ipynb-kernel-session.ts stays under the max-lines lint cap.

Replaces #27721.

Co-authored-by: m4air <m4air@m4airs-MacBook-Air.local>
Co-authored-by: brennanb2025 <79079362+brennanb2025@users.noreply.github.com>
2026-11-08 12:47:54 -08:00
OrcaWinandOrcaWin 21462e0566 test: remove 26 low-value mobile tests (#39961)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 12:46:42 -08:00
Kelvin Amoaba 77b297bbe8 fix(mobile): refresh native Home when worktree rows change (#39929) 2026-11-08 20:45:51 +00:00
Kelvin Amoaba 9bfa701b9c perf(mobile): keep task lists on the phone between launches (#39948)
* perf(mobile): keep task lists on the phone between launches

* test(mobile): type the stored task list setItems mock
2026-11-08 20:45:13 +00:00
Kelvin Amoaba d8e34719d1 perf(runtime): drop old terminal resume output through a head index instead of splicing (#39931)
* perf(runtime): drop old terminal resume output through a head index instead of splicing

* refactor(runtime): bound reverse scans with findLastIndex
2026-11-08 20:43:48 +00:00
OrcaWinandOrcaWin 2b89fa7c98 test: remove 61 low-value mobile tests (#39955)
* test: remove 61 low-value mobile tests

* test: use array shorthand in retry fixture

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 12:31:33 -08:00
OrcaWinandOrcaWin 8e55f80278 test: remove 92 low-value mobile tests (#39957)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 12:29:43 -08:00
Jinjing ed719bf794 Allow disabling plugins from activity bar (#39956) 2026-11-08 12:24:54 -08:00
Neil 0d1220c31f Organize SSH and managed-server modules by concrete owner (#39937)
* refactor(main): organize SSH transport and managed server owners

* Remove orphan deploy readiness fixture and shrink test baselines

* refactor(wsl): import lock records from their defining owner

* refactor(wsl): use the canonical deferred update contract
2026-11-08 12:20:22 -08:00
OrcaWinandOrcaWin 49d74f57b1 test: remove 6 low-value query and cache tests (#39953)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 12:06:50 -08:00
Kelvin Amoaba 2881d6f5c6 fix(native-chat): drop Open in new tab from the file link menu (#39950)
Chat file links share the terminal's row builder, which added the row
whenever the source tab had a split or neighbor. Open file already places
the file beside the chat, so the extra row was noise. Terminal links keep it.
2026-11-08 20:06:12 +00:00
Kelvin Amoaba d0f273f5dd perf(ai-vault): skip re-rendering unchanged Session History rows (#39944)
* perf(ai-vault): skip re-rendering unchanged Session History rows

* fix(ai-vault): keep memoized history rows current with host capabilities and time

* fix(ai-vault): recompute chat-resume eligibility when host agent facts change

* refactor(ai-vault): simplify the history row memo comparator

* fix(ai-vault): drop the hook-deps suppression React Compiler bails on
2026-11-08 20:04:15 +00:00
OrcaWinandOrcaWin 41e980f4d6 test: remove 9 low-value IPC and SQLite tests (#39947)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 11:59:11 -08:00
Brennan Benson ed78b51cad Let native chats finish slow agent startup (#38727)
* Let native chat startup follow provider readiness

* Remove obsolete startup deadline expectation

* Preserve startup retry when Claude exits before initialize

* Join startup cleanup with the observed Claude exit

* Model the observed Claude exit in the startup fixture

* Wake Pi startup on fatal session failure

* Keep Pi refusal assertion typed as an unknown result

* Keep startup tests tied to the fixed regressions
2026-11-08 11:58:34 -08:00
Brennan Benson 252b427dfd Display private GitHub attachment images in fetched items (#39250)
* Display private GitHub attachment images in fetched items

* Keep attachment event identity aligned with committed renders

* Complete GitHub image response type contracts

* Return private image sources with accepted issue edits

* Keep issue edits successful without optional display data

* Cover unusable issue edit image responses

* Keep optional GitHub image parsing from failing accepted saves

* Fetch GitHub body images with the existing body read
2026-11-08 11:58:15 -08:00
OrcaWinandOrcaWin b4f198379a test: remove 17 low-value mobile test cases (#39941)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 11:43:36 -08:00
Kelvin Amoaba 51c77320bc feat(mobile): mark agents read and clear them from the Agents tab (#39245)
Unread rows show the desktop's bell, swipe right toggles read, swipe
left clears a finished agent, and the long-press and options menus get
Mark read/unread, Unread only, Mark all read and Clear finished. Writes
go through agentActivity.setRead/clear and show optimistically until the
desktop's list confirms them.
2026-11-08 19:40:47 +00:00
Brennan Benson 8f58492e3f fix(toasts): match toast action buttons to Orca's Button (#39935)
* fix(toasts): match toast action buttons to Orca's Button

* fix(toasts): keep toast cancel buttons on the secondary color in dark mode
2026-11-08 11:37:14 -08:00
Kelvin Amoaba c5c12af6f7 fix(session-history): match more Claude and Pi folder names in scope recovery (#39936)
Workspace and Project add older in-scope sessions by matching agent
folder names to the scope. Several real names were missed: Claude's
truncated long-path buckets, Windows paths in another case, drive and
filesystem roots, the other WSL share spelling, and Pi buckets under
PI_CODING_AGENT_DIR's sessions/ folder. An unreadable folder now shows
up as a scan issue instead of looking empty.
2026-11-08 19:32:44 +00:00
Kelvin Amoaba c18515a5d9 fix(ai-vault): keep search results on screen while typing in Session History (#39325)
* fix(ai-vault): keep search results on screen while typing in Session History

* perf(ai-vault): fold session search text once and keep resolver maps stable on empty replies
2026-11-08 19:32:30 +00:00
Kelvin Amoabaandggbdpq ba6b11cd8b fix(ai-vault): cut session search index disk writes with wider FTS merges and fewer vacuums (#39314)
* fix(ai-vault): cut search-index disk writes from merge rewrites and idle vacuums

The session-search index sustained tens of GB of daily writes on busy
multi-agent days (#36666): ~650 KB/s of file-backed pages dirtied by the
Orca Helper process that owns the index, against a ~214 MB database.

Two write paths compound there:

1. FTS5 merges whole segment levels on every steady append. With the
   default automerge=4, an index of this size rewrites several bytes of
   deep segments for each byte appended, and every merge page is then
   copied from WAL into the database by autocheckpoint.
2. Every full purge ran `incremental_vacuum(2000)` even when it deleted
   nothing, moving free pages around the file. Full purges back every
   freshness wait (`reconcile({ full: true })`) and the periodic sweep,
   so idle sweeps themselves became a write source. A measured loop
   (one busy transcript appending 100 KB per 20 s cycle, sweeps every
   15 cycles) shows sweeps dropping from 428-736 KB to 132-144 KB per
   pass and merge spikes from ~1 MB to 432-800 KB (-28% total WAL bytes
   at 10 MB index scale; the merge saving grows with index size).

Fix:

- Set FTS5 `automerge` to 8 on every open (new and existing databases,
  no schema rebuild): merging wider rewrites roughly half the
  deep-level pages on this insert-heavy, rarely-deleted index, at a
  small read fan-in cost.
- Gate the trailing `incremental_vacuum` in retention drains on actual
  deletion work. Drains scheduled after real deletions (retention,
  replacement, retirement) keep reclaiming pages; recurring unlimited
  purges with nothing to delete leave the freelist for page reuse
  instead of shuffling it.

Read paths, cache semantics, and the on-disk schema are unchanged.

Fixes #36666

* fix(ai-vault): vacuum the search index only when free pages pile up

FTS merges free pages on every write and later writes reuse them, so a
vacuum after every drain batch and sweep only moved pages around. Gate it
on the free share of the file instead of on whether a purge deleted
anything, which also covers drains after whole-session replaces.

---------

Co-authored-by: ggbdpq <ggbdpq@gmail.com>
2026-11-08 19:32:09 +00:00
Kelvin Amoaba 96ac06c00f feat(mobile): add an Agents tab listing every agent across your desktops (#39244)
* feat(agents): send paired phones the desktop Agents list's verdict per agent

While a phone is paired, the desktop window publishes its own Agents-list
classification for each pane (listed, status, unread, clearable, title,
worker parent) and worktree.ps attaches it to each agent row, so the phone
lists agents exactly as the sidebar does. agentActivity.setRead/clear apply
through the sidebar's own Activity actions and resolve once the new
verdicts are stored.

* feat(mobile): add an Agents tab to Home

One row per agent across every paired desktop, grouped by status, with
a desktop filter, search, group-by, nested workers and a long-press
menu. Feed's per-workspace Agents section becomes a short Needs you
list, and the needs-you badge moves to the Agents tab.
2026-11-08 19:31:50 +00:00
Kelvin Amoaba 9abd095d08 feat(agents): send paired phones the desktop Agents list's verdict per agent (#39243)
While a phone is paired, the desktop window publishes its own Agents-list
classification for each pane (listed, status, unread, clearable, title,
worker parent) and worktree.ps attaches it to each agent row, so the phone
lists agents exactly as the sidebar does. agentActivity.setRead/clear apply
through the sidebar's own Activity actions and resolve once the new
verdicts are stored.
2026-11-08 19:30:27 +00:00
OrcaWinandOrcaWin e1a20be7ad test: remove 8 low-value mobile test cases (#39939)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 11:26:44 -08:00
OrcaWinandOrcaWin 4e70998609 test: remove 8 low-value test cases (#39934)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 11:23:56 -08:00
Kelvin Amoaba b032aa5615 feat(runtime): tell phones which settings changed (#39718)
* feat(runtime): tell phones which settings changed

* test(mobile): re-record Source Control goldens for the settings stream
2026-11-08 19:12:26 +00:00
Jinjing 8781bcb6be Reduce the maximum height of the model picker (#39774) 2026-11-08 10:58:00 -08:00
OrcaWinandOrcaWin 069cc7e22e test: remove 10 low-value mobile test cases (#39927)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 10:57:42 -08:00
OrcaWinandOrcaWin fcd356ad88 test: remove 6 low-value test cases (#39925)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 10:50:46 -08:00
Kelvin Amoaba f74bb65fa1 feat(runtime): tell phones when git status changes (#39672)
* feat(runtime): tell phones when git status changes

* fix(runtime): tell phones about HEAD and packed-refs moves too

* fix(runtime): don't let a phone's status re-read join a read begun before the change

* perf(runtime): limit status-read invalidation to the checkouts an outside change touched

* fix(runtime): match a checkout's status keys under any execution host

* fix(runtime): invalidate globally while a primary checkout is unread

* test(mobile): re-record the Changes and settings goldens on the rebased main

* fix(runtime): invalidate globally while a listed checkout has no cached path

* test: follow the moved paired-client harness

* refactor(mobile): let the host list's catalog read hold the event router
2026-11-08 18:36:13 +00:00
Kelvin Amoaba 2aa47c91d2 fix(runtime): send a terminal's first screen before closing its stream on exit (#39681)
* fix(runtime): send a terminal's first screen before closing its stream on exit

A PTY exit while terminal.subscribe was still publishing its first snapshot
ended the stream at once: the phone got end with no screen. The exit now
waits for that publication, the exited PTY's model stays readable (off the
live map) until it finishes, and queued layout work settles on exit so it
can't hold the stream open.

* fix(runtime): skip the renderer seed when the PTY exits while its screen is read
2026-11-08 18:34:16 +00:00
Brennan Benson 5266dbe53b fix(github): stop PR pages and GitHub requests from hanging forever when the rate-limit cache expires (#39581)
* fix(github): stop PR pages from hanging when the rate-limit cache expires

Slot holders await assertRateLimitBudget -> getRateLimit while holding a
gh semaphore slot, and the /rate_limit probe queued for a slot behind
them. With all four slots held by budget waiters nothing ever released.
The probe is quota-exempt and deduped, so it no longer takes a slot.

* fix(github): bound rate-limit probe concurrency without the gh semaphore

Forced getRateLimit calls now join an in-flight probe, and all /rate_limit
probes share a small probe-only limiter that acquires nothing else.
Fold the deadlock regression test into rate-limit.test.ts as a direct await.

* fix(github): make forced rate-limit probes read quota after the call

Forced callers (403 reset refinement) share one follow-up probe queued
behind the running one instead of joining a probe that may predate the
403, so a stale positive budget cannot clear a fresh breaker block.

* fix(github): hand forced rate-limit follow-ups off synchronously

A pending forced follow-up could outlive its probe's settlement, so a
later forced caller joined a probe that predated it. Settlement now
detaches the shared deferred follow-up and starts its probe in one
synchronous step. Run rate-limit.test.ts on the Node runtime, where the
V8 scheduling that opens the race is reproducible.
2026-11-08 10:29:37 -08:00
OrcaWinandOrcaWin 4eadc6623e test: remove 19 low-value skill and renderer tests (#39921)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 10:28:11 -08:00
buf0-bot[bot] 1af2a4b804 Update README downloads badge (#39922)
Co-authored-by: buf0-bot[bot] <252831055+buf0-bot[bot]@users.noreply.github.com>
2026-11-08 18:20:37 +00:00
Brennan Benson ace74af490 Open search-result agent setup as a hover submenu (#39569)
* Open search-result agent setup as a hover submenu

The + menu's search-result agent rows opened setup through a separate
click popover. Route them through the same native submenu the regular
agent rows use, delete the popover path, and keep hover from moving
focus off the omnibox input.

* Keep omnibox typing in the search box when agent setup opens or closes

Hovering a search row's › no longer moves focus into the setup panel, and
Escape, ArrowLeft or leaving the open row return focus to the search input.
Also stop dimming disabled setup rows twice.

* Give omnibox agent setup pointer grace before another row closes it

Crossing an ordinary result on the way to the panel no longer closes the
setup; another row closes it after 300 ms unless the pointer reaches the
panel or returns to its row, like Radix submenus.

* Keep a hover-opened omnibox setup from taking focus after a keystroke

Typing can shift a row under a resting pointer and open its setup while
Radix is in keyboard mode; its content autofocus now returns to the
search input until the pointer moves into the panel.

* Open omnibox agent setup on pointer movement, and keep panel typing on leave

Per the decider ruling: a row shifting under a resting pointer no longer
opens its setup (Radix sub-triggers also open on pointermove), and leaving
the row after clicking › keeps focus in the setup editor instead of moving
typing back to the search box.

* Return omnibox focus to the search box when a focused setup closes on its own

Clicking › and then moving to another row let the hover grace close the
panel while it held focus, dropping focus to the page; closing it now
returns typing to the search input.

* Test that a caller-closed setup returns focus to the omnibox input

* Render omnibox search tests inside the + menu so agent setup has its menu

* Keep omnibox setup wiring React Compiler friendly

Build each row's setup handlers at the call site from plain hook state, and
configure the launched option inside the handler, so nothing that reads refs
runs during render.
2026-11-08 10:08:52 -08:00
Brennan Benson 7220069db0 Open the branch picker from the branch name under the chat composer (#39692)
* Open the branch picker from the branch name under the chat composer

* Copy the current branch from its row in the composer's branch picker

* Keep the composer copy button clickable and out of the list's keyboard, and keep a twin copy's status out of the picker

* Read a twin copy's status privately in the branch picker and drop refreshes that land after its twin is selected

* Block on a twin's returned read error, re-read after the picker closes itself, and distrust a twin's leftover status on becoming owner

* Build the environment name selector outside the component so the React compiler can lower the picker

* Trust a copy's status again once its picker refresh settles, even when an identical newer poll superseded it

* Read a newly owning copy's own status until the inherited slot changes, instead of trusting a settled refresh

* Route the composer picker through the copy's owner and block while this chat's turn is active

* Keep the composer picker's agent gate on the shared working check, as in Source Control
2026-11-08 10:06:53 -08:00