Commit Graph
20622 Commits
Author SHA1 Message Date
OrcaWinandOrcaWin dabdb6068d test: remove low-value chat hook tests (#38448)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 00:13:04 -08:00
OrcaWinandm4air 5434ee9933 fix(ci): unblock the release cut's Windows skill gate and Linux golden run (#38443)
* fix(ci): run the release skill-sharing Electron install step in bash

#38130 turned this step into a POSIX path fallback, but the skill sharing
release gate also runs on windows-2022, where the default shell is
PowerShell. The step failed with a ParserError, so release-preflight
skipped every build for the v1.4.250 cut.

* test(e2e): keep the one-time Codex notice out of golden runs

The v1.4.250 golden e2e on Linux timed out clicking New Terminal: the
'Orca now runs Codex without its shared server' toast fires once when the
golden stub (a Codex terminal) appears, and here it landed while the +
menu was open and closed it. Mark it seen in the completed-user fixture
like the other one-time notices, and restore that fixture from the
workflow ref in the release golden job so a recovered tag uses it.

---------

Co-authored-by: m4air <m4air@Mac.localdomain>
2026-11-05 08:05:38 +00:00
OrcaWinandOrcaWin 08a8bc1671 test: trim low-value chat transport and subagent tests (#38438)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 23:55:07 -08:00
OrcaWinandOrcaWin 5a01490c06 test: trim low-value structured session and status tests (#38441)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 23:54:07 -08:00
Jinwoo Hong 0d696aef33 Let a finished worker keep messaging its coordinator (#38357)
* Let a finished worker keep messaging its coordinator

* Tell a finished remote worker why its coordinator is out of reach

* Let a finished worker's ask wait for its answer instead of starting a follow-up

* Share the assignee check, keep the finished lookup in dispatch-lookup, and fix review findings

* Match a finished terminal worker by its process too; cover resume after a follow-up
2026-11-05 02:42:50 -05:00
OrcaWinandOrcaWin a5b1b72994 test: trim low-value chat ownership and transcript tests (#38430)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 23:40:06 -08:00
Jinwoo Hong 4bd16d8877 fix(orchestration): don't let a dim prompt suggestion hold mail as a draft (#38370)
Claude Code shows its next-prompt suggestion as dim text in the empty
composer. The orchestration draft hold read it as the user's unsent draft
and held wakes for up to 10 minutes after the user last typed. The hold
now asks the typed-only composer reader (the one native chat already uses
for a terminal's unsent input), so dim suggestions and placeholders no
longer count, while real typed drafts still hold delivery.

Fixes #38015. Based on the diagnosis in #38015 and the approach explored
in #38077.
2026-11-05 02:35:52 -05:00
OrcaWinandOrcaWin 0dd5998ebe test: trim low-value composer and draft test inventories (#38426)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 23:33:54 -08:00
OrcaWinandOrcaWin 9288fcf32f test: trim low-value native chat attachment and header tests (#38428)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 23:31:39 -08:00
Jinwoo Hong f7cd8d231d fix(orchestration): drop the worker brief line that read as a ban on pushing (#38349)
* fix(orchestration): let the task spec decide whether a worker pushes or opens a PR

The worker brief said "Don't post to Slack, GitHub, or other channels during the run." Codex read that as forbidding pushes and pull requests even when the task asked for them. The rule began as a reporting rule (reach the coordinator through the CLI, not Slack or GitHub comments), so fold it back into that sentence.

Fixes #38111

* fix(orchestration): drop the Slack and GitHub clause from the worker brief
2026-11-05 02:27:56 -05:00
OrcaWinandOrcaWin 2dfa51079c test: trim low-value session bridge and sender tests (#38422)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 23:19:23 -08:00
6c0c0a3403 fix(contextual-tours): don't reopen the agent sessions tour for users who already split (#38390)
* fix(contextual-tours): don't restart the agent sessions tour for existing users

v1.4.249 prepended a "New agents start here" step to the workspace agent
sessions tour. No earlier action completes it, so long-time users who never
closed the old tour (usually because they had already split panes) now see
it from step 1. Mark it seen at startup for profiles that finished
onboarding before that release; new users still get the full tour.

* test(contextual-tours): cover which profiles skip the agent sessions tour

Profiles still in onboarding, or onboarded at or after the v1.4.249 release,
keep the tour; earlier profiles get it marked seen without losing other seen tours.

* fix(contextual-tours): don't reopen the agent sessions tour for users who already split

Replace the startup cutoff backfill with a rule derived from what the user did:
a tour never auto-starts after one of its actions is already done (unless it is
already running this session or replayed), and a start never lands before the
latest done step, so steps added ahead of the user's progress can't rewind it.

* perf(contextual-tours): stop watching the page for a tour progress already blocks

* fix(contextual-tours): decide the progress block inside the tour effect

Selecting the derived flag ran it against partial test stores during render; read
the raw fields and decide in the effect, like the session-consumed check.

---------

Co-authored-by: m4air <m4air@Mac.localdomain>
Co-authored-by: Brennan Benson <79079362+brennanb2025@users.noreply.github.com>
2026-11-04 23:11:32 -08:00
OrcaWinandOrcaWin ffff2d9ea9 test: remove low-value attachment and tool presentation tests (#38420)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 23:08:45 -08:00
OrcaWinandOrcaWin fd04f15026 test: remove low-value chat session and picker tests (#38417)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 23:02:33 -08:00
Jinwoo Hong f0e7eaa070 fix(orchestration): let worker_done settle when SQLite cannot write a temp file (#38358)
On a host whose temp directory is full or unwritable, every worker_done
failed and the task never settled (#38123). The settlement runs inside
savepoints, and SQLite keeps savepoint journals in a temp file by default.
When that file cannot be written, SQLite rolls back the whole transaction
itself, so our own rollback then failed with 'cannot rollback - no
transaction is active' and hid the real error. Heartbeats and questions
use no savepoints, which is why they kept working.

The orchestration database now keeps temp storage in memory, and the
lifecycle rollback skips when SQLite already ended the transaction so any
remaining failure of this kind reports its own error.
2026-11-05 02:02:23 -05:00
OrcaWinandOrcaWin 7e99398ff5 test: trim chat queue, prompt and receipt test inventories (#38414)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 22:49:44 -08:00
Neil 1cdc53d47a refactor(ci): colocate the shard timing catalog with sharding (#38409) 2026-11-04 22:47:35 -08:00
OrcaWinandOrcaWin 4353e3287c test: remove low-value transcript and permission-picker tests (#38408)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 22:32:50 -08:00
OrcaWinandOrcaWin a927cccb04 test: trim chat rendering inventories and synthetic layout suites (#38405)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 22:23:25 -08:00
OrcaWinandOrcaWin c3f3a1d24f test: remove native chat inventories and redundant composer cases (#38402)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 22:18:49 -08:00
OrcaWinandOrcaWin 319a01aacd test: trim project view inventories and duplicate dialog cases (#38399)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 22:07:26 -08:00
OrcaWinandOrcaWin f64d9c80a8 test: remove renderer flag inventories and fake React suites (#38396)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 22:01:32 -08:00
Neil 159ef69b44 refactor(native-chat): drop the unreachable answer-input paste origin branch (#38395)
#38325 made the question card's answer field a textarea, so
findNativeChatAnswerField (HTMLInputElement-only) can no longer match.
The bridge's 'origin instanceof HTMLInputElement' branch was already
unreachable since #32035 stopped the context menu passing a paste origin;
the only remaining origin caller (app-menu paste) passes the queued-editor
textarea from findNativeChatPasteField. Remove the branch, the helper, and
the test that only exercised it by calling the bridge directly.
2026-11-04 22:00:30 -08:00
Neil 46fa97a6b4 refactor(relay): group route, forwarding and connection owners (#38374)
* refactor(relay): group route, forwarding and connection owners

* refactor(relay): use explicit defining-owner type imports
2026-11-04 21:59:50 -08:00
OrcaWinandOrcaWin f3e9e92fd4 test: remove mock-only editor drop and retry suites (#38391)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 21:57:27 -08:00
OrcaWinandOrcaWin a9d75910d9 test: trim renderer mock and private-work assertions (#38393)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 21:54:26 -08:00
NeilandClaude 45b4f1a69c Highlight the first agent search match that Enter picks (#38382)
* Highlight the first agent search match that Enter picks

Co-Authored-By: Claude <noreply@anthropic.com>

* Move the search-default highlight into the dropdown menu primitive

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-05 05:45:30 +00:00
OrcaWinandOrcaWin 005312b30d test: remove mocked image import and link routing suites (#38384)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 21:39:49 -08:00
OrcaWinandOrcaWin 6c888cf295 test: trim synthetic viewport and save callback tests (#38387)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 21:38:45 -08:00
OrcaWinandOrcaWin f447fd1c9b test: remove fake menu and lowlight parity suites (#38383)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 21:27:38 -08:00
OrcaWinandOrcaWin 34350b70f3 test: trim redundant notebook and editor tests (#38377)
* test: trim redundant notebook and editor tests

* test: remove implementation-budget notebook and PDF tests

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 21:17:49 -08:00
OrcaWinandOrcaWin fc2ce9fda2 test: remove redundant editor helper and mock suites (#38375)
* test: remove redundant editor helper and mock suites

* test: remove capability-only and mocked paste suites

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 21:17:31 -08:00
Neil 9bd6272fdf refactor(tooling): organize build, CI, and test owners (#38130)
* refactor(tooling): organize test runtime and maintenance owners

* test(tooling): preserve relocated runtime fixture dependency edges

* refactor(tooling): preserve xterm routing owner checks

* ci(tooling): include routing owner in sparse checkout

* test(tooling): preserve copied workflow dependency closures

* fix(tooling): normalize hashed JSON assets in release parity

* fix(tooling): distinguish asset aliases from literal references

* fix(tooling): frame normalized asset reference payloads

* fix(tooling): normalize decoded JSON asset references

* refactor(tooling): organize build, CI and release owners

* fix(tooling): align moved generator and workflow path contracts

* fix(tooling): update generated plugin bundle owner banners

* test(tooling): create relocated mobile verifier fixture directories

* test(tooling): copy headless detector dependency closure

* test(tooling): align native batch policy fixtures with owner path

* fix(tooling): link moved reliability command to historical evidence

* fix(tooling): preserve nested sandbox owners and canonical guide source

* fix(tooling): target release version owners in checkout fixture
2026-11-04 21:08:19 -08:00
OrcaWinandOrcaWin a7f39ba4d1 test: trim redundant Markdown and editor tests (#38372)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 21:02:00 -08:00
OrcaWinandOrcaWin 908e101546 test: remove low-value editor inventories and mock tests (#38368)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 20:55:55 -08:00
OrcaWinandOrcaWin 46be7e06bb test: remove low-value editor prop and helper tests (#38366)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 20:50:27 -08:00
OrcaWinandOrcaWin 20b28609f4 test: remove low-value dashboard state and profile tests (#38364)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 20:42:02 -08:00
OrcaWinandOrcaWin b6d760d4f9 test: remove low-value dashboard and preview tests (#38362)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 20:37:28 -08:00
Jinwoo Hong c9bf506097 fix(diff): colour visible diff lines as soon as a pane is laid out (STA-12770) (#38266)
Tokenize visible diff-pane lines when a diff editor's model, hidden areas or layout change, so outer-scrolled combined-diff sections paint coloured (STA-12770).
2026-11-04 23:31:03 -05:00
Jinwoo Hong a6e5b5bd41 fix(combined-diff): load up to three diff sections at once (STA-12716) (#38265)
Load up to three combined-diff sections at once instead of one (STA-12716).
2026-11-04 23:30:59 -05:00
OrcaWinandOrcaWin 82585c11dc test: remove low-value browser and dashboard test inventories (#38360)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 20:26:59 -08:00
OrcaWinandOrcaWin 57d384cd69 test: remove low-value terminal, VM and voice settings tests (#38351)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 20:18:41 -08:00
OrcaWinandOrcaWin 778470b3cd test: remove low-value renderer inventories and mock pipelines (#38356)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 20:16:20 -08:00
308b500050 Use the shared agent picker for Source Control authoring (#38019)
Use the shared agent picker for Source Control Customize and AI-author setup. Preserve existing Arguments, templates, Custom commands, model/effort choices and settings ownership; keep nested menus and tooltips within their dialog portal.

Co-authored-by: Jinjing <6427696+AmethystLiang@users.noreply.github.com>
Co-authored-by: Courtenay <1909814+hdsheena@users.noreply.github.com>
Co-authored-by: Andy Zhang <hiandyzhang@gmail.com>
2026-11-04 20:10:48 -08:00
OrcaWinandOrcaWin d4db1a36f6 test: remove low-value settings UI and persistence pipelines (#38346)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 20:01:07 -08:00
OrcaWinandOrcaWin aefcdd99a5 test: remove low-value mobile and repository settings tests (#38339)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 19:49:00 -08:00
Brennan Benson f249010999 Keep a Pi chat awake while its background subagents run (#38207)
* fix(pi): keep a native chat awake while its background subagents run

The idle sweep stopped a Pi chat 30 quiet minutes after its last turn even
while pi-subagents workers it had started in the background were still
running. On Windows those workers are children of Pi and died with it, so
the coordinator never got their results.

Pi extensions with detached work already declare it through the shared
session-liveness registry that Pi hosts read before idle eviction, and
pi-subagents registers there. Native chat runs Pi as a child process, so
Orca now loads a small bridge extension into native-chat Pi launches that
installs that registry at load and reports, over Pi's RPC stdout, whether
the session has active providers. The Pi adapter keeps the last report and
the idle sweep treats it like provider-held sends: the chat is not stopped
while work is declared, and idles a full window after it ends. Nothing else
reads it, so clear and compaction are unchanged.

Tracked in #28710.

* fix(pi): harden the background-work bridge after review

Keep the bridge ticking after a failed report so the next answer is
re-derived, validate registrations the same way the reference host does,
log a bridge that could not be written, and use type guards in its test.

* fix(pi): confirm Pi background work at idle-stop time

A cached report could be stale when work starts between samples, so the
idle sweep now asks a running child's provider right before stopping it
and stops only on a fresh idle answer. Pi's bridge answers requests that
Orca drops into a private per-child folder, replying on its status line,
so the probe never becomes a dialog or a prompt other extensions or the
model would see. A child launched without the bridge stops as before;
one with the bridge but no ready instance is left for the next sweep.

* test(pi): replay the bridge's recorded probe answers

Recorded on Windows from Pi 1.5.0 with pi-subagents 0.84.0 and the bridge:
ready, active while a worker ran, idle after its wake turn, and shutdown.

* fix(pi): let the Pi child own its probe folder and reject malformed answers

A launch abandoned before Pi started left its prepared folder behind, so
the bridge now creates the folder itself. An answer with no probe pending
could throw while reading Pi's output; replies are now matched exactly and
anything else times out as unknown. Leftover folders are reclaimed only
when their Orca process is proven gone.

* test(pi): reproduce an unasked-for answer from the ready bridge

* fix(native-chat): apply an idle window changed while a provider answered

The idle stop now re-reads the chat idle setting after the provider's
answer, so switching a chat to Never during the probe keeps its agent.
Normalize each Pi launch's private probe folder in the launch parity
snapshots, which now include the background-work bridge.
2026-11-04 19:47:37 -08:00
OrcaWinandOrcaWin 60c3d62c64 test: remove low-value appearance and chat settings tests (#38337)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-04 19:47:29 -08:00
Kelvin Amoaba 902fc52c7d fix(session-tabs): paired devices follow every tab they open, not just the first (#38336)
* fix(session-tabs): send per-client frames without projecting them twice

A frame sent to one client (a tab it opened, picked or reopened) was already
that client's projection, but delivery projected it again. That stacked the
:client-navigation epoch suffix and the selection revision, so the client
treated it as another publication and fenced it. A link clicked in a server
browser page then only brought its new tab forward the first time.

* test(session-tabs): fold the per-client frame publication check into the caller-selection test
2026-11-05 03:43:59 +00:00
Brennan Benson 274b99919f Keep the phone's chat Send button the same as desktop while the agent works (#38317)
* fix(mobile): the chat Send button keeps desktop's arrow while the agent works

#36588 swapped the phone's send icon and label for Queue or Steer while
a turn ran; desktop keeps the plain Send arrow and offers the other way
through Cmd/Ctrl+Enter. The phone now matches, with hold as its
alternate.

* test(mobile): the send button keeps its arrow while the agent works
2026-11-04 19:30:11 -08:00