Commit Graph
20612 Commits
Author SHA1 Message Date
OrcaWinandOrcaWin 64cd31458d test: remove 31 low-value interaction and state tests (#38629)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 11:21:57 -08:00
OrcaWinandOrcaWin a820de5ff5 test: remove 91 low-value terminal and compiler tests (#38623)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 11:11:42 -08:00
14bc9fef26 fix(mobile): show history scan notices separately from skipped transcripts (#38626)
* Show source scan notices accurately in mobile Agent History

Reuse the existing desktop presentation policy in shared code, keep host failures and source notices separate from skipped transcript files, and retain their scanner-authored messages.

Adapted from the remaining mobile presentation in original PR #15671. Rebased onto main: the classifier now lives in src/shared/ai-vault/scanning/, desktop keeps its translated skip reasons, and mobile reuses its existing skipped-transcript notice.

Co-authored-by: Brennan Benson <79079362+brennanb2025@users.noreply.github.com>

* refactor(ai-vault): share the scan issue row key between desktop and mobile

---------

Co-authored-by: Neil <neil@stably.ai>
Co-authored-by: Brennan Benson <79079362+brennanb2025@users.noreply.github.com>
2026-11-05 19:11:35 +00:00
Brennan BensonandAJIADb9 239a70040c Terminal tabs show the agent session's name instead of the first-prompt title (#38518)
* fix(tabs): show the agent session's name on terminal tabs

The tab strip rebuilt each terminal tab without its session title and then re-ranked it, so the first-prompt title won over the session's own name. Carry the session title through the projection, and give the tab strip, unified tab label and sidebar agent row one shared name order so they cannot drift.

Co-authored-by: AJIADb9 <ajiadb9@bgd.team>

* fix(tabs): paired desktops take the host's session name for mirrored terminal tabs

The host projection now forwards the window's session title to paired clients, and the client's rebuild adopts it (older hosts omit it, so the client keeps its own). Without it a mirrored tab re-ranked to the client's first-prompt title.

* fix(tabs): one writer per session for a mirrored tab's session name

The paired client's own title sync keeps a session it already tracks current; the host's name only fills a session the client doesn't know, so a stale host snapshot can't revert a rename the client already read.

* fix(tabs): a paired host is the only writer of a session name it publishes

* fix(tabs): only a host window that resolves session names speaks for them

* fix(tabs): derive session title authority from live publishers

* fix(tabs): keep the session title publisher check concrete for runtime subclasses

* fix(tabs): one publication when a closing window drops browsers and title authority

* test(tabs): follow main's runtime test helper layout

* fix(tabs): paired desktops keep a quick-command name ahead of the session name

* fix(tabs): a name the host cleared doesn't come back as the idle pane's title

* test(tabs): build the idle-pane fixture as its own surface variant

* fix(tabs): point the moved session-title projection at its new shared path

---------

Co-authored-by: AJIADb9 <ajiadb9@bgd.team>
2026-11-05 11:04:58 -08:00
Brennan Benson 799b60b074 Keep orchestration messages tied to their actual agent identity (#37966)
* Show background completion mail as its command source

* Use minted sender handles in identity regression fixtures

* Verify command source labels in translated chat views

* Preserve command-only queued source regression coverage

* Use a minted terminal identity in host sender coverage

* Reuse command sender labels across unchanged message and queue reads

* Keep sender performance contract within the shared typecheck boundary

* Keep command reports in the background surface and preserve observed sender identity

* Use the shipped phone background report translation namespace

* Settle the prior dispatch before testing terminal reuse

* Keep live worker status tied to its recorded agent invocation

* Withdraw worker invocation proof when identity refresh fails

* Drop unproved worker associations at the failed refresh boundary

* Cover ordinary and remote sender rows during failed refresh

* Assert preserved session and peer content on failed sender reads

* Align sender navigation and relay tests with observed provenance

* Keep background report sources neutral and bound sender snapshot caches

* Construct readonly phone report fixture without mutation

* Keep callback-free federated transport assertions exact

* Keep orchestration sender identity separate from endpoint activity

* Validate mailbox receipt fixture shapes without casts

* Keep current Crew endpoint status separate from saved message activity

* Keep sender activity fixtures within lint contracts

* Avoid repeated serialization for fitting relay pages

* Use the valid workspace sidebar value in scale coverage

* Keep operation-count SQL expectation in sync with main
2026-11-05 11:00:15 -08:00
OrcaWinandOrcaWin cde6bd02f3 test: remove 181 low-value skill and source-policy tests (#38619)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 10:52:11 -08:00
OrcaWinandOrcaWin 9dbfcf0868 test: remove 75 low-value workflow and runtime tests (#38616)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 10:51:43 -08:00
Brennan Benson 1a5e8ad2e6 fix(native-chat): make file links in terminal-backed plan approvals actionable (#38495)
* fix(native-chat): make file links in terminal-backed plan approvals actionable

Each chat view now provides its link handler through one per-chat
context that link-drawing components read themselves, replacing the
onLinkClick/allowFileUriLinks props threaded by hand through rows and
cards. The terminal-backed approval card was the surface that never got
them; any card inside a chat view now gets links without wiring.

Tracked in STA-13722.

* native-chat: correct link context comment

* native-chat: fixture for a terminal-backed plan approval with file links

* native-chat: drop stray blank line in turn-diff rollup
2026-11-05 10:43:26 -08:00
Brennan Benson dd1784f55b Keep partial check details from replacing complete PR status (#38514)
* Keep PR check status tied to complete observations

* Correct checks presentation types and count import

* Preserve localized empty states and declared runtime support

* Correct discovery fixture stack types

* Omit empty failed-check subtitles

* Preserve check identity through refresh and row publication

* Withhold row identity for malformed check errors

* Limit local capability wakes to local task sources

* Correct PR check regression fixtures

* Preserve browser APIs in PR check regression fixture

* Settle PR check adoption after failed detail reads

* Use the parsed PR check detail type during refresh

* Preserve PR metadata across checks discovery and committed query lifetimes

* Keep complete checks proof separate from legacy publication policy

* Keep PR lookup fixtures independent from complete checks collection

* Keep complete-check fixtures within lint contracts

* test: align PR recordings with source check discovery
2026-11-05 10:39:54 -08:00
OrcaWinandOrcaWin 384b445585 test: remove 143 low-value tests and 13 entire suites (#38614)
* test: remove report inventories and dependency policy replays

* test: remove lint rule inventories and release mock replays

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 10:27:41 -08:00
Brennan Benson 15caa932bc fix(mobile): make file links in phone plan approvals actionable (#38510)
* fix(mobile): make file links in phone plan approvals actionable

The phone chat view now provides its file opener through one per-chat
context. Chat markdown renders through a shared adapter that reads it,
and tool, diff and attachment targets read it directly, replacing the
onOpenFile props threaded by hand through rows and cards. The plan
approval card was the surface that never got it.

Tracked in STA-13722.

* fix(mobile): open attached files while editing a queued message

Composer attachment chips read the chat's file opener from the per-chat
context instead of the structured composer config, which the queued
message editor built without it.

* test(mobile): provide the chat file opener to the attachment preview test
2026-11-05 10:26:43 -08:00
Brennan Benson 85a68bfa4f Codex subagent rows show their task names instead of all saying "worker" (#38491)
* fix(agents): tell Codex subagent rows apart by task name instead of role

A Codex subagent's task name only reached the sidebar when one early read of its rollout succeeded; otherwise every child fell back to its role, so two workers both read "worker". The child poll now re-reads an unnamed child's own rollout, the first-line read allows the existing 256 KiB line cap, and a child with no task name or nickname carries the tail of its id, as Codex's own agent list does. Labels keep the path below the root so nested children with the same leaf stay distinct.

* fix(agents): retry an unnamed Codex child's own rollout without a parent transcript

A relay restart can leave a child hook as the only evidence, sent before the child's rollout was readable. Keep that path as pending identity work and retry it through the existing transcript poll, which now stays scheduled while a child still owes its name.

* fix(agents): carry the id tail to every child-row surface and bound identity retries

- Full-mode sidebar rows and dashboard subagent cards use the same suffixed label as compact rows.
- A role a host publishes as the name (Claude's subagent_type) no longer counts as a name.
- A final identity miss no longer re-arms polling; retries take turns, eight children per poll.
- Replace an error cast with a type guard.

* fix(agents): keep every identity read inside the per-poll budget

The parent-rollout poll now queues an unnamed child for the bounded, rotating identity retries instead of reading it directly, and full-mode rows keep the id tail for a child with no name or role.

* fix(agents): keep plain names on task-only rosters and guard the queued rollout path

A host that publishes only a task roster carries no role, so its names can't be told from roles and get no id tail. Update the sidebar lineage test for a role-only child's id tail.

* fix(agents): tell role-named tasks apart on task-only rosters

A host that publishes only a task roster sends Claude's subagent_type as the task name, so two such tasks read identically. A named agent task with no description now carries its id tail; an unnamed one keeps its kind label.

* fix(agents): a task path found meanwhile wins over a queued header read

Placeholder labels (e.g. unknown) count as unnamed when queueing, and a child the parent rollout named before its turn drops its pending read instead of being overwritten by the header's nickname.
2026-11-05 10:26:01 -08:00
Brennan Benson e076a683a3 fix(acp): permission prompts from an agent's own work wait for you (#38488)
* fix(acp): permission prompts from an agent's own work wait for you

A permission or question that an ACP agent (OMP, Grok, OpenCode, others)
asks during work it started itself, such as picking up a finished
background job, was answered "cancelled" at once and never shown. It now
shows as a card, raises the needs-input alert, and waits for the answer,
unless Stop, a steer or teardown cuts it short.

While OMP refuses a sent message as busy, a request from its own turn now
appears at thread level instead of being cancelled, so it never lands in
the held message's turn.

Tracked in STA-13625.

* fix(acp): keep later requests askable after a Stop, and honor the agent's withdrawal

A Stop or a card's Cancel left the chat refusing every later permission
request until the session ended; the stop now covers only the work it
interrupted. A request the agent withdraws with $/cancel_request now
withdraws its card. Cancel on a card from the agent's own work reaches the
agent even when no message is running.

* test(acp): narrow approval rows before reading their resolution

* fix(acp): a live request's card outlives its turn instead of being cancelled with it

Requests group with the active turn again, as before. A permission or question
the agent is still waiting on now stays pending and answerable when its turn
ends, is replaced, or is settled by the host; only the person's answer, the
agent's withdrawal, Stop, a steer or the session ending settles it. Settled
requests are pruned at turn end.

Stop covers only Orca's running message, so later requests from the agent's
own work can still ask. Cancel on a card with no running turn now reaches the
host from desktop and phone for every agent, and a question the agent
withdraws before its card opens no longer leaves a stuck card.

* fix(acp): never strand a live request without a card, and scope Cancel to it

A request the agent still waits on now always gets an answerable card, even
when its turn settled before the card was written, and answering it releases
the timeline's hold. Cancel on a card from an agent's own turn refuses further
requests from that turn until it ends. Desktop never turns Cancel on a card
into a whole-chat Stop on hosts that can't take a card cancel.

* fix(acp): a new message is never covered by a Stop of the agent's earlier turn

* fix(native-chat): a card's Cancel with no running turn passes the RPC schema

The cancel params required a turn whenever a card was named, so Cancel on a
card from an agent's own work (and Pi's turnless card Cancel) was rejected
before it reached the host. A background-task cancel still names its turn.

* test(rpc): a card with no running turn cancels by itself
2026-11-05 10:25:23 -08:00
OrcaWinandOrcaWin f865fb26a8 test: remove 141 low-value tests and 13 entire suites (#38613)
* test: remove server qualification inventories and mocked build tests

* test: remove packaging inventories and synthetic native tests

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 10:22:08 -08:00
OrcaWinandOrcaWin 0b5a3a4ad9 test: remove 209 low-value tests and 20 entire suites (#38605)
* test: remove low-value mobile browser tests

* test: remove low-value mobile browser tests

* test: remove native build capability replays and pin inventories

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 10:08:14 -08:00
Neil 439e28b8a2 refactor: organize runtime semantic operations by concrete owner (#38602)
* refactor: organize runtime semantic operations by concrete owner

* refactor: consolidate terminal tab close type imports

* refactor: finish runtime contract owners and mobile catalog snapshot ownership
2026-11-05 10:00:28 -08:00
OrcaWinandOrcaWin 10c123d179 test: remove low-value mobile browser tests (#38600)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 09:23:24 -08:00
OrcaWinandOrcaWin 90113c2265 test: remove low-value mobile browser tests (#38598)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 09:18:49 -08:00
Neil 18bab90efa refactor(main): group client RPC pairing and host runtime owners (#38584)
* refactor(main): group client RPC pairing and host runtime owners

* test: target concrete mobile notification owner in headless fixture

* test: retarget dynamic quit mocks to runtime metadata owner
2026-11-05 09:16:47 -08:00
OrcaWinandOrcaWin f410ea89fb test: remove low-value mobile and script test inventories (#38596)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 09:08:18 -08:00
OrcaWinandOrcaWin 06178ea9af test: remove low-value build and packaging test inventories (#38593)
* test: remove low-value build and packaging test inventories

* ci: retire removed dependency resolution suite invocation

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 08:47:58 -08:00
Kelvin Amoaba 66bb93395c fix(file-explorer): keep fast folder clicks as toggles instead of rename (#38321)
Double-clicking a file or folder name no longer starts inline rename.
The second click of a fast pair on a folder now toggles it back, and a
file name double-click pins the preview like the rest of the row.
Rename stays on Enter and the context menu.
2026-11-05 16:15:24 +00:00
OrcaWinandOrcaWin b7fe7ba45f test: remove low-value workflow and compiler test inventories (#38587)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 08:08:26 -08:00
OrcaWinandOrcaWin c7a9075f0e test: remove low-value build and CI test inventories (#38582)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 07:53:30 -08:00
Neil ebd724b2f8 refactor(main): group browser runtime code by defining owner (#38576) 2026-11-05 07:44:10 -08:00
OrcaWinandOrcaWin 7c1fd62f37 test: remove low-value relay SQL and lifecycle test inventories (#38580)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 07:30:50 -08:00
OrcaWinandOrcaWin 4fee14f89b test: remove low-value host control and connection test inventories (#38578)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 07:12:53 -08:00
OrcaWinandOrcaWin 167cb81e60 test: remove low-value cell test inventories and duplicate suites (#38577)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 07:05:26 -08:00
Neil 8417fa890a refactor(main): group agent runtime code by defining owner (#38565) 2026-11-05 06:45:18 -08:00
OrcaWinandOrcaWin afe06c366a test: remove low-value relay test inventories and mocked worker suite (#38572)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 06:42:22 -08:00
OrcaWinandOrcaWin dd4db9351c test: remove low-value relay admission simulations and guard examples (#38568)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 06:22:51 -08:00
OrcaWinandOrcaWin 4d0d42c854 test: remove paced relay load benchmarks and trivial guard examples (#38562)
* test: remove paced relay load benchmarks and trivial guard examples

* test: add required braces to relay fixture cleanup

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 06:06:56 -08:00
Neil 1f3648cc95 refactor(runtime): group workspace creation and lifecycle owners (#38534)
* refactor(runtime): group workspace lifecycle and creation owners

* refactor(runtime): consolidate relocated test imports
2026-11-05 06:01:41 -08:00
OrcaWinandOrcaWin b69d67f699 test: remove low-value native ownership tests (#38557)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 05:44:00 -08:00
OrcaWinandOrcaWin 7deeabd41f test: remove low-value native validation tests (#38553)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 05:35:34 -08:00
OrcaWinandOrcaWin 00b56535c6 test: remove low-value native helper tests (#38552)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 05:25:57 -08:00
OrcaWinandOrcaWin 24d277e0ca test: remove low-value terminal readiness tests (#38548)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 05:15:24 -08:00
OrcaWinandOrcaWin d4b4e0217d test: remove low-value terminal runtime tests (#38544)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 05:09:11 -08:00
OrcaWinandOrcaWin 6e91427ee7 test: remove low-value terminal runtime tests (#38536)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 04:45:12 -08:00
OrcaWinandOrcaWin 5683c67f24 test: remove low-value tab-bar and GitHub task tests (#38531)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 04:42:34 -08:00
OrcaWinandOrcaWin 5799405031 test: remove low-value sidebar and skill tests (#38526)
* test: remove low-value sidebar tests

* test: remove orphaned sidebar golden test fixture

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 04:39:43 -08:00
OrcaWinandOrcaWin e7ef889cbd test: remove low-value status-bar and tab-bar tests (#38527)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 04:38:09 -08:00
OrcaWinandOrcaWin bdcae110ab test: remove low-value sidebar tests (#38525)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 04:18:17 -08:00
Neil a0384aa58f fix(runtime): explicit server actions connect a disconnected server; name the launch hold (#38530)
Update, Rollback, Recover and Restart of a managed server already reset
its crash-loop brake as Connect does, but left the user's Disconnect of
the server and its SSH host in place, so the action was refused. They
now lift the holds Connect lifts (server and host Disconnect, cancelled
sign-in, re-pair cap) without dialing the host first, since Connect's
server-update check would run before the action (a Rollback would then
roll back the update it just made). Status resumes once the action ends.

A host with "Reconnect on launch" off holds its servers disconnected at
every launch. Their status now says so ("Reconnect on launch is off for
<host>. Connect to resume.") instead of claiming a manual disconnect the
user never made. The error code is unchanged.

Refs #38347
2026-11-05 04:12:30 -08:00
OrcaWinandOrcaWin 18eef71685 test: remove low-value sidebar tests (#38523)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 04:03:28 -08:00
Neil 87788aeae5 refactor(runtime): group terminal execution owners (#38517)
* refactor(runtime): group terminal execution owners

* fix(tooling): retarget terminal ANSI consumer owner
2026-11-05 03:46:49 -08:00
OrcaWinandOrcaWin 0b00d7aaab test: remove low-value sidebar tests (#38521)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 03:36:53 -08:00
NeilandMatthew Wilkinson f660d8c47d feat(plugins): add permissioned desktop appearance publication (#38524)
* feat(plugins): add permissioned desktop appearance publication

* docs(plugins): add one-line API comments for appearance provider

* chore(plugins): regenerate declarative testing kit for appearance API

---------

Co-authored-by: Matthew Wilkinson <wilkinson.m@outlook.com>
2026-11-05 11:31:23 +00:00
OrcaWinandOrcaWin cebd80887a test: remove low-value sidebar tests (#38520)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-05 03:26:07 -08:00
0bb26d7480 perf(plugins): read catalog images in batched Git calls (#38463)
* perf(plugins): read catalog images in batched Git calls

Each catalog refresh ran one ls-tree and one cat-file per image or
manifest read. Batch every file an extraction round asks for into one
ls-tree listing and one cat-file --batch read, then rerun extraction
over the loaded files until nothing is missing.

* fix(plugins): bound speculative catalog blob prefetch

---------

Co-authored-by: m4air <m4air@Mac.localdomain>
Co-authored-by: Neil <neil@stably.ai>
2026-11-05 03:19:07 -08:00