removeWorktree already cleaned up openFiles, terminal layouts, browser
tabs, and several worktree-keyed maps, but four state properties leaked
indefinitely after a worktree was deleted:
- editorDrafts — unsaved draft content keyed by file ID
- markdownViewMode — rich/source toggle keyed by file ID
- expandedDirs — file explorer expansion state keyed by worktree ID
- activeTabIdByWorktree — remembered terminal tab keyed by worktree ID
Over a long session with many worktree create/delete cycles these
accumulated entries consume memory and can never be reclaimed because the
corresponding file and worktree IDs no longer exist in openFiles or
worktreesByRepo.
The fix collects the file IDs of the removed worktree's open files and
deletes their editorDrafts and markdownViewMode entries, then removes the
worktree's expandedDirs and activeTabIdByWorktree entries. A shallow copy
is only created when there are actually entries to remove, preserving the
no-op identity check that existing tests rely on.
Co-authored-by: Test User <test@example.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
* fix: dispose PTY event listeners before kill to prevent SIGABRT crash
node-pty's onData/onExit callbacks register native NAPI ThreadSafeFunction
objects. When a PTY process is killed without deregistering these callbacks,
the stale ThreadSafeFunction references survive into the Node environment
cleanup phase (node::FreeEnvironment). NAPI then attempts to invoke CallJS
on the destroyed environment, causing Napi::Error::ThrowAsJavaScriptException
to throw a C++ exception that terminates the process with SIGABRT.
Store the IDisposable handles returned by proc.onData() and proc.onExit(),
and dispose them in clearPtyState() before the process is killed. This
covers all teardown paths: explicit pty:kill IPC, runtime controller kill,
page-reload orphan cleanup, and app-quit killAllPty.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: use T[] array syntax instead of Array<T> to satisfy oxlint
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* wip
* fix: replace fragile worktree card height estimation with constant
The virtualizer's estimateSize tried to predict exact pixel heights from
Tailwind class constants, which drifted from actual rendered sizes and
caused overlapping cards. Replace with a generous constant (120px) —
measureElement/ResizeObserver already corrects to real heights, so the
estimate just needs to overshoot. Delete the now-dead estimate module.
Strip YAML/TOML front-matter before handing content to the rich editor
and display it as a read-only banner. In preview mode, render front-matter
as a styled block above the markdown output. Remove the frontmatter entry
from UNSUPPORTED_PATTERNS so files with front-matter can use rich mode.
Also fixes: look up html-or-jsx matcher by reason instead of fragile index.
- Only show "Create worktree" action after the user types a query
- Remove per-row CornerDownLeft enter arrow (footer already shows Enter → Open)
- Rename footer label from "Jump" to "Open"
- Remove the border-bottom separator in the agent hovercard when no agents
are active (looked off as a stray line under "No agents active")
- Add a "Hide from titlebar" button at the bottom of the hovercard that
disables the badge via settings and shows a persistent dismissible toast
pointing users to Settings → Appearance to re-enable
* fix: address review findings
Replace repeated dynamic imports in tests with a single static import.
* fix: address CI lint failure — use T[] instead of Array<T>
* fix: Cmd+X in rich markdown editor deletes only the current line
- Guard against depth < 1 (GapCursor before top-level leaf nodes) to
prevent RangeError crash
- Add visual-line cutting for word-wrapped paragraphs so Cmd+X removes
one visual line at a time instead of the entire paragraph
- Normalize soft line breaks on load/update: split paragraphs with
embedded \n into separate paragraph nodes so block-level cut works
per-line
- Add comprehensive tests for cut handler behavior and normalization
* fix: address review findings
- Normalize soft breaks at all document depths (not just top-level)
using doc.descendants() instead of doc.forEach()
- Capture transaction lazily from editor.view.state.tr to avoid stale
state after setContent()
* fix: use editor.view.state consistently in normalizeSoftBreaks
Read doc and create tr from editor.view.state (not editor.state) so
position collection and transaction application share the same base
state, avoiding stale-doc corruption after setContent().
Add a `showTitlebarAgentActivity` setting under Appearance > Titlebar
that lets users toggle the agent activity badge in the titlebar.
- Add `showTitlebarAgentActivity` to GlobalSettings (default: true)
- Add toggle in AppearancePane under a new "Titlebar" sub-section
- Upgrade badge from Tooltip to HoverCard with per-worktree breakdown
- Show dimmed idle state when no agents are active
- Fix badge/tab overlap when sidebar is closed (min-w-0 + conditional shrink-0)
- Extract countWorkingAgentsForTab helper for reuse by per-worktree counter
Cmd+Shift+G was opening the source control sidebar even when terminal
search was active, because both App.tsx and keyboard-handlers.ts
registered capture-phase keydown listeners on window with no
coordination between them.
Fix with two layers:
- App.tsx: skip Cmd+Shift+G when [data-terminal-search-root] is in the
DOM (reliable regardless of listener registration order)
- App.tsx: bail on defaultPrevented as a general guard
- keyboard-handlers.ts: upgrade stopPropagation to
stopImmediatePropagation for the search navigate handler
Neil
RamziandClaude Opus 4.6
Jinjing
Brennan Benson
brennanb2025
Jinwoo Hong
Jinwoo-H
Pim de Jong
Alexander