4 Commits

Include renames

Author	SHA1	Message	Date
OrcaWinandOrcaWin	ed7849eb7b	fix(worktrees): stop silently switching existing Windows setup scripts to Git Bash (#12406) ... * fix(worktrees): stop silently switching existing Windows setup scripts to Git Bash #6967 derived the Windows setup-runner shell from `terminalWindowsShell`. On upgrade, any Windows user whose terminal preference resolved to Git Bash had their existing `orca.yaml` setup script (and issue command) handed to bash instead of cmd.exe. Scripts authored against the cmd runner — `copy`, `xcopy`, `set VAR=value`, `if errorlevel 1`, `%VAR%`, backslash paths — broke with no migration and no warning, and the failure looked like Orca broke the project. The conflation is also wrong in the steady state: a terminal preference is per-user, so two people on the same repo got different interpreters for the same orca.yaml and no project could write a setup script that worked for all of its Windows contributors. The interpreter is now a property of the script, declared the standard way: a leading `#!` line. Native Windows keeps the historical `.cmd` runner unless the script declares a POSIX shell, so no existing script changes behavior. `resolveSetupRunnerShell` keeps its role as the feasibility gate — a bash runner still requires the terminal to resolve to Git Bash, since the launch command is typed into that shell and uses MSYS `/c/...` paths. `buildWindowsRunnerScript` now drops a leading `#!` line rather than `call`ing it, so a declared-bash script that falls back to cmd (Git Bash missing) fails on a real setup line instead of aborting on errorlevel at line one. WSL worktrees, POSIX platforms, and SSH hosts are untouched. * fix(worktrees): keep the cmd setup runner launchable from a Git Bash pane Adversarial review of this PR found that pinning the runner format per script reopened issue #6896 one layer down. - `WorktreeSetupLaunch.shell` had been redefined to mean "the format the runner file was written in". `resolveSetupRunnerCommand` consumes it as "the shell that types the launch command", so a Git Bash terminal with a batch setup script produced `cmd.exe /c "C:\...\setup-runner.cmd"` typed into a bash pane, where MSYS rewrites the `/c` switch into a drive path: cmd opens interactively and setup never runs. `shell` is the terminal's family again; the runner file's .cmd/.sh extension carries the format, and a batch runner launched from a POSIX pane reuses the existing PowerShell ProcessStartInfo launcher. - The cmd runner dropped a leading `#!` line and ran the rest as batch, so a bash script reaching cmd (PowerShell/cmd terminal, or any SSH-to-Windows host) got its interpreter-agnostic prefix executed before failing mid-way. It now prints why and exits 1 without running anything. - A `#!` line's option flags were discarded: `#!/usr/bin/env -S bash -euo pipefail` lost pipefail because the runner is launched as `bash <path>`. The generated posix runner now replays declared flags via `set` and drops the duplicate interpreter line. - Docs cover the per-user setup command in repository hook settings, which goes through the same `#!` rule, and describe what the `#!` line does and does not select. Tests: composed launch command for a POSIX pane + cmd runner (hooks, shared runner command, setup sequencing gate, observed-setup signal), the cmd runner's shebang refusal, and shebang flag replay. Each fails with the source reverted. * fix(worktrees): replay only real `set` flags and keep the gate in the pane's shell Two round-2 review findings: - `#!/bin/bash -l` replayed `set -l`, which exits 2 and aborted the runner under its own `set -e` before a single setup line ran (all platforms). Only the flags `set` documents are replayed now; a bare `-o` with no option name is dropped instead of dumping the shell-option table. - The wait-for-setup gate picked its language from the runner file, so a batch runner launched from a Git Bash pane got the PowerShell gate while the agent startup command was already POSIX-quoted — `Invoke-Expression` cannot parse `'\''`. The gate now follows the pane; the runner still launches through the ProcessStartInfo launcher, never through bash. --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>	2026-08-03 23:25:50 -07:00
5 people	8c5371ebad	fix(worktrees): respect Windows shell for setup runners (#6967) ... * Honor configured shells during worktree setup * Align setup launch paths with selected Windows shells * Carry setup shell selection through deferred launches * Prove Windows setup shell routing at its real adapters * Ground remote PowerShell proof in the real writer * Preserve Git Bash across deferred setup launches * Harden Windows setup runner shell selection - Resolve remote PowerShell binary without local pwsh probe: for SSH/remote Windows worktrees, isPwshAvailable() reflects only the LOCAL host, so an 'auto' implementation could route the remote runner to a pwsh.exe the remote lacks. Add resolveSetupRunnerShell(..., { probeLocalPwsh: false }) so remote auto keeps the always-present powershell.exe; explicit pwsh.exe still honored. - Preserve native exit codes in the PowerShell runner by checking $LASTEXITCODE before $?, so a failing native command surfaces its real code instead of a generic exit 1; $? still catches cmdlet soft-failures. - Write the PowerShell runner with a UTF-8 BOM so Windows PowerShell 5.1 (the new default powershell.exe) reads it as UTF-8 instead of ANSI, preventing non-ASCII setup-script corruption. - Add unit tests for the remote-probe behavior. * Restore setup-shell scope narrowing over the rebase The force-pushed rebase dropped five review-fix commits that were already on this branch; this reapplies their combined effect on top of the new base and the hardening commit: - Keep SSH setup shell selection remote-owned (no local terminalWindowsShell or pwsh routing for remote hosts; supersedes the probeLocalPwsh guard) - Preserve cmd setup compatibility outside POSIX shells (no .ps1 runner family, so the BOM/exit-code hardening is no longer applicable) - Route WSL setup runners from the project runtime - Avoid blocking PowerShell probes during setup creation - Correct SSH and WSL background setup fixtures * Satisfy the changed-code gates for the setup-shell runner - createWorktreeRunnerScript took 7 positional parameters, tripping the changed-code max-params gate; move it to a single options object. - hooks-runner.test.ts deep-equals the createSetupRunnerScript result, so assert the cmd shell now returned for native Windows worktrees. * Carry the setup launch shell through observed and issue runners - buildObservedSetupCommand takes the runner's launch shell so WSL-routed Windows-drive setup replays use /mnt/c instead of Git Bash /c - resolveSetupRunnerShell gates the posix runner on the same Git Bash resolution the PTY uses, so a missing or non-MSYS bash keeps the cmd runner - issue-command runners carry their launch shell, and the renderer passes it when building the queued command - treat a bare `bash` shell setting as POSIX like `bash.exe` Co-authored-by: Orca <help@stably.ai> * fix(worktrees): close counsel P1 gaps for Windows setup shells Route windowless/headless creates through the shell-aware setup runner when a PTY controller is available, existence-check explicit Git Bash paths before committing to .sh runners, thread the resolved shell into issue-command runners, and document the intentional Git Bash interpreter flip with a narrow scope table. * Convert setup env to MSYS form and harden the bare cmd runner launch C3: a Git Bash setup runner now receives ORCA_*/CONDUCTOR_*/GHOSTX_* path values in /c/... form, matching the runner path and the shell's own HOME/PWD. C5: extension-less `bash` resolves to Git Bash everywhere, matching how resolveWindowsShellStartupFamily already classifies it. C7: runner paths carrying characters that cannot be quoted on a cmd command line launch through a delayed-expansion PowerShell shim instead, and the batch runner disables inherited delayed expansion so `!` in setup lines survives. Co-authored-by: Orca <help@stably.ai> * docs: note MSYS ORCA_* paths and bare bash Git Bash resolution Keep the setup-shell release note aligned with C3 env conversion and C5 bare bash resolution so the published claim matches runtime behavior. * revert: drop windows-setup-shell doc allowlist and AGENTS link Keep the counsel P1/P2 product fixes without expanding the docs allowlist or AGENTS.md guidance surface. * fix(plugins): contain Parcel unsubscribe rejections under Vitest Dev plugin watchers fire-and-forget unsubscribe, and in-process Parcel can reject when temp watch roots are already deleted. Catch those rejections so they cannot fail the suite as unhandled errors. * fix(plugins): keep in-process unsubscribe rejection surface Swallowing Parcel unsubscribe errors broke mocked unsubscribe tests that return non-Promises and expect rejections. Contain failures only in PluginDevWatcher fire-and-forget paths. --------- Co-authored-by: OrcaWin <alpha-eng@stably.ai> Co-authored-by: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Co-authored-by: Jinjing <6427696+AmethystLiang@users.noreply.github.com> Co-authored-by: Orca <help@stably.ai>	2026-08-02 17:40:58 -07:00
Brennan BensonandOrca	a278a30b1c	Let agents wait for setup when requested (#6298) ... Co-authored-by: Orca <help@stably.ai>	2026-06-28 13:50:00 -07:00
Neil	0fd484c75d	Fix WSL UNC setup runner casing (#4139)	2026-05-31 05:47:21 -07:00