2 Commits

Include renames

Author	SHA1	Message	Date
Neil	77f23b013f	refactor(shared): drop the shared/types barrel and import from the real modules (#14447) ... #14397 split `shared/types.ts` into 46 per-domain modules but kept the path as a re-export barrel so the import sites did not have to change. This removes the barrel: every consumer now imports from the module that actually declares the type, and `src/shared/types.ts` is deleted. Barrels hide where a type lives, make every consumer look like it depends on the whole domain, and let an unrelated edit invalidate a module that ~2,000 files transitively import. 2,323 import declarations across 2,321 files. Rewritten mechanically: each specifier was resolved to an absolute path via the TypeScript AST and recomputed, rather than string-substituted, so alias forms (`@/../../shared/ types`) and per-specifier `type` modifiers survive. Four cases the mechanical pass had to handle, each found by a gate rather than by reading the diff: - Modules inside `src/shared` import the barrel as `./types`, not `shared/types`. A pre-filter on the latter string skipped 176 of them and left imports dangling at a deleted file, which surfaced as confusing `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>` errors rather than "module not found". - The barrel RENAMED one type on the way through (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name in the owning module has to be re-aliased at each consumer. - Three test files put `;(globalThis as ...)` on the line after the import. TypeScript parses that `;` as the import statement's terminator, so replacing through `statement.getEnd()` deletes it and breaks ASI. The rewrite now stops at the module specifier. - A file that already imported directly from a module got a SECOND import from it, because the barrel re-exported those same names — which trips `import/no-duplicates` under `--deny-warnings`. A post-pass merges declarations sharing a specifier and type-only-ness; the `import type` plus `import` pair from one module is left alone, since that form is allowed. Splitting one barrel import into several genuinely adds lines, which pushed `terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character import must wrap, and neither local type collapses onto one line (101 and 116 characters). Rather than contort a type declaration to fit a line budget, `collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` — they are pure structural operations on the layout tree and independent of PTY ownership. `visible-worktrees.ts` similarly loses its own mini-barrel re-export of `isDefaultBranchWorkspace`, with the four real consumers repointed at the declaring module. No `max-lines` bypass added. Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted first — these projects are `composite: true` and reuse stale caches); the full `pnpm lint` green, not just bare oxlint — the narrower local check is what let the duplicate imports reach CI; max-lines ratchet OK at 344.	2026-08-13 22:48:24 -07:00
Brennan Benson	5fcf777617	feat(mobile): Quick Commands (terminal + agent-prompt presets) (#9298) ... * feat(mobile): add Quick Commands (terminal + agent-prompt presets) Brings the desktop Terminal Quick Commands feature to mobile: saved agent-prompt or terminal-command presets that launch a new terminal tab. Entry point sits in the session tab strip next to the "+" new-terminal button (with a divider) — quick commands spawn a tab, so they live with tab creation, mirroring desktop's tab-bar split button. - Launcher button + Quick Commands bottom sheet (search, This project / Global groups, run/edit/delete rows, add row). - Add/Edit sheet mirroring desktop TerminalQuickCommandDialog: Label, Action toggle (Terminal Command | Agent Prompt), Agent select, Prompt / Command Text, Advanced (Append Enter, Scope Global/Project), validation and save-failure feedback. - Launch reuses handleCreateTerminal (extended with enter + toast copy): agent prompts launch the agent then deliver the prompt; terminal commands run the (Enter-appended) command text. - Expose terminalQuickCommands over the remote/mobile RPC surface (getClientSettings/updateClientSettings allowlists, RuntimeStore type, and the strict SettingsUpdate zod schema). - Mirror the agent-prompt support predicate mobile-side (stdin-after-start agents are unsupported) with a parity test guarding drift from desktop. - Mock server: sample quick commands + settings.update handler for QA. * fix(mobile): harden quick command execution * fix(mobile): harden quick command persistence and launch * test(mobile): preserve unexpected quick command errors * fix(mobile): harden quick command launch performance * fix(runtime): reject malformed quick command updates * refactor(mobile): reuse shared quick-command logic instead of mirroring The mobile quick-commands mirror was built on a false premise — that runtime-importing src/shared/terminal-quick-commands breaks the RN bundle / Vitest. It doesn't: tui-agent-config → orca-cli-command-name is a pure leaf with no module-load Node APIs (verified via probe + bundle-graph). - Mobile now reuses the canonical desktop helpers (action/agent/scope/ matchesRepo/support/flatten) directly from src/shared; only genuinely mobile-specific pieces (agent-branded labels, native row truncation, the launch plan) stay local. - Multiline runnable terminal commands now flatten via the shared flattenTerminalQuickCommand (";"-join) — unity with desktop, so a command saved on one runs identically on the other. - Drop the MOBILE_TUI_AGENT_PROMPT_COMMAND_UNSUPPORTED mirror + its parity test; use the shared supportsTerminalAgentQuickCommand predicate. - Export the shared MAX_QUICK_COMMAND_* length caps for reuse. * fix(mobile): protect quick command data boundaries * fix(mobile): enforce quick command limits * fix(mobile): make quick command updates atomic * fix(mobile): keep quick command filters recoverable * fix(mobile): use filled play icon for quick commands * Revert "fix(mobile): use filled play icon for quick commands" This reverts commit 169bf053b0. * fix(mobile): gate quick commands on host capability	2026-07-19 23:42:31 -07:00