Commit Graph
23587 Commits
Author SHA1 Message Date
Neil 362b8b32bb Merge remote-tracking branch 'private/cloud/integration' into cloud/dev-seed-gate
# Conflicts:
#	cloud/apps/sandbox-control/src/index.ts
2026-11-16 01:40:20 -08:00
Neil 261a952519 Merge pull request #823 from nwparker/cloud/team-sharing-hold
feat(cloud): hold team workspace sharing behind TEAM_SHARING (default off)
2026-11-16 01:35:54 -08:00
Neil 1d95740dc5 fix(cloud): every dev-only route and behavior is on only where SANDBOX_ENV is dev, local or test (devOnly allowlist; was 'anything but prod') 2026-11-16 01:34:35 -08:00
Neil 3fee610d06 fix(cloud): the dev GitHub seed route exists only where SANDBOX_ENV is dev, local or test (allowlist; was 'anything but prod') 2026-11-16 01:32:20 -08:00
Neil 73bd780f35 Merge pull request #825 from nwparker/cloud/team-sharing-desktop-hold
feat(cloud): TEAM-SHARING-HOLD hide team sharing on the desktop (cloudTeamSharing, off)
2026-11-16 01:31:32 -08:00
Neil 80fdb67d64 Merge remote-tracking branch 'private/cloud/integration' into cloud/team-sharing-hold 2026-11-16 01:30:35 -08:00
Neil 61eadf0fb3 Merge pull request #822 from nwparker/cloud/gh-solo-member
fix(cloud): solo workspace gh/git act as the member without an attested sender (orca-plugins#89 bot-authored PR)
2026-11-16 01:28:51 -08:00
Neil a4c889aa68 feat(cloud): TEAM-SHARING-HOLD team sharing held on the desktop (capability cloudTeamSharing, off)
Neil: sharing cloud workspaces with the team is held for a future release; keep the code. The
share-links flag from #819 becomes `cloudTeamSharing` (capabilities.flags; absent = off, so an older
or unaware control plane never brings it back) and now covers sharing as a whole. With it off:
- Share with team / Make private: gone from the sidebar menu, the workspace panel menu and the
  cloud list's ⋯ menu (cloudWorkspaceActionGroups + the list row menu).
- Indicators: the list's Private lock badge, Settings › Workspaces' Access column, the people chip
  on a workspace (followers / who's here) and the list rows' presence avatars.
- Open cloud workspace…: no Team scope (lists your own), and its description no longer says
  "shared by teammates".
- Share links stay off with it (Copy › link, list Copy link items, ⌘⌥⇧L and its Settings entry).
Unchanged: Reassign owner, orca://cloud opens (a workspace you can't open shows the existing
no-access message), the create flow (the desktop never sent a visibility choice). The control
plane's half (TEAM_SHARING: PATCH team refused, views report private) is gh-access's.
2026-11-16 01:16:13 -08:00
Neil 6057044fd3 feat(cloud): TEAM-SHARING capability on the single-workspace response too 2026-11-16 01:11:48 -08:00
Neil b60415760c Merge pull request #821 from nwparker/cloud/short-dialog-verbs
fix(desktop): short-verb dialog buttons (Move, Delete, Create, Save…)
2026-11-16 01:11:14 -08:00
Neil 3e12a58b15 fix(cloud): TEAM-SHARING a revoke queued while the workspace slept leaves the next session private (queue-time stamp kept; no session = not shared for it) 2026-11-16 01:07:26 -08:00
Neil a7df7fbbc8 fix(cloud): Make private keeps shared credential mode until the next boot too (a private row with a grant revoked this session); tests for it and concurrent sweeps 2026-11-16 01:06:01 -08:00
Neil 62881cb01e test(cloud): GIT-ACTOR read-count test's synthetic ids can no longer collide with the real one (flaky)
(cherry picked from commit e735f41be6)
2026-11-16 01:05:51 -08:00
Neil b99fa165c1 fix(cloud): TEAM-SHARING hold keeps shared credential mode for the session a teammate's grant was revoked in (M1); sweep only team workspaces (L1) 2026-11-16 01:04:38 -08:00
Neil 3aa45164f0 fix(cloud): GH-SOLO a teammate whose grant is still being revoked keeps the workspace from being solo 2026-11-16 01:01:02 -08:00
Neil cfe5661a73 chore: drop the glossary allowlist entry for the removed 'Delete VM' label 2026-11-16 01:00:19 -08:00
Neil ce48b4769f fix(cloud): GH-SOLO solo is decided from the people set (owner without a grant counts), never from no expiry; re-check after the VM write and drop the mark if a grant began 2026-11-16 00:59:46 -08:00
Neil 05fe1508f2 feat(cloud): TEAM-SHARING hold sweep revokes non-owner grants (team_sharing_held); credential mode follows effective visibility once no teammate grants remain 2026-11-16 00:58:26 -08:00
Neil e735f41be6 test(cloud): GIT-ACTOR read-count test's synthetic ids can no longer collide with the real one (flaky) 2026-11-16 00:57:33 -08:00
Neil c122522e53 fix(cloud): GH-SOLO a one-person workspace's gh and git act as that member with no attested sender (a TUI typed into directly), matching the control plane 2026-11-16 00:54:03 -08:00
Neil 7dbf002f78 chore: sync protected copy keys for the VM delete dialog's new Delete key 2026-11-16 00:50:38 -08:00
Neil 79781e805c feat(cloud): TEAM-SHARING hold: TEAM_SHARING (default off) refuses sharing with the team and makes stored team workspaces act private 2026-11-16 00:50:25 -08:00
Neil 0c8ee7a5ca fix(desktop): SHORT-VERBS dialog primary buttons are a short verb; the title carries the context
Neil: a dialog's confirm/primary button is one word where possible. Swept the dialogs added or
changed on cloud/integration (DialogFooter / AlertDialog / confirm({ confirmLabel })):

Changed (button, was -> now):
- Move to this computer: "Move to this computer" -> "Move" (computer icon kept; title unchanged)
- Delete sandbox / VM (VmDeleteConfirmDialog): "Delete sandbox" / "Delete VM" -> "Delete" (new key;
  the build-failure card's own "Delete sandbox" button is unchanged), "Keep it" -> "Keep"
- Cloud environment: "Use this build" -> "Use"; Import from repo: "Apply to draft" -> "Apply"
- Mirror to this computer (sync section): "Remove copy" -> "Remove"
- Share a port: "Create public link" / "Create link" -> "Create"
- API keys: "Create key" -> "Create", "Revoke key" -> "Revoke"; Approve app: "Generate code" ->
  "Generate", "Generate a new code" -> "Regenerate"
- Routines: "Create routine" -> "Create", "Save changes" -> "Save", "Delete routine" -> "Delete"
- Agent API key remove: "Remove {{name}}" -> "Remove"
- orca.yaml trust: "Run hooks" -> "Run"; setup script review: "Save local setup" -> "Save"
- Local command approval: "Always allow this command" -> "Always allow" (its scope line stays)
- Skill share: "Publish skill" / "Publish bundle" / "Publish new version" -> "Publish"

Kept (no one-word form without losing meaning): "Sign out", "Turn on", "Make private",
"Make owner", "Allow once", "Add line and open" (adds an SSH config line, then opens), "Cancel
upload", and the Claude account switch's "Restart N sessions" (the count is the live selection).
Already short: delete-workspace Archive / Delete (#814).
2026-11-16 00:48:03 -08:00
Neil 17e7b447d3 Merge pull request #820 from nwparker/cloud/git-actor-line-2
fix(cloud): GH-ACTING-LINE read the workspace's githubActing / you (#817)
2026-11-16 00:22:43 -08:00
Neil 88de553dd5 fix(cloud): GH-ACTING-LINE reads the workspace's githubActing / you (#817's shape)
#818 read a gitActor variant the control plane never shipped, so the line never showed.
- Source control and the people tooltip read githubActing / you from the workspace record
  (cloudWorkspaces.get, and the team live list for the people chip); no feature header.
- Reasons: window_expired -> 'no one has sent in the last hour'; no_sender_yet -> 'whoever sends
  next, or Orca bot'; sender_not_connected / reconnect -> 'Orca bot'; off / not_github -> nothing.
  Connect GitHub when you.connected is false (bot cases only).
- Removed #818's gitActor schema, client method, IPC and the git-actor header (the server doesn't
  read it).
2026-11-16 00:16:22 -08:00
Neil 459a675fe8 Merge pull request #817 from nwparker/cloud/git-coauthor
feat(cloud): co-author trailer for bot-fallback commits; acting GitHub identity for the UI
2026-11-16 00:16:08 -08:00
Neil fd28d22e11 Merge pull request #819 from nwparker/cloud/share-link-flag
feat(cloud): SHARE-LINKS-HOLD share links behind cloudShareLinks capability (off)
2026-11-15 23:54:13 -08:00
Neil 056e8f86d8 feat(cloud): SHARE-LINKS-HOLD cloud workspace share links off for this release (capability flag)
Neil: hold share links this release, keep the code. Every way to produce a link is behind the
account capability flag `cloudShareLinks` (capabilities.flags, the existing server-driven pattern),
so it's off unless the control plane turns it on:
- sidebar right-click Copy › "Link to W-n" / "Workspace link": hidden;
- the cloud workspace list's ⋯ "Copy link to W-n" and "Copy link to this chat/terminal": hidden;
- ⌘⌥⇧L: does nothing (global and in the list row), and is gone from Settings › Shortcuts and its
  search;
- copyCloudWorkspaceLink itself returns false with no clipboard write or toast, so the
  private-link toast (#815) can't be reached from anywhere.
Unchanged: opening incoming orca://cloud links, and Share with team / Make private (access, not
the link).
2026-11-15 23:47:42 -08:00
Neil 3506e06d38 Merge remote-tracking branch 'private/cloud/integration' into cloud/git-coauthor 2026-11-15 23:02:41 -08:00
Neil 4f2a5a2841 Merge pull request #818 from nwparker/cloud/git-actor-line
feat(cloud): GH-ACTING-LINE who pushes and PRs go out as (source control + people tooltip)
2026-11-15 23:01:48 -08:00
Neil ed56742681 fix: the git actor's background re-read pauses while the window is hidden 2026-11-15 22:55:08 -08:00
Neil a66b711d81 perf(cloud): GIT-ACTOR the workspace list reads grants, sends and GitHub connections once per request, not per row (one pure rule, pickActing) 2026-11-15 22:54:50 -08:00
Neil 8769dddccc fix(cloud): a device id claimed by more than one member maps to nobody in the VM's devices map (no last-wins attestation as another member) 2026-11-15 22:52:34 -08:00
Neil a541fcee3e feat(cloud): GH-ACTING-LINE who pushes and PRs go out as, in source control and the people tooltip
A cloud workspace's git acts as its solo owner, else the latest sender within the hour, else Orca's
bot; the control plane decides (#817's gitActor) and the desktop only says it, quietly:
- Source control, under Commit/Push: "Pushes and PRs go out as @login" / "as Orca bot" / "as Orca
  bot (no one has sent in the last hour)", with the approvals/merges caveat in its tooltip. The
  only place with an action: Connect GitHub, when it's the bot and the viewer isn't connected.
- The people chip: the same words as a second line in the acting member's avatar tooltip (the
  first avatar's when it's the bot). No new header chip.
- Read with feature `git-actor` from GET /v1/team/workspaces/:id (owner and members alike), one
  read per workspace shared by both places; re-read on focus, every 2 min, and when a shared
  workspace's hour lapses (`until`). Absent field (not GitHub, identities off, older control
  plane): nothing shown.
2026-11-15 22:52:32 -08:00
Neil bf0f77f791 feat(cloud): GIT-ACTOR as githubActing + you on the workspace view (list and detail), with the desktop wire schema 2026-11-15 22:51:11 -08:00
Neil d3bd6a8475 feat(cloud): GIT-ACTOR who pushes and PRs go out as right now, on GET status (owner) and GET team workspace (members), behind feature git-actor 2026-11-15 22:48:20 -08:00
Neil 9a770d4686 feat(cloud): GIT-COAUTHOR a commit that falls back to the workspace identity while a known member drove it carries Co-authored-by for them 2026-11-15 22:48:20 -08:00
Neil 9b3fad6ed5 Merge pull request #816 from nwparker/cloud/gh-wrapper-path
fix(cloud): GH-AS-MEMBER gh wrapper was shadowed by the real gh on PATH
2026-11-15 22:47:11 -08:00
Neil 443a05ac56 Merge pull request #815 from nwparker/cloud/share-link-ux
feat(cloud): SHARE-LINK-PRIVATE copy link on a private workspace offers Share with team
2026-11-15 22:41:37 -08:00
Neil 36303ac480 fix(cloud): GH-AS-MEMBER gh wrapper actually runs: the real gh moves off PATH (tools/gh/bin) and tools/bin/gh links to the wrapper; older images migrated at entry-point install 2026-11-15 22:37:07 -08:00
Neil 50abda16aa feat(cloud): SHARE-LINK-PRIVATE Copy link on a private workspace says teammates can't open it yet
Copy link (menu, ⌘⌥⇧L, the list) on a private cloud workspace used to say "Workspace link copied"
while a teammate opening it is refused. Now, still copied:
- private, you can share it (owner): "Link copied, but teammates can't open it yet" (warning
  tone) with Share with team, the same visibility change as the menu's Share with team, then the
  usual "Shared with your team" toast;
- private, someone else's: the same title, "Only its owner can share it with the team", no action;
- team-visible, or visibility unknown (no answer within the copy's lookup): unchanged, "Workspace
  link copied". A chat link says "Chat link copied, but…".
Visibility comes from the workspace identity cache (now keeps it) or the copy's own lookup.
2026-11-15 22:35:58 -08:00
Neil 9d369ff270 Merge pull request #812 from nwparker/cloud/gh-as-member
fix(cloud): GH-AS-MEMBER PRs, comments and pushes from a cloud workspace show as the member, not the bot
2026-11-15 22:31:29 -08:00
Neil f26bcb958f Merge pull request #814 from nwparker/cloud/tab-chip-delete-labels
fix(desktop): remove the W-number tab chip; delete dialog says Archive / Delete
2026-11-15 22:22:29 -08:00
Neil 42c102137a fix(desktop): drop the W-number chip from the tab bar; delete dialog reads Archive / Delete
- The cloud workspace's W-number chip (CloudWorkspaceNumberChip) is gone from the workspace tab
  bar and the titlebar strip; the component, its fixture and its two chip-only strings are
  deleted. Copying the workspace link stays on the sidebar's right-click Copy › Workspace link and
  ⌘⌥⇧L (cloud-workspace-links.ts), neither of which used the chip.
- Delete-workspace dialog buttons: "Archive instead" -> "Archive", "Delete workspace" -> "Delete"
  (same string in the cloud workspace list's confirm dialog).
2026-11-15 22:17:08 -08:00
Neil e994d835ba fix(cloud): GH-AS-MEMBER approve/merge path checks case-insensitive with optional trailing slash; an unread review body counts as an approval 2026-11-15 21:24:54 -08:00
Neil 3d96f7d720 fix(cloud): GH-AS-MEMBER approvals never as a member (any workspace); merges as a member only in a one-person workspace (incl. REST branch merges); approve event case-insensitive; shared cap default 60 min 2026-11-15 21:23:00 -08:00
Neil 67ab8991bf Merge pull request #813 from nwparker/cloud/connect-github-prompt
fix(settings): the GitHub row says pull requests and comments show as you too
2026-11-15 21:20:39 -08:00
Neil 730334b4f5 fix(cloud): GH-AS-MEMBER PRs, comments and pushes from a cloud workspace show as the member, not the bot
stablyai/orca#42960 (Neil, dev) was authored by orca-cloud-dev[bot]. Neil had connected GitHub; member
identities only reached git: gh ran on the workspace placeholder (the App's installation token), and
the Worker's member route on api.github.com allowed only REST under the repo while gh pr create is
GraphQL.

- VM: a gh wrapper runs gh with the attested sender's own placeholder (orcad attests, as for git);
  plain gh otherwise. Behind GH_AS_MEMBER=on (dev on).
- Worker, api.github.com with a member placeholder: the member's own token only for REST under the
  workspace repo and for allowlisted authorship mutations whose every target resolves to it
  (repositoryId equals its node id; other ids looked up with the installation token, cached per repo,
  failures not cached). graphql-js parse; variable defaults, owner-level projectIds, duplicate
  top-level keys and anything unexpected are not member requests. Everything else goes out on the
  installation token as before; an out-of-repo pinned mutation is refused with a GraphQL error.
- Shared workspaces never approve or merge as a member (GraphQL and REST): those go out on the
  installation token, so branch protection still applies.
- Identity rule: the only person who can use a workspace always acts; in a shared one the latest
  sender acts until another member sends, for at most MEMBER_GIT_SHARED_MAX_MINUTES (default 480).
- A GitHub connect or disconnect mid-session reaches the running VM's identities now.
- Tokens never enter the VM.
2026-11-15 21:18:00 -08:00
Neil bcc7a567c8 fix(settings): the GitHub row says pull requests and comments show as you too
GH-AS-MEMBER (#812): a connected member's PRs, comments and pushes from cloud workspaces now show as
them, not only commits. The settings row's connect and disconnect copy says so.
2026-11-15 21:14:13 -08:00
Neil 2a21ea6646 Merge pull request #811 from nwparker/cloud/create-gh-connect
feat(cloud): CREATE-GH-IDENTITY connect-your-GitHub line in the create wizard
2026-11-15 21:10:40 -08:00