4 Commits

Include renames

Author	SHA1	Message	Date
Neil	7980ab9942	test: remove mock echoes and duplicate contracts that only reading finds (#23953) ... * test: remove mock echoes and duplicate contracts that only reading finds Two veins in one wave, both requiring the production path to be read rather than pattern-matched. Mock echoes (36 strongest candidates reviewed, 2 real): the flagged shape — literals shared between a mock factory and an expect matcher — is almost always a test feeding an input and asserting a transform. The two genuine echoes are in `pty-management.test.ts`, where the handler returns `getDaemonFolderAccessMismatch(identity)` verbatim, so asserting the mock's own `evidence('allowed')` object and its `null` proved only the mock. One case's own comment conceded the handler makes no decision. The branch-exercising cases in that file stay. Semantic sweep of 80 files no detector flagged, 27 junk cases removed. What it found has no mechanical signature: - a handler that is literally `() => getComputerUsePermissionStatus()`, so `resolves.toBe(result)` guarded nothing; - "does not mutate a stale registration off Linux" whose refusal came from a DIFFERENT guard — `cli.ts` has no platform check, and the test's own mock made `resolveAppImageRuntimeIdentity` return null, which a sibling case already owns; - "keeps probing a host that is still retained" asserting a no-op, because `retainScopes` only cancels queued probes and stores no state; - two cases comparing against `referenceAllowedRoots`, a verbatim copy of the pre-change algorithm kept in the test file — expected values produced by the thing under test. The third such case stays: it calls the old algorithm to COUNT its work (100_000 containment checks vs 100), a real bound on the authorization hot path; - a remote-folder refusal that came from the fake provider's own rejection message rather than any Orca guard; - "advertises each capability once", where a duplicate entry is inert in production because membership is `includes`; - an Antigravity `scaffold self-check` built on a hand-typed five-line screen — the exact fixture shape docs/reference/antigravity-readiness-evidence.md blames for five failed detector attempts — whose banner had already drifted to `Antigravity CLI 1.0.3` against a real captured `1.2.0`. The raw-capture provenance guard and the transcript checklist ratchet in that file stay. No production file is touched and no test file is deleted. * test: retire duplicate daemon and filesystem cases the sweep found Continues the semantic sweep into src/main/ipc filesystem handlers and src/main/daemon. 16 cases removed across 13 files; no production file touched. The recurring shape is a case that reaches the same branch as its sibling by a different-looking route: - `parseArgs` is a flag-scanning loop, so "handles flags in any order" asserts the identical result object as the in-order case, and "throws with no args" lands on the same `Usage:` throw the two missing-flag cases already reach; - an ENOENT case with "no code at all" and its sibling with a numeric transport code both fall through to the same `ENOENT_MESSAGE.test` branch; - "establishes connection with hello handshake" and "receives stream events" are strict subsets of cases that require two matching authenticated sockets and a frame split inside a multibyte character. Two were vacuous rather than duplicated: a fixture self-comparison asserting `String.normalize` gives different NFC and NFD spellings, and a `not.toThrow` batch case whose 200k events are truncated by `MAX_BATCHED_WATCHER_EVENTS = 5_000` long before the argument spread it was written to exercise. One whole-file deletion was reversed: `freebuff-detection.test.ts` looked like a table restatement, but the sibling detection test covers only dependency ordering and platform gating, not freebuff/codebuff independence — and those two names share a suffix, so it is the only guard against one shadowing the other.	2026-09-29 17:35:12 -07:00
Brennan BensonandMerge Sim	b5a85890ac	perf(git): bound git subprocess execution with an atomic admission scheduler (#16874) ... * perf(git): bound git subprocess execution with an atomic admission scheduler Field traces (#16038, #11363) show Windows freeze storms driven by unbounded concurrent git children (12+ at once, 50-65s status convoys for 25+ minutes). Admit every main-process git child against atomic per-budget base+headroom counters (general / network / per-route), with reserved interactive capacity, ordering-only aging, close-bound permit release, a 120s fail-safe read timeout that feeds scheduler backoff, tier plumbing through every option carrier, and coalesced+jittered visibility pollers. Killswitch: ORCA_GIT_ADMISSION_DISABLED=1. Storm harness A/B: max concurrent children 65 -> 6, interactive p95 791ms -> 88ms; output-parity battery byte-identical with admission on vs off. * test(git): run the admission output-parity battery on every platform Parity needs real git, not the storm harness's PATH stub, so it must not share that file's POSIX gate - Windows is the platform where parity evidence matters. * fix(git): preserve interactive admission invariants * perf(git): keep admission queue drains linear * fix(git): close final admission gaps * perf(git): bound eligible route selection * fix(merge): remove unrelated stale snapshot changes * fix(git): preserve refresh lifecycle authority * test(git): align admission lifetime contracts * fix(git): harden admission across runtime paths * fix(git): restore freshness for bulk status reads * test(git): repoint delete-dialog source pins after admission plumbing The hydration effect now orders its targets through orderDeleteWorktreeStatusHydrationTargets and passes includeLineStats alongside the abort signal, so both literal anchors stopped matching. The invariants are unchanged and still pinned: dropping the signal, the main-worktree/folder filter, or getState-instead-of-subscribe each still reddens this test. * Fix git admission tier propagation and lock ordering Decode optional Git status tiers permissively and default runtime RPC status reads to the status lane while preserving renderer caller intent. Acquire the FETCH_HEAD mutex before atomic admission so same-repository fetch waiters hold no global or route permits. Preserve automatic pull-request refresh reasons, keep explicit hosted-review refreshes interactive, remove the dead candidate tier, and keep relay scheduling unchanged. Use tier-aware status lease keys because a shared lease cannot be safely promoted after its admission request is queued or granted. * test: align expectations with admission plumbing * refactor(child-process): move the process contract types to process-spec run-process.ts crossed its line cap after gaining the termination observer; the public types and defaults move out with re-exports so no caller changes. * chore: restore pnpm-lock.yaml to main (unintended local drift) --------- Co-authored-by: Merge Sim <sim@local>	2026-08-30 14:19:05 -07:00
Neil	15e1ba3f84	refactor(ipc): split main-process IPC modules under the max-lines budget (#14703) ... The six oversized src/main/ipc modules each carried a file-level `eslint-disable max-lines` and ran 427-671 counted lines against a 300-line budget. AGENTS.md calls for splitting rather than suppressing, and config/max-lines-baseline.txt is a shrink-only ratchet, so this removes all six suppressions and prunes their entries (341 -> 335). Pure move, no behavior change. Each file is cut along the seams it already had: pet splits into format allowlist / storage paths / symlink-safe copy / bundle manifest + import; filesystem-auth into path-containment primitives, the config-derived allow-list, and the git-registered root cache; notifications into sound selection, native lifecycle, permission probe, and burst cooldown; crash-reporting into renderer error reports, breadcrumbs, and sender. The IPC surface is proved intact rather than assumed: comparing (method, channel) multisets between HEAD and the split gives 49 registrations across 49 distinct channels on both sides. filesystem-auth's security boundary keeps its acyclic layering -- containment primitives, then allow-list, then root cache, then path-resolution orchestration -- with no layer gaining a back-edge. Also keeps clipboard-ipc-handlers.test.ts under the 800-line test budget. The split had briefly added a redundant vi.mock for isENOENT (byte-identical to the real implementation) that pushed it to 801; the mock is dropped in favor of the real function, with realpath added to the existing node:fs/promises mock. Verified: oxlint clean, ratchet passes, typecheck clean, full unit suite green (the one remaining failure is a pre-existing load flake in an untouched file, green when re-run serially), no new runtime import cycles among 617 modules, and no lint suppression added anywhere.	2026-08-15 18:08:54 -07:00
Neil	9367169888	refactor(tests): split every oversized test file off the max-lines suppression list (#14728) ... * refactor(tests): split oversized test files off the max-lines suppression list Every `*.test.ts`/`*.spec.ts` that carried an `eslint/oxlint-disable max-lines` directive is now split into focused, behavior-scoped suites that fit the 800-line test budget, with shared setup extracted into co-located `*-test-harness.ts` / `*-test-fixtures.ts` modules (300-line budget). 83 files became ~930; the largest output is 797 effective lines. `orca-runtime.test.ts` is intentionally untouched. Test bodies were moved by scripted line-range slicing rather than retyped, so assertions are byte-identical. The only permitted body edits were mechanical rebinding where a shared value moved into a harness (e.g. `tmpHome` -> `homes.tmpHome`). Registries that enumerate test files were updated in lockstep: - config/max-lines-baseline.txt: pruned 341 -> 258 entries (all 83 removed). - config/reliability-gates.jsonc: 33 gates repointed at the split files, with assertionRefs split per file where a gate's coverage now spans several. - .github/workflows/pr.yml: the real-zsh lane now lists the 4 split files that actually exercise zsh, so they keep running in the dedicated shell lane. Also renamed agent-hooks `server-test-fixtures.ts` to `server.test-fixtures.ts` so the global-fetch call-site audit keeps skipping it, and added `.js` extensions to the CLI suites' dynamic harness imports (node16 resolution) to unbreak `build:cli`. Verification: full suite 52,449 passing vs 52,448 at baseline with zero assertions lost; `pnpm lint`, `pnpm typecheck`, and `pnpm build:cli` all exit 0; the terminal-pane e2e spec runs 31/31 headless. * refactor(tests): split hook-idle arbitration suite that oxfmt pushed over budget The pre-commit oxfmt pass reflowed pty-connection-hook-idle-arbitration.test.ts to 811 effective lines, 11 over the test budget. Split the hook-completion side effect and replacement-agent veto cases into their own suite; both files now sit well under the cap and the 15 tests are unchanged. * test: port upstream test changes into the split files after rebase Rebasing onto main surfaced 27 tests that main had added to files this branch deleted, plus edits to tests that had already moved. Taking the deletion side of those modify/delete conflicts would have dropped that coverage silently, so each upstream change is ported into the split file that now owns the behavior — for example main's six orchestration mailbox tests land across orchestration-runs, -send, and -check. Also repoints `orchestration.notification-mailbox-consistency`, a gate main added after this branch's gate remap, at those same three split files, and re-prunes the max-lines baseline against main's (257 entries). Verified: all 27 upstream test titles present; full suite 52,761 passing with the only diff vs baseline being 12 tests main itself removed and 3 that moved from skipped to passing; lint and typecheck exit 0. * fix(test): flush pending continuations before tearing down terminal test globals CI shard 5/16 failed on both Node 24 and 26 with `ReferenceError: window is not defined` from pty-connection.ts, surfacing through pty-connection-daemon-snapshot-replay.test.ts. The reattach/settle chains `await` a real promise and then touch `window.api`. Under fake timers those continuations cannot run, so they only become schedulable once restoreTerminalTestGlobals() switches back to real timers — which previously happened immediately before `delete globalThis.window`, so a late continuation threw and failed the whole file. Flush async ticks in that window instead. This is latent in the source rather than new: the pre-split 25k-line file kept running other tests after these, which gave the chains time to settle before teardown. Splitting the file moved teardown directly behind them. * fix(test): keep an inert window after terminal test teardown instead of deleting it The async-tick flush was not enough: the reattach/settle chain can resolve after teardown regardless of how long we drain, so CI shard 5/16 still failed with `ReferenceError: window is not defined` from pty-connection.ts. A real renderer never loses `window`, so deleting it was the artificial part. Swap in an inert proxy whose properties resolve to callables and whose calls resolve to undefined, making a late `window.api.pty.*` call a harmless no-op. The next test replaces it wholesale via installTerminalTestGlobals(), and no test asserts that `window` is absent.	2026-08-15 00:54:20 -07:00