2 Commits

Include renames

Author	SHA1	Message	Date
Brennan Benson	80e0bee23b	fix(floating-workspace): keep agent launches from moving the main window's tab (#22603) ... * fix(floating-workspace): keep agent launches from moving the main window's tab Launching an agent from the floating workspace's "+" menu switched the main window off whatever chat or editor tab it was showing and onto its terminals. The main window's selection is supposed to move only for the worktree it is showing: browser and editor tab creation, splits, moves and drops all check `activeWorktreeId === worktreeId` before touching it. Two places did not: - `launchAgentInNewTab` called `setActiveTabType('terminal')` without a worktree, which targets the active worktree whatever worktree the launch landed in. - terminal `createTab` wrote the global `activeTabId` for a tab in any worktree. Both now follow the store rule. The launch still selects its tab within its own worktree, which is what the floating panel renders. The floating titlebar button had side-stepped this with an `activate: false` opt-out plus manual selection. That opt-out had no other caller and is removed; the button now launches and focuses like every other entry point. * fix(tabs): scope the remaining launch surface writes to the launch's worktree Three more launch paths create a terminal tab and then call `setActiveTabType('terminal')` without a worktree, which targets whatever worktree is active when the call runs rather than the one the tab landed in: - the paired-host agent launch, after the host's asynchronous create - Session History resume, which can target a worktree the user is not viewing and activates it only afterwards - sleeping-agent resume, which the activation gate runs after asynchronous readiness checks, by which time the user may have moved to another worktree Each now names its worktree, like the local agent launch. The new tab still lands selected when the user switches to that worktree. * test(tabs): pin the paired-host launch scope in its existing web-runtime test * test(tabs): type the left-worktree resume fixture instead of casting it * refactor(tabs): require the worktree that setActiveTabType applies to `setActiveTabType(type, worktreeId?)` quietly fell back to the active worktree when the caller left the worktree out. A caller acting on a tab in another worktree (the floating workspace, a background launch, a reveal that lands after an async step) therefore retyped whatever the main window was showing. The launch paths fixed earlier in this branch were instances of that; 54 other callers still relied on the fallback. The worktree is now a required argument (nullable only for the no-active- worktree case), so every caller states which worktree it means and a new unscoped call fails to compile. Each call site passes the worktree of the tab it acts on; where that is by construction the active worktree (shortcuts, palette, tab strip), the result is unchanged. `activateTabAndFocusPane` resolves the tab's owning worktree the same way `setActiveTab` does. End-to-end helpers that drive the store directly pass the active worktree, which keeps their previous behaviour. * fix(floating-workspace): let the floating New Terminal activate its own tab The floating "+" New Terminal created its tab with `activate: false` and then selected it with `activateTab`, because creating an active tab used to write the main window's selected tab even for another worktree. `createTab` now activates a tab only within its own worktree's group unless that worktree is the one on screen, so the workaround is no longer needed. Creating the tab active also moves the floating workspace's remembered tab to the new one; before, it stayed on the previously selected floating tab, which auto-acknowledge reads to decide which floating agent the user is looking at. * refactor(floating-workspace): route every floating New Terminal through one creator The floating "+" New Terminal had stopped deferring activation, but Cmd+T with the floating panel focused still went through a separate creator that created the tab inactive and activated it by hand, which left the floating workspace's remembered tab on the previous tab. Both now call createFloatingWorkspaceTerminalTab, which creates the tab active in its own group and focuses it. * docs(tabs): say why an unowned tab id keeps the on-screen worktree scope	2026-09-24 10:54:43 -07:00
NeilandBrennan Benson	fbe94ceff6	fix: close readiness gaps found by merged-change audit (#17159) ... * fix(ssh): fence stale kills and retired pane replay * fix(ssh): support cancellable interactive authentication * fix(ssh): await remote catalog before snapshot adoption * fix(pty): contain Windows ConPTY input failures * fix(power): avoid redundant macOS display blocking * perf(editor): narrow markdown override subscriptions * fix(quick-open): close directory handles after reads * refactor(linux): remove unused proc socket scanner * fix(usage): apply flat Sonnet 4.6 pricing * ci: prime Node next native test cache * docs(skills): resolve snapshot cleanup data path * fix(ssh): recover install locks after host reboot * test(ssh): recognize boot-aware install locks * test(ssh): prove previous-boot lock recovery live * test(wire): pin pre-metadata release coverage * fix(terminal): preserve remote tab ownership through recovery races * test(runtime): fence replaced terminal handles in agent guard * fix(ssh): preserve remote snapshot authority across polls * fix(pty): contain late ConPTY output EPIPE * test(pty): register Windows exit watcher before kill * fix: close SSH and tab readiness race gaps * fix(tabs): retain headless order and placeholder titles * fix(build): avoid parallel electron-vite config race * test(windows): avoid MSYS temp path rewriting * test(windows): avoid killing exited PTY * fix(pty): avoid late ConPTY input teardown race * fix(terminal): sync reconnect error ownership after commit * fix(runtime): use canonical worktree identity comparison * test(ssh): assert complete cold-hydration baseline * test(windows): invoke quoted retention fixture via PowerShell * test(windows): read ConPTY grid through mode con * fix(terminal): publish PTY replacements atomically * fix(terminal): infer stale identity on reattach * fix(terminal): fence stale pane PTY callbacks * fix(terminal): fence stale pane binds after rebind * fix(terminal): reject stale pane transport callbacks * fix(terminal): fence mirrored reattach spawn callbacks * fix(terminal): replace stale pane PTYs on remount * fix(ci): size the Windows launcher-compile test budget from measurement `native-smoke (windows-latest)` fails ~4.5% of runs on `preserves a multiline argument through the compiled remote launcher` with "Test timed out in 15000ms" — on unrelated PRs, for reasons that have nothing to do with them. Across 176 sampled attempts it is the only red that job produced, and it hit seven different PRs in two days: #16900, #16904, #16915, #16955 (twice), #16979, #17014, #17085. The test is six process creations: powershell.exe forks csc.exe, then the freshly compiled orca.exe forks node.exe, twice. Hosted Windows runners periodically slow process creation down, and this test amplifies that far harder than anything else in the job. Comparing the 80 attempts where it ran under 3s against the 12 where it ran over 12s, its own median goes 2198ms -> 15917ms (7.2x) while the same file's powershell-only test moves 556 -> 686ms (1.2x), the cmd.exe and Git Bash process tests in the neighbouring file move 1.4x, and the other 35 files put together move 1.5x. Measured across those 176 attempts: 1881ms to 35438ms, p50 4264ms, correlation +0.881 with the job's total Vitest duration. 8 of 176 (4.5%) exceeded the 15s cap; 2 of 176 (1.1%) also exceeded the shared 30s testTimeout, so deleting the override and inheriting the config is not enough on its own. 60s clears all 176 with 1.7x headroom on the worst. This is slow, not hung. Every body here is synchronous spawnSync, so Vitest cannot interrupt one — the timer fires only after the body returns and the reported duration is real elapsed time. That is why a failure reads `× ... 22464ms` under `Test timed out in 15000ms`. The work finished; the stopwatch was short. Seven reruns at one identical head measured 2053 / 4680 / 5551 / 8732 / 13506 / 14868 / 21937ms — the last of those would have been red on code that had not changed. The 15s came from #8897, which raised this test off Vitest's built-in 5s default because the job then ran bare `pnpm vitest run`. #8909 landed 3h27m later and pointed the job at config/vitest.config.ts, which is the real fix for that. The constant stayed behind and has been the binding budget ever since. * fix(terminal): fence stale remount reattach ownership * fix(terminal): reconcile mounted pane identity after replacement * fix(terminal): fence stale reattach fallback ownership * fix(terminal): fence deferred SSH reattach ownership * fix(terminal): fence stale split pane ownership callbacks * fix(terminal): keep stale spawns from consuming startup --------- Co-authored-by: Brennan Benson <79079362+brennanb2025@users.noreply.github.com>	2026-08-31 08:17:40 -07:00