Commit Graph
16060 Commits
Author SHA1 Message Date
Neil aa1195c014 refactor(wsl): import lock records from their defining owner 2026-11-08 11:35:37 -08:00
Neil 1dcd285b31 Remove orphan deploy readiness fixture and shrink test baselines 2026-11-08 11:26:16 -08:00
Neil a05bfaaeaf refactor(main): organize SSH transport and managed server owners 2026-11-08 11:26:16 -08:00
OrcaWinandOrcaWin 4e70998609 test: remove 8 low-value test cases (#39934)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 11:23:56 -08:00
Kelvin Amoaba b032aa5615 feat(runtime): tell phones which settings changed (#39718)
* feat(runtime): tell phones which settings changed

* test(mobile): re-record Source Control goldens for the settings stream
2026-11-08 19:12:26 +00:00
Jinjing 8781bcb6be Reduce the maximum height of the model picker (#39774) 2026-11-08 10:58:00 -08:00
OrcaWinandOrcaWin fcd356ad88 test: remove 6 low-value test cases (#39925)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 10:50:46 -08:00
Kelvin Amoaba f74bb65fa1 feat(runtime): tell phones when git status changes (#39672)
* feat(runtime): tell phones when git status changes

* fix(runtime): tell phones about HEAD and packed-refs moves too

* fix(runtime): don't let a phone's status re-read join a read begun before the change

* perf(runtime): limit status-read invalidation to the checkouts an outside change touched

* fix(runtime): match a checkout's status keys under any execution host

* fix(runtime): invalidate globally while a primary checkout is unread

* test(mobile): re-record the Changes and settings goldens on the rebased main

* fix(runtime): invalidate globally while a listed checkout has no cached path

* test: follow the moved paired-client harness

* refactor(mobile): let the host list's catalog read hold the event router
2026-11-08 18:36:13 +00:00
Kelvin Amoaba 2aa47c91d2 fix(runtime): send a terminal's first screen before closing its stream on exit (#39681)
* fix(runtime): send a terminal's first screen before closing its stream on exit

A PTY exit while terminal.subscribe was still publishing its first snapshot
ended the stream at once: the phone got end with no screen. The exit now
waits for that publication, the exited PTY's model stays readable (off the
live map) until it finishes, and queued layout work settles on exit so it
can't hold the stream open.

* fix(runtime): skip the renderer seed when the PTY exits while its screen is read
2026-11-08 18:34:16 +00:00
Brennan Benson 5266dbe53b fix(github): stop PR pages and GitHub requests from hanging forever when the rate-limit cache expires (#39581)
* fix(github): stop PR pages from hanging when the rate-limit cache expires

Slot holders await assertRateLimitBudget -> getRateLimit while holding a
gh semaphore slot, and the /rate_limit probe queued for a slot behind
them. With all four slots held by budget waiters nothing ever released.
The probe is quota-exempt and deduped, so it no longer takes a slot.

* fix(github): bound rate-limit probe concurrency without the gh semaphore

Forced getRateLimit calls now join an in-flight probe, and all /rate_limit
probes share a small probe-only limiter that acquires nothing else.
Fold the deadlock regression test into rate-limit.test.ts as a direct await.

* fix(github): make forced rate-limit probes read quota after the call

Forced callers (403 reset refinement) share one follow-up probe queued
behind the running one instead of joining a probe that may predate the
403, so a stale positive budget cannot clear a fresh breaker block.

* fix(github): hand forced rate-limit follow-ups off synchronously

A pending forced follow-up could outlive its probe's settlement, so a
later forced caller joined a probe that predated it. Settlement now
detaches the shared deferred follow-up and starts its probe in one
synchronous step. Run rate-limit.test.ts on the Node runtime, where the
V8 scheduling that opens the race is reproducible.
2026-11-08 10:29:37 -08:00
OrcaWinandOrcaWin 4eadc6623e test: remove 19 low-value skill and renderer tests (#39921)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 10:28:11 -08:00
Brennan Benson ace74af490 Open search-result agent setup as a hover submenu (#39569)
* Open search-result agent setup as a hover submenu

The + menu's search-result agent rows opened setup through a separate
click popover. Route them through the same native submenu the regular
agent rows use, delete the popover path, and keep hover from moving
focus off the omnibox input.

* Keep omnibox typing in the search box when agent setup opens or closes

Hovering a search row's › no longer moves focus into the setup panel, and
Escape, ArrowLeft or leaving the open row return focus to the search input.
Also stop dimming disabled setup rows twice.

* Give omnibox agent setup pointer grace before another row closes it

Crossing an ordinary result on the way to the panel no longer closes the
setup; another row closes it after 300 ms unless the pointer reaches the
panel or returns to its row, like Radix submenus.

* Keep a hover-opened omnibox setup from taking focus after a keystroke

Typing can shift a row under a resting pointer and open its setup while
Radix is in keyboard mode; its content autofocus now returns to the
search input until the pointer moves into the panel.

* Open omnibox agent setup on pointer movement, and keep panel typing on leave

Per the decider ruling: a row shifting under a resting pointer no longer
opens its setup (Radix sub-triggers also open on pointermove), and leaving
the row after clicking › keeps focus in the setup editor instead of moving
typing back to the search box.

* Return omnibox focus to the search box when a focused setup closes on its own

Clicking › and then moving to another row let the hover grace close the
panel while it held focus, dropping focus to the page; closing it now
returns typing to the search input.

* Test that a caller-closed setup returns focus to the omnibox input

* Render omnibox search tests inside the + menu so agent setup has its menu

* Keep omnibox setup wiring React Compiler friendly

Build each row's setup handlers at the call site from plain hook state, and
configure the launched option inside the handler, so nothing that reads refs
runs during render.
2026-11-08 10:08:52 -08:00
Brennan Benson 7220069db0 Open the branch picker from the branch name under the chat composer (#39692)
* Open the branch picker from the branch name under the chat composer

* Copy the current branch from its row in the composer's branch picker

* Keep the composer copy button clickable and out of the list's keyboard, and keep a twin copy's status out of the picker

* Read a twin copy's status privately in the branch picker and drop refreshes that land after its twin is selected

* Block on a twin's returned read error, re-read after the picker closes itself, and distrust a twin's leftover status on becoming owner

* Build the environment name selector outside the component so the React compiler can lower the picker

* Trust a copy's status again once its picker refresh settles, even when an identical newer poll superseded it

* Read a newly owning copy's own status until the inherited slot changes, instead of trusting a settled refresh

* Route the composer picker through the copy's owner and block while this chat's turn is active

* Keep the composer picker's agent gate on the shared working check, as in Source Control
2026-11-08 10:06:53 -08:00
Brennan Benson 87947ae868 Show CI results as one-line cards on desktop and phone, following the desktop setting (#39658)
* Show CI result lines on the phone, following the desktop setting

The host now sends nativeChatCiResultLines resolved in settings.get, the
ready snapshot and a nativeChatCiResultLinesChanged event, from one
publisher that tracks each pushed chat preference separately. The phone
keeps one store per desktop connection and preference, reads the CI value
only from the paired desktop, and hides the lines until that desktop
reports one. CI rows stay in the projection and are filtered after it, so
a flip rebuilds nothing. The phone draws the line with links to the pull
request and commit.

* Let the phone CI line wrap and select like other notices

Long repository names at large font scale no longer push the commit link
past an ellipsis: the line wraps, centered, with the icon on its first
line. Its text follows the system-notice selection policy, so iOS selects
natively and Android keeps the long-press actions sheet. The CI strings
are translated in every mobile locale, the filter copies only once it
meets a CI row, and the tests drop a token assertion and a duplicate case.

* Draw CI results as one-line cards on desktop and phone

The CI result line becomes a one-line card in the same frame as the
opened pull request card, with the Hide button inline at its right end
on desktop, and in the phone's chat card frame without one. Only the
lead and pull request name truncate, so the commit link and the Hide
button stay reachable on narrow widths. The fixture uses real
percent-encoded item ids so its links render.

* Make the CI card's whole lead open its pull request

A translated lead at large font scale can push the ellipsis before
repo#N, which left no visible way to open the pull request. The
truncating segment is now the pull request's target on desktop and
phone, named for it, while "at <sha>" stays the commit's own target.
The ja, zh and zh-Hant leads use a plain colon so the space after it
isn't doubled.

* Read the CI result lines setting only for structured chats

CI result lines come only from structured sessions' journals, so a
terminal chat no longer sends the setting read. The prompt-controller
fixture stubs the setting hook: its tests count only the chat's prompt
writes, and the structured chat's one read per desktop connection is
expected.
2026-11-08 10:05:27 -08:00
OrcaWinandOrcaWin f2d1d5782c test: remove 12 low-value skill transfer tests (#39911)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 10:01:47 -08:00
Neil cd546dc3d0 refactor(skills): retire unused removal service and test concrete owners (#39902) 2026-11-08 09:19:54 -08:00
OrcaWinandOrcaWin 492ccce634 test: remove 5 low-value skills tests (#39903)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 09:07:53 -08:00
OrcaWinandOrcaWin d5f7081243 test: remove 8 low-value skills tests (#39899)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 08:55:00 -08:00
Neil a964c9e0b5 refactor(acp): group transport, session, launch, and timeline owners (#39897) 2026-11-08 08:42:10 -08:00
OrcaWinandOrcaWin 078bda27f8 test: remove 7 low-value workspace-store tests (#39896)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 08:34:08 -08:00
OrcaWinandOrcaWin 89422778ee test: remove 11 low-value agent-status tests (#39893)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 08:16:45 -08:00
OrcaWinandOrcaWin 4ec21a86df test: remove 13 low-value hook tests (#39892)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 08:07:11 -08:00
OrcaWinandOrcaWin 786a5b21a2 test: remove 23 low-value hook tests (#39889)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 07:56:03 -08:00
Neil 26a4db6b4e refactor(skills): group discovery, install, cloud, and transfer owners (#39874)
* refactor(skills): organize installation, discovery, and transfer owners

* chore(skills): reconcile move validation metadata
2026-11-08 07:39:57 -08:00
OrcaWinandOrcaWin 459128006c test: remove 6 low-value renderer work-count tests (#39885)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 07:34:34 -08:00
OrcaWinandOrcaWin e0ea78c7d4 test: remove 6 low-value resume and lifetime tests (#39881)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 07:17:34 -08:00
OrcaWinandOrcaWin 749829b2a6 test: remove 5 low-value agent launch tests (#39875)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 07:09:20 -08:00
Neil c10881fa8c refactor(shared): organize execution and automation defining owners (#39776)
* refactor: import journal queue state from defining owners

* refactor(shared): organize execution and automation owners

* fix: retain type imports used by surviving test cases

* refactor: finish work item owners and refresh validation metadata

* test: infer reconnect status fixture type

* test(claude): resolve source files beside same-named directories

* test(runtime): group repository creation mock registrations
2026-11-08 06:46:09 -08:00
784aefee50 perf(tasks): look up the GitLab comment viewer only on phone reads (#39860)
* perf(tasks): look up the GitLab comment viewer only on phone reads

The phone is the only reader of viewerDidAuthor, so GitLab detail reads
from desktop IPC and the Checks poll skip the `glab api user` lookup.
The phone sends markViewerComments on every GitLab detail read.

Ported from #39749 (GitLab part only); GitHub REST-fallback viewer
lookup is unchanged.

Co-authored-by: AmoabaKelvin <97001695+AmoabaKelvin@users.noreply.github.com>

* perf(tasks): keep GitLab viewer marks by default; desktop detail reads opt out

Older phones and callers that omit markViewerComments keep author marks.

Co-authored-by: AmoabaKelvin <97001695+AmoabaKelvin@users.noreply.github.com>

---------

Co-authored-by: m4air <m4air@m4airs-MacBook-Air.local>
Co-authored-by: AmoabaKelvin <97001695+AmoabaKelvin@users.noreply.github.com>
2026-11-08 06:27:50 -08:00
OrcaWinandOrcaWin b67159291b test: remove 14 low-value renderer tests (#39871)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 06:26:47 -08:00
Neilandm4air dddc1260e5 chore(lint): oxlint 1.91, cheap perf/correctness rules, return-await fixes (#39730)
* chore(lint): bump oxlint to 1.91, add perf lint rules and perf audits

* fix(lint): await promises returned inside try/catch/finally for return-await

Prepare typescript/return-await with error-handling-correctness-only: await
returns whose catch or finally was meant to cover them, and suppress the eight
sites where the catch must not re-handle the returned promise.

* chore(lint): enable return-await (error-handling-correctness-only); exempt secondary-scan directives in the changed gate

* refactor(mobile): move file preview discard modal into its own module

Keeps MobileFilePreviewScreen under the 400-line limit after merging main.

---------

Co-authored-by: m4air <m4air@m4airs-MacBook-Air.local>
2026-11-08 06:21:54 -08:00
ae6675d67c fix(window): cancelling a quit prompt clears the quit latch so later closes aren't treated as quits (#39597)
* fix(window): cancelling a quit prompt now cancels the quit

Renderer-owned quit prompts (running-work "Close Window?", Save dialog,
close-guard and shutdown-checkpoint vetoes) never reach
will-prevent-unload, so main kept isQuitting latched after Cancel. A later
plain close was treated as a quit and renderer crashes were not recovered.

Add a window:close-cancelled IPC (preload ui.cancelWindowClose; no-op in the
web client) that the renderer sends on each cancel path. Main accepts it only
from its own renderer, only while quitting, and only once that renderer has
acknowledged the newest close request, then runs the same abort path as a
beforeunload veto.

Fixes #39596

Co-authored-by: Neil <neil@stably.ai>

* test(window): expose webContents.send on the renderer recovery harness type

---------

Co-authored-by: tomarai85 <tomarai85@users.noreply.github.com>
Co-authored-by: Neil <neil@stably.ai>
2026-11-08 06:17:53 -08:00
d464685250 fix(codex): do not count a dangling link raced into the target as bridged (#39862)
When a link attempt finds the target taken, check what is there. A
dangling symlink another writer created after the directory listing is
not readable history, so the thread stays out of the bridged set, as
on main.

Co-authored-by: m4air <m4air@m4airs-MacBook-Air.local>
Co-authored-by: AmethystLiang <6427696+AmethystLiang@users.noreply.github.com>
2026-11-08 06:14:48 -08:00
OrcaWinandOrcaWin 60aee85d91 test: remove 27 low-value hook and terminal tests (#39866)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 06:05:26 -08:00
OrcaWinandOrcaWin 7d195c7e50 test: remove 95 low-value renderer tests (#39859)
* test: remove 95 low-value renderer tests

* test: remove duplicate environment directives

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 05:53:18 -08:00
OrcaWinandOrcaWin 8c1e6dfba7 test: remove four redundant terminal tests (#39858)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 05:43:52 -08:00
Neil 10c01509de fix(ime): don't swallow the first Enter after toggling Japanese IME off with Hankaku/Zenkaku (#39834)
On Windows, Hankaku/Zenkaku commits the Japanese composition as a
Process/229 keydown that may never send a keyup. The composer treated any
Process/229 keydown as an IME-confirm Enter and armed the carry, so the
user's next real Enter was swallowed. Only arm the carry when the
processed key's physical code is Enter (or unknown), sharing the code
check with the terminal IME path.

Fixes #39289
2026-11-08 05:32:19 -08:00
Neil 5fb71170ff fix(hermes): tolerate a deleted cwd in the status hook so pre_tool_call isn't blocked (#39833)
Hermes Kanban cleanup can remove a worker's cwd; os.getcwd() then raised
FileNotFoundError from the orca-status plugin and Hermes failed pre_tool_call
closed, blocking the tool. The payload now omits cwd when it can't be read.

Fixes #39736.
2026-11-08 05:32:09 -08:00
OrcaWinandOrcaWin 96f5f5a9eb test: remove 128 low-value tests (#39853)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 05:31:22 -08:00
Jinjing 63637e82e8 perf(codex): bridge account history with async directory diffs (#39805)
Account selection and every Codex launch walked all rollouts in every
source home and ran a synchronous existsSync per rollout on the main
process, then linked missing ones with sync mkdir/link/symlink. A CPU
profile of an installed build attributed ~6.4s of sampled existsSync time
to this bridge during typing lag.

The bridge now walks all source homes together and diffs directory
listings asynchronously, so a target directory is read once per pass and
history the target already holds costs no per-rollout synchronous call.
Small directories use per-path checks instead of listing a wide target.
Name matching yields every 256 entries.

Behavior matches the previous bridge:
- An existing target name is never overwritten.
- Earlier sources are tried first, and a later source still gets an
  attempt when an earlier one cannot be linked.
- Hardlink-only targets skip and leave no folders behind.
- Readiness, index healing and quit handling are unchanged.
2026-11-08 13:14:22 +00:00
OrcaWinandOrcaWin 22f387b6b3 test: remove 231 low-value tests (#39850)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 05:06:36 -08:00
Neil 656a05de0d perf(main): overlap independent fs probes; skip per-entry copies (#39729)
* perf(main): overlap independent fs probes on git status, agent detection and orcad startup

* perf: skip per-entry copies in git change list and tab hydration; drop unused activity barrel
2026-11-08 05:05:19 -08:00
8995b03646 perf(skills): read skill folders ahead of the walk, three reads at a time (#39836)
* perf(skills): read skill folders ahead of the walk, three reads at a time

Port of #35220. findSkillFiles awaited realpath then readdir for every
folder, so a busy main process paid about two event-loop turns per folder.
A read-ahead now lists folders in walk order while the walk claims them
in its own depth-first order, so results, order, alias winners and the
cycle guard are unchanged.

Changes from #35220: up to 3 read-ahead reads (was 64) plus at most one
demand read from the serial walk, so at most 4 directory reads in flight
on libuv's 4-thread pool; a sorted array replaces the min-heap; tests
assert walk results only.

Co-authored-by: thefrikidude <100475418+thefrikidude@users.noreply.github.com>

* test(skills): drop walk tests that cannot detect the read-ahead

Both pass on the old walk, so they do not guard this perf-only change.
Note the in-flight bound applies per walk.

Co-authored-by: thefrikidude <100475418+thefrikidude@users.noreply.github.com>

---------

Co-authored-by: m4air <m4air@m4airs-MacBook-Air.local>
Co-authored-by: thefrikidude <100475418+thefrikidude@users.noreply.github.com>
2026-11-08 04:41:21 -08:00
0f6432319d perf(orchestration): back off failing federation relays instead of polling every second (#39734)
Each federated dispatch relay now reschedules itself and doubles its wait
after consecutive failures (capped at 30 s) instead of syncing every second
forever. A server turning verified, or a sync completed by another caller,
returns the relay to the base cadence. A coordinator blocked in
`check --wait` re-arms its run's relays every 15 s, so a recovered worker is
seen within that window. Relays for a server removed from this host stop
instead of retrying; the next relay arm brings them back if it is re-added.
Stale in-flight syncs no longer record acknowledgments, epochs or home
auto-release after the relay stopped.

Replaces #39283.

Co-authored-by: m4air <m4air@m4airs-MacBook-Air.local>
Co-authored-by: brennanb2025 <79079362+brennanb2025@users.noreply.github.com>
2026-11-08 04:38:49 -08:00
Neilandm4air 2a5a939a0c test: split GitHub and GitLab mocks out of runtime setup.spec to fix main lint (#39837)
* test: split GitHub and GitLab mocks out of runtime setup.spec

setup.spec.ts reached 801 counted lines after #39575, failing the root
oxlint max-lines rule on main. Move the GitHub/hosted-review and GitLab
mock functions and their vi.mock registrations into sibling modules that
setup.spec re-exports, so every consumer keeps the same imports and mocks.

* test: name split runtime mock modules as test harnesses

The module-mocking lint exempts *-test-harness.ts support modules shared by
split suites; the split-out GitHub and GitLab mock modules are exactly that.

---------

Co-authored-by: m4air <m4air@m4airs-MacBook-Air.local>
2026-11-08 04:22:50 -08:00
RoastFriedandNeil ba04481e42 fix(browser): keep native popup minimum content size and first Windows fixture error (#39319)
Native popups now hide the app menu bar like origin-bar popups, so the
Windows menu no longer eats into the 200px minimum content height.

The popup compatibility fixture keeps the first reported error across
later status writes, stops serializing the destroyed Event as an error,
and replaces its status file with the Windows retry helper. The native
resize check now compares against the native outer window size.

Fixes #39299

Co-authored-by: Neil <neil@stably.ai>
2026-11-08 04:01:25 -08:00
OrcaWinandOrcaWin 5fc3b26766 test: remove 712 low-value tests (#39829)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-08 03:51:04 -08:00
WenhaoandNeil 448aaadde6 fix(antigravity): detect Orca Chat sign-in via antigravity-acp/acp_token.json (#39398)
agy-acp-server 1.4.1 keeps the personal sign-in at
<GEMINI_HOME>/antigravity-acp/acp_token.json; nothing it writes ends in
oauth-token, so a signed-in Chat read as signed out and new chats could
move to the host's ~/.gemini account.

Fixes #39395

Co-authored-by: Neil <neil@stably.ai>
2026-11-08 03:45:48 -08:00
Brennan Benson d857e09615 Git Graph: commit actions (checkout, cherry-pick, revert) (#39069)
Adds commit actions to the Git Graph: check out a commit or branch, cherry-pick, revert, and create a branch from a commit. Conflicts hand off to Source Control with continue and abort. Works on local, WSL and remote hosts.
2026-11-08 03:43:30 -08:00
Brennan Benson 3fe350eaed Create a worktree per repository from an empty folder workspace (#39575)
A folder workspace with no worktrees now offers Create worktree for each repository, named after the folder workspace. If that branch name is already taken, the host refuses instead of picking another name, and the composer opens so you can choose.
2026-11-08 03:30:10 -08:00