3 Commits

Include renames

Author	SHA1	Message	Date
Neil	991a3fe963	chore(lint): update oxlint to 1.77 and enable no-op cleanup rules (#13901) ... Enable eleven oxlint rules that simplify code without changing behavior, and fix every existing violation. Each candidate was gated on measured cost rather than assumption, so rules that regressed runtime performance or type checking were dropped instead of suppressed. typescript/no-redundant-type-constituents is the largest addition: 113 sites, no autofix. Dead constituents are deleted. Where the redundant literal existed to document intent (`string | 'all'`), it is preserved as `(string & {})`, which keeps the autocomplete hint the original code was reaching for instead of flattening it away. The rule also caught a broken import — remote-shared-control-retirement-probe.ts pulled RuntimeStatus from src/shared/types, which does not export it, so the type silently degraded to `any`; no tsconfig covers that file, so tsc never saw it. oxlint stays at 1.77.0 rather than 1.78.0 because .npmrc sets minimum-release-age=4320 and 1.78.0 is younger than that window. Rules evaluated and rejected, with what disqualified each: - prefer-string-raw: String.raw is a runtime call, not a literal (184x slower) - prefer-string-replace-all: 26% slower - text-encoding-identifier-case: ~5% slower, reproducible - prefer-spread: [...str] is 110% slower than split('') and differs on surrogates - no-implicit-coercion: `!!x` narrows types and `Boolean(x)` does not (22 tsc errors) - prefer-arrow-callback: arrows are not constructible, breaking `new` on mocks - object-shorthand: rewrites source text asserted by a tracked reliability gate - switch-case-braces: pushes ten files past max-lines, which cannot be suppressed - no-useless-switch-case: drops `case undefined:` that switch-exhaustiveness-check needs - arrow-body-style: 115 violations have no fix, and it breaks max-lines - newline-after-import: false-positives on the leading-semicolon ASI idiom electron-vite-output-contract asserted on the literal Object.prototype.hasOwnProperty.call text; retarget it to Object.hasOwn, which rejects inherited keys identically.	2026-08-11 18:19:43 -07:00
5 people	8c5371ebad	fix(worktrees): respect Windows shell for setup runners (#6967) ... * Honor configured shells during worktree setup * Align setup launch paths with selected Windows shells * Carry setup shell selection through deferred launches * Prove Windows setup shell routing at its real adapters * Ground remote PowerShell proof in the real writer * Preserve Git Bash across deferred setup launches * Harden Windows setup runner shell selection - Resolve remote PowerShell binary without local pwsh probe: for SSH/remote Windows worktrees, isPwshAvailable() reflects only the LOCAL host, so an 'auto' implementation could route the remote runner to a pwsh.exe the remote lacks. Add resolveSetupRunnerShell(..., { probeLocalPwsh: false }) so remote auto keeps the always-present powershell.exe; explicit pwsh.exe still honored. - Preserve native exit codes in the PowerShell runner by checking $LASTEXITCODE before $?, so a failing native command surfaces its real code instead of a generic exit 1; $? still catches cmdlet soft-failures. - Write the PowerShell runner with a UTF-8 BOM so Windows PowerShell 5.1 (the new default powershell.exe) reads it as UTF-8 instead of ANSI, preventing non-ASCII setup-script corruption. - Add unit tests for the remote-probe behavior. * Restore setup-shell scope narrowing over the rebase The force-pushed rebase dropped five review-fix commits that were already on this branch; this reapplies their combined effect on top of the new base and the hardening commit: - Keep SSH setup shell selection remote-owned (no local terminalWindowsShell or pwsh routing for remote hosts; supersedes the probeLocalPwsh guard) - Preserve cmd setup compatibility outside POSIX shells (no .ps1 runner family, so the BOM/exit-code hardening is no longer applicable) - Route WSL setup runners from the project runtime - Avoid blocking PowerShell probes during setup creation - Correct SSH and WSL background setup fixtures * Satisfy the changed-code gates for the setup-shell runner - createWorktreeRunnerScript took 7 positional parameters, tripping the changed-code max-params gate; move it to a single options object. - hooks-runner.test.ts deep-equals the createSetupRunnerScript result, so assert the cmd shell now returned for native Windows worktrees. * Carry the setup launch shell through observed and issue runners - buildObservedSetupCommand takes the runner's launch shell so WSL-routed Windows-drive setup replays use /mnt/c instead of Git Bash /c - resolveSetupRunnerShell gates the posix runner on the same Git Bash resolution the PTY uses, so a missing or non-MSYS bash keeps the cmd runner - issue-command runners carry their launch shell, and the renderer passes it when building the queued command - treat a bare `bash` shell setting as POSIX like `bash.exe` Co-authored-by: Orca <help@stably.ai> * fix(worktrees): close counsel P1 gaps for Windows setup shells Route windowless/headless creates through the shell-aware setup runner when a PTY controller is available, existence-check explicit Git Bash paths before committing to .sh runners, thread the resolved shell into issue-command runners, and document the intentional Git Bash interpreter flip with a narrow scope table. * Convert setup env to MSYS form and harden the bare cmd runner launch C3: a Git Bash setup runner now receives ORCA_*/CONDUCTOR_*/GHOSTX_* path values in /c/... form, matching the runner path and the shell's own HOME/PWD. C5: extension-less `bash` resolves to Git Bash everywhere, matching how resolveWindowsShellStartupFamily already classifies it. C7: runner paths carrying characters that cannot be quoted on a cmd command line launch through a delayed-expansion PowerShell shim instead, and the batch runner disables inherited delayed expansion so `!` in setup lines survives. Co-authored-by: Orca <help@stably.ai> * docs: note MSYS ORCA_* paths and bare bash Git Bash resolution Keep the setup-shell release note aligned with C3 env conversion and C5 bare bash resolution so the published claim matches runtime behavior. * revert: drop windows-setup-shell doc allowlist and AGENTS link Keep the counsel P1/P2 product fixes without expanding the docs allowlist or AGENTS.md guidance surface. * fix(plugins): contain Parcel unsubscribe rejections under Vitest Dev plugin watchers fire-and-forget unsubscribe, and in-process Parcel can reject when temp watch roots are already deleted. Catch those rejections so they cannot fail the suite as unhandled errors. * fix(plugins): keep in-process unsubscribe rejection surface Swallowing Parcel unsubscribe errors broke mocked unsubscribe tests that return non-Promises and expect rejections. Contain failures only in PluginDevWatcher fire-and-forget paths. --------- Co-authored-by: OrcaWin <alpha-eng@stably.ai> Co-authored-by: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Co-authored-by: Jinjing <6427696+AmethystLiang@users.noreply.github.com> Co-authored-by: Orca <help@stably.ai>	2026-08-02 17:40:58 -07:00
NeilandOrca	97e4776dfe	feat(plugins): Orca plugin system — kernel, content packs, panels, workers, marketplace v0 (experimental) (#8549) ... * feat(plugins): Orca plugin system — kernel, content packs, panels, workers, marketplace v0 (experimental) Adds Orca's experimental plugin system behind a settings flag: a supervised kernel, declarative content packs (VM recipes, commands and keybindings, language packs), sandboxed iframe panels, forked worker hosts, and a Git-backed marketplace v0 with consent, provenance and kill-list enforcement. Theme, icon-theme and terminal-theme contributions are deferred to a follow-up pass. * fix(plugins): make unsupported marketplace listings unreachable by key findPlugin() backs preview/install/previewInstalledUpdate via requireListing(), so filtering only listPlugins() hid the catalog card while leaving the dead install path reachable one click later. * fix(plugins): fan Pi session-only status out to plugin subscribers The providerSessionOnly early-return in applyNormalizedStatus emitted to onAgentStatus (main-window fanout) but skipped enrichedStatusListeners, so plugins subscribed to agent.status.changed silently missed every Pi session_start event. Route both emit sites through one helper so a future early return cannot drop the plugin tap again. Co-authored-by: Orca <help@stably.ai> * plugins: drop dead code and hoist duplicated trust-boundary patterns Cleanup pass over the P1 diff, no behavior change: - Delete `readPluginTreeSnapshot`/`readSnapshotFile` and their types, plus the now-vestigial `directories`/`signal` plumbing in `collectFiles`. - Delete `resolveContainedPluginDirectory` (no callers). - Delete `plugin-content-load-pool.ts`; it reimplemented the existing `mapWithConcurrency`, whose index arg also removes the pairing wrapper in `buildPluginList`. - Hoist `PLUGIN_CONTENT_HASH_PATTERN` and `PLUGIN_COMMIT_PATTERN` into the install-lockfile module; 11 sites hand-rolled these identically. - Point the new reliability gate at the PR instead of gitignored docs paths, matching every other gate's link form. * fix(plugins): retry plugin state renames on Windows AV/EPERM locks Six plugin write paths (lockfile, provenance, current pointer, kill list, marketplace cache, staged install dir) did a plain rename, so an antivirus or indexer holding the target open surfaced as a failed install. The repo already retries this hazard for issue #1507, but only through a sync helper; these paths are all async. Adds one bounded async retry + atomic write used by all six, and trims a consent-provenance header that restated its own JSX. * test(plugins): cover the Windows rename retry path The retry loop shipped untested: both existing cases hit the non-retry path, and the temp-cleanup test passed identically with the `finally` removed. Mock `rename` to queue errno codes so CI can exercise locks it cannot provoke. Co-authored-by: Orca <help@stably.ai> * fix(plugins): pin bundled plugin resources to LF Windows CI checks out with autocrlf, so the byte-hashed launch tree arrived as CRLF and verify-packaged-plugin-resources rejected it — the packaged build could never pass on Windows. Reproduced locally: CRLF yields the exact CI error, LF verifies clean. Files are already LF, so nothing renormalizes. Co-authored-by: Orca <help@stably.ai> * test: guard the bundled-plugin LF pin against a CRLF checkout The byte-hash mismatch only surfaced in Windows packaging CI. Assert the .gitattributes pin and that a CRLF tree is rejected, so a regression fails on any platform instead of waiting for a packaged Windows build. Co-authored-by: Orca <help@stably.ai> * ci: trigger packaged-build check on bundled plugin resource changes The launch tree is byte-hashed during packaging, but no trigger path covered it — so the CRLF fix for that check would not have re-run the check. Add the resources, verifier and .gitattributes paths that can break packaging. Co-authored-by: Orca <help@stably.ai> * perf(plugins): rebuild the panel frame only when its baked theme values change The revision keys the panel iframe, so every bump destroys the sandboxed frame and its in-panel state. It counted root attribute mutations, but --workspace-sidebar-live-width is written every rAF of a sidebar drag, so dragging with a panel open blanked it ~60x/sec. Compare the two values the shell actually bakes in instead. Co-authored-by: Orca <help@stably.ai> * test: stop pinning a plugin name in the CRLF guard The CRLF case rewrites every launch file, so the reported mismatch is whichever plugin sorts first. P2 adds theme plugins that sort ahead of orca-navigation-shortcuts, which broke the assertion there. Co-authored-by: Orca <help@stably.ai> * style: drop stray blank lines left by the rebase resolutions Both sides of the agent-hooks and orca-runtime conflicts contributed a trailing blank, which oxfmt rejects. Whitespace only. Co-authored-by: Orca <help@stably.ai> * test(plugins): stop the startup budget failing on machine load P95 runs 16-34ms idle but exceeds the 50ms bound under full-suite parallelism, so the gate flaked. Widen it to catch an order-of-magnitude regression instead; the no-worker/no-plugin-code assertions are the real guarantee. Verified a 400ms regression still fails. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>	2026-07-27 01:14:33 -07:00