2 Commits

Include renames

Author	SHA1	Message	Date
OrcaWinandOrcaWin	7d6603aa17	[comment audit] Complete repository-wide comment cleanup (#33249) ... * [comment audit] Align legacy failure-read counts with cached display * [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci] * [comment audit] Condense shared generation, path and preview comments [skip ci] * [comment audit] Condense host, file and Git contract rationale [skip ci] * [comment audit] Tighten Git lifecycle and provider contract comments [skip ci] * [comment audit] Clarify shared host authority and launch isolation [skip ci] * [comment audit] simplify local access mobile and native chat contracts [skip ci] * [comment audit] simplify native chat presentation and state contracts [skip ci] * [comment audit] simplify native runtime and provider contracts [skip ci] * [comment audit] simplify migration and orchestration contracts [skip ci] * [comment audit] simplify plugin trust and process capture rationale [skip ci] * [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci] * [comment audit] clarify remote recovery and launch wire rationale [skip ci] * [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci] * [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci] * [comment audit] clarify sidebar, skill and SSH invariants [skip ci] * [comment audit] condense structured chat delivery and timing rationale [skip ci] * [comment audit] condense terminal replay and telemetry invariants [skip ci] * [comment audit] clarify launch permission and terminal delivery rationale [skip ci] * [comment audit] clarify workspace ownership and layout contracts [skip ci] * [comment audit] wait for fitted and painted SSH terminal links * [comment audit] clarify layout persistence and session ownership [skip ci] * [comment audit] clarify host routing and workspace lifecycle contracts [skip ci] * [comment audit] clarify startup persistence and app lifetime comments [skip ci] * [comment audit] clarify recovery and activity boundaries [skip ci] * [comment audit] condense activity and artifact invariants [skip ci] * [comment audit] condense automation authority contracts [skip ci] * [comment audit] simplify automation scheduling and history contracts [skip ci] * [comment audit] clarify browser chrome and annotation lifecycles [skip ci] * [comment audit] clarify browser routing and retained guest ownership [skip ci] * [comment audit] clarify browser recovery and document ownership comments [skip ci] * [comment audit] restore hosted runners required by native IME fixtures * [comment audit] shorten preview, palette and dashboard invariants [skip ci] * [comment audit] clarify terminal preview, dashboard and retention comments [skip ci] * [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci] * [comment audit] shorten rich-text and combined-diff ownership comments [skip ci] * [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci] * [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci] * [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci] * [comment audit] clarify rich Markdown source and selection safeguards [skip ci] * [comment audit] clarify editor loading and emulator stream lifetimes [skip ci] * [comment audit] trim emulator and feature tour narration [skip ci] * [comment audit] clarify floating workspace and GitHub cache ownership [skip ci] * [comment audit] trim provider controls and Linear filter explanations [skip ci] * [comment audit] clarify pairing and chat resume lifetimes [skip ci] * [comment audit] clarify chat delivery and transcript lifetimes [skip ci] * [comment audit] clarify session options and host-owned status [skip ci] * [comment audit] clarify draft durability and live-status precedence [skip ci] * [comment audit] Trim chat send and model ownership explanations [skip ci] * [comment audit] Shorten transcript ownership and send recovery comments [skip ci] * [comment audit] Simplify native chat composer and transcript hook comments [skip ci] * [comment audit] Shorten native chat scroll and structured session explanations [skip ci] * [comment audit] Trim workspace picker and onboarding commentary [skip ci] * [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci] * [comment audit] Trim sidebar and session history explanations [skip ci] * [comment audit] Condense session resume and review checks comments [skip ci] * [comment audit] Shorten checks state and file explorer refresh comments [skip ci] * [comment audit] Trim plugin bridge and source-control action rationale [skip ci] * [comment audit] Trim source-control listing and review rationale [skip ci] * [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci] * [comment audit] Condense Settings account and appearance rationale [skip ci] * [comment audit] Trim pairing and repository Settings explanations [skip ci] * [comment audit] Condense Settings search SSH and terminal safeguards [skip ci] * [comment audit] Shorten Settings voice and provider ownership comments [skip ci] * [comment audit] Condense Settings draft persistence and host-state rationale [skip ci] * [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci] * [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci] * [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci] * [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci] * [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci] * [comment audit] Prune focus-read baseline after comment cleanup * [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci] * [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci] * [comment audit] Clarify viewport geometry and skill update safeguards [skip ci] * [comment audit] Tighten skill inventory, usage and host status comments [skip ci] * [comment audit] Clarify usage ownership and resource kill safeguards [skip ci] * [comment audit] Tighten tab selection, rename and search contracts [skip ci] * [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci] * [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci] * [comment audit] Tighten provider loading and terminal recovery comments [skip ci] * [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci] * [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci] * [comment audit] Tighten PTY startup and replay explanations [skip ci] * [comment audit] Clarify PTY identity and delivery ownership [skip ci] * [comment audit] Shorten remote reconnect and input replay rationale [skip ci] * [comment audit] Condense terminal parking clipboard and file link comments [skip ci] * [comment audit] Clarify IME ownership and trim trace history [skip ci] * [comment audit] Shorten pane recovery and parked watcher explanations [skip ci] * [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci] * [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci] * [comment audit] Trim renderer lifecycle and menu rationale [skip ci] * [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci] * [comment audit] Clarify renderer hook evidence and source ownership [skip ci] * [comment audit] Tighten IPC ownership and reconnect explanations [skip ci] * [comment audit] Trim renderer focus, paste and attention comments [skip ci] * [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci] * [comment audit] Trim agent launch, resume and ownership commentary [skip ci] * [comment audit] Shorten account, browser and editor comments [skip ci] * [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci] * [comment audit] Condense launch recovery and editor tokenization comments [skip ci] * [comment audit] Condense workspace selection and terminal pane rationale [skip ci] * [comment audit] Condense terminal fitting and rendering recovery comments [skip ci] * [comment audit] Condense terminal input and host routing explanations [skip ci] * [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci] * [comment audit] Condense structured launch and terminal link explanations [skip ci] * [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci] * [comment audit] Condense session persistence and workspace activation rationale [skip ci] * [comment audit] Condense workspace routing and browser ownership rationale [skip ci] * [comment audit] Condense mirror recovery and layout authority rationale [skip ci] * [comment audit] Condense runtime transport and file safety rationale [skip ci] * [comment audit] Condense runtime graph and structured session rationale [skip ci] * [comment audit] Condense browser creation and remote tab recovery rationale [skip ci] * [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci] * [comment audit] Condense frame, startup and provider cache rationale [skip ci] * [comment audit] Condense host twin and agent lifecycle rationale [skip ci] * [comment audit] Condense browser authority and editor cleanup rationale [skip ci] * [comment audit] Condense editor buffer identity and review cache rationale [skip ci] * [comment audit] Condense provider lifetime and repository ownership rationale [skip ci] * [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci] * [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci] * [comment audit] Condense cleanup ownership and listing admission rationale [skip ci] * [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci] * [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci] * [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci] * [comment audit] Condense cloud rollout and assignment safety rationale [skip ci] * [comment audit] Condense relay session and database recovery rationale [skip ci] * [comment audit] Condense relay placement and protocol compatibility rationale [skip ci] * [comment audit] Condense build and packaging constraints [skip ci] * [comment audit] Condense CI gates and validation isolation rationale [skip ci] * [comment audit] Condense catalog identity and browser validation rationale [skip ci] * [comment audit] Condense mobile browser and frame-budget rationale [skip ci] * [comment audit] Shorten mobile route and browser test explanations [skip ci] * [comment audit] Condense editor and session seam test rationale [skip ci] * [comment audit] Trim session and terminal closure history [skip ci] * [comment audit] Shorten terminal browser and census explanations [skip ci] * [comment audit] Preserve root-only E2E diagnostic baseline * [comment audit] Condense mobile seam and HTML preview test rationale [skip ci] * [comment audit] Condense preview instrumentation and render harness rationale [skip ci] * [comment audit] Condense bundle contracts and native-build constraints [skip ci] * [comment audit] Shorten native packaging and CI routing rationale [skip ci] * [comment audit] Condense release tooling and benchmark constraints [skip ci] * [comment audit] Condense packaging and platform gate rationale [skip ci] * [comment audit] Shorten mobile route and history rationale [skip ci] * [comment audit] Condense mobile browser and component rationale [skip ci] * [comment audit] Shorten drawer and workspace-form rationale [skip ci] * [comment audit] Trim mobile review and editor-document explanations [skip ci] * [comment audit] Condense editor lifecycle and Markdown explanations [skip ci] * [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci] * [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci] * [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci] * [comment audit] Condense bridge stream, native request and audio rationale [skip ci] * [comment audit] Reduce bridge schema and page-client commentary [skip ci] * [comment audit] Tighten mobile page bridge contracts [skip ci] * [comment audit] Clarify mobile cache and session constraints [skip ci] * [comment audit] Condense mobile route and lifecycle rationale [skip ci] * [comment audit] Tighten mobile shell hook timing rationale [skip ci] * [comment audit] Clarify route handoff and notification compatibility [skip ci] * [comment audit] Clarify push registration and dictation cleanup constraints [skip ci] * [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci] * [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci] * [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci] * [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci] * [comment audit] Tighten stream replay and queued session ownership rationale [skip ci] * [comment audit] Condense mobile composer and reply-schema constraints [skip ci] * [comment audit] Clarify mobile transcript recovery and session ownership [skip ci] * [comment audit] Clarify mobile queue and source-control compatibility [skip ci] * [comment audit] Condense storage and task launch constraints [skip ci] * [comment audit] Clarify task schemas and terminal document ownership [skip ci] * [comment audit] Tighten terminal input and viewport rationale [skip ci] * [comment audit] Shorten terminal and RPC recorder contracts [skip ci] * [comment audit] Condense recorder engine and connection contracts [skip ci] * [comment audit] Shorten host credential and relay recovery comments [skip ci] * [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci] * [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci] * [comment audit] Condense catalog and relay entry contracts [skip ci] * [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci] * [comment audit] Condense WSL relay and E2E regression rationale [skip ci] * [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci] * [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci] * [comment audit] Shorten layout oracle and regression explanations [skip ci] * [comment audit] Condense paired recovery and ownership regression contracts [skip ci] * [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci] * [comment audit] Condense terminal rendering and IME regression rationale [skip ci] * [comment audit] Shorten terminal recovery and benchmark contracts [skip ci] * [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci] * [comment audit] Condense workflow routing and release rationale [skip ci] * [comment audit] Condense mobile security and installer contracts [skip ci] * [comment audit] Shorten native rationale and stylesheet workarounds [skip ci] * [comment audit] Shorten Windows visibility probe rationale [skip ci] * [comment audit] Condense embedded release and signing rationale [skip ci] * [comment audit] Retain current main test behavior in final reconciliation [skip ci] * [comment audit] Complete final comment review across current source inventory * [comment audit] Handle consolidated audit reports before final CI * [comment audit] Preserve credential storage census detail [skip ci] * [comment audit] Scale broad changed E2E selections with verified timing shards * [comment audit] Align E2E assertions with browser close and settled session metadata * [comment audit] Match existing E2Es to current resource and windowing contracts * [comment audit] Observe the shared server outage notice in reconnect coverage * [comment audit] Make existing renderer probes measure settled tab and PTY work * [comment audit] Align palette E2E selector with task search * [comment audit] Refresh remaining palette search selectors * [comment audit] Keep selector correction within selected audit specs * [comment audit] Await emoji fixture settings inside renderer evaluation * [comment audit] Cancel fixture fit retries between terminal tests --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>	2026-10-25 04:05:46 -07:00
Brennan Benson	26a265d704	Host plans agent launches with the window's runtime rule and one runtime fact (C1) (#27692) ... * feat(agent-launch): host plans agent launches with the window's runtime rule and one runtime fact Host-started agent launches now pick their platform with the same rule the window uses (project runtime, else a \\wsl$ path, else the host), and resolve one runtime fact that supplies both the command quoting and the PTY shell. Adds the agent.launch.terminal-inputs.v1 capability and its optional title/extraAgentArgs/requestKind/terminalOnly fields; no sender yet. OpenCode's createAgentSession stays on today's rules until C2 (temporary). * fix(agent-launch): one shared runtime rule, a derived fact, and only quoted commands carry it Round-1 review fixes for C1: - Window and host read a workspace's runtime through one shared resolver (local-workspace-execution-runtime.ts); a repo-less \\wsl$ folder gets no runtime, as in the window. - The fact is { platform, remote, pty } with the spawn's own PTY type; the quoting shell is derived from it, never stored. - createAgentSession uses the same fact (its pre-C1 exception is deleted). - Worktree startups quote from a fact for the repo and pass it on; a runtime that needs repair fails the startup, not the create. `shell` is required when building a launch command. - The host planner stamps a fact only on commands quoted with it; a caller-quoted command keeps the spawn's own rule. - Qoder probes where the process runs (\\wsl$ cwd, then a WSL shell). - wslShellRule 'host-legacy' keeps today's WSL-shell outcome where no project chose a runtime (temporary, removed by C8). - terminalOnly reaches the early-tab decision with an accurate receipt sentence; the unused client gate is removed. - Adds one host C0 row for a \\wsl$ repo with no saved runtime. * fix(agent-launch): round 2: keep request fields for C2, extend main's resolver, one answer per workspace Problem: the first round still carried request fields and window-parity switches that only the next step sends, added a new shared resolver that also changed window code, and left some background launches using a different runtime answer than the one they spawn with. - Move the agent.launch request fields, their capability and fingerprint handling, and the prompt/Codex parity switches out to the next step; today's host behaviour is kept. - Drop the shared resolver: main's resolveLocalWorkspaceRuntime now finds the project by repo id or source repos, folders borrow their single local repo, and a \\wsl$ path is not refused on a stale distro list. Window code is back to main. - Agents started in an existing worktree use that worktree's answer; the phone's fallback paths spawn with the answer they quoted for, and a runtime that needs repair shows its message instead of a plain shell. - The OpenCode model check looks where the agent will run. - A Windows --shell in a \\wsl$ workspace names the path, not a runtime setting that cannot change it. - The temporary folder rule names its follow-up, STA-10231. * fix(agent-launch): OpenCode model picks in WSL folders keep today's Windows runtime Problem: once a folder follows its repo's WSL runtime, an OpenCode launch that picks a model would be checked and started inside WSL, where Orca cannot yet verify OpenCode models, so picks that work today could be refused. Where main had no runtime for the scope (only folders), a model-picked OpenCode launch keeps main's answer. Start, resume and the worker's model check read the same answer. Temporary until OpenCode models are verified inside WSL. * fix(agent-launch): round 3: OpenCode keyed on the agent, new worktrees quoted for where they land Problem: round 2's OpenCode exception keyed on a model pick, so a resumed chat could run somewhere other than where it started, and the worker's model check read WSL from the Terminal shell and refused folders that work today. A new worktree's startup used the repo's answer even when the worktree lands in a WSL share. - In a folder whose repo runs in WSL, every OpenCode launch keeps main's Windows answer: create, resume and the worker's model check agree. The model check reads WSL from the path alone, as main did. STA-10251. - A new worktree's startup is planned for its WSL-share base folder when one is set (newWorktreeLaunchScope). - A \\wsl$ working directory runs in WSL whatever the project says, so non-OpenCode agents there are written for Linux. - The planner test derives the answer instead of passing it in. - Smaller shapes for the PTY settings type, the cache-less resolve, executionRuntimePlatform, spawnShellInputs and two comments. * fix(agent-launch): round 3c: one labelled rule for where the path decides; OpenCode follows the WSL-share fix Problem: OpenCode in a repo on a WSL share whose project is saved as Windows host still got PowerShell quoting typed into WSL, because the WSL-share fix skipped OpenCode. The fix and the two temporary parity rules were also split across two returns, so deleting the temporary ones could take the permanent fix with them. - One expression decides when the path places the agent, each term labelled: WSL share + Windows host (permanent fix), folder + Windows host (STA-10231), OpenCode in a folder (STA-10251). - OpenCode now gets the WSL-share fix too; a model pick there is refused, as main's model check already did. - The OpenCode entry-point tests set a WSL Terminal shell, so the model check test fails if it reads WSL from that shell again. - Tests trimmed with no coverage loss; the spawn-precedence unit test is dropped (the C0 WSL-share row covers the reachable case). * fix(agent-launch): keep the window's WSL answer for panes the window spawns Live Windows QA (Terminal shell wsl.exe, global default Windows host, repo with no project setting) saw an agent command written with PowerShell quoting typed into a WSL pane, so codex lost the apostrophes in its prompt. The host wrote the command for its own answer (Windows, PowerShell), but on routes where the window spawns the pane (the phone while a window is open, a focused desktop chat create, `orca terminal create --command` in a repo) the window spawned it by the Terminal shell, which is WSL. Quoting and the pane came from two different answers. Those routes ran in WSL with Linux-style quoting on main and worked, so the temporary host-legacy term (STA-10231) now also covers them: when the window spawns the pane, the path and Terminal shell decide, as on main. Background routes keep the approved change (PowerShell instead of cmd.exe with Linux-style quoting, which was broken on main). createTerminal and the pre-launch planning share one `windowSpawnsTerminal` rule so they can't disagree about who spawns the pane. * Revert "fix(agent-launch): keep the window's WSL answer for panes the window spawns" This reverts commit 3e4311db19. * fix(agent-launch): report a runtime that needs repair as a refusal, not an unknown outcome `orca agent launch` into a folder whose one repo is set to a WSL distro that is no longer installed printed "Orca could not confirm the launch outcome; the agent may already be running", although nothing had started. The host knew the launch was refused before any spawn, but the refusal went out as the generic `runtime_error`, which the CLI must treat as possibly started. The launch planner now raises that refusal under its own code, `project_runtime_repair_required`, with the same message, and the RPC layer passes the code through. The CLI then prints the repair message as a plain failure. Older CLIs read the unrecognised code as a failure too; a newer CLI against an older host still gets `runtime_error`, as before. * fix(agent-launch): say a repair refusal in plain words, and repeat them on a retry The repair refusal from the last commit read "Project runtime requires repair before terminal spawn: wsl-distro-missing", an internal reason code rather than what happened and what to do. It now says, for example, "No agent was started. Ubuntu is not installed in WSL. Choose an installed distro or switch this project to Windows.", adding "This project follows the default in Settings > Project Runtime." when the runtime came from the default. Those sentences are the project settings page's own. They now live in one shared module that maps each repair reason to the page's existing translation key; the settings page passes its translator, and the host writes English, since it also runs headless where the desktop's translations can't load. The planner checks for a repair before the shell lookup, so the shared spawn message, which window spawns still use, is untouched. A retried launch (`--retry-launch`, or a phone resend) used to answer with the bare error code. The failed launch record now keeps the refusal's words and the retry repeats them. * fix(agent-launch): test that a retry repeats a refusal's words, and keep the host's English equal to the window's A retried launch now repeats a coded refusal's own words, but nothing tested it. A new case refuses a launch with a coded error and checks the retry answers with the same words. The repair sentences live in one shared module whose English the host writes and whose keys the settings page translates. The localization checks can't see call sites outside the window and main, so the module's test now checks each sentence against the window's English catalog for its key. Smaller, behaviour-identical tidy-ups: the reason-to-words mapping is a table, the refusal type fits on one line, and the length cap the retry words share with folder refusals has a neutral name. * refactor(agent-launch): keep main's behaviour where the stacked fixes change it The repair refusal's own code and words, the \\wsl$ path's distro in the agent list, --shell refusals for agents (decision and words), OpenCode's model check in a \\wsl$ repo, and finding a repo's project by its id move to their own stacked PRs. Until they land, each keeps main's behaviour with temporary code and a test that pins it. A disabled agent is refused as disabled before its runtime is looked at again, as on main. * fix(agent-launch): keep main's folder agent list when only the group names another host The agent list for a folder reads the folder's own host pin, as on main; only launches also read the containing group's host tag. * ci: re-run checks now that main's capacity-capture replay fix (#28286) has landed * test(agent-launch): give main's account-env startup test the launch runtime its build now returns	2026-10-13 15:00:32 -07:00