mirror of
https://github.com/stablyai/orca.git
synced 2026-11-02 18:17:36 +00:00
bbb563e83a1979eb14c47027e5e2fc1178dccc87
17
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 Neil
|
f59bd43c46 |
fix(wsl-host): Remove keeps a WSL host's server that another Orca on this computer shares (R39) (#34699)
* fix(wsl-host): Remove keeps a WSL host's server that another Orca on this computer shares A WSL host's server lives in the Linux login's ~/.orca, so two Orca installs on one Windows account (stable and dev), or a desktop reaching the distro over SSH, share one server. Remove used to close every terminal there and decommission it, ending the other desktop's sessions and agents. The server now answers host.peerDesktops (capability orcad.peer-desktops.v1): the other desktops paired with it, whether each is connected now, and when each was last seen. Before tearing anything down, Remove asks. If another desktop is connected or was seen in the last 30 days, it only closes this desktop's bridge and reports the server kept. If the server can't answer, the teardown is refused. An older server without the capability gets today's teardown, plus a warning. * fix(wsl-host): a shared Remove releases this Orca from the host, and says the host keeps running - On a shared server, Remove now revokes this desktop's own device (and its phones) on the host, through the new host.releaseDesktop, before letting go. Otherwise its recent row would make a peer's later Remove keep the server forever. Peers also skip rows of the caller's own installation (same caller fingerprint), such as an enrollment from before a re-add. - The renderer says when a removal kept the host for another Orca, and the Remove confirmation no longer promises to end terminals unconditionally. - Remove-path files now route CI to the fake transport e2e spec, which exercises Remove. * i18n(wsl-host): Russian and Traditional Chinese for the shared-host Remove copy * fix(wsl-host): tell desktops apart by device key, and release this Orca on every Remove - Peers are no longer hidden by caller fingerprint. Every device-key fork of one pairing token row inherits that row's fingerprint, so two installations that paired through one code hid each other, and one's Remove could tear the server down under the other. Only a shared device public key now marks the same installation, as with a re-add under a new token. - This desktop's own device is released as the last call over the bridge on every Remove that proceeds (no terminals left), not only a shared one. A later Add then Remove never meets a stale row of ours. - When the release fails on a shared Remove, the toast says the host may keep running for a while. The Russian confirmation copy is corrected. * fix(wsl-host): move undo refuses a removed host whose server another Orca kept A Remove that kept a WSL host's server for another Orca (R39) now records that. Before, undo of a move onto that host read the missing environment as "its terminals and automations stopped with it", and would have restored the project here while the host's copies kept running, duplicating its agents and automations. Undo now reads such a host as unreachable and refuses, as it does for any host it can't reach. A later Remove that proves the server stopped clears the record. If the record can't be saved, the host stays listed as pending instead. * i18n(wsl-host): Turkish for the shared-host Remove copy * fix(wsl-host): each WSL desktop splits off its own row from orcad's startup pairing orcad publishes one startup pairing offer and never rotates it, so every desktop that enrolled through it shared one token row and device id. Stable and dev Orca on one distro were invisible to each other as peers, and releasing that shared row broke the next re-add and pairing repair. - New host.forkDesktop (same orcad.peer-desktops.v1 capability). A runtime device on a shared desktop token mints its own token row, forked from it and named by the caller. Forks share the device-key fork cap, and a released fork frees its slot. - The WSL desktop forks right after enrolling through the startup offer, or after a repair lands back on it, and keeps the forked pairing (named after its userData folder, e.g. Orca or Orca Dev). On an older orcad, or if the fork fails, it keeps the shared pairing and warns. - A token row that desktops forked from counts as a peer only while something is connected on it. One that nobody forked from keeps the last-seen rule. * fix(wsl-host): keep host.forkDesktop to the startup offer's holder, over E2EE, with a clean label host.forkDesktop mints a credential, so: - only the holder of the desktop pairing offer this server advertised last (orcad's startup offer) may fork; an older offer, a fork, a phone or any other row is refused; - the fork takes exactly the caller's grants and reach; params are just a label (strict, so a grant request is refused); - it runs only on an authenticated E2EE socket; the token goes back only in that reply and is never logged; - the label is display-only: control, zero-width and bidi characters stripped, whitespace collapsed, at most 64 characters; an empty result is refused. * refactor(wsl-host): count only Orcas connected right now as WSL host peers; drop fork and release Review found the token fork and self-release add more identity state than R39 warrants: orphan forks, a desktop left on the shared token releasing it, and a changed caller fingerprint. So this drops host.forkDesktop, host.releaseDesktop and the 30-day last-seen rule, and restores the restart test. A peer is now another Orca installation with a control socket open on the server right now. The desktop declares its installation (a hash of its userData path) with host.declareClient on its shared-control socket after every ready, including reconnects. The server tags that socket and drops the tag when it closes. host.peerDesktops takes the caller's installation id, so its own other sockets (multiplex, one-shot) never count, and two desktops sharing one startup token stay distinct. Undeclared sockets, phones and browser sessions are ignored. Peer names go through sanitizeDeviceLabel, and a startup-offer "CLI <date>" name shows as "another Orca". An older orcad lacks the method: nothing is declared, and Remove keeps today's teardown with a warning. Limit: an Orca that's closed while its terminals keep running isn't protected. * fix(wsl-host): keep a reconnecting Orca as a WSL host peer for 60 seconds Lost contact isn't proof an Orca left. When an installation's last declared control socket closes (a bridge exit, an orcad restart, resume from sleep, reconnect backoff), the server keeps counting it as a peer for 60 seconds, or until it re-declares. A Remove inside that gap no longer tears down its terminals. * fix(wsl-host): say an open Orca keeps the host, and name each peer once - The Remove confirmation now reads "Unless another Orca that's open on this computer is using it", since only a connected Orca keeps the server. Updated in all 10 locales. - The kept-host toast dedupes peer names, so several unnamed peers read "another Orca" once. * test(wsl-host): pin the reconnect grace to the last socket's close, and to the server's own forget - The unit test advances the clock between the two closes and checks that the peer still counts when the first close's grace would have run out. - The integration test waits until the server has dropped the closed socket before reading peers, so it fails without the grace (checked by setting the grace to zero). * fix(wsl-host): sweep expired reconnect graces on every close, on a monotonic clock Expired graces are dropped at the start of forget() as well as peers(), so the map stays bounded even when nobody asks for peers. The default clock is performance.now(), so a wall-clock jump can't stretch or cut the grace. * i18n(wsl-host): German for the shared-host Remove copy |
||
  Sojiro.OandBrennan Benson
|
9802866ed5 |
fix(editor): Copy Remote URL links to the code the workspace is on, with the selected line range (#33597)
* fix(editor): Copy Remote URL links to the code the workspace is on, with the selected line range The gutter menu's Copy Remote URL always built the link on the default branch and dropped any multi-line selection. Prefer the HEAD commit when origin already has it, then the origin branch the current branch tracks, then the default branch; carry an optional end line through IPC, RPC and the git provider so a selection becomes a line range. * fix: pair remote file links with published repository refs * fix: prepare exact remote file fallback before publication scan * test: consolidate remote file URL integration coverage * test: document real-clock cancellation deadline proof * test: handle optional cancellation signal in assertion * test: reuse spawned child fixture across runtimes --------- Co-authored-by: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> |
||
  OrcaWinandOrcaWin
|
0294e1118a |
test: remove 47 low-value tests (#34505)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com> |
||
|
OrcaWinandOrcaWin
|
bbc35c1a98 |
test: remove 30 low-value cases and 11 suites (#34288)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com> |
||
|
Neil
|
7a9abe48f3 | refactor: group remote runtime client modules (#34133) | ||
|
OrcaWinandOrcaWin
|
852dfcd282 |
test: remove redundant browser and transport coverage (#33757)
* test: remove redundant browser and transport coverage * test: retire deleted suites from reliability manifest --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com> |
||
|
OrcaWinandOrcaWin
|
6808f4be23 |
test: remove redundant checks and tighten runtime query coverage (#33583)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com> |
||
|
OrcaWinandOrcaWin
|
7d6603aa17 |
[comment audit] Complete repository-wide comment cleanup (#33249)
* [comment audit] Align legacy failure-read counts with cached display * [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci] * [comment audit] Condense shared generation, path and preview comments [skip ci] * [comment audit] Condense host, file and Git contract rationale [skip ci] * [comment audit] Tighten Git lifecycle and provider contract comments [skip ci] * [comment audit] Clarify shared host authority and launch isolation [skip ci] * [comment audit] simplify local access mobile and native chat contracts [skip ci] * [comment audit] simplify native chat presentation and state contracts [skip ci] * [comment audit] simplify native runtime and provider contracts [skip ci] * [comment audit] simplify migration and orchestration contracts [skip ci] * [comment audit] simplify plugin trust and process capture rationale [skip ci] * [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci] * [comment audit] clarify remote recovery and launch wire rationale [skip ci] * [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci] * [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci] * [comment audit] clarify sidebar, skill and SSH invariants [skip ci] * [comment audit] condense structured chat delivery and timing rationale [skip ci] * [comment audit] condense terminal replay and telemetry invariants [skip ci] * [comment audit] clarify launch permission and terminal delivery rationale [skip ci] * [comment audit] clarify workspace ownership and layout contracts [skip ci] * [comment audit] wait for fitted and painted SSH terminal links * [comment audit] clarify layout persistence and session ownership [skip ci] * [comment audit] clarify host routing and workspace lifecycle contracts [skip ci] * [comment audit] clarify startup persistence and app lifetime comments [skip ci] * [comment audit] clarify recovery and activity boundaries [skip ci] * [comment audit] condense activity and artifact invariants [skip ci] * [comment audit] condense automation authority contracts [skip ci] * [comment audit] simplify automation scheduling and history contracts [skip ci] * [comment audit] clarify browser chrome and annotation lifecycles [skip ci] * [comment audit] clarify browser routing and retained guest ownership [skip ci] * [comment audit] clarify browser recovery and document ownership comments [skip ci] * [comment audit] restore hosted runners required by native IME fixtures * [comment audit] shorten preview, palette and dashboard invariants [skip ci] * [comment audit] clarify terminal preview, dashboard and retention comments [skip ci] * [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci] * [comment audit] shorten rich-text and combined-diff ownership comments [skip ci] * [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci] * [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci] * [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci] * [comment audit] clarify rich Markdown source and selection safeguards [skip ci] * [comment audit] clarify editor loading and emulator stream lifetimes [skip ci] * [comment audit] trim emulator and feature tour narration [skip ci] * [comment audit] clarify floating workspace and GitHub cache ownership [skip ci] * [comment audit] trim provider controls and Linear filter explanations [skip ci] * [comment audit] clarify pairing and chat resume lifetimes [skip ci] * [comment audit] clarify chat delivery and transcript lifetimes [skip ci] * [comment audit] clarify session options and host-owned status [skip ci] * [comment audit] clarify draft durability and live-status precedence [skip ci] * [comment audit] Trim chat send and model ownership explanations [skip ci] * [comment audit] Shorten transcript ownership and send recovery comments [skip ci] * [comment audit] Simplify native chat composer and transcript hook comments [skip ci] * [comment audit] Shorten native chat scroll and structured session explanations [skip ci] * [comment audit] Trim workspace picker and onboarding commentary [skip ci] * [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci] * [comment audit] Trim sidebar and session history explanations [skip ci] * [comment audit] Condense session resume and review checks comments [skip ci] * [comment audit] Shorten checks state and file explorer refresh comments [skip ci] * [comment audit] Trim plugin bridge and source-control action rationale [skip ci] * [comment audit] Trim source-control listing and review rationale [skip ci] * [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci] * [comment audit] Condense Settings account and appearance rationale [skip ci] * [comment audit] Trim pairing and repository Settings explanations [skip ci] * [comment audit] Condense Settings search SSH and terminal safeguards [skip ci] * [comment audit] Shorten Settings voice and provider ownership comments [skip ci] * [comment audit] Condense Settings draft persistence and host-state rationale [skip ci] * [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci] * [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci] * [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci] * [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci] * [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci] * [comment audit] Prune focus-read baseline after comment cleanup * [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci] * [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci] * [comment audit] Clarify viewport geometry and skill update safeguards [skip ci] * [comment audit] Tighten skill inventory, usage and host status comments [skip ci] * [comment audit] Clarify usage ownership and resource kill safeguards [skip ci] * [comment audit] Tighten tab selection, rename and search contracts [skip ci] * [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci] * [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci] * [comment audit] Tighten provider loading and terminal recovery comments [skip ci] * [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci] * [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci] * [comment audit] Tighten PTY startup and replay explanations [skip ci] * [comment audit] Clarify PTY identity and delivery ownership [skip ci] * [comment audit] Shorten remote reconnect and input replay rationale [skip ci] * [comment audit] Condense terminal parking clipboard and file link comments [skip ci] * [comment audit] Clarify IME ownership and trim trace history [skip ci] * [comment audit] Shorten pane recovery and parked watcher explanations [skip ci] * [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci] * [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci] * [comment audit] Trim renderer lifecycle and menu rationale [skip ci] * [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci] * [comment audit] Clarify renderer hook evidence and source ownership [skip ci] * [comment audit] Tighten IPC ownership and reconnect explanations [skip ci] * [comment audit] Trim renderer focus, paste and attention comments [skip ci] * [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci] * [comment audit] Trim agent launch, resume and ownership commentary [skip ci] * [comment audit] Shorten account, browser and editor comments [skip ci] * [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci] * [comment audit] Condense launch recovery and editor tokenization comments [skip ci] * [comment audit] Condense workspace selection and terminal pane rationale [skip ci] * [comment audit] Condense terminal fitting and rendering recovery comments [skip ci] * [comment audit] Condense terminal input and host routing explanations [skip ci] * [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci] * [comment audit] Condense structured launch and terminal link explanations [skip ci] * [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci] * [comment audit] Condense session persistence and workspace activation rationale [skip ci] * [comment audit] Condense workspace routing and browser ownership rationale [skip ci] * [comment audit] Condense mirror recovery and layout authority rationale [skip ci] * [comment audit] Condense runtime transport and file safety rationale [skip ci] * [comment audit] Condense runtime graph and structured session rationale [skip ci] * [comment audit] Condense browser creation and remote tab recovery rationale [skip ci] * [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci] * [comment audit] Condense frame, startup and provider cache rationale [skip ci] * [comment audit] Condense host twin and agent lifecycle rationale [skip ci] * [comment audit] Condense browser authority and editor cleanup rationale [skip ci] * [comment audit] Condense editor buffer identity and review cache rationale [skip ci] * [comment audit] Condense provider lifetime and repository ownership rationale [skip ci] * [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci] * [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci] * [comment audit] Condense cleanup ownership and listing admission rationale [skip ci] * [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci] * [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci] * [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci] * [comment audit] Condense cloud rollout and assignment safety rationale [skip ci] * [comment audit] Condense relay session and database recovery rationale [skip ci] * [comment audit] Condense relay placement and protocol compatibility rationale [skip ci] * [comment audit] Condense build and packaging constraints [skip ci] * [comment audit] Condense CI gates and validation isolation rationale [skip ci] * [comment audit] Condense catalog identity and browser validation rationale [skip ci] * [comment audit] Condense mobile browser and frame-budget rationale [skip ci] * [comment audit] Shorten mobile route and browser test explanations [skip ci] * [comment audit] Condense editor and session seam test rationale [skip ci] * [comment audit] Trim session and terminal closure history [skip ci] * [comment audit] Shorten terminal browser and census explanations [skip ci] * [comment audit] Preserve root-only E2E diagnostic baseline * [comment audit] Condense mobile seam and HTML preview test rationale [skip ci] * [comment audit] Condense preview instrumentation and render harness rationale [skip ci] * [comment audit] Condense bundle contracts and native-build constraints [skip ci] * [comment audit] Shorten native packaging and CI routing rationale [skip ci] * [comment audit] Condense release tooling and benchmark constraints [skip ci] * [comment audit] Condense packaging and platform gate rationale [skip ci] * [comment audit] Shorten mobile route and history rationale [skip ci] * [comment audit] Condense mobile browser and component rationale [skip ci] * [comment audit] Shorten drawer and workspace-form rationale [skip ci] * [comment audit] Trim mobile review and editor-document explanations [skip ci] * [comment audit] Condense editor lifecycle and Markdown explanations [skip ci] * [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci] * [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci] * [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci] * [comment audit] Condense bridge stream, native request and audio rationale [skip ci] * [comment audit] Reduce bridge schema and page-client commentary [skip ci] * [comment audit] Tighten mobile page bridge contracts [skip ci] * [comment audit] Clarify mobile cache and session constraints [skip ci] * [comment audit] Condense mobile route and lifecycle rationale [skip ci] * [comment audit] Tighten mobile shell hook timing rationale [skip ci] * [comment audit] Clarify route handoff and notification compatibility [skip ci] * [comment audit] Clarify push registration and dictation cleanup constraints [skip ci] * [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci] * [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci] * [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci] * [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci] * [comment audit] Tighten stream replay and queued session ownership rationale [skip ci] * [comment audit] Condense mobile composer and reply-schema constraints [skip ci] * [comment audit] Clarify mobile transcript recovery and session ownership [skip ci] * [comment audit] Clarify mobile queue and source-control compatibility [skip ci] * [comment audit] Condense storage and task launch constraints [skip ci] * [comment audit] Clarify task schemas and terminal document ownership [skip ci] * [comment audit] Tighten terminal input and viewport rationale [skip ci] * [comment audit] Shorten terminal and RPC recorder contracts [skip ci] * [comment audit] Condense recorder engine and connection contracts [skip ci] * [comment audit] Shorten host credential and relay recovery comments [skip ci] * [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci] * [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci] * [comment audit] Condense catalog and relay entry contracts [skip ci] * [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci] * [comment audit] Condense WSL relay and E2E regression rationale [skip ci] * [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci] * [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci] * [comment audit] Shorten layout oracle and regression explanations [skip ci] * [comment audit] Condense paired recovery and ownership regression contracts [skip ci] * [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci] * [comment audit] Condense terminal rendering and IME regression rationale [skip ci] * [comment audit] Shorten terminal recovery and benchmark contracts [skip ci] * [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci] * [comment audit] Condense workflow routing and release rationale [skip ci] * [comment audit] Condense mobile security and installer contracts [skip ci] * [comment audit] Shorten native rationale and stylesheet workarounds [skip ci] * [comment audit] Shorten Windows visibility probe rationale [skip ci] * [comment audit] Condense embedded release and signing rationale [skip ci] * [comment audit] Retain current main test behavior in final reconciliation [skip ci] * [comment audit] Complete final comment review across current source inventory * [comment audit] Handle consolidated audit reports before final CI * [comment audit] Preserve credential storage census detail [skip ci] * [comment audit] Scale broad changed E2E selections with verified timing shards * [comment audit] Align E2E assertions with browser close and settled session metadata * [comment audit] Match existing E2Es to current resource and windowing contracts * [comment audit] Observe the shared server outage notice in reconnect coverage * [comment audit] Make existing renderer probes measure settled tab and PTY work * [comment audit] Align palette E2E selector with task search * [comment audit] Refresh remaining palette search selectors * [comment audit] Keep selector correction within selected audit specs * [comment audit] Await emoji fixture settings inside renderer evaluation * [comment audit] Cancel fixture fit retries between terminal tests --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com> |
||
|
Neil
|
59cc46994c |
fix(remote-terminal): calm, honest reconnect status — one notice per server, cause, delay from measured RTT (#33095)
* fix(remote-terminal): calm, honest reconnect status with one notice per server * fix(remote-terminal): keep the SSH sign-in wait immediate under the calm reconnect banner * fix(remote-terminal): a surface that loses its turn drops its notice at once * fix(remote-terminal): resolved action cards and handed-off notices leave at once * fix(remote-terminal): only the leader at the end of an outage holds its notice |
||
|
Neil
|
b33ad1bb2c |
feat(remote): trace why each remote-runtime connection closed (#33094)
Client control-socket closes and server heartbeat reaps only reached the console, which a packaged app never shows. Each control-socket close now writes a remote-runtime.control-socket-close span (cause, close code, error code, last keepalive RTT, socket and ready uptime). Each server reap writes remote-runtime.server-socket-reaped. Both land in the main trace file that Send app diagnostics collects. Keepalive pongs now measure RTT, exposed as lastRttMs and lastCloseCause on the shared-control diagnostics. |
||
|
Neil
|
c1d7a17008 | refactor: colocate remote runtime socket cleanup (#33051) | ||
|
Neil
|
77efa5aeeb | refactor: colocate remote runtime error classification (#33024) | ||
|
Neil
|
82534d0183 | refactor: colocate remote runtime passthrough socket (#33009) | ||
|
Neil
|
9c262ffe36 | refactor: colocate remote runtime connect bound (#33004) | ||
|
Neil
|
55a45491be | refactor(shared): colocate remote runtime Tailscale guidance (#32992) | ||
|
Neil
|
1cc2a2afd8 | refactor(shared): group remote runtime shared-control lifecycle (#32977) | ||
|
Neil
|
9a5da64fdd | refactor: group remote runtime requests and subscriptions (#32952) |