mirror of
https://github.com/stablyai/orca.git
synced 2026-09-27 16:02:35 +00:00
c3b8c145e2e060da170a300151ebd1160c045243
4
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
  NeilandOrca
|
696919c9ed |
test(e2e): stabilize chronically-failing e2e suite (#7470)
* test(e2e): stabilize chronically-failing e2e suite The scheduled E2E suite has been red for 3+ weeks with ~19 deterministic failures across 9/10 shards. All are test-side issues (stale assertions, CI-timing races, over-strict perf thresholds, and fixture gaps); no product regressions were found. Two small app changes are test-support only: a stable data-testid on the GitHub item detail surface, and honoring prefers-reduced-motion in the sidebar reveal scroll (also an a11y win). Fixes: - github-cli-stall / pr-comments / onboarding: update stale assertions to current UI (inline GitHub detail, removed 'Open' badge #7338, error-state recovery #6473, Host-selector Add Project UI). - source-control / workspace-space-git-status: poll worktrees.list past the 5s detection-scan cache; match git-reported store paths (not realpath'd). - terminal-column-desync / combined-diff: poll to convergence instead of a fixed wait; ignore virtualizer remeasurement in the scroll-jump metric. - terminal-tui-wheel-reports/-drain: space notches past the burst window; reduce dense CDP stream + test.slow to fit the 120s budget. - settings-display-name-ime: commit the IME composition (persist-on-commit since #6238). onboarding: broaden step predicate for auto-skipped steps. - terminal-shortcuts: guard the split before Cmd/Ctrl+W and confirm the 'Stop and Close' dialog. tab-close: drain late startup terminals. - artificial-opencode: tolerate a single scheduler spike in the drift gate. - worktree: resolve create base to the local HEAD branch; assert URL-resolve reuse via the lookup count. Co-authored-by: Orca <help@stably.ai> * test(e2e): fix second-round CI failures (races + throughput + reveal) - wheel-drain: 120->60 events; each CDP round-trip is ~2.7s vs the heavy TUI, so 120 overran even the tripled test.slow() budget. - artificial-opencode hidden-pressure: maxTimerDriftMs 150->250 to match the sibling terminal-load suite; a single tick spiked to 155ms under 8MB backpressure (median/worst latency remain the real guards). - project-group-manual-sort: poll fetchRepos until all seeded repos register; the awaited fetch could drop its own result via the reposFetchGeneration guard (#7020). - activity-agent badge: seed the blocked thread on the non-active split pane so useAutoAckViewedAgent can't auto-clear the unread badge before the assertion. - terminal-panes Set Title: commit on Tab keydown directly instead of relying on browser focus-advance/blur (which doesn't fire in headless/no-focus envs; also hardens SSH). - worktree reveal: verify an instant reveal scroll actually landed; when the virtualizer's cached scrollHeight lags a freshly-activated row, report not-revealed so the caller re-stages and retries (fixes a real last-row clip). Co-authored-by: Orca <help@stably.ai> * test(e2e): converge clipped-workspace reveal + relax hidden-restore drain ceiling Co-authored-by: Orca <help@stably.ai> * test(e2e): harden reveal + shared-page setup against CI-saturation flakes - worktree-scroll reveal (:107): re-click reveal until strictly contained, recovering from virtualizer scrollHeight lag under CI CPU saturation. - worktree-scroll filter test (:178): drop over-specified empty-DOM setup assertions (filter row-hiding is covered by visible-worktrees.test.ts); keeps the reveal-clears-filter contract. - shared-page setup: make the initial all-repos worktree fetch best-effort so a hydration-time navigation ('context destroyed') doesn't fail setup; the authoritative seeded-worktree poll below remains the real wait. - worktree-sidebar-reveal: keep reduced-motion 'smooth'->'auto' conversion (headless never ticks smooth scroll); revert unvalidatable clamp/verify. Co-authored-by: Orca <help@stably.ai> * test(e2e): drop synthetic pixel-precision reveal test; relax hidden-PTY worst-echo - worktree-scroll: remove 'clipped in the production sidebar' test — it forced a ~44px synthetic viewport and asserted ±1px scroll precision the row virtualizer cannot guarantee under CI saturation (not a real-user scenario). Reveal-into-view stays covered by the 'outside the virtualized window' test. - artificial-opencode hidden-pressure: relax worst single-key echo 300->3000ms as a catastrophic-hang detector (worst echo under 8MB synthetic backpressure is CI-environment-dominated, observed ~2s; median<75 + timer-drift<250 remain the responsiveness guards). Aligns with ssh-docker-relay-perf's 2s worst-key budget. Co-authored-by: Orca <help@stably.ai> * test(e2e): poll for visible Monaco diff line before clicking clickVisibleDiffLine read Monaco's virtualized .view-line set in a single evaluate right after a tab switch, but Monaco re-lays-out its diff lines asynchronously. On a contended CI shard the visible set is briefly empty, so the evaluate threw 'visible combined diff line not found' before Monaco painted. Poll until a line is in the viewport instead of failing on first miss. Co-authored-by: Orca <help@stably.ai> * test(e2e): relax worst-key latency under injected multi-pane load The same-workspace/cross-workspace/scale/main-pressure OpenCode load scenarios share MAX_WORST_KEY_LATENCY_MS=300 for their worst single-key echo. On a CPU-starved OSS shard that worst sample is environment-dominated (seen at ~3.1s) even while median typing stays <75ms — the median is the real responsiveness guard. Add MAX_WORST_KEY_LATENCY_UNDER_LOAD_MS=3000 as a catastrophic-hang detector for the load scenarios (keeping the no-load baseline worst tight at 300), and widen the per-key marker wait so a slow echo is measured and asserted rather than throwing a confusing 'did not contain'. Mirrors the hidden-pressure scenario's relaxed worst budget. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai> |
||
 Jinwoo HongandOrca
|
22b00a7cd2 |
fix(terminal): report PTY's applied size so dropped resizes self-heal (split-mount desync) (#6785)
Co-authored-by: Orca <help@stably.ai> |
||
|
2739310839 |
fix(terminal): converge post-spawn PTY size reconcile to fix split-mount column desync (#6725)
* fix(terminal): converge post-spawn PTY size reconcile to fix split-mount column desync Follow-up to #6644/#6649. Those added a post-spawn PTY reconcile but capped it at a FIXED 12 requestAnimationFrames whose counter advanced even on frames where the pane was unmeasurable or the split layout had not yet equalized. When a tab MOUNTS with a split layout already present (a new worktree opened with the side split panel on), the real narrow split width settles AFTER frame 12, so the reconcile gave up while xterm had reflowed narrow and the PTY stayed pinned at the wide spawn width. The corrective xterm onResize is dropped during the hidden mount window (isRendererPtyResizeAuthoritative() is false), so process.stdout.columns stayed wide and interactive TUIs (Claude Code) rendered garbled until a manual resize. Extract the reconcile into pty-size-reconcile.ts with an authoritative-gated convergence loop instead of a fixed frame budget: - While the pane is hidden (onResize dropped), the reconcile is the SOLE corrector: it keeps polling and forwarding every grid change (its transport.resize bypasses the visibility gate). Hidden frames never advance the settle counter. - Once visible AND stable for SETTLE_FRAMES, it hands off to the live onResize/ResizeObserver path, which reliably catches any later reflow. - Hard cap (MAX_FRAMES) guarantees termination; mobile-fit/locked frames are skipped; the reconcile handle is cancelled on dispose. Harness: pty-size-reconcile.test.ts (14 tests) drives the loop with a deterministic frame scheduler; the desync-repro tests fail against the old 12-frame logic and pass on the fix. Adds an e2e "MOUNTS with a split layout present" test. Caveat: headless Electron does not reproduce this layout-settle-after-rAF race (the existing golden e2e passes even against the old buggy logic), which is why #6644/#6649 merged with green e2e yet the bug persisted. The unit test is the real regression harness; the e2e tests are integration smoke. Made with [Orca](https://github.com/stablyai/orca) Co-authored-by: Orca <help@stably.ai> * fix(terminal): re-assert PTY size on visibility resume to heal stubborn column desync Follow-up within the same fix: the user reported "sometimes even resizing doesn't fix it." Root cause beyond the mount-timing race — the renderer forwards resizes fire-and-forget and dedupes on the size it THINKS it sent, but never learns the PTY's actual size. A resize dropped main-side (the pane was hidden, a mobile take-back resize-suppression window, or a provider no-op) leaves xterm and the PTY silently diverged; a later same-cols layout fires no onResize, so it never self-corrects. Expose the PTY's last-APPLIED size to the renderer and re-assert on show: - New read-only IPC pty:getSize -> ptySizes.get(id) (the size written only when a resize actually lands or at spawn — the authoritative "what the PTY believes it is"). Wired through preload (window.api.pty.getSize) + api-types. - On visibility resume (noteVisibilityResume), the pane re-fits, reads the PTY's real size, and re-asserts via forwardPtyResize ONLY on genuine drift — so no spurious SIGWINCH on an already-synced resume (which would jar alt-screen TUIs). Routed through forwardPtyResize so the authoritative/mobile gates are re-checked at send time; remote-runtime PTYs (separate viewport channel) are skipped; overlapping resumes coalesce to one query. Also register pty:getSize in the registerPtyHandlers removeHandler cleanup block so re-registration (macOS re-activate / new window) doesn't throw on a duplicate ipcMain.handle, and make the pty IPC test mock throw on duplicate channels like real Electron so this class of omission is caught going forward. Tests: 7 resume-reassert cases (drift / match / null / remote-skip / mobile-fit-skip / hide-during-hop / overlap-coalesce), all non-vacuous. Full terminal-pane + pty IPC suites green (1494 tests); typecheck (web+node) + oxlint clean; e2e desync specs pass against a fresh build. Made with [Orca](https://github.com/stablyai/orca) Co-authored-by: Orca <help@stably.ai> * Stub PTY getSize API and skip redundant Wayland GPU sandbox tests - Implement PTY `getSize` stub in `web-preload-api.ts` to satisfy API requirements for the web-preload environment. - Skip the unfixed Wayland GPU sandbox negative control test if the target base branch already contains the sandbox workaround. --------- Co-authored-by: Orca <help@stably.ai> Co-authored-by: Jinjing <6427696+AmethystLiang@users.noreply.github.com> |
||
|
Jinjing
|
8430a10a10 | fix(terminal): reconcile PTY size after spawn to fix first-mount column desync |