Commit Graph
12611 Commits
Author SHA1 Message Date
Neil d31deaa39f fix(terminal): verify an exact stop through an overlapping liveness inventory (#32948)
* fix(terminal): verify an exact stop through an overlapping liveness inventory

terminal.stopExact re-read the PTY inventory once after the stop. When a newer
inventory started meanwhile (the exit's own session republish triggers one),
the older read was voided as stale and the confirmed stop came back as
terminal_liveness_unavailable, so hibernating a remote pane on a busy host
rolled back. Retry the post-stop read within one list budget.

* test(terminal): keep the post-stop liveness failure fixture unavailable across retries
2026-10-23 17:42:59 -07:00
OrcaWinandOrcaWin 02d7214c1a refactor: remove four unreachable preload IPC bridges (#32950)
* refactor(repos): remove unreachable repos:getGitUsername IPC

* refactor(mobile): remove unreachable mobile:isWebSocketReady IPC

* refactor(skills): remove unreachable skills:deletePackageVersion IPC

* refactor(space): remove unreachable workspaceSpace:closeWindow IPC

* chore: prune repo-host-read baseline for removed git username handler

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 17:39:44 -07:00
9527812655 fix(agents): + quick launch on a paired host uses the desktop's launch settings (#32050)
* fix(agents): preserve quick-launch presets in legacy tab creation

* fix(agents): + quick launch on a paired host uses the desktop's launch settings

An empty-prompt agent tab opened with + on a paired or SSH-tunnelled host
sent only the agent id, so modern hosts used their own default args and
legacy hosts rebuilt the command from host settings. Send the same
startup plan the prompted launch already sends, so both
terminal.createAgentSession (agentArgs) and the legacy
session.tabs.createTerminal fallback get the desktop's arguments.

Replaces the legacy-only legacyStartupPlan field and its linux/darwin gate:
one launch shape now serves both paths, matching prompted launches.

Fixes #31986

Co-authored-by: StrangerG <8511644+StrangerG@users.noreply.github.com>

---------

Co-authored-by: Neil <neil@stably.ai>
Co-authored-by: StrangerG <8511644+StrangerG@users.noreply.github.com>
2026-10-23 17:38:10 -07:00
OrcaWinandOrcaWin bc9ba76989 test: verify runtime delivery and remove real-time socket waits (#32988)
* test: exercise runtime request routing with deterministic socket deadlines

* test: isolate local status and await redaction stream completion

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 17:34:11 -07:00
OrcaWinandOrcaWin cdba9a7703 refactor(dashboard): remove unreachable popout spawn/sleep IPC (#32954)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 17:33:42 -07:00
OrcaWinandOrcaWin da620ad632 refactor(rate-limits): remove unreachable setPollingInterval and refreshMiniMax IPC (#32945)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 17:32:57 -07:00
OrcaWinandOrcaWin 2c46becd29 perf(emulator): accumulate MJPEG chunks instead of re-joining partial frames (#32967)
* perf(emulator): accumulate MJPEG chunks instead of re-joining partial frames

A simulator frame spans many socket chunks, and extractJpegFrames re-concatenated
the growing partial frame on every chunk, which is quadratic in chunks per frame on
the Electron main thread. Hold chunks until one could complete the frame, then join
once. Held chunks are copied, so no caller chunk memory is retained.

* perf(emulator): ignore empty MJPEG chunks in the accumulator

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 17:31:03 -07:00
OrcaWinandOrcaWin d1aef1eee9 refactor(worktrees): remove unreachable legacy worktree list IPC (#32942)
* refactor(worktrees): remove unreachable legacy worktree list IPC

The desktop and web preloads both always provide `worktrees.listDetected`,
so the renderer's fallback to `worktrees.list` never ran, and nothing calls
`worktrees.listAll`. Remove both IPC handlers, their preload/web wrappers,
the renderer fallback, and helpers only they used. Tests that observed
behaviour through the removed handlers now go through `worktrees:listDetected`.

* test(worktrees): drop removed list channels from SSH listing matrix

Address review: the canonical SSH listing test built channel names dynamically
and still invoked worktrees:list/listAll. Also fold the detected-result reader
into the shared worktree test fixtures, refresh stale comments, and assert the
backfill no-op test listed authoritatively.

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 17:30:59 -07:00
96ac40e244 fix(speech): avoid full-recording copies when encoding dictation (#32432)
* fix(speech): avoid full-recording copies when encoding dictation

* test(speech): drop the dictation heap probe

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
2026-10-23 17:27:13 -07:00
Neil cd59239927 fix(workspaces): add main-owned project move pause barrier (#32940)
* fix(workspaces): add main-owned project move pause barrier

* test(workspaces): type project move pause reply fixtures
2026-10-23 17:25:22 -07:00
OrcaWinandOrcaWin 2351c6de3f test: remove copied inventory and strengthen CLI, preload, and Cloud boundaries (#32982)
* test: isolate lock refusal and verify trust probe diagnostics

* test: exercise preload close wiring and clarify reserve assertions

* test: remove Jira inventory and exercise CLI launch routing

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 17:22:32 -07:00
Brennan Benson 1279104c2b Consolidate structured status projection at each host feed (#32239)
* refactor: project structured status once per host emission

* test: keep host fixture literals checked against Tab

* test: declare the nullable bridge store without a cast

* refactor: compare tab membership directly at the read gate

* test: isolate approval activity fixture from GitHub refresh

* fix: recover status projection cleanup and bound removal work

* test: give status apply spy a callable type

* Scope structured status membership to host groups

* Type structured status lifecycle fixture tabs
2026-10-23 17:15:19 -07:00
OrcaWinandOrcaWin 225f940453 test: strengthen CLI expectations and consolidate repeated scenarios (#32976)
* test: strengthen CLI refusals and consolidate serve validation

* test: consolidate terminal creation and strengthen restore output

* test: pin dashboard telemetry clock away from midnight

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 17:11:16 -07:00
Brennan Benson c84817e8f9 fix(native-chat): preserve accepted command outcomes across agent startup (#31605)
* fix(native-chat): a goal set while the agent rests clears the composer

Setting a goal starts the agent when none is running, which moves the
session's runtime fence before the host answers. The composer dropped
that successful answer as stale, so the objective and Goal chip stayed.
Keep the reply for goal changes as for the other writes that may start
the agent.

* fix(native-chat): settle each command independently of runtime changes

* fix(native-chat): scope rewind timeout feedback to its issuing pane

* test: use checked native chat command fixtures

* test: complete native chat presentation fixtures

* fix(native-chat): admit Stop before capability discovery

* test(native-chat): consolidate overlapping startup coverage

* test(native-chat): preserve IME composition on goal acceptance

* fix(native-chat): capture each action before async preparation

* fix(native-chat): preserve shared Stop failure reporting

* test(native-chat): cover already-sent queue notices after disposal
2026-10-23 17:11:05 -07:00
Neil 1cc2a2afd8 refactor(shared): group remote runtime shared-control lifecycle (#32977) 2026-10-23 17:04:58 -07:00
OrcaWinandOrcaWin 5ee5765c44 fix: shimmer stale reference metadata without layout shifts (#32949)
* fix: keep stale linked-reference status inline

* fix: shimmer stale reference rows without a clock

* docs: compare row and shadcn text shimmer treatments

* fix: shimmer only stale reference metadata

* fix: remove obsolete row shimmer class

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 16:54:09 -07:00
OrcaWinandOrcaWin 01652255f0 test: strengthen hook, build, and mobile lifecycle coverage (#32968)
* test: strengthen hook, build, and mobile lifecycle coverage

* fix: use relocated Jira types in issue user field

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 16:38:53 -07:00
OrcaWinandOrcaWin 4687e90a16 [comment audit] Continue main-process comment cleanup (#32946)
* [comment audit] Shorten daemon, hook, and emulator comments [skip ci]

* [comment audit] Shorten VM, conversation, SQLite, and theme-import comments [skip ci]

* [comment audit] Tighten Git execution and source-control comment contracts [skip ci]

* [comment audit] Clarify repository probes and maintenance comments [skip ci]

* [comment audit] Shorten status, diff-cache, and checkout comments [skip ci]

* [comment audit] Clarify worktree lifecycle and WSL routing comments [skip ci]

* [comment audit] Shorten forge identity and review-refresh comments [skip ci]

* [comment audit] Tighten hosted-review client comment contracts [skip ci]

* [comment audit] Clarify GitLab compatibility and review comments [skip ci]

* [comment audit] Tighten hook ownership and watchdog rationale [skip ci]

* [comment audit] Condense host and integration compatibility comments [skip ci]

* [comment audit] Clarify IPC authority and remote-routing rationale [skip ci]

* [comment audit] Finalize file-import and containment comment cleanup

* [comment audit] Fix stale Jira type imports blocking full CI

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 16:27:37 -07:00
Brennan Benson fb1f4b3e6f Agents: store each agent's permission itself; terminals and new chats read it (#31315)
* feat(agents): store each agent's permission itself instead of typing flags into Arguments

Terminals and new chats read one stored choice per agent (Use the agent's own
settings, Ask for approval, Accept edits, Approve for me, Full access). Orca adds
the flag at launch; Arguments hold only the user's own text. A one-time move
lifts Orca's flags out of saved Arguments. Older clients still see and write
the flag as part of Arguments; the host translates.

* fix(agents): say the all-agents switch resets agents set separately; keep primitives unstyled

* test(agents): the one-time move returns every launch-profile field

* Fix permission carrier ownership and surface-specific defaults

* Preserve uncertain permission operands and name the option inventory

* Check env entries without indexing typed agent maps

* Combine Chat permission capability imports

* Use folder execution-host platform for permission environment

* Preserve launch map replacement and acknowledge permission saves

* Keep permission feedback fallbacks statically discoverable

* Provide preload platform to Agents settings render tests

* Preserve Gemini approval arguments under Full access

* fix(settings): retain complete environment edits through save outcomes

* fix(settings): narrow local failure scope and preserve host messages

* fix(settings): retire argument drafts after acknowledged saves

* fix(settings): keep Goose environment editable after reset

* fix(settings): show resolved arguments for legacy hosts

* Preserve pending environment resets and bound launch settings work

* Keep optional settings fallback in repository metadata reads

* Read repository visibility defaults through the raw settings fixtures

* Prepare whole Environment edits and retire unchanged drafts

* Keep Environment settings transitions in an acyclic module

* Update raw settings reader test fixtures

* Place test fixture safety notes on assertion starts

* test: pin permission settings work and recovery contracts

* test: type permission settings work fixtures

* test: cover migrated permission inputs and captured CLI grammar

* test: preserve typed permissions in WSL Claude restarts
2026-10-23 16:20:55 -07:00
Brennan BensonandOrca Worker d49ad60ead feat(chat): add terminal-style pane header actions (#28968)
* Transfer keyboard focus when a sibling chat pane opens

* fix(native-chat): hand focus to newly opened chat composer

* fix(native-chat): keep tab bar controller within line limit

* fix(chat): split into a fresh conversation beside the current chat

* test(chat): declare the split fixture store without an assertion

* fix(chat): route the split to the source conversation host

* test(chat): keep the split regression focused on the launch contract

* test(chat): give the command palette split fixture its conversation agent

* test(chat): seed the legacy command fixture without expanding its asserted shape

* test(chat): isolate pane identity commands from the split launch boundary

* Prevent chat splits from starting a terminal on host refusal

* Cancel structured launches when their destination pane closes

* Model live destination groups in agent launch test fixture

* Capture split chat focus intent at the user action

* feat(chat): add the terminal pane hover action cluster

* fix(chat): keep pane controls above the conversation surface

* refactor(chat): share the tab resume launch hook and format pane controls

* style(chat): document reuse of the terminal header button styles

* refactor(ui): share the pane title button variants between terminals and chats

* fix(chat): keep header actions scoped to the displayed chat

* fix(chat): abandon Resume when its destination pane closes

* test(chat): declare destination fixtures without type assertions

* fix(chat): keep Resume visible when its source pane closes

* fix(chat): reuse tab menu Resume placement unchanged

* test: fix Resume regression harness setup

* fix(chat): hand input to the split pane during admission

* fix(chat): Split opens a fresh chat beside the current one

Split Right/Down on a native chat used to move the chat into a new pane.
It now opens an empty pane beside the chat and launches a new chat of the
same agent on the same host into it through the New Chat launch, so the
new composer takes focus at once. A launch that never opens a tab closes
the empty pane. Drops the earlier admission and focus-transfer changes
that main now covers.

* fix(chat): Split palette search words describe a new chat, not a move

* fix: remove misleading chat move shortcut hints

* fix(chat): a new chat stays in its pane until its host lists it

A host tab list built before a chat's create landed can arrive after the
create reply. Once the reply settled the launch, nothing protected the new
tab, so that older list dropped it: Split's new pane collapsed and focus
moved to another chat, and the next list re-added the chat elsewhere.

Keep a small in-memory record for a chat this client created that no host
list has shown yet. While it exists, a list that omits the chat keeps its
tab. The record ends when an accepted list from that host includes the
chat, when the tab closes, on workspace teardown, or 30 seconds after the
reply, when the worktree is re-read from its host (including an unchanged
version) so a chat the host really closed is dropped then. The launch
lifecycle, status, persistence and settlement are unchanged.

* test(chat): type the faked create replies without an assertion

* Keep new chat protection tied to accepted host lists

* Update paired chat close regression to current suppression API

* fix(chat): Portuguese Split palette words describe a new chat

* test(chat): use the destination group option in split fixture

* Avoid History projection in native chat header and currentness checks

* fix(native-chat): keep Find below pane controls

* fix(ui): keep noninteractive tooltip layers pointer-transparent

* Mount native chat actions only for shown panes

* Use checked property access in header instrumentation

* Read Continue eligibility records through workspace selectors

* Cover native header Find clearance and tooltip click passage

---------

Co-authored-by: Orca Worker <orca-worker@localhost>
2026-10-23 16:17:28 -07:00
Brennan Benson 87eccfe9f4 Pick Jira users for required Reporter and custom user fields (#31972)
* fix(jira): pick real users for required create fields

* test(jira): keep user picker coverage within renderer boundary

* fix(jira): preserve known user identities and metadata choices

* test(jira): preserve full dialog fixture model type

* test(jira): target metadata Select trigger

* fix(jira): show matching people before known ID action
2026-10-23 15:58:12 -07:00
79cb7fd4bc fix(editor): avoid redundant CRLF normalization when syncing Monaco (#32583)
* fix(editor): reuse unchanged model text before EOL normalization

* fix(editor): preserve paired CRLF separators during live updates

* test(editor): drop the Monaco content-sync heap probe

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
2026-10-23 15:56:16 -07:00
5f0c4a50bd fix(memory): decode image and encrypted reply bytes without character arrays (#32300)
* fix(memory): avoid character arrays when decoding image bytes

* fix(web): use bounded-allocation base64 decoding for encrypted replies

* refactor(memory): drop heap-probe tests and reuse the shared base64 decoder

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
2026-10-23 15:56:12 -07:00
Neil 9a5da64fdd refactor: group remote runtime requests and subscriptions (#32952) 2026-10-23 15:52:57 -07:00
Brennan Benson 7a5d0c02bd Open files dragged from the explorer in the target editor group (#31961)
* fix(editor): open files dragged from the explorer in the target group

* fix(editor): preserve selected drop resources and owner routing

* test(editor): narrow accepted workspace drag result

* test(editor): bound workspace drop processing work
2026-10-23 15:42:49 -07:00
Brennan Benson 20b78bbd15 Explain agent startup failures in plain words (#31932)
* fix(terminal): explain agent startup failures in plain words

* fix(i18n): use the established Japanese agent label

* fix(terminal): preserve uncertainty in startup error messages

* Reuse pane agent identity and bound startup toast work

* test: render startup notices with shipped locale catalogs
2026-10-23 15:40:18 -07:00
Jinwoo Hong 8586fc761d fix(linux): stop marking the terminal host scope ManagedOOMPreference=avoid (#32935)
uresourced before 0.5.5 answers every attribute write on the scope's cgroup by
re-setting its CPU and IO weights, which makes systemd rewrite the oomd xattr
again. The loop pins systemd --user and eventually stops it starting new
terminals. Per-terminal scopes already keep oomd from taking every terminal.
2026-10-23 18:38:16 -04:00
Jinwoo Hong 2c53a550ff feat(connectors): pending prompts, answers and turn events behind experimentalConnectors (B3) (#32160) 2026-10-23 15:31:49 -07:00
NeilandJesse Sanford 0008e0cdf5 fix(orcad): add --reclaim-stale-lock for a lock no start can judge after a reboot on a shared home (#32915)
* fix(orcad): add --reclaim-stale-lock for a lock no start may judge

On a Linux host with no machine id whose ~/.orca is on a network or FUSE
home, a lock left by the host's own previous boot names a PID that is
evidence only on the machine that issued it, so every start after a
reboot refused it, and the only way out was deleting orcad.lock by hand.

Starts still refuse it: losing contact is not proof of exit, and a home
other machines may share must never be taken over automatically. Now:

- `orca serve --reclaim-stale-lock` (and `orcad --reclaim-stale-lock`)
  checks that the lock was written on this host, in an earlier boot, at
  least 2 minutes ago, and that nothing answers at its holder's
  endpoints. It prints the pid, host, boot and age and warns about other
  machines sharing the home, and clears the lock only with --yes,
  through the normal race-safe reclaim of that exact record.
- Lock records now name their host, as evidence for that command.
- The refusal has its own code, orcad_instance_lock_holder_unverifiable,
  names the command, and exits 3, so `orca serve --supervise` waits on it
  instead of giving up, and the desktop refuses on it like a held lock.
- orcad advertises orcad.stale-lock-reclaim.v1 so a client can offer
  the command on hosts that have it.

Fixes #32177

Co-authored-by: Jesse Sanford <108698+jessesanford@users.noreply.github.com>

* fix(orcad): let --reclaim-stale-lock clear a reclaimer cut short by the reboot, and probe IPv6

A reclaimer from the same earlier boot on this host that the reboot cut
short left a recovery owner the command could never judge, so --yes
always failed. The confirmation now covers such an owner too, and only
one from this host's earlier boot. An IPv6 WebSocket endpoint is probed
by its bare address.

Co-authored-by: Jesse Sanford <108698+jessesanford@users.noreply.github.com>

* fix(cli): ship the stale-lock reclaim module with packaged builds, and refuse an unreachable lock

The CLI loads main modules from out/main after the main build replaces
it, so the reclaim module becomes a stable plain-Node entry and is
unpacked from the asar. A lock that cannot be stat'ed for any reason other
than absence (a permission error, say) is now a refusal, not "nothing to
reclaim".

Co-authored-by: Jesse Sanford <108698+jessesanford@users.noreply.github.com>

* fix(orcad): make --reclaim-stale-lock name the real data root and report a status

- The refusal prints a runnable command for the data root it refused:
  an orcad names its own runtime and entry plus `--data-root <dir>`,
  since managed hosts have neither `orca` nor `orcad` on PATH and their
  data root is not the default. The hint is Linux-only.
- Both entry points take `--data-root` and `--json` and report one of
  none, eligible, refused or reclaimed, each with its own exit code
  (4, 2, 1, 0), so a missing lock never reads as a recovery.
- The evidence says nothing answers on this machine, and that the host
  name and boot checks cannot rule out another machine with the same
  name; --yes stays the gate.
- wss endpoints default to port 443, a same-boot branch that could never
  run is gone, and the supervisor's standby line points at the command.

Co-authored-by: Jesse Sanford <108698+jessesanford@users.noreply.github.com>

* fix(orcad): point the eligible message at the same command plus --yes

Co-authored-by: Jesse Sanford <108698+jessesanford@users.noreply.github.com>

* fix(orcad): refuse an empty --data-root, and name the right program in reclaim hints

- `--data-root` with no usable value (a trailing flag, an empty or blank
  string) prints usage and exits 1 on both entry points, never falling
  back to the default profile.
- A refusal raised while the reclaim command itself runs names
  `orca serve --reclaim-stale-lock`, not the binary the CLI runs under;
  an orcad still names its own runtime and entry.
- The supervisor's standby hint includes this profile's --data-root.
- The unreadable-lock test is skipped when running as root.

Co-authored-by: Jesse Sanford <108698+jessesanford@users.noreply.github.com>

* test(cli): reuse the existing client stub for the --data-root refusal test

Co-authored-by: Jesse Sanford <108698+jessesanford@users.noreply.github.com>

---------

Co-authored-by: Jesse Sanford <108698+jessesanford@users.noreply.github.com>
2026-10-23 15:26:03 -07:00
Kelvin Amoaba 291e2e807e feat(browser): open links beside their pane, focus link tabs, honor window.close() (#31844) 2026-10-23 22:20:34 +00:00
Kelvin Amoaba 4c6cfda0ac fix(editor): keep paragraphs starting with "Dr.", "A." or "iv." out of ordered lists (#32694) 2026-10-23 22:19:53 +00:00
Brennan BensonandGabriel Petrovic 18adb179b7 Keep Claude weekly usage from jumping back to an idle session’s old value (#32249)
* fix(usage): ignore an idle Claude session's older usage for the same window

Claude Code re-sends each session's last-seen rate limits to the statusline,
dropping only windows whose reset has passed. An idle session days old keeps
posting the current weekly window at the value it saw back then, so the
weekly figure flipped between that stale value and the current one while the
5-hour figure held. Usage inside one window only grows, so a lower value for
the same reset (or an earlier reset) is dropped, and a post with nothing newer
leaves the snapshot and the OAuth poll timing untouched.

Fixes STA-10493 (#28418). Ports the rule from #23421.

Co-authored-by: Gabriel Petrovic <243207667+gabba6@users.noreply.github.com>

* fix(usage): separate Claude display receipts from corrective checks

* fix(usage): honor Claude retry eligibility when selecting refreshes

* test: verify fresh usage checks after service recreation

---------

Co-authored-by: Gabriel Petrovic <243207667+gabba6@users.noreply.github.com>
2026-10-23 15:14:17 -07:00
OrcaWinandOrcaWin cb34886d49 test: reuse editor slice fixture for owner view-state regression (#29650)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 15:12:17 -07:00
OrcaWinandOrcaWin 3a3e9c4038 test: reuse maintenance worker setup for compatibility cases (#29761)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 15:12:12 -07:00
OrcaWinandOrcaWin bd0261d147 test: verify terminal chunk yields without waiting for Enter delay (#29752)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 15:03:46 -07:00
OrcaWinandOrcaWin 0797def856 test: isolate shutdown suites from unused application startup (#29703)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 15:03:43 -07:00
Brennan Benson ef66a5e151 feat(crash-reporting): record renderer long-task measurements (#32193)
* feat(crash-reporting): include renderer long-task measurements

* Remove incidental package manager lockfile churn
2026-10-23 14:59:29 -07:00
Neil d3bff1c2e4 refactor(terminal): the file-link open turn and HTML browser open get their own modules (#32932) 2026-10-23 14:58:37 -07:00
OrcaWinandOrcaWin ef91e89faf test: reduce mobile relay integration startup imports (#29624)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 14:56:32 -07:00
OrcaWinandOrcaWin 731a54a863 test: retain Activity search semantics without work counters (#29807)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-23 14:56:29 -07:00
Brennan Benson e268135719 feat(native-chat): chat agents are offered wherever their chat program runs, not only where their CLI is installed (#28709)
* feat(acp): ACP agents can declare a managed runtime installed on first chat start

An ACP launch spec may name a pinned runtime Orca installs under its locked
data folder. The stock lookup searches it last (Command, PATH, install
directories, managed folder); a start whose lookup missed installs it under
the acquisition's signal, then resolves the launch again. A Command setting,
restart-recovery reads and catalog probes never install.

The pinned-runtime materializer can now publish a verified multi-member
folder: extract once into staging, check each member's sha256, rename into
place, with a per-asset download size limit. Node's runtime path is unchanged.

* Fix ACP managed runtime lookup precedence

* feat(acp): ACP agents can run with a private per-process temp folder

* feat(acp): old managed runtime versions are removed at host start

Once per host start, the ACP registration removes every version beside an
agent's current managed runtime folder, and staging left by an earlier
process. One host owns the data root and ACP servers are never reattached
across host runs, so nothing runs from them. This process's own staging is
kept (a publish may be in flight). Best effort: a failure is logged and never
holds up a launch.

* feat(acp): a sign-in prompt on an ACP agent's stderr ends the start or turn signed out

An agent that waits for a browser sign-in prints a link on stderr and blocks for
minutes. A launch spec can now name that line (signInPrompt); the connection then
closes with a typed sign-in failure through the existing process owner, so a start
reads notSignedIn and a running turn fails signed out instead of settling unknown.
The matched line, which carries the sign-in URL, never enters the retained stderr
tail, errors or diagnostics.

* Prevent sign-in URLs leaking from long stderr lines

* feat(acp): an agent can enforce the permission mode itself through a session config option

An optional launch-spec field names the session config option and its ask/full values. Every new or
reopened session gets the value for the chat's full-access posture before it is exposed, and a refusal
fails the start. With the field present Orca no longer answers permission requests for the person.
No agent sets it yet.

* fix(acp): reject unconfirmed permission mode during acquisition

* feat(acp): an agent enforcing the permission mode itself runs the chat's own mode

The launch spec maps each chat permission mode to its session option value; a start sets the
value for the mode the host launches with (ask when it names none), replacing the global Agent
Permissions full-access read. A mid-chat change takes effect through the host's existing restart
of a child launched with another mode before the next send.

* Keep ACP session acquisition within the line limit

* feat(acp): open Antigravity in the Chat UI over its ACP server

With the experimental chat setting on, Antigravity chats run Google's
Antigravity ACP server, which Orca installs on the first chat start: a
pinned 1.3.0 release whose archive and both executables are verified by
hash (macOS arm64/x64, Linux x64/arm64).

Each host keeps one private sign-in folder for these chats under Orca's
data folder, made owner-only before every start; the server keeps its
sign-in there as a file. A chat signs in with the server's Google method
through the existing auth-required retry; with no saved sign-in the
server's sign-in prompt ends the chat signed out. The Agent Permissions
setting maps to the server's own mode, and a question the server asks
shows as a question that takes one of its choices, never auto-answered.
A chat reopens its session with session/resume.

* fix(acp): separate Antigravity chat command and require pinned host

* test(acp): assert Antigravity launch arguments across hosts

* feat(acp): Antigravity chats offer Ask, Accept edits and Full access per chat

Each mode maps to the server's own (default, auto_edit, yolo). No Approve for me:
the server has no automatic reviewer. Accept edits gets its own description,
since auto_edit approves file edit tools only.

* feat(native-chat): offer host-provided chats without their CLI detected

A host now marks each agentSession.agents row whose chat program Orca provides there
(an ACP managed runtime with a pinned build on this host). With Chat UI on, the tab-bar
picker, the empty-workspace default chat and the new-agent shortcut offer those agents
beside the detected ones when the launch opens as a chat. Terminal launches still follow
detection, and an older host that sends no mark keeps today's detection-only offer.

* Fix CLI-free chat fallback and picker updates

* Fix admission refusal reason test expectation

* feat(native-chat): the host health snapshot says whether each chat's program is on the machine

Antigravity's chat runs Orca's own download of Google's ACP program, not the agy CLI, so clients
could not tell from CLI detection whether it can open as a chat. Each snapshot row now carries an
optional chatProgram (available, installable, missing, unknown), found through the agent's own
launch resolver without spawning anything, and re-derived after a managed runtime install or
removal. Health state and reason are unchanged, so older clients decode the frame as before.

* feat(native-chat): one renderer reading of whether an agent can open as a chat on its host

Pickers asked CLI detection whether an agent can open as a chat, which is wrong for Antigravity,
whose chat runs a program Orca downloads. This module answers from the host's published chat
program fact, and for hosts that publish none, from the host's managed-runtime mark and install
capability or else CLI detection. Facts not yet learned read as unlearned, not as no.

* fix(native-chat): a declined chat opens its agent's terminal only where the CLI is installed

Once a chat can be offered without its CLI, a host refusal used to fall back to a terminal that
runs a CLI that is not there. The one admission boundary now reports the host's refusal instead
when the workspace host's detected agents lack the CLI, for new-tab, work-item and workspace
creation launches alike. A caller's own fallback, like the empty workspace's shell, still opens.

* feat(native-chat): the + menu and Settings offer a chat wherever its program runs

With Chat UI on and no agy CLI, Antigravity had no chat row in the + menu (or a disabled
'Not installed' one when switched on), because both read CLI detection. The menu now reads the
host's chat-program answer: a chat row where the program runs or installs from the chat, no
'(CLI)' row or terminal button without the CLI. A failed CLI check no longer keeps the menu from
learning that answer. Settings shows an unchosen provider on when its CLI or the program Orca
runs for it (downloaded or found outside Orca) is installed, and holds the switch until that is
known. A saved default that opens as a chat no longer says it is not detected.

* feat(native-chat): a default agent that opens as a chat starts without its CLI

An empty workspace and the new-agent shortcut skipped a default agent whose CLI is not detected,
even when it opens as a chat on that host (Antigravity without agy). Both now honor that default,
waiting briefly for the host's chat facts when they are not known yet, while the automatic pick
with no default still chooses only detected agents. Blank and the shell fallback are unchanged.

* feat(native-chat): new workspaces, work items, continuations and the dashboard offer chat-only agents

The new-workspace composer, work-item launches, session continuation and the dashboard launcher
listed only agents whose CLI is detected, so an agent that opens as a chat without its CLI could
not be picked, and an explicit pick of it was dropped. They now also offer agents that open as a
chat on the workspace's host, keep such an explicit choice, and the dashboard republishes when
the host's chat facts arrive. Automatic picks still choose only detected agents.

* feat(native-chat): Source Control and Fix Checks accept a chosen agent that opens as a chat

The Source Control action dialog, its saved auto-start, the checks panel, recovery launches and
Fix Checks (before and after its workspace exists) rejected a saved or default agent whose CLI
is not detected, even where it opens as a chat. They now accept it there and list it, through
the shared source-control pick, while the automatic pick still chooses only detected agents.

* fix(native-chat): an empty workspace does not wait on chat facts for a Claude or Codex default

Claude and Codex have no program Orca downloads, so without their CLI only the host's own answer
could offer them as a chat; holding the workspace empty for the host's agent list could not
change that.

* test(native-chat): pin the chat-program fact, cold explicit defaults and the CLI-less decline

Covers the host's program lookup and its re-read after an install, older and unknown snapshot
values falling back to the managed mark and install capability of the same host, an explicit
default opening as a chat with CLI detection failed while automatic and blank picks stay on
detected agents, kept composer and saved Source Control choices, and a declined chat reporting
the refusal instead of opening a terminal for a missing CLI on both launch paths.

* refactor(source-control): the action dialog's agent list lives in its own hook

The dialog hook was over the file-length limit after it learned which agents
open as a chat without their CLI; detection and that offer now live together
in use-source-control-launchable-agents.

* fix: typed test mocks and record the dialog's pre-existing reset effect

The Source Control dialog's open-cycle reset effect was already on main; the
changed-code gate reported it because the effect now also learns which agents
open as a chat.

* fix(native-chat): a declined chat refuses its terminal only when the CLI is known to be missing

When a host declines a chat, Orca falls back to that agent's terminal. A chat can now be offered
without its CLI, so the fallback must not open a terminal that cannot start. But a failed or
still-pending CLI check is not proof the CLI is missing: treating it that way blocked a working
terminal fallback (for example an OpenCode version that runs in a terminal but not as a chat).

Each detection producer (local, paired server, SSH) now records the outcome of its latest attempt
for the exact target, next to the IDs it already keeps. The decline check refuses the terminal
only when the same host's latest attempt succeeded and did not list the CLI; pending, failed or
unresolved outcomes keep the existing fallback, and a caller's own shell fallback is untouched.

* fix(native-chat): every launch surface learns whether a chat opens before it decides

A chat whose program runs on the host without its CLI (for example Antigravity) could be missing,
greyed out or swapped for another agent depending on which surface launched it: the composer
dropped an explicit pick while the host was still answering, Fix Checks and the Checks panel
refused a saved chat agent, an inactive paired host was never asked about its chats, the Providers
switch flashed off, and session continuation auto-picked an agent that was only offered.

One lease per host, runtime and pairing now acquires the host's agent list and health stream
for whoever needs it: the + menu, composers, Settings, the dashboard and its pop-out, Source
Control and Checks, Fix Checks, work items, shortcuts and continuation. Actions wait for those
facts within one bounded deadline (ordinary CLI detection keeps its own wait), cancel when the
workspace's host is genuinely replaced, and re-read settings before launching. A saved, default
or explicit choice may open as a chat without its CLI; automatic picks still come only from
detected agents. Pending or unknown facts never erase a choice or flash a switch off.

The dashboard's holds are reconciled by the publishers that read them, and a hold that notifies
while it is being created no longer leaks a second stream holder.

* fix: the new-workspace composer memoizes its launch workspace from its own fields

* fix: a declined chat reads the launch host's own agent inventory; test fixtures match their types

* fix: work-item launches detect before waiting on chat facts; the composer and Source Control list agents from one owner

The composer card no longer holds its own chat-facts lease beside its modal's, Source Control reads agent
inventory only while its dialog is open, and a work-item launch keeps the new workspace's own detection
when the store has not loaded that workspace yet.

* fix(native-chat): keep acquisition tied to the current host resource

* fix(native-chat): verify the current acquisition before returning choices

* fix(i18n): retain legacy terminal-list English entries in the runtime catalog

* fix(native-chat): the dashboard republishes launch options when the active workspace's host changes

Both dashboard publishers now watch the active workspace and its selected host, which own its launch
options. Two QuickLaunchButton tests assert the current "couldn't list terminal agents" wording.
Restores base forms and drops a duplicate workspace helper to stay inside the change budget.

* test: the dashboard publisher test reads its watched state from the function it tests

* fix(native-chat): dashboards watch one checked route-input view; saved Source Control discovery settles every outcome

Both dashboard publishers observe and derive launch options from one exhaustive, compiler-checked view of
the store slices the launch-route readers take, so a route input can no longer be missed by one list. A
saved Source Control action's discovery now ends as success, cancelled or failed; only success can auto-start,
and a cancelled or failed attempt reveals the editable dialog instead of launching on a replacement runtime.
Restores base forms and shares one worktree workspace helper to stay inside the change budget.

* style: format the runtime metadata resolver

* fix: merge duplicate imports the code-quality gate rejects

* test: the dashboard watch fixture seeds every route-input field

* test: the dashboard watch fixture is fully typed without a cast

* fix: an unknown agent scan stays unknown for Fix Checks and recovery, and a saved Checks agent keeps its message

* fix: the action-first chat path asks the same missing-CLI check before opening a declined terminal; compact to the size cap

* refactor: compact the chat-program changes to the size cap after merging main

* Pickers list an agent that can't open here as disabled with its reason instead of hiding it

The Create workspace and continuation pickers only searched the agents the caller could launch, so an enabled agent with no chat on this host (for example Antigravity when the host can't run it) lost its disabled row, while the + menu showed it.

* Continuation test accepts more than one disabled subfolder row now that disabled rows are listed

* Re-run CI: the code scan was cancelled across the repository

* test: cover chat selection without terminal CLI

* test: compact host chat program fixtures
2026-10-23 14:49:30 -07:00
Jinjing b9700e48fa Refresh automation run history before opening a run (#32788)
* Refresh automation run history before navigating to a run

- Prevent stale cached runs from opening or reporting missing history
- Show loading and preserve dashboard navigation during refresh

* Update run history inputs after layout commit

* Resolve workspace run links on their host and preserve cancellation

* fix test
2026-10-23 14:46:11 -07:00
Kelvin Amoaba ffd784286e fix(onboarding): start the default agent in the first folder added after skipping onboarding (#32701) 2026-10-23 21:44:40 +00:00
Neil aeb039938f refactor(jira): colocate shared contracts and capabilities (#32927)
* refactor(jira): colocate shared contracts and capabilities

* test(jira): validate title width against panel budget
2026-10-23 14:31:05 -07:00
Kelvin Amoaba 2d06b6d6f9 fix(links): open local html file links in the browser link routing picks (#32706) 2026-10-23 21:18:09 +00:00
Neil 6ed9382c05 Allow SSH migration recovery without stopping preserved relay terminals (#32914)
* fix(ssh): preserve running relay panes during migration recovery

* fix(ssh): wire pane eligibility through existing relay seams
2026-10-23 13:54:17 -07:00
Brennan Benson cd1f1901ee Show OpenCode provider quota failures as usage limits (#31937)
* fix(opencode): show provider quota errors as usage limits

* fix(opencode): preserve billing and entitlement failures

* test(mobile): cover OpenCode failure notice contract
2026-10-23 13:47:32 -07:00
Brennan Benson 6e7f43e57f fix(cli): explain unsupported and unresolved worktree parents (#32256)
* fix(cli): identify unsupported and unresolved worktree parents

* fix(cli): preserve failing worktree lookup recovery

* fix(cli): keep recovery imports on pure error types

* Remove incidental package manager lockfile churn
2026-10-23 13:46:55 -07:00
Neil 772d661e1d refactor(task-page): colocate Linear composition modules (#32916) 2026-10-23 13:35:28 -07:00
OrcaWin 2847bbe9e8 [comment audit] Consolidate completed code comment cleanup
Combine the completed comment cleanup from 319 stacked PRs into one change against `main`, so the full CI suite validates the combined result once. This replaces the previous audit stack; no additional audit work is included.

The change shortens redundant comments across 2,753 source and shell-snapshot files (25,235 net lines removed). Conflicts preserve current-main executable code. Runtime behavior, test assertions, directives, licenses, generated notices, SAFETY rationales, and compatibility markers are preserved. The audit tracker remains local, outside the repository.

Validation:
- Equivalent source/emitted AST and executable tokens across all 2,750 source files, with separate checks for embedded shell, SQL, JavaScript, CSS, and generated fixtures.
- Identical executable lines in the three shell snapshots; protected comments unchanged.
- Changed-code quality gate passed with no new findings.
- 358 tests passed, 2 skipped across 23 focused test files.
- `git diff --check` passed.
2026-10-23 13:15:45 -07:00