OrcaWin and OrcaWin
0b27a777ea
test: remove 220 low-value hook, timeline and Ruby tests ( #38739 )
...
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com >
2026-11-05 16:20:16 -08:00
OrcaWin and OrcaWin
7d6603aa17
[comment audit] Complete repository-wide comment cleanup ( #33249 )
...
* [comment audit] Align legacy failure-read counts with cached display
* [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci]
* [comment audit] Condense shared generation, path and preview comments [skip ci]
* [comment audit] Condense host, file and Git contract rationale [skip ci]
* [comment audit] Tighten Git lifecycle and provider contract comments [skip ci]
* [comment audit] Clarify shared host authority and launch isolation [skip ci]
* [comment audit] simplify local access mobile and native chat contracts [skip ci]
* [comment audit] simplify native chat presentation and state contracts [skip ci]
* [comment audit] simplify native runtime and provider contracts [skip ci]
* [comment audit] simplify migration and orchestration contracts [skip ci]
* [comment audit] simplify plugin trust and process capture rationale [skip ci]
* [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci]
* [comment audit] clarify remote recovery and launch wire rationale [skip ci]
* [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci]
* [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci]
* [comment audit] clarify sidebar, skill and SSH invariants [skip ci]
* [comment audit] condense structured chat delivery and timing rationale [skip ci]
* [comment audit] condense terminal replay and telemetry invariants [skip ci]
* [comment audit] clarify launch permission and terminal delivery rationale [skip ci]
* [comment audit] clarify workspace ownership and layout contracts [skip ci]
* [comment audit] wait for fitted and painted SSH terminal links
* [comment audit] clarify layout persistence and session ownership [skip ci]
* [comment audit] clarify host routing and workspace lifecycle contracts [skip ci]
* [comment audit] clarify startup persistence and app lifetime comments [skip ci]
* [comment audit] clarify recovery and activity boundaries [skip ci]
* [comment audit] condense activity and artifact invariants [skip ci]
* [comment audit] condense automation authority contracts [skip ci]
* [comment audit] simplify automation scheduling and history contracts [skip ci]
* [comment audit] clarify browser chrome and annotation lifecycles [skip ci]
* [comment audit] clarify browser routing and retained guest ownership [skip ci]
* [comment audit] clarify browser recovery and document ownership comments [skip ci]
* [comment audit] restore hosted runners required by native IME fixtures
* [comment audit] shorten preview, palette and dashboard invariants [skip ci]
* [comment audit] clarify terminal preview, dashboard and retention comments [skip ci]
* [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci]
* [comment audit] shorten rich-text and combined-diff ownership comments [skip ci]
* [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci]
* [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci]
* [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci]
* [comment audit] clarify rich Markdown source and selection safeguards [skip ci]
* [comment audit] clarify editor loading and emulator stream lifetimes [skip ci]
* [comment audit] trim emulator and feature tour narration [skip ci]
* [comment audit] clarify floating workspace and GitHub cache ownership [skip ci]
* [comment audit] trim provider controls and Linear filter explanations [skip ci]
* [comment audit] clarify pairing and chat resume lifetimes [skip ci]
* [comment audit] clarify chat delivery and transcript lifetimes [skip ci]
* [comment audit] clarify session options and host-owned status [skip ci]
* [comment audit] clarify draft durability and live-status precedence [skip ci]
* [comment audit] Trim chat send and model ownership explanations [skip ci]
* [comment audit] Shorten transcript ownership and send recovery comments [skip ci]
* [comment audit] Simplify native chat composer and transcript hook comments [skip ci]
* [comment audit] Shorten native chat scroll and structured session explanations [skip ci]
* [comment audit] Trim workspace picker and onboarding commentary [skip ci]
* [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci]
* [comment audit] Trim sidebar and session history explanations [skip ci]
* [comment audit] Condense session resume and review checks comments [skip ci]
* [comment audit] Shorten checks state and file explorer refresh comments [skip ci]
* [comment audit] Trim plugin bridge and source-control action rationale [skip ci]
* [comment audit] Trim source-control listing and review rationale [skip ci]
* [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci]
* [comment audit] Condense Settings account and appearance rationale [skip ci]
* [comment audit] Trim pairing and repository Settings explanations [skip ci]
* [comment audit] Condense Settings search SSH and terminal safeguards [skip ci]
* [comment audit] Shorten Settings voice and provider ownership comments [skip ci]
* [comment audit] Condense Settings draft persistence and host-state rationale [skip ci]
* [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci]
* [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci]
* [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci]
* [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci]
* [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci]
* [comment audit] Prune focus-read baseline after comment cleanup
* [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci]
* [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci]
* [comment audit] Clarify viewport geometry and skill update safeguards [skip ci]
* [comment audit] Tighten skill inventory, usage and host status comments [skip ci]
* [comment audit] Clarify usage ownership and resource kill safeguards [skip ci]
* [comment audit] Tighten tab selection, rename and search contracts [skip ci]
* [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci]
* [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci]
* [comment audit] Tighten provider loading and terminal recovery comments [skip ci]
* [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci]
* [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci]
* [comment audit] Tighten PTY startup and replay explanations [skip ci]
* [comment audit] Clarify PTY identity and delivery ownership [skip ci]
* [comment audit] Shorten remote reconnect and input replay rationale [skip ci]
* [comment audit] Condense terminal parking clipboard and file link comments [skip ci]
* [comment audit] Clarify IME ownership and trim trace history [skip ci]
* [comment audit] Shorten pane recovery and parked watcher explanations [skip ci]
* [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci]
* [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci]
* [comment audit] Trim renderer lifecycle and menu rationale [skip ci]
* [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci]
* [comment audit] Clarify renderer hook evidence and source ownership [skip ci]
* [comment audit] Tighten IPC ownership and reconnect explanations [skip ci]
* [comment audit] Trim renderer focus, paste and attention comments [skip ci]
* [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci]
* [comment audit] Trim agent launch, resume and ownership commentary [skip ci]
* [comment audit] Shorten account, browser and editor comments [skip ci]
* [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci]
* [comment audit] Condense launch recovery and editor tokenization comments [skip ci]
* [comment audit] Condense workspace selection and terminal pane rationale [skip ci]
* [comment audit] Condense terminal fitting and rendering recovery comments [skip ci]
* [comment audit] Condense terminal input and host routing explanations [skip ci]
* [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci]
* [comment audit] Condense structured launch and terminal link explanations [skip ci]
* [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci]
* [comment audit] Condense session persistence and workspace activation rationale [skip ci]
* [comment audit] Condense workspace routing and browser ownership rationale [skip ci]
* [comment audit] Condense mirror recovery and layout authority rationale [skip ci]
* [comment audit] Condense runtime transport and file safety rationale [skip ci]
* [comment audit] Condense runtime graph and structured session rationale [skip ci]
* [comment audit] Condense browser creation and remote tab recovery rationale [skip ci]
* [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci]
* [comment audit] Condense frame, startup and provider cache rationale [skip ci]
* [comment audit] Condense host twin and agent lifecycle rationale [skip ci]
* [comment audit] Condense browser authority and editor cleanup rationale [skip ci]
* [comment audit] Condense editor buffer identity and review cache rationale [skip ci]
* [comment audit] Condense provider lifetime and repository ownership rationale [skip ci]
* [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci]
* [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci]
* [comment audit] Condense cleanup ownership and listing admission rationale [skip ci]
* [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci]
* [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci]
* [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci]
* [comment audit] Condense cloud rollout and assignment safety rationale [skip ci]
* [comment audit] Condense relay session and database recovery rationale [skip ci]
* [comment audit] Condense relay placement and protocol compatibility rationale [skip ci]
* [comment audit] Condense build and packaging constraints [skip ci]
* [comment audit] Condense CI gates and validation isolation rationale [skip ci]
* [comment audit] Condense catalog identity and browser validation rationale [skip ci]
* [comment audit] Condense mobile browser and frame-budget rationale [skip ci]
* [comment audit] Shorten mobile route and browser test explanations [skip ci]
* [comment audit] Condense editor and session seam test rationale [skip ci]
* [comment audit] Trim session and terminal closure history [skip ci]
* [comment audit] Shorten terminal browser and census explanations [skip ci]
* [comment audit] Preserve root-only E2E diagnostic baseline
* [comment audit] Condense mobile seam and HTML preview test rationale [skip ci]
* [comment audit] Condense preview instrumentation and render harness rationale [skip ci]
* [comment audit] Condense bundle contracts and native-build constraints [skip ci]
* [comment audit] Shorten native packaging and CI routing rationale [skip ci]
* [comment audit] Condense release tooling and benchmark constraints [skip ci]
* [comment audit] Condense packaging and platform gate rationale [skip ci]
* [comment audit] Shorten mobile route and history rationale [skip ci]
* [comment audit] Condense mobile browser and component rationale [skip ci]
* [comment audit] Shorten drawer and workspace-form rationale [skip ci]
* [comment audit] Trim mobile review and editor-document explanations [skip ci]
* [comment audit] Condense editor lifecycle and Markdown explanations [skip ci]
* [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci]
* [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci]
* [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci]
* [comment audit] Condense bridge stream, native request and audio rationale [skip ci]
* [comment audit] Reduce bridge schema and page-client commentary [skip ci]
* [comment audit] Tighten mobile page bridge contracts [skip ci]
* [comment audit] Clarify mobile cache and session constraints [skip ci]
* [comment audit] Condense mobile route and lifecycle rationale [skip ci]
* [comment audit] Tighten mobile shell hook timing rationale [skip ci]
* [comment audit] Clarify route handoff and notification compatibility [skip ci]
* [comment audit] Clarify push registration and dictation cleanup constraints [skip ci]
* [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci]
* [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci]
* [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci]
* [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci]
* [comment audit] Tighten stream replay and queued session ownership rationale [skip ci]
* [comment audit] Condense mobile composer and reply-schema constraints [skip ci]
* [comment audit] Clarify mobile transcript recovery and session ownership [skip ci]
* [comment audit] Clarify mobile queue and source-control compatibility [skip ci]
* [comment audit] Condense storage and task launch constraints [skip ci]
* [comment audit] Clarify task schemas and terminal document ownership [skip ci]
* [comment audit] Tighten terminal input and viewport rationale [skip ci]
* [comment audit] Shorten terminal and RPC recorder contracts [skip ci]
* [comment audit] Condense recorder engine and connection contracts [skip ci]
* [comment audit] Shorten host credential and relay recovery comments [skip ci]
* [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci]
* [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci]
* [comment audit] Condense catalog and relay entry contracts [skip ci]
* [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci]
* [comment audit] Condense WSL relay and E2E regression rationale [skip ci]
* [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci]
* [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci]
* [comment audit] Shorten layout oracle and regression explanations [skip ci]
* [comment audit] Condense paired recovery and ownership regression contracts [skip ci]
* [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci]
* [comment audit] Condense terminal rendering and IME regression rationale [skip ci]
* [comment audit] Shorten terminal recovery and benchmark contracts [skip ci]
* [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci]
* [comment audit] Condense workflow routing and release rationale [skip ci]
* [comment audit] Condense mobile security and installer contracts [skip ci]
* [comment audit] Shorten native rationale and stylesheet workarounds [skip ci]
* [comment audit] Shorten Windows visibility probe rationale [skip ci]
* [comment audit] Condense embedded release and signing rationale [skip ci]
* [comment audit] Retain current main test behavior in final reconciliation [skip ci]
* [comment audit] Complete final comment review across current source inventory
* [comment audit] Handle consolidated audit reports before final CI
* [comment audit] Preserve credential storage census detail [skip ci]
* [comment audit] Scale broad changed E2E selections with verified timing shards
* [comment audit] Align E2E assertions with browser close and settled session metadata
* [comment audit] Match existing E2Es to current resource and windowing contracts
* [comment audit] Observe the shared server outage notice in reconnect coverage
* [comment audit] Make existing renderer probes measure settled tab and PTY work
* [comment audit] Align palette E2E selector with task search
* [comment audit] Refresh remaining palette search selectors
* [comment audit] Keep selector correction within selected audit specs
* [comment audit] Await emoji fixture settings inside renderer evaluation
* [comment audit] Cancel fixture fit retries between terminal tests
---------
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com >
2026-10-25 04:05:46 -07:00
Brennan Benson
7b4e10b104
fix(mobile-ios): pin fastlane and gate the Fastfile in CI ( #15092 )
...
* fix(mobile-ios): pin fastlane and gate the Fastfile in CI
The ios-distribute job failed on every run from 2026-08-10 to 2026-08-13
because distribute_testflight passed distribute_only without app_platform,
so pilot fell through to an interactive platform prompt on ubuntu. No CI
check loads the Fastfile, so external testers got nothing for six days.
- Pin fastlane 2.238.0 and commit mobile/Gemfile.lock so ios-build (macos)
and ios-distribute (ubuntu) cannot resolve different versions ~25 minutes
apart. Fixes the Gemfile comment's dead mobile-build.yml reference.
- Add a Fastfile smoke check (bundle exec fastlane lanes) plus a static
contract test for the TestFlight lane arguments to Mobile Checks.
- Set reject_build_waiting_for_review so a superseded same-train build in
beta review stops blocking the submission.
* fix(mobile-ios): install the pinned Gemfile.lock in frozen mode
Without frozen, a lockfile that drifts from the Gemfile is silently
re-resolved per job, which is the version split the pin exists to prevent.
* test(mobile-ios): anchor the TestFlight argument contract against an empty selection
* chore(mobile-ios): canonicalize the lockfile platforms
Bundler's own normalization drops arm64-darwin-25 as redundant with the
versionless arm64-darwin, and the ubuntu runners resolve x86_64-linux-gnu.
2026-08-17 12:03:20 -07:00
Brennan Benson
0ae0fd0434
fix(mobile-ios): set app_platform for distribute-only TestFlight upload ( #14087 )
2026-08-12 16:23:18 -07:00
Jinjing
418fbb3192
fix(mobile-ios): gate release on TestFlight distribution ( #13419 )
2026-08-10 01:47:36 -07:00
Brennan Benson
20aeb0cb99
Prepare mobile 0.0.42 and fix TestFlight CI hang ( #12961 )
...
* Bump mobile app.json to 0.0.42
* fix(mobile-ios): stop TestFlight CI from waiting on ASC processing
0.0.42 builds 1–2 uploaded successfully then hung for hours polling
processing with no Ready build and no Apple email. Exit after upload
and cap the job at 90m so the next cut does not repeat that hang.
* fix(mobile-ios): fully skip Pilot wait (no changelog)
Pilot only returns immediately after upload when changelog is nil;
passing notes re-enters the ASC build-list poll.
2026-08-07 16:52:37 -07:00
Neil
3830851a83
fix(mobile): unblock iOS releases and prepare 0.0.36 ( #10888 )
...
* fix(mobile): block iOS uploads below the last shipped App Store version
The closed-train guard looked up each candidate version's own App Store
record, but a version only gets one once it is submitted for review.
0.0.34 reached TestFlight and was never submitted, so it had no record,
nothing looked closed, and the patch-bump walk stopped there — while
0.0.35 had already shipped. Apple rejected the upload after a 24-minute
build (90186 closed train, 90062 needs a higher CFBundleShortVersionString).
Fetch the highest closed version once and treat everything at or below it
as closed, comparing semver numerically so 0.0.10 outranks 0.0.9.
Also read appVersionState alongside appStoreState: the latter is
deprecated in App Store Connect API 3.3 and renames the shipped state to
READY_FOR_DISTRIBUTION, so reading only the old field would silently find
zero closed versions once Apple stops populating it.
* chore(mobile): prepare 0.0.36
app.json sat at 0.0.32 while 0.0.35 shipped on the App Store, because
release versions are resolved on the runner and never committed back.
Close the four-version drift so the checked-in version matches reality
and the iOS release no longer depends on the closed-train walk to find
an open version.
Bump Android versionCode 8 -> 9 in the same commit: the version is shared
between platforms, and shipping 0.0.36 with the code that already shipped
for 0.0.32 produces an APK that cannot install over the released build.
2026-07-27 01:53:11 -07:00
OrcaWin and OrcaWin
801ff57e83
fix(mobile): unblock iOS releases ( #10224 )
...
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com >
2026-07-23 14:23:44 -07:00
Brennan Benson and Orca
584cec78c3
fix(mobile): fail fast when iOS App Store train is closed ( #6633 )
...
Co-authored-by: Orca <help@stably.ai >
2026-06-29 14:08:23 -07:00
Jinwoo Hong and Orca
674e1ccee9
Provide TestFlight changelog for external sharing ( #6006 )
...
Co-authored-by: Orca <help@stably.ai >
2026-06-21 16:12:08 -07:00
Jinwoo Hong and Orca
f524fdf8bb
Fix mobile iOS Fastlane paths ( #6004 )
...
Co-authored-by: Orca <help@stably.ai >
2026-06-21 15:36:10 -07:00
Jinwoo Hong and Orca
f6b82829f4
Improve iOS mobile release versioning ( #5994 )
...
Co-authored-by: Orca <help@stably.ai >
2026-06-21 12:25:25 -07:00
Jinwoo Hong and Orca
b17d8fc293
Share iOS releases with TestFlight peeps ( #5841 )
...
Co-authored-by: Orca <help@stably.ai >
2026-06-19 15:49:00 -07:00
Jinwoo Hong
c8f583c90a
Set CODE_SIGN_IDENTITY to Apple Distribution for iOS archive
...
Pin CODE_SIGN_IDENTITY so the archive uses the imported distribution cert. Admin-merge: only repo-wide pr.yml break failing.
2026-06-16 00:28:47 -07:00
Jinwoo Hong
7bbea13e70
Set team + profile on iOS archive for manual signing
...
Pass DEVELOPMENT_TEAM/CODE_SIGN_STYLE/PROVISIONING_PROFILE_SPECIFIER to the archive. Admin-merge: only repo-wide pr.yml break failing.
2026-06-16 00:24:27 -07:00
Jinwoo Hong
8b05f1e631
Fix iOS Fastfile: read profile name from SIGH_NAME
...
Use SIGH_NAME instead of nonexistent SIGH_PROFILE_MAPPING. Admin-merge: only repo-wide pr.yml break failing.
2026-06-16 00:19:53 -07:00
Jinwoo Hong
4481e2fabf
Use manual signing with explicit profile for iOS export
...
Fetch explicit profile via sigh + API key, export with manual signing against imported cert. Avoids cloud-signing permission error. Admin-merge: only repo-wide pr.yml break failing.
2026-06-16 00:15:45 -07:00
Jinwoo Hong
1f80d8bcd0
Fix iOS export signing: pass auth key to exportArchive
...
Add export_xcargs with ASC auth key so the export step can fetch the distribution profile. Admin-merge: only repo-wide pr.yml break failing.
2026-06-15 23:46:19 -07:00
Jinwoo Hong
da386fae8c
Fix iOS auth key: decode .p8 PEM from secret directly
...
Decode base64 ASC_API_KEY_P8 directly into the .p8 Tempfile so xcodebuild gets valid PEM. Admin-merge: only repo-wide pr.yml break failing.
2026-06-15 23:10:31 -07:00
Jinwoo Hong
3691267939
Fix iOS signing: pass App Store Connect API key to xcodebuild ( #5476 )
...
Feed xcodebuild the ASC API key via xcargs (-authenticationKeyID/IssuerID/Path) so -allowProvisioningUpdates can generate a profile. Materialize the .p8 from api_key[:key] to a Tempfile.
Merged with --admin: only failing check is the repo-wide pr.yml break, unrelated.
2026-06-15 23:06:31 -07:00
Jinwoo Hong
b5e6390ad2
Split mobile release into separate iOS and Android workflows ( #5475 )
...
Splits the combined Mobile Release workflow into mobile-ios-release.yml (mobile-ios-v* tags) and mobile-android-release.yml (mobile-android-v* tags) so iOS App Store review no longer gates Android. Also fixes iOS signing by passing the App Store Connect API key to build_app so xcodebuild can provision via -allowProvisioningUpdates.
Merged with --admin: the only failing check is the repo-wide pr.yml '@/lib/utils' vitest break affecting all PRs, unrelated to this change.
2026-06-15 23:01:44 -07:00
Jinwoo Hong
6740c00351
Build and ship iOS to TestFlight from CI ( #5468 )
...
Adds an ios-build job to the Mobile Release workflow (build + sign + TestFlight upload on a macOS runner via fastlane + App Store Connect API key), and fixes a pre-existing Mobile Checks bug where the mobile typecheck needed root deps for ../src imports.
Merged with --admin: the only failing check is the repo-wide pr.yml '@/lib/utils' vitest resolution break affecting all open PRs, unrelated to this change.
2026-06-15 21:38:00 -07:00
OrcaWinandOrcaWin
Brennan Benson
Jinjing
Neil
Jinwoo HongandOrca