mirror of
https://github.com/stablyai/orca.git
synced 2026-11-15 02:17:31 +00:00
de3da487fa6bbfde6f9e4b53fba7672fada5322c
16002
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 Neil
|
24d1d10da8 | refactor(shared): colocate session thread-goal contracts (#36720) | ||
 Brennan Benson
|
c64e1f615a |
Preserve queued command and card order through recovery (#36430)
* Advertise mid-turn queueing as queued-messages.v2 Released clients read the v1 name with an unfinished queue UI; they never see v2 and keep sending immediately. * Let each desktop send choose queue or steer while the agent works The follow-up choice is now a Queue / Steer setting saved under nativeChatFollowUpBehavior, Steer by default; the old nativeChatQueueFollowUps switch, which every install saved as true while queueing was dark, is retired on load. Every reader goes through native-chat-follow-up-behavior. While the agent works, Enter follows the setting and Cmd/Ctrl+Enter sends the draft the other way; the alternate flips the setting before the queue's own rules (a waiting command still queues, prompts no one here can answer still send now) and never applies while Stopping. Cmd/Ctrl+Shift+Enter steers the head card only and leaves the draft. An idle agent's card reads Send, and the card menu no longer offers "Turn off queueing". * Hold Send on the phone to queue or steer a message mid-turn While the agent works on a host that queues, holding Send opens a Queue / Steer sheet; a choice other than the host's setting sends the alternate, resolved against the chat as it is when it lands, by the desktop's rule. Release and dismiss send nothing. The phone reads the host's new follow-up setting (absent reads as Steer), and an idle agent's card reads Send. * Read the follow-up default from one place on desktop and phone * Keep phone follow-up choices aligned with live host state * Update stream and wire fixtures for live follow-up preferences * Document minimal runtime test fixture assertions * Keep mobile preference tests in the mobile compiler project * Preserve queued input order through handover and recovery * Consolidate input selection type imports * Keep queue request capability types in the shared compiler graph * Preserve reopen admission context and bound queue projection work * feat(native-chat): queue follow-ups by default with a toggle * fix(tests): preserve projection contracts in the node compiler * fix(native-chat): retain receipt lookup after journal replacement * test(mobile): assert shared preference renders on real changes * Remove obsolete follow-up option translations * Preserve input places across journal recovery without predecessor snapshots * Keep recovered card placement tied to the exact handoff * Preserve replay source types and correct verification fixtures * Complete indexed queue selection and recovery ordering * Preserve queued input order across recovery and source replay * Fix legacy queue recovery fixture types * Use a specific name for queue pause inputs * Preserve fallback queue identity across journal recovery * Place nested storage negative directive on its constrained call * Constrain journal draft property type parameter * Remove journal input order import cycle * Preserve lazy journal counter reads within line limit * test: preserve legacy conversion and display work contracts * test: align journal refusal and restore accounting contracts |
||
|
Brennan Benson
|
de192f1e96 |
Native chat: Stop turns into Send while you type a follow-up, with a shortcut hint (#36655)
* Turn Stop into Send while the agent works and a draft has text While the agent works, the desktop composer's Stop button becomes the ordinary Send button once the draft holds text or images, and returns to Stop when the draft is empty. It sends like Enter, so it follows the queue setting; Esc still stops. Its tooltip names what Cmd/Ctrl+Enter does instead (steer when queueing is on, queue when it is off), read from the same resolver the send uses, so it is absent wherever the shortcut would send no differently. The Send/Stop decision moves into native-chat-composer-send-state so the pane stays within its size limit. * Tie alternate delivery hints to the composer submission * Combine duplicate composer test imports * Return snapshot results from composer option fixture |
||
|
Brennan Benson
|
a2235ad4b9 |
fix(native-chat): new chats' model picker opens with the full list instead of a partial one (#36646)
* fix(native-chat): show the account's model list while a new folder's own listing runs A new Claude or Codex chat in a folder with no saved model list showed only its remembered model (or nothing) until that folder's model probe finished, then the full list appeared 1-2 s later. Every new worktree and every chat after a restart hit this, because these agents keep one list per folder and the account-level list reads already fall back to was never written. The account's own listing (prewarm names no folder) now also saves that list, and a read whose folder isn't listed yet answers from it, including before its scope resolves. The stand-in names no default as the folder's; the folder's own listing still replaces it. * fix(native-chat): preserve account catalog publication ownership * fix(native-chat): retain scoped account inventory under binding pressure * test: make passive catalog deadline coverage deterministic * test: consolidate catalog fixture type imports * test: repair catalog fixture types and integration placement * fix: retain accepted model catalog authority during refresh |
||
 OrcaWin
|
7556133a5a |
test: remove 266 low-value cases including 11 whole suites (#36717)
* test: remove low-value suites and cases * test: update wall-clock baseline after case removal |
||
|
Brennan Benson
|
07813de4b3 |
Let workers follow up with their own finished helpers (#36663)
* Allow workers to continue their own finished helpers * Own helpers follow takeovers and who holds the agent; refusals after closing a leftover shell say so - A worker's own-helper check now walks back from the caller through follow-ups and through exact pane takeovers recorded in the terminal's ordered owner history, same Run at every hop, so the documented reopen-on-the-same-agent recovery keeps the worker's helpers while a stop in another Run does not. - The helper's owner is the creator of the Dispatch that last took custody of its agent, so a coordinator attempt that never got an agent no longer takes the helper away; a real coordinator takeover still does. With no custody at all the follow-up is refused. - The refusal names the Dispatch the sender addressed (and its latest work when that differs) and says what to do instead. - Follow-ups check nesting depth before placement can close a leftover shell; if a later check refuses after that close was requested, the error keeps its code and cause but says the close was requested instead of claiming no effects. * Cover takeover ancestry, custody ownership and post-release refusals in the helper follow-up CLI test Recovery-flow takeover (live, closed, unreadable history), takeover plus fresh follow-up composition, a stop in another Run, failed coordinator attempts, a real coordinator takeover, depth before and after release, refusals after a leftover-shell close, held-mail follow-through from own and foreign senders, and the ancestry read bound now counting custody-history reads. Error data is asserted, not only text. * A helper that never got an agent stays its requester's When no Dispatch in a helper's lineage ever took custody of an agent, its owner is the creator of the first Dispatch in its follow-up chain (every link read, same Run, no cycles), checked through the same caller continuation as before. A worker can again continue its own helper whose start failed before an agent came up, including after coordinator attempts that also never got one; a real coordinator takeover still blocks it. The round-1 denial for this case is gone. The post-release refusal rewrite names the message convention it relies on. Tests: terminal-create and native setup-gate failures, failed coordinator attempts before a continued worker's retry through both addresses, takeover then an unplaced attempt, coordinator/foreign/missing/cyclic/cross-Run origins, and held mail on a failed coordinator attempt. The CLI fixture moves to a shared test-support file and ownership cases to their own file, which keeps each under the line limits. * A worker reopened on the user's own terminal keeps its helpers The own-helper ancestry also follows an external pane's previous holder. Each check reads the pane's complete assignment history once, from dispatch_contexts through a new full-history index on pane leaf and host (created on every open, so existing databases get it too), reading the exact-host and unknown-host cohorts and joining each holder's own custody row. Custody rows are inserted at acquisition, so original-acquisition rowids order the holders; timestamps and acceptance order are never used. The immediate predecessor is fixed before any check: if any holder lacks its own orderable row (a direct dispatch to the same agent, a backfilled, transferred or unreadable row, an unknown host), no edge is derived. The predecessor must then be the same process, same host and settled, and the walk keeps same-Run-per-hop and its seen set. The derived order lives only for that check. External rows stay external and gain no cleanup. Tests: live and closed recovery on the user's terminal with equal timestamps, composition with a follow-up in a new pane and a takeover, another Run's assignment accepted after but acquired before the recovery, a real direct dispatch in between, replaced process, other host, backfilled and unreadable rows, held mail, a restart with the index rebuilt on an existing database, and read/plan contracts for unrelated history, one long pane chain and two panes joined by a follow-up at N and 10N. Ownership and core test files consolidated. * Find a worker's former custody through its process identity, once per check The own-helper walk no longer scans every custody row's owner history for each ancestor. It reads the Dispatch's own row by owner first; for a former holder it reads the custody rows of that Dispatch's exact process and host through the identity index, keeps the one whose ordered owners name it, and takes the owner right before it. Each identity cohort, decoded owner history and pane order is read at most once per check and dropped when the check returns. The shared former-owner reader and target routing are unchanged. Tests: the call-count contract is replaced by read contracts over the actual SQL: a four-recovery chain reads one identity range visiting one row whether 40 or 400 unrelated Dispatch and custody rows sit beside it, with indexed plans and no former-owner scan; a 3- and 30-step follow-up chain reads one identity range and decodes the same number of histories. * A direct dispatch before a worker no longer cuts it off from its helpers A direct dispatch claims the user's pane in the Dispatch row it inserts, with no worker row and no custody row, so its insertion order bounds where it can sit. The pane history now reads each holder's Dispatch insertion order and whether it has a worker row, treats only that claim shape as a direct claim, and keeps the latest claim's insertion as a floor: an earlier holder is reachable only when it was inserted after every direct claim on the pane. Insertion order is never compared with custody order. Every other holder whose place is unproven still blocks the whole pane, and the floor is computed once per pane per check. Tests: live and closed recovery after a direct dispatch before the worker (also from another Run), the claim between a worker and its recovery blocking only that edge while the next recovery keeps the reopened worker's own helper, a supervised Dispatch without its own custody row still blocking, and the history read contracts extended with old claims and the worker-row probe. * Tighten the helper follow-up CLI tests Drop the coordinator row from the refuse-after-release cases, which takes the same follow-up path as the worker's, and give the three-caller zero-effects case the refusal each caller gets. * Count the former-owner scan's visited rows in the caller read trace * Continue a worker's helpers only through recorded custody, finding each former holder once per check A worker re-placed on a terminal it never held in saved custody no longer inherits helpers from an earlier start there: the pane-history derivation and its index are gone. Former custody is found by exact process through one membership map per identity, so the walk is linear in ancestors and rows. * Pin the narrowed custody walk: one refusal for the user's terminal, linear identity and probe contracts The external recovery tests and their pane-history contracts go. One case pins that a worker re-placed on the user's own terminal is refused its earlier helper with no effects while the coordinator still continues it. The follow-up chain contract now grows both ancestors and same-process rows and bounds field reads and Dispatch probes; the never-placed matrix bounds the walk to the first request. * Use a fixed observation time in the reopened-helper test The provider session's observation time is never read on this path, so the wall clock added nothing but a flaky-test gate failure. * Drive the helper follow-up CLI tests through the runtime's own RPC server The CLI now reaches the test runtime as it reaches the app: through the metadata the real RPC server publishes, its socket, dispatcher and error mapping, instead of module mocks of the runtime client and printer. Recorded SQL rows are parsed into a named row type before their reads are counted. * Type the helper follow-up test traces without assertions The SQL trace spies on each statement method through its own typed signature and reads plan rows as the rows they are; the Dispatch probe trace spies on each read separately; the never-placed matrix picks its requester and corruption by origin. * Type the CLI output spy as a console.log mock instance An instantiation expression over spyOn's overloads named its type, and this vitest's typings reject it; MockInstance names the spy directly. |
||
|
Neil
|
4365547899 | refactor(shared): colocate legacy session child-work projection (#36711) | ||
|
OrcaWin
|
8d475840bf | test: remove 16 low-value suites and 138 individual cases (#36710) | ||
|
Neil
|
893152fa0c | refactor(shared): colocate structured session event coalescer (#36708) | ||
|
OrcaWin
|
fe4595d6d6 |
test: remove 11 low-value suites and 157 individual cases (#36703)
* test: remove low-value suites and cases * test: preserve historical reliability gate evidence |
||
|
OrcaWin
|
a0f75207ce | test: remove 17 low-value suites and 133 individual cases (#36700) | ||
|
OrcaWin
|
1da1099dad | test: remove 14 low-value suites and 241 individual cases (#36693) | ||
 NeilandClaude
|
68a4bfb58f |
fix(runtime-host): Explorer and Source Control load again once a runtime host answers (#36684)
* fix(runtime-host): Explorer and Source Control load again once a runtime host answers After a relaunch with a WSL-host workspace active, both panels read before the host connected: Explorer kept "the Orca server … isn't answering" until Retry, and Source Control kept a clean status until a reload. The runtime status stays verified across the relaunch, so the existing contact-regained signal never fired when the WSL host's connection came up. - subscribeRuntimeHostContactRegained also fires when the environment's WSL host turns ready. - Explorer reloads a failed root on that signal (gated: never boots a stopped distro), as it already does for SSH providers. - Git status polling reads again on that signal. Co-Authored-By: Claude <noreply@anthropic.com> * fix(runtime-host): keep the Explorer's contact retry current from an effect, not render React Doctor flags a ref mutated during render. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> |
||
|
OrcaWin
|
63fc1f11c5 |
test: remove 19 low-value suites and 200 individual cases (#36681)
* test: remove low-value suites and cases * test: shrink stale timeout baseline after removing cases |
||
|
Neil
|
2e3af9aa03 |
fix(wsl): startup CLI reconciliation never inspects distros Orca has no record of (#36683)
At every startup, managed WSL CLI registration reconciliation ran a guest command in every running distro it hadn't inspected recently, including the user's own unrelated distros. That's EDR-noisy and touches environments Orca never set up. It now repairs distros carrying Orca's own registration record, and inspects only distros Orca deployed a WSL host into. |
||
|
Neil
|
de53032ea4 | refactor: group journal body-admission and producer tests (#36682) | ||
|
Neil
|
bbd324a57a | refactor(renderer): group Jira sorting tests (#36677) | ||
|
OrcaWin
|
effa751b93 |
test: remove 10 low-value suites and 130 individual cases (#36672)
* test: remove low-value suites and cases * test: shrink two stale flaky-pattern baseline counts |
||
|
Brennan BensonandClaude Fable 5.1
|
002e975e96 |
Open chats move to the account you switch to, before their next message (#30955)
* fix(native-chat): an open chat moves to the account you switch to before its next message A running chat's agent read its account only when it started, and nothing compared it with the account a start would use now, so open chats kept answering on the old account after a switch. The agent a chat runs now records the account its launch used, and the host's replace-before-the- next-send check replaces an idle one whose account is no longer what a start would use. A chat mid-reply finishes on the old account first. Claude chats follow; agents whose chats keep the account they were created on are never compared. A chat's model-list reads and saves now use the account it runs on, so a moved chat no longer writes its new account's list under its first account (STA-11281). Tracked in STA-11211. * fix(native-chat): declare the launch-account read for the runtime layer that wires the host * fix(claude): find custom chat history before managed-account resume * test(claude): assign the complete custom account home * Preserve unknown account model facts and legacy option replay * Clarify terminal account-switch feedback in translated locales * Keep option mutation plans checked against their contract * Cover unknown model choices across chat consumers * Keep consumer fixtures aligned with canonical types * Match the mobile picker label in its consumer test * fix: clarify terminal scope in translated Claude account settings * Update integration tests for current session and remote client contracts * Keep native worker replies on their receiving account * Preserve receiving accounts across cold starts and nested reports * Preserve the delivery receiver when reading chat commands * Clarify native reply matching and consolidate imports * Resolve catalog scope without re-entering conversation queues Give owned option mutations and delivery settlement a resolved catalog input while external reads acquire scope once. Preserve account routing, catalog lifetime and current response obligations. * Align catalog and mobile test fixtures with current contracts Explain the existing timeout budgets and provide the idle turn identity and truthful model-only picker label in the mobile fixture. * Align receiving-account readers and fixtures with typed contracts * Repair account-switch fixtures and measure receiving work * Use the checked account-home path in catalog tests * Restore executed-option recorder context * Control receiving catalog deadline test clock * Align unknown-model consumer fixtures with send capture * Consolidate session host type imports * Align cross-version catalog fixtures with host read contracts * test(native-chat): bind Runs through the current start authority in receiving fixtures Main now resolves a worker start lazily through bindRun with objective and task references, and creating a Run no longer unbinds a coordinator's earlier Runs; run-use does. The receiving fixtures follow the same production owners so every original scenario, input and bound is exercised unchanged. The receiving runtime subclass moves verbatim into its own support module. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(native-chat): follow the selected account before its folder exists A live Claude chat compared its account against the selected one only after that account's folder passed an availability check, so an account still being set up (or whose setup failed) left the chat silently answering on the previous account, and a resting chat refused its start before preparation could run. The retirement comparison and the start pre-read now ask the router for the selected route as identity, through the existing resolver purposes; catalog, create and probe reads keep checking availability. Preparation, typed launch failure and parking are unchanged. Session History details show the account a chat was last launched under when the host recorded one, else its founding home. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test(ai-vault): build the stale acquisition receipt without a type assertion The History account case now reads the fixture receipt through the typed acquisition reader instead of spreading the record field through a cast; the three assertions and their inputs are unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test(native-chat): narrow the rig acquisition link before relinking it The account-setup cases spread an optional link, which typed its id as possibly undefined; the rig always links a handle, so a guard that cannot fire narrows it. No assertion or input changes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test(native-chat): follow main's chat admission in fixtures and bound the History account projection Chat admission no longer reads an experimental host setting, so the continuation-context test drops the spy main dropped in its own fixtures. The two History consumers that install a minimal chat host give their fake store the record accessor and host id the real store has, since the projection now reads the acquisition receipt. An operation-count contract holds the production History projection to one roster read and one record lookup per owned row at 10 and 100 rows. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test(native-chat): give the declared-effort catalog fake its capture port The declared-effort fixture builds a catalog service without the capture member the options reader asks every catalog for, which failed its desktop, catalog and phone consumers; it now supplies the inert test operation like the other fakes. The History projection contract also drops an unused map parameter. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * Consume main's outcome change feed in the receiving-account index Main's keyed journal records deliver each change after an epoch's frozen prefix as an outcome sequence naming touched keys instead of typed rows. The receiving-account index now re-reads those keys at their current values: queue cards by id, a deleted submission retires its exact notice, and a deleted item drives the existing recovery rebuild, with Stop marks still excluded. The in-process read row exposes the already-persisted queue.cards keys and per-key deletion facts; itemIds and submissionIds keep listing every touched key. The mobile unknown-consumer test mocks MobileSwitch as main's picker test does. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> |
||
|
Neil
|
b69a5c6c7e |
feat(themes): per-folder-name icons in plugin icon themes (#36565)
* feat(themes): per-folder-name icons in plugin icon themes Icon themes could only set one generic folder and folder-open icon, so themes like Material Icon Theme could not give src, docs or tests their own icons. Add VS Code's folderNames and folderNamesExpanded maps. They use the same lowercasing, duplicate checks, own-key records and limits as fileNames, and older Orca builds skip them. Every folder icon now goes through FolderIcon: the explorer, Source Control, diff and conflict trees, and the remote, sparse and symlink pickers. * fix(themes): match the common icon-theme fallback for open folders |
||
|
OrcaWin
|
1afbd1d559 |
test: remove eight low-value suites and 198 individual cases (#36650)
* test: remove low-value suites and cases * test: fix retained timestamps and prune flaky baseline * test: document malformed persisted-provider fixture cast * test: restore types used by retained divergence regressions |
||
|
Neil
|
fdfcfb3551 |
fix(windows): stop each WSL host's server on uninstall so its distro can stop (#36612)
* fix(windows): stop each WSL host's server on uninstall so its distro can stop Uninstall released the holders but left orcad and any live terminals running, which kept the distro (and its VM) up indefinitely. The existing --orca-uninstall-release-wsl-holders preflight now also runs Remove host's teardown for every recorded host whose distro is confirmed running, driven through orcad's own CLI inside the distro: close terminals, count, then the instance-checked decommission that retires an idle daemon. Stopped distros are skipped, each stop is bounded at 15 s, and nothing changes the exit code. NSIS now also launches the preflight when WSL host records exist. Grok removal also cleans the rolling .bak of Orca's hook file. * fix(windows): list up to 1000 terminals when uninstall stops a WSL host * fix(windows): leave WSL host servers running while another Orca install remains The HKCU/HKLM twin shares this userData, its WSL host records and each distro's server. NSIS now adds --orca-uninstall-stop-wsl-servers only when ORCA_OTHER_INSTALL_STATE is none, as the agent-hooks removal already does; the preflight stops servers only with that flag. Holder release is unchanged. * fix(grok): clean the hook backup without sync fs on the quit path |
||
|
Brennan Benson
|
0d94c0ba8f |
Native chat: queue messages sent while the agent works (on by default, Settings toggle, Cmd/Ctrl+Enter to send one now) (#36588)
* Advertise mid-turn queueing as queued-messages.v2 Released clients read the v1 name with an unfinished queue UI; they never see v2 and keep sending immediately. (cherry picked from commit |
||
|
Brennan Benson
|
4a8114375d |
Share chat option writes across desktop and phone (#36624)
* Share chat option writes across desktop and phone * Restore main's failure notice scope for chat option picks Held launch refusals toast again while the transport is still closed, desktop notices follow only the chat's presentation scope so a fence or status change on the same chat still reports, and the phone banner no longer depends on the read record. |
||
|
Brennan Benson
|
1f66a6e5eb |
Release idle renderer completion feed owners (#34987)
* fix(native-chat): release idle completion feed owners * Add braces to completion feed lifecycle checks * Cover completion feed attention and mounted consumer lifetimes |
||
|
Neil
|
55507b87e9 | fix(plugins): link community plugins to the author's repository, not the mirror (#36638) | ||
|
NeilandClaude
|
f5f2ec6749 |
i18n(plugins): translate missing plugin strings in all locales (#36642)
Adds the README link (#36527) and 'Show all N plugins' strings, plus every other plugin UI string still falling back to English, to de, es, fr, ja, ko, pt, ru, tr, zh and zh-Hant. Co-authored-by: Claude <noreply@anthropic.com> |
||
|
Neil
|
98615d3b12 |
plugins: Try it on a syntax plugin opens a blank untitled file (#36637)
Drop the hand-written per-language samples. Try it now opens an empty untitled<first extension> through the existing untitled-file flow, so the grammar highlights what the user types. Custom editors with newFiles keep their template-seeded new file. |
||
|
Neil
|
41c71922a8 | fix(plugins): refresh dev-folder icon themes when SVGs change in place (#36636) | ||
|
OrcaWin
|
9a7068223c |
test: remove nine low-value suites and 147 individual cases (#36629)
* test: remove low-value suites and cases * test: shrink flaky-pattern counts after case removals |
||
|
Brennan Benson
|
233b3dc704 |
Make explicit hosted review refresh fetch current provider state (#36522)
* Make explicit hosted review refresh read current provider state * Name the right provider and keep GitHub's own copy when a Checks refresh fails A failed manual refresh now names the repo's provider (from the review, its link, or the remote), clears once a newer read lands for the panel, never stops GitHub checks and comments from refreshing, and gives way to GitHub's classified sign-in or rate-limit copy. The copy is one interpolated line in every locale. * Read after the write when Orca merges, closes, reopens or edits a GitLab MR Every GitLab merge request write now drops the host's cached review lookups for the repository, and the Checks panel's follow-up read can't join a poll that began before the write, so merging in Orca shows Merged and Delete Workspace without a manual Refresh. A user refresh also forgets Gitea's shared repository scan before reading. * Clear a failed Checks refresh only on a real provider read The host now tells the desktop store, when asked, whether its answer came from a provider read it stored as current or from a cache or last-good fallback. The Checks panel keeps a failed Refresh until such a read lands, a click succeeds, or the context changes. On GitHub the PR read owns the refresh status, so a failed review-card read no longer raises the generic failure. * Don't let a joined host lookup clear a failed Checks refresh A poll that joins a lookup already running for an earlier request didn't start that read, so its answer can't show the provider recovered after the failure. Only the request that started the stored lookup reports a provider read now. The host read also uses the shared reply outcome directly, and the renderer writes the provider-read generation where it publishes the entry. * Type the Checks refresh breadcrumb for every review provider The breadcrumb already received Bitbucket, Azure DevOps and Gitea values; its annotation now says so. Tests build typed fixtures instead of asserting types. * Test the read-outcome reply at IPC, RPC and runtime, and the post-merge read The flag reaches the runtime, and only a caller that asks gets the envelope, including for a definitive null. After Orca merges, the card read starts after the write, and its failure leaves the merge reported as done. * Use a boolean for the empty-state fixture's remote-operation flag * Trim redundant hosted-review refresh tests * Keep the signed-out GitHub empty-state test |
||
|
Neil
|
b45d71bf8d |
plugins: ask "Make sure you trust <publisher>" before installing any non-official plugin (#36271)
* plugins: ask "Make sure you trust <publisher>" before installing any non-official plugin * plugins: show the derived publisher in the install trust dialog * plugins: rebase install trust dialog onto main; register its copy as protected |
||
|
NeilandClaude
|
51e183a08e |
feat(markdown): expand Mermaid diagrams into the pan and zoom viewer everywhere they render (#36575)
Markdown preview, the rich editor and .mmd/.mermaid files now get the same expand button that comment diagrams already had. Co-authored-by: Claude <noreply@anthropic.com> |
||
 Jinwoo Hong
|
bf13e6cc76 |
Guard concise orchestration list output against long text (#36625)
One table-driven test keeps every concise orchestration list row short when stored text is huge. Concise run-list cuts each Run's objective to one line of at most 160 characters; --full is unchanged. |
||
 Brennan BensonandCodex
|
2cc33b8d89 |
fix(native-chat): save each chat change as keyed records and reopen from the newest (#36024)
* Save native chat state and restore only its journal tail Publish versioned reducer checkpoints atomically, checkpoint through the chat write queue, and backfill closed chats without retiring journal rows. Co-Authored-By: Codex <noreply@openai.com> * Keep checkpoint recovery durable and skip unchanged captures * Keep journal timer and restart fixtures compatible with checkpoints * Keep checkpoint performance tests focused on operation contracts * Remove unused benchmark import * Restore journal append interception and control Stop fixture time * Compare saved reducer state without a key assertion * Supply thread scope in checkpoint test appends * Prove restored journal consumer paths * test: exercise restored consumer backward pagination * fix: pace journal backfill with a monotonic clock * refactor: keep journal opening cursor checks together * refactor: project chat journal state in the append transaction Track isolated reducer mutations and persist keyed changes under a savepoint before adopting committed state. Keep appends working through projection lag and repair coverage on the write lane, including legacy bootstrap. Co-Authored-By: Codex <noreply@openai.com> * fix: keep reducer objects live across journal commits The draft isolates every write until COMMIT, then writes each dirty copy back onto its original, so submissions, items and queue cards handed out before a commit keep reading current values as they did with in-place folding. A failed COMMIT still leaves live state untouched. Also replaces banned Reflect.get uses and adds braces the lint rule requires. * fix: bound projection repair and check the invariant after notification Failed publications and savepoints back off from 1 s up to an hour, reset by a healthy incremental write or a reopen. open() no longer waits for a legacy chat's publication; the scheduled repair publishes it on the write lane. A failed open closes its handle. The equality check runs after commit notification, only when projection tests opt in or, log-only and sampled, in development, and it requires the saved coverage to match. Removes the unused streamed commit argument. * fix: keep the background projection pass proportional to chats The orphan sweep reads one state row per chat and clears orphans by session key. A chat whose fold cannot publish stops at its first damage and is skipped until its epoch or newest row changes. * fix: version the keyed projection layout as codec 2 This branch's earlier whole-state layout used version 1; it now decodes to null and the chat replays. * test: follow the append-with-fold contract and deferred publication A submission whose fold throws now rolls back with its receipt before any dispatch, so those sends are refused and nothing is recorded. The unconfirmed continuation outcome is pinned through its real cause: the agent admits the message and no delivery proof arrives. Tests that need saved state right after a chat opens publish it explicitly, the history reload clears the saved state covering its edited row, and the codex stream bound matches its capture. * test: pin projection repair backoff, background pass and N/10N costs Covers the production repair timer under a persistent failure, a legacy open that publishes after it resolves, a failed open leaving no timer, a damaged closed chat skipped until a new row, and equal per-write, reopen, sweep and closed-chat publication work at N and 10N. Projection tests opt into the per-commit equality check. * refactor: inline draft write-back helpers The repo lint bans object-typed parameters; the copy and write-back now run in the closure that already holds the wrapped value. * fix: write a new epoch's saved state in its own transaction New chats, rollovers and rewinds publish the new epoch's projection beside its rows, inside the same statement-only savepoint the append path uses, so they start covered instead of waiting a second for a repair. A projection failure there still keeps the epoch and leaves the scheduled repair to publish it. * fix: keep the sampled development check log-only on any failure A read failing inside the check must not reject an append that already committed and notified. * fix: typecheck the draft copy without closure narrowing Assign the lazily created copy through a local so strict programs that do not narrow a captured variable after ??= still see an object. * test: catch whole-table sweeps and an undecodable projection The sweep contract now records exec statements too and pins its exact keyed statement list, so a NOT EXISTS scan through exec fails it. A projection whose item stops decoding fails the per-commit check on coverage although a full replay still matches. Also fixes two test lint findings. * refactor: drop draft casts the types can carry Overlay maps and sets finish from their own typed touched keys, and present map entries are read through one helper. The two remaining generic boundaries, a draft standing for its object and finishing back to it, carry the repo's SAFETY directive. * test: show a parked damaged chat publishes after a clean epoch replaces it The replacement ends at the parked chat's newest sequence, so only the epoch in the skip key re-arms it. * test: give the seeded queued card its enqueue cursor Production records queuedAt as the cursor before the queue row; the fixture now does too. * fix: catch lagging saved chat state up in atomic pages Repair of a legacy, lagging or undecodable chat, open or closed, no longer republishes the whole chat. One runner folds the rows after the saved coverage onto a private copy of the saved prefix, at most 32 rows or about 1 MiB of row text per page, and commits each page's changed entries with the new coverage in one FULL transaction. That transaction first checks the chat's epoch and the exact saved row the page was folded from, so a page from a retired epoch or a stale base writes nothing. Pages rest between slices, and the saved prefix is decoded in pages too. An open chat runs the pages on its write lane; sends keep committing between them and skip the projection until coverage reaches the tip, then project incrementally again. The background pass hands a chat over to its open owner at a page boundary. Damage parks the chat after the pages before it, and a failed page keeps the committed ones and retries from them on the existing backoff. Whole-chat publication now runs only inside epoch transactions. * test: pin the draft layer's tracked nodes per streamed revision and acceptance A transition now reports how many objects and collections its fold reached. The scaling chat gains accepted sends (receipts and aliases) and waiting, dispatched and returned queue cards at N and 10N. A streamed revision's only growing term is the card scan, one node per card plus each returned card's body; an echo also reads every item with its body and every submission. * test: append the between-pages send by item identity appendItem takes the provider identity, not its key. * test: check every catch-up prefix of the recorded Claude and Codex streams A runner can page single rows, so the recorded streams' aliases, Stop settlement and per-row timestamps are each checked at a committed prefix against a full replay. * test: measure each backfill pass's row reads on its own The parked-chat test counted its own replay checks: 64 pass rows plus 68, 68 and 100 oracle rows made the 300 CI saw. Each timer window is now measured alone, and coverage is read from its saved row, so the unchanged pass reads 0 rows and the re-armed one reads one page. * fix: bound catch-up reads, release the finished prefix, and keep unreadable views - A catch-up page now stops reading rows at the row whose text reaches about 1 MiB, so rows past the budget are never fetched and fetched again; saved-view item and entry pages use the same budget. - An open chat drops its private prefix once coverage reaches the tip and keeps it only across a failed or parked page. - A present current-epoch view this build cannot read (another codec version or corrupt content) is no longer cleared by the first page. Its whole history must fold cleanly through the tip first; otherwise it parks untouched. A storage error while reading the view fails with backoff instead of reading as a missing view. - The pace charges only the runner's own work units, so time spent waiting on an open chat's catch-up or the write lane no longer lengthens the next rest. * test: cover takeover, epoch replacement and stop in the middle of a pass A chat opened while the pass rests is caught up by its own runner from the committed page; the pass pages it no further and does not charge the wait to its pace. A replacement leaves its new view untouched, and a stopped pass resumes after its last committed page. * test: fail the takeover test without the handover break, and the replacement test without the stale-runner guard The takeover test asserts the pass asks the open owner only twice for the handed-over chat, and pins performance.now so the open runner's pace never waits on a fake timer. The replacement now lands while the open runner is resting in its saved-view decode, so its page reaches the lane after the replacement; the test asserts no transaction opens. * test: read saved-view pages with the page budget, and await database closes The paged-decode round trip passes the row-and-text budget and checks the view decoded. Projection, scaling and ACP launch tests await the now-async test database close, so a closing checkpoint worker cannot close the next test's database. * Persist native chat outcomes with a rebuildable cache Store immutable keyed transition results with canonical ordering, fence outcome epochs, and convert legacy inputs through paced invisible generations. Rebuild disposable caches from validated outcomes and read sparse logical sequence groups without changing the wire. Co-Authored-By: Codex <noreply@openai.com> * test: repair the split suites so they parse, lint clean and find their setup Restores the describe blocks the split truncated, the loop variable it renamed, the fixture references and imports it dropped, and a stray argument pair. Moves the grandfathered flaky-pattern counts with the code that moved. * test: read outcome epochs as outcomes where the adapted assertions read input rows A replaced epoch restates its Stop in the saved pause marks, the sparse-group batch test needs an outcome epoch rather than the input-format fixture, and a revised item keeps its first place, so the held-write order is read from the replayed groups. * test: expect saved queue cards as whole values in the queue-history assertions The adapted helpers read card outcomes, which store each card's whole state, so an import or refusal shows as the card's own state change rather than as an input row. * style: format the files this PR changed * test: import each module once in two journal suites * fix: decode saved outcomes with a frozen format-1 schema, independent of the cache codec Outcome values decode through a versioned format-1 schema that never follows the live reducer type; an unknown field reads as saved by a newer Orca, and the cache codec only delegates to it, so a codec bump rebuilds the cache and nothing else. * fix: key outcomes by an integer generation and keep the cache stamp in its state row Each outcome row names its generation, the attempt's id, instead of repeating the chat id, epoch and a UUID; the cache stamp is a column of the cache's own state row, so there is one stamp to keep in step; cache ordinals are text like the outcomes they copy. Orphaned caches are swept from the per-chat state row with indexed per-chat deletes. The WSL census lists both schema files. * fix: finalize queue ownership before publishing a new epoch, and reject unreadable outcome rows Epoch replacement and rollover adopt the committed state, keep attachment claims and finalize the queue receipt before the fallible publication step, as before outcomes. Every persisted outcome row is read back through the row reader, so a row it rejects fails as journal_row_rejected. Publishing an epoch checks the epoch it replaces is still current. A key deleted and re-created in one write moves to the end of the pending changes, matching its new ordinal. * fix: open a chat synchronously and unpaced, and classify read failures by cause A user's open reads the cache or rebuilds from outcomes in one synchronous pass, like replay on main, so no background rebuild can interleave with it and nothing paces or bills it. Only an outcome decode failure is damage; a value from a newer format is refused as newer; storage errors propagate as unavailable. Writes derive cache currency from the stamp instead of a latch and ask the maintenance runner when it lags. * fix: run all journal maintenance through one paced runner per database One runner serves requested chats first, then lagging ones, one catch-up at a time, open or closed, so an open chat keeps its conversion's progress. A busy or replaced chat is skipped and the pass continues; content that cannot convert parks until the chat's rows change; storage failures back off. Background work alone pays the duty cycle. Conversion verifies the whole input once, then only the outcome tail; cache rebuilds copy outcome pages to the moving tip and stamp from the scalar outcomes. * test: adapt journal suites to generation-keyed outcomes, the merged cache stamp and the publication order Queries read outcomes by generation; the bootstrap test expects the queue receipt to finalize before publication; queue-import-scaling states the reopen's constant two key visits when it retries a failed import; append-delivery reads the outcome change index's item ids. * test: pin outcome format 1 with checked-in rows, and cover open consistency, transient reads and re-created keys A golden fixture of format-1 outcome rows covering every field and scalar must restore to the pinned chat; a cache codec bump only rebuilds the cache; an unknown field reads as newer. An open between two pages of a cache rebuild reads the whole chat from outcomes. A transient read error during open is unavailable, not damage, and the next open loads the chat. A key deleted and re-created around a new key in one row keeps live order, written or converted. * refactor: check a converting chat's epoch once, in the catch-up step that runs each page The catch-up reads the chat's epoch in the same synchronous step as the page's transaction, for conversion and cache rebuild alike, so the conversion's second copy of the check is dropped. * test: drive the maintenance runner over a real database, each guard killed by a mutation Startup sweeps, closed chats converted one at a time with a busy chat skipped, an open chat writing between conversion pages, a stop between pages, an epoch replaced mid-conversion, content parked until the chat writes again and then delivered, and a storage failure backed off rather than parked. * test: N/10N contracts for outcome appends, opens, conversion, publication, idle passes, sweeps, tail verify and wire catch-up Each counts statements through prepare and exec, rows read per table and rows and bytes written, never time, and requires the same work for a chat ten times larger: a streamed revision, a Codex plan update and an acceptance; a cached open reads no outcome; a conversion page reads one page of input and publication none; an idle background pass reads no history; a retired generation and an orphaned cache are deleted one indexed page at a time; a second verify reads only the new outcomes; a wire catch-up reads only the groups asked for. * test: shipped builds keep a new or converted outcome chat untouched The newest release refuses the chat as a newer Orca's and leaves every byte of the database as it was; a build from before that reason opens it read-only with nothing shown, refuses writes, and changes no saved row. * test: an epoch publication over an epoch the caller did not see is refused, and damage at row 1 still yields to a newer row Publishing a new epoch checks, inside its transaction, the epoch the caller last saw, and writes nothing when it changed. A chat whose first row is unreadable keeps reading for a newer build's row, as main does, and is refused as a newer Orca's. * test: old-build probes fold input rows only, and the interrupted-call probe writes inputs * test: import the state layout once in the cache test support * fix: type the tail verify's live lookups per collection, and two test call shapes The tail verify looked keys parsed from stored JSON up in a union of live maps, which does not typecheck; each format-1 collection now has a typed lookup that narrows the parsed key first, and the table is checked complete against the format's collection list. * fix: wake the maintenance runner for a request or a due retry ahead of the periodic pass One timer now wakes the runner at the earlier of the next periodic pass and the first due request or storage retry, re-derived from the waiting chats after each pass, so a request after the first pass is served within a second and a backoff retry is no longer replaced by the six-hour pass. A chat whose load swept a retired page keeps its turn instead of waiting for the next pass. Tests drive start(), requests and timers on fake time. * test: pin the draft's tracked nodes per streamed revision and acceptance at N and 10N The scaling chat gains dispatched and returned queue cards. A streamed revision's only growing term is the queue card scan, one node per card plus each returned card's body; an acceptance echo also reads every item with its body and every submission. Main's reducer makes the same scans on these rows; the draft adds one node per value reached. * test: cross-version probes read a new chat's turn end as one outcome sequence, and the kept-card downgrade uses an unconverted chat * fix: store every new write as format-tagged outcome records after an existing chat's rows, with no conversion An existing chat keeps its input rows byte for byte; its first write appends one marker row that shipped builds refuse, and its records follow. New chats hold only their marker and records. Each record carries its own format and the epoch keeps the highest format it holds, checked before a cache is used or anything is written. Opening a chat with an input prefix folds the prefix as main does and applies the records over it, deletions included, keeping prefix keys in place; catch-up pages the prefix rows, then the record groups. Background conversion and its attempts, staging, verification and publication are gone; the maintenance runner rebuilds only caches of chats without a prefix, parks a rebuild on its epoch's records rather than the newest sequence, and looks a requested chat up by its key. * test: pin the marker, prefix-plus-records reopen, record admission before the cache, cache-only runner parking and N/10N work Input fixtures stand for a chat an older build wrote: their input epoch keeps taking input rows, so the input reader still meets writer-made rows; epochs this build founds are written as it writes them. Conversion tests give way to a mixed chat whose prefix keys are deleted, recreated and updated in place, the runner's rebuild parking that later writes never re-arm, and contracts for writing to, opening and rebuilding chats at N and 10N. * fix: refuse a chat whose outcome marker is a newer version as a newer Orca's, not as damage * test: shipped builds refuse an existing chat at its appended marker, its input rows unchanged, and this build reads it whole again The probe writes three items as input rows the way an older build did, then this build's writes append one marker and outcome records; the newest release refuses the chat as a newer Orca's with every byte unchanged, the writable baseline latches read-only at the marker, and the re-upgraded build reads all six items with the prefix rows as they were. * test: read the runner's rebuild instances as rebuilds, so the parked-chat test typechecks * fix: admit saved outcome records and the cache only through a strict storage schema A saved record or cached value holding a key or union tag this build does not declare, at any depth, now refuses the chat as a newer Orca's before the cache is used or anything is written. The storage schema reuses the wire's shared definitions, completes the keys they leave out (failure facts, senders, edit patches and the rest), and closes every object and open union; string vocabularies and opaque payloads keep the wire's meaning. A compile-time check fails CI when a persisted type gains a key storage does not declare, and a checked-in corpus of every declared shape replaces the schema fingerprint, so an added optional key needs no new format. * fix: refuse an input row or legacy card holding a key this build does not declare before folding it Restating a chat on a new epoch is safe only if the open chat holds nothing this build half understands. An input row of a known kind (an existing chat's frozen prefix, with or without outcome records after it) is now checked key by key against what this build declares before main's reader normalizes it, and refuses the chat as a newer Orca's; values keep main's checks and execution options their legacy meaning. A legacy queued card whose saved body holds an undeclared key stays on disk, unadopted, as an unreadable card does. Client sends already arrive through strict request schemas, and their options through a reader that drops choices this build does not use. Main's tests that kept a newer build's unknown body kind, subject or key readable and writable now expect the refusal; the three that drove a newer Orca's approval or item through this build's own writers are removed, since this build can no longer hold one. A checked-in input prefix pins how this build folds older rows, and every value it folds into is one storage admits. * test: a persisted type holding a key storage does not declare, nested included, fails to compile * test: this build refuses a newer build's body or subject kind as a newer Orca's, keeping the row an older build deletes * fix: fold each outcome write from the row a reload reads, so an annotation the reader drops never fails the strict record write An ACP usage report with size 0 (allowed by the protocol) reached the model as an unusable window, the strict encoder refused it, and the agent was stopped mid-turn. Main writes that row and drops the annotation on reload; folding the read-back row keeps live state equal to that reload for every annotation the reader drops. * test: an echo declared without a known original is stored as null, the shape a reload reads * test: probe the downgrade refusal on both releases in the downgrade window, not only the newest * test: both releases in the downgrade window write a Claude and a Codex chat through their own writers, and this build admits every row and opens the chat as that release had it * test: rewind, replacement and rollover of a chat holding old rows, the marker and records keep what the user kept and delete the retired epoch whole * test: phone and paired catch-up over a chat holding old rows then records, from a cursor inside the old rows, draws as the clients render it * test: ACP launch decisions read an outcome chat from its cache and from its records alone, and a newer one as unreadable * Open new and mixed chats from each key's newest record and drop the saved-state cache The cache copied each key's newest record into a second set of tables and needed stamps, a paced rebuild, a savepoint fallback and a repair runner to stay usable. The records' key index already answers the same read: an open seeks from one key to the next, taking each key's newest record (deletions included) and never reading superseded revisions. A mixed chat still folds its frozen input prefix first. A send now writes only its records, the epoch's coverage and its receipt, so any failure among them refuses the send as main's row insert does. The background runner keeps only the paced sweep of retired generations, its one remaining job. The cache tables are no longer created; they never shipped. * Derive an outcome chat's last sequence from its coverage instead of recording it Every write recorded the sequence scalar beside its own records, about half the records on streamed paths. The epoch's coverage already holds it, so a read supplies it from there and a write no longer stores it. Records an earlier build stored still decode. * test: count strict admission per open, catch-up page and write of an existing chat at N and 10N Admission walks each input row it reads once (on top of main's parse), and each outcome record it reads or writes once: the open of a mixed chat walks exactly its prefix rows and admits one record per key, a catch-up page walks one row per input row it returns, and a write walks its row's read-back and admits each record it inserts. Linear in what is read, with a constant of one. * Keep a record that updated a prefix key when a later prefix fold no longer yields that key A tail record with the prefix ordinal is the key's newest value. If a later build's reducer reads the old rows differently and no longer produces that key, the value is appended instead of refusing the whole chat as damaged; only that key's place can change. * Resume each sweep page at the generation it is deleting After a page of records the sweep went back to its start position, so every later page rescanned every live chat's generation numbered below the retired one. It now resumes at that generation; a contract at N and 10N live chats pins that only a pass's first page walks them. * test: the sweeper rests nine times each page's work * Start the retired-record sweep from the chat database the attachments already take The sweep was wired through an optional parameter, so dropping it at the one production caller would have left retired records forever with every test passing. It now runs on the required journal database, and a wiring test checks that installing starts it and stopping ends it. * test: an existing chat whose first write fails keeps no marker, and the newest release still opens and writes it * test: chats the window's releases and the oldest release with this chat database wrote are edited, sent to and rewound by this build as the newest release does Each release writes a Claude and a Codex chat through its own writers. This build opens it, edits a card the old rows hold (its first write: the marker and an in-place update), sends, rewinds (every kept message and card saved again through the strict encoder) and reopens, with every commit restoring to the live chat. The result equals the newest release's after the same steps. The oldest release is resolved from tags, as the window is. * test: the released-chat writer resumes the queue after every Stop it records, and the probe reads each step's result once * test: the released-chat probe checks this build's edit, send and rewind on its own result Comparing the carried chat with the newest release's would fail the required cross-version check for any legitimate main change to those flows until the next release ships. The probe still admits every released row, opens the chat as the release and the newest release do, keeps the release's rows byte for byte with one marker, and restores to live after every commit; after that it checks the edited card, the accepted send and the rewind's survivors. The oldest release with the per-host database is named directly: it never changes. * test: the golden input prefix holds data in every keyed collection Six collections folded empty, so a change to how old rows derive their keys went unnoticed there. Eight rows v1.4.245 wrote through its own journal (an item with an execution owner, a declared echo, a removed turn, and a queued card handed over with carried history, then cancelled in doubt) follow the existing rows unchanged, and the test now requires every collection to be non-empty. * Say once, beside the marker version, that the reading of old rows under it is frozen The fold comment claimed an unheld prefix-ordinal value only moves that key; a prefix read differently can also show a key twice or bring back one the tail deleted. The marker version now states the rule: a build that reads old rows into different keys or values keys that reading off a new marker version, and duplication or resurrection is never intended. * test: the released-chat probe compares what the release wrote, not fields this build adds The open check compared whole snapshots, so a field main starts setting would fail the required cross-version job until a release ships it. It now compares the release's items, sends and cards, in order and by value, allowing added fields; the byte-identity and restore-equals-live checks are unchanged. * test: say why the first-write-failure downgrade test needs a longer timeout * Type the open-union fallback check by schema, not a bare object * Check each outcome-format key set separately so no check reads as a redundant union member * Read an open or branded string as a value in the storage key check, not as an object * Decode each newest outcome record from the value admission parsed, without parsing or walking it again or keeping its text * Match each encoded record to its change by position, so a settlement batch's encode stays linear in its mutations * Encode each changed value as the draft holds it, without reading it through the draft's tracking * test: rewind, replacement and rollover restate a chat with fixed statements and work linear in what they restate --------- Co-authored-by: Codex <noreply@openai.com> |
||
|
Neil
|
7a7f46f8a3 |
fix(wsl): find distros when wsl.exe drops its redirected list output (#35509) (#36616)
On some WSL 3.0.3 hosts `wsl.exe --list` exits 0 with nothing on a redirected stdout. Orca read that as no distros installed and none running, so the project runtime lost WSL and the background-read gates reported a running distro as stopped. When the installed list comes back empty, read the registered distros from the Lxss registry (default first). If the registry has distros, this host loses list output, so running distros are read through a console instead, where wsl.exe still writes them. Only a painted registered name counts: a blank console or the localized none-running text leaves the answer unverifiable, never stopped. Only list calls run, so no distro starts. |
||
|
NeilandClaude
|
97681f3de9 |
feat(wsl): offer a \\wsl.localhost project's distro as a host; explain WSL 1 and empty distro lists (#36615)
* feat(wsl): offer a \\wsl.localhost project's distro as a host, and explain WSL 1 and empty distro lists Co-Authored-By: Claude <noreply@anthropic.com> * fix(wsl): restore the WSL hosts setting when accepting the host offer fails Co-Authored-By: Claude <noreply@anthropic.com> * test(wsl): type the settings update stub with GlobalSettings Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> |
||
|
Neil
|
27a19dbd8f |
perf(terminal): submit at once to a shell idle at its prompt (#36614)
* perf(terminal): submit at once to a shell idle at its prompt * test: name the captured app transcript by role * fix(terminal): require host shell-foreground proof and a clean prompt cycle before skipping the submit settle * fix(terminal): keep the settle for a pane without an identity * fix(terminal): count a failed idle proof toward the submit settle * fix(terminal): refuse a fast submit cancelled during the idle proof * fix(terminal): time the idle proof with a monotonic clock * test: settle writer idle proofs by hand instead of timed promises |
||
|
OrcaWin
|
5edb1b6f9a |
test: remove 14 low-value suites and 119 individual cases (#36617)
* test: remove low-value suites and cases * test: shrink flaky-pattern counts after case removals * test: remove empty suite and stale release workflow fixture |
||
|
Jinwoo Hong
|
8a38328872 |
Keep orchestration list output short (#36622)
Concise task-list rows carry id, status, title and ids only; specs and results stay in --full (407 KB to 11.5 KB text on a 138-task Run). Concise gate-list rows drop resolutions and timestamps. |
||
|
Brennan Benson
|
20a356ec78 | Expire unclaimed chat uploads after seven days (#36597) | ||
|
Brennan Benson
|
84aed85c7c |
Share chat options read ownership across desktop and phone (#36582)
* Share chat options read ownership across desktop and phone * Start a new chat context's options read at once Reads were coalesced on one queue for the whole view, so after a reconnect, provider restart, phone path change or chat switch the current read waited behind the previous context's request, up to the transport timeout. Each attachment now has its own queue: reads still coalesce to one active and one trailing request within a context, while a new context reads immediately and the old context's reply stays inert. Restores the shared option refresh contract and the reopen test to their original expectations. * Let desktop options tests wait for the shared read queue The shared read queue starts a read one microtask after it is scheduled, where the old desktop runner started it synchronously. The selection lifetime and context usage tests now wait for each read to start before asserting on it, keeping every original assertion, including one active and one trailing refresh. The paired server test compares transport targets by value, since the options view memoizes an equal target per environment. * Keep chat support projections stable between options answers Desktop and phone rebuilt the conversation, image and command support objects every render, and a host that omits commands produced a fresh empty list each time. Project them once per accepted answer. * Import options wire types once in the selection reads performance test * Keep chat support visible across a controller change Replacing the selection controller, as a desktop re-pair does, cleared the last accepted support, so slash commands, the goal row and the context meter disappeared until the next options answer. On the phone, returning to a chat before the other chat answered showed fallbacks. The support stays tagged with its session and every consumer already filters by session, so it is now kept, as before the shared owner. * Coalesce phone options rereads across turns and status changes Each new turn or host status change re-attached the phone's options reader, so a quick run of turns sent one parallel options request per turn. These changes now reread within the current context, as on desktop: one request runs and at most one waits behind it, and only the latest answer publishes. A status change that arrives while a read is in flight now waits for that read, which the transport bounds. * Restore the phone status wake assertion and type the burst test commands A refused pick is dropped rather than kept as a finished operation, and the path change replaced the options record, so no revalidation read is in flight when the status wake arrives. The wake therefore reads at once, as the original test asserted. The burst test's superseded answer now carries a real conversation command. |
||
|
Jinwoo Hong
|
6c2fde67f5 |
Let send talk to a worker in any state, reopening closed workers for follow-ups (#36533)
orca orchestration send --to dispatch:<id> now works whatever the worker's state: a working worker reads it now; a finished worker still open gets it as a follow-up Task in place; a closed worker is reopened in its saved conversation, or started fresh with the earlier task and report when no conversation is saved. Unread mail at worker_done becomes a follow-up automatically. An older paired server refuses send to a finished worker with an update message. |
||
 Jinjing
|
93f8583033 |
Render CodeRabbit review icons in git comments (#36198)
* Render CodeRabbit review icons locally in git comments - Replace trusted external SVGs with themed Lucide icons - Suppress picture sources to prevent remote image fetches * Fix code review icon rendering in git comments |
||
|
Neil
|
1bd6718548 |
test(wsl): time the lane's first output without the agent-paste Enter settle (#36598)
* test(wsl): time the lane's first output without the agent-paste Enter settle terminal.send with enter:true waits 500 ms before Enter so agent TUIs do not take it as part of a paste; no keystroke pays that, but every lane first-output number did. Send the probe with its Enter inside the text, record time to the shell prompt as its own field, and poll at 25 ms. Stopping orcad now checks the pid's command line names the active slot and tolerates an orcad that already exited. * test(wsl): count only orcad-cold runs that stopped a live orcad A run whose stop found no live orcad for the active slot measured a warm reconnect; keep it out of orcadCold, report how many were attempted, and fail if none stopped one. Rename time-to-prompt to first screen output, since a login banner may come first. * test(wsl): count an already-exited orcad as stopped; name first output plainly stopOrcadKeepingDistro now tells an exited orcad (no pid, or no such process) apart from a live pid whose command line does not name the slot: the first counts as stopped, only the second is excluded from orcadCold and reported as excludedNotStopped. Rename the first-screen field to timeToFirstOutputMs. * test(wsl): count orcad as down only on evidence, never on a missing record GONE now needs a known active slot and a numeric pid file whose process no longer exists; a missing or malformed record answers UNKNOWN, which is not counted as stopped. |
||
|
OrcaWin
|
72104bfc64 | test: remove low-value fixture and forwarding suites (#36600) | ||
|
Jinwoo Hong
|
99cddd9796 |
Name worker-keep-open in the orchestration recovery reference (#36599)
The recovery reference now names worker-keep-open instead of the renamed worker-retain. Guide wording only. |
||
|
Jinjing
|
ec6073093a | Soften dark mode foreground text contrast (#36595) | ||
|
Jinwoo Hong
|
47b7af097c |
Add --spec-file and one keep-open name to orchestration worker commands (#36545)
worker-start and task-create take --spec-file <path> (or - for stdin). worker-start --keep-open keeps a worker open after it finishes in one step, and worker-keep-open replaces worker-retain (kept as a hidden alias). Concise text output escapes terminal control characters in worker-written values. |
||
|
Jinwoo Hong
|
48a1c512e3 |
Always submit an orchestration wake once it has been typed (#36511)
Once Orca has typed a wake line into an agent terminal, it now always sends the Enter, even if the mail was read during the short delay before it. Previously the Enter was skipped and the typed line stayed in the composer, where it counted as a user draft and held later wakes. |