Commit Graph
5 Commits
Author SHA1 Message Date
OrcaWinandOrcaWin a9a0e8cd21 test: remove shallow catalog, browser and launch checks (#41258)
* test: remove routine native and catalog suites

* test: remove shallow browser, bridge and CLI checks

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-11 14:44:15 -08:00
Brennan Bensonandtemp_final_v5 ac9e854c04 Settings and launch menus list your account models (#40175)
* Share account model lists across Settings and launch menus

Use one surface-aware model policy and demand-driven catalog acquisition for Settings defaults and new-agent menus. Preserve literal saved selections, native invocation boundaries, and older-host listing reads.

Co-authored-by: temp_final_v5 <73724370+qq2144@users.noreply.github.com>

* Keep model menus scoped, responsive, and editable

* Keep model menus stable while host listings refresh

Retain applicable listings through refresh failures, preserve host availability metadata, and distinguish unlearned registration from known absence. Show Settings pending choices without blocking discovery, scope the fallback note to failed demand, and register its translations. Verify the structured phone reader and menu wrapper share the composer policy without changing phone presentation.

Co-authored-by: temp_final_v5 <73724370+qq2144@users.noreply.github.com>

* Keep retired model lists out of reopened menus

Keep completed empty and unknown workspace answers in the shared snapshot cache so successor menu owners cannot seed older account or workspace models. Derive observer state from that cache and remove the duplicate owner retirement guard. Extend the lifecycle regression through last unsubscribe, owner replacement, failed reopen and a fresh replacement answer.

* Preserve catalog answers across scope and owner changes

* Reuse unchanged model catalog projections

* Keep new-chat model placeholders scoped to their own catalog

* Use the launched surface’s model catalog in Settings and launch menus

Select protocol sources before applying the shared model-menu policy. Keep Antigravity CLI and Chat answers independent, route discovery through the actual host/runtime, and clear menu-owned effort only on an explicit model-only replacement.

Co-authored-by: temp_final_v5 <73724370+qq2144@users.noreply.github.com>

* Keep paired launch mock clearing out of hook cleanup

Co-authored-by: temp_final_v5 <73724370+qq2144@users.noreply.github.com>

* Bound catalog invalidation epochs by host and agent

* Keep CLI fallbacks out of terminal choices and suppress unchanged listings

* Acquire terminal catalogs only for consumers of that surface

* Restore setup panel explanations

* Reuse settled CLI catalogs in Settings menus as well

* Discover models in the terminal agent execution runtime

* Exercise catalog demand and retire regression fixture observers

* Use the visible draft rather than its default for CLI demand

* Keep discovery runtime fixture independent of Electron paths

* Share effective terminal execution selection with PTY planners

* Separate workspace inventory resolution from launch preparation

* Use read-only worktree projection for terminal inventory selectors

* Preserve PTY context precedence without redundant default-distro reads

* Declare the read-only selector on the runtime construction boundary

* Add terminal model discovery without changing Git discovery routing

* Revalidate held terminal model lists on demand after ten minutes

* Classify legacy model fallbacks from agent probe metadata

* Repair terminal catalog boundary test harnesses

* Refuse foreign execution owners in terminal model discovery

* Resolve model menu validation failures

* Restore terminal model discovery in the new-tab menu

* Repair model menu CI test boundaries and fixtures

* Restore settings read bound across picker generations

* Keep discovery registration and selected-agent admission reliable

* Assert the terminal discovery response envelope after reopening

* Keep model discovery reads and waits in their own phases

* fix: retain model discovery through demand-owned phase transitions

* fix: ignore obsolete model catalog job completions

* Keep Settings model labels through unchanged settings refreshes

* Show idle Settings model labels before opening discovery

* Trim low-value model menu tests

* Move terminal model discovery to its own branch

* Use host model catalog replies directly

* Keep Settings display scoped to its current source

* Assert the saved model displayed text

* Refresh paired launch defaults on reopen and preserve legacy reads

* Narrow merged Settings rows and type the catalog fixture

---------

Co-authored-by: temp_final_v5 <73724370+qq2144@users.noreply.github.com>
2026-11-11 10:45:28 -08:00
OrcaWinandOrcaWin 3c7d1e1675 test: remove 263 low-value cases across 20 suites (#41144)
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-11-11 04:05:46 -08:00
Brennan Benson abc8850180 Choose an agent setup from the new tab menu (#34728)
* Unify dedicated agent launch choices and argument badges

* Enable action model and effort menus with argument migration

* Bound argument choice edit range processing

* Preserve independent action effort through launch and migration

* Preserve literal config arguments and explicit launch permissions

* Respect repository action argument groups and share launch controls

* Remove duplicate action launch command coverage

* Add agent setup search and controls to the new tab menu

* Show inherited choices beside picker reset options

* Keep terminal Arguments separate from shared launch choices

* Launch default agents from rows and select resolved setup values

* Keep terminal settings available while Chat defaults load

* Reuse existing launch setup controls and Arguments editor

* Unify Source Control action choices and repository overrides

* Use precise types in action choice contracts

* Consolidate action choice test imports

* Correct action choice types and integration test boundaries

* Complete prepared terminal test result contract

* Align action integration expectations with canonical choices

* Keep launch defaults authoritative and couple CLI controls

* Assert production Chat preparation runs in launch contract

* Preserve alternate Chat launches and bound picker argument derivation

* Publish committed picker priority and satisfy control contracts

* test(mobile): type the file preview retry test helpers so the test typecheck passes (#35431)

(cherry picked from commit 0774fc9373)

* fix: keep picker integration tests within compiler boundaries

* fix: revalidate completed picker defaults on reopen

* test: give exported launch fixture mocks portable signatures

* fix: keep fallback launch carriers out of action mode controls

* Preserve Fast argument badges outside dialog mode controls

* Project existing Fast carriers independently of model capabilities

* Keep setup focus during launch row pointer transitions

* Allow declared tier choices without an inherited selection

* fix: place agent setup beside the launch menu

* Commit edited action arguments before planning and launch

Reconcile deliberate raw edits once into the submitted action recipe so replacement model and effort flags reach Save and Start together. Preserve captured sources and untouched load conflicts.

* Name portable Source Control dialog fixture results

* Keep agent setup contained and preserve known argument policy

* Use checked style properties in popup geometry fixture

* Keep setup scrolling inside a plain content wrapper

* fix(agent-picker): match the setup panel to the approved layout

Flush model search and list, one settings section with label-left rows
(Effort, compact Permissions menu, Fast mode), a fixed Arguments
disclosure row with its hint, and a summary footer with Launch chat /
Launch terminal. Settled defaults with nothing chosen keep the model
list and Effort pickable. Hovering another menu row no longer closes
the open panel.

* fix(agent-picker): use primitive-owned spacing and update launch labels in tests

* fix(agent-picker): add panel labels to localization catalogs

* Keep one launch setup open and align picker spacing

* Tighten launch model rows and clarify terminal hint

* Keep keyboard focus in replacement launch setup

* fix(tab-bar): keep a long agent setup result's chevron inside the menu

* test(agent-picker): wait for outgoing focus cleanup event

* Show empty model search feedback and name setup dialog

* test: register selection catalog in launch guard fixture

* fix(agent-picker): retain setup drafts and contain Arguments

* fix(agent-picker): retain authored setup route after alternate launch

* style(agent-picker): use a ghost setup chevron with divider

* style(agent-picker): apply muted color to setup glyph

* test(agent-picker): declare retained catalog default
2026-10-29 20:17:26 -07:00
Brennan Benson f06f737802 Unify Source Control action permissions and card layout (#30449)
* Source control actions start chats and terminals on their saved model

A "start an agent" action's model lived only in free-text CLI arguments, which a native chat
never reads, so AI Fix opened a chat on the default model. Each action now saves a structured
model and effort that both routes apply: chat create options, or the agent's own flags in a
terminal (winning over the same flag in CLI arguments). Desktop, dialog, fix-checks and mobile
launches carry it; Settings rows get Model/Effort selects and the CLI arguments field says it is
terminal-only.

Tracked in STA-11102.

* Name the model in the repository override note

* Type the dialog's model hand-off; keep Agent in English in Japanese copy

* fix: preserve action chat model choices through launch

* Preserve action selection ownership across chat launches

* Keep terminal host contract fixtures aligned with preflight

* fix: wait for action Settings agent inventory

* fix: consolidate direct agent routing imports

* fix: use standard action option labels

* fix: align action launch contracts with shared types

* fix: sync action option localization metadata

* test: provide action Settings inventory in mounted fixtures

* Keep action options row height stable while loading

* Let each Source Control action choose its chat permission mode

An action's saved chat choice may now carry a permission mode, with or without a model;
"Same as new chats" saves nothing. A model is replaced only when the action names one,
so a permission-only choice keeps the chat's remembered model and options.

* fix(native-chat): leave older hosts their own permission mode and keep action options readable

- An action's saved permission mode is sent only to hosts that advertise
  agentSession.create.options-mode.v1. Older hosts get no mode, in create
  options or a later setOption, so the chat starts on that host's new-chat
  default, as a phone launch to such a host already does. Hosts from
  1.4.225 to 1.4.227 refused a mode their tables lacked (OpenCode, Grok,
  OMP), leaving the action unable to start.
- Settings action rows give Model and Permissions full rows in the options
  column so saved values are readable; the loading placeholder reserves the
  same rows.
- Remove two unused locale keys; fix two stale comments.
- Tests: the older-host create carries no permission mode; a permission
  mode picked alone keeps the remembered model on an acquired create.

* fix(settings): reserve one options row while loading an action with nothing saved

Terminal and permissions-only rows no longer shrink when loading ends; a chat
agent with a model list may grow by its Model row once known.

* fix(native-chat): keep the create options mode a checked literal type

* fix(settings): share verified action option fields

* fix(settings): keep action selectors on standard typography

* Keep the launch files under their length limits after the main merge

The structured route imports its result types where they are defined, and the two older-host
action-launch tests share one setup helper.

* One action settings section for chat and terminal launches

A Source Control action's Model, model options and Permissions now apply whether it opens a
chat or a terminal; terminals receive them as the agent's own flags, and a repository's own
CLI arguments keep the flags it sets. Extra CLI arguments stay terminal-only.

* fix(source-control-ai): one terminal projection for saved action choices

Ask in a terminal now states its permission instead of leaving it to the
user's own config: Claude and Grok pass --permission-mode default, Codex
passes -a on-request -s read-only -c approvals_reviewer="user" (the
interactive CLI has no untrusted policy, so a read-only sandbox is what
asks before edits). Agents whose CLI has no flag for a mode show the
existing "Applies to chats only" hint.

The strict launch-preferences projection now requires the launch agent at
every caller, composes model ids through the resolver's own step, carries
a mode only where the agent's terminal has a flag for it, and the local
string wire keeps booleans as 'true'/'false', so Cursor Thinking/Fast reach
the terminal and an OpenCode permission-only choice is not refused.

The argument parser knows flag arity, so removing a boolean permission
flag keeps other options' values, following positionals and '--'.
Pre-admission and executor share one terminal admission check on the
options the terminal will receive. Customize with Save launches the recipe
as it will resolve once saved; legacy partial repository overrides are
edited as the complete recipe they resolve to. Empty Extra CLI arguments
start collapsed.

* fix(source-control-ai): an edited repository action saves complete

Every Settings edit of a repository action (agent, model, permission,
prompt or arguments) now starts from the complete recipe the action
resolves to, whether its stored override is owned or a legacy partial.
The resolved agent selection is kept (never an agent only detected to run
a default), an explicit null args clear stays null, and empty args stay
empty instead of being dropped. Clearing the last preference therefore
means the action agent's own defaults rather than re-inheriting Global.

The action text draft is lossless: unset or cleared prompt and args stay
so until the user types, and the inputs show them as empty, so saving a
prompt no longer writes empty args that suppress the agent's default
flags. Untouched sibling actions are not rewritten by the edit.

* fix(settings): style the Extra CLI arguments toggle through Button's own variant and size

CI's changed-code quality check refuses restyle classes on Button and
CollapsibleContent. Use the ghost variant at size xs with a margin, and
put the content spacing on a plain inner wrapper.

* fix: keep saved action and restart launch recipes consistent

* fix: describe inherited arguments and chat-only permissions accurately

* test: check repository action settings fixture type

* test: map saved action options into terminal compiler inputs

* fix: retain saved action controls during agent detection

* fix(i18n): retire obsolete Portuguese action labels

* test: align folder launch fallback mock with outcome export

* fix: carry resolved connector launch intent and mode together

* test: pin shared action launch branches to recorded agent output

* test: preserve saved source control choices through detection and migration

* test: align launch fixtures with integrated result contract

* test: retain recipe and restart contracts after main integration

* Unify Source Control action permission settings

* Keep native Ask copy with its owning change

* Preserve action drafts and old-host permission intent

* Consume rejected Source Control action saves

* Follow the moved Settings persistence fixture

* Keep permission integration contracts in the cross-version test project

* Include the action permission inheritance label in English catalogs

* Align launch contracts with shared permission recipes

* Keep Source Control action controls within their Settings columns

* Use primitive variants for compact action settings controls

* Show action arguments only for terminal defaults and widen recipe rows

* Apply terminal-only action arguments visibility to repository overrides

* Align action permission control with model controls

* Use shared settings label for action permissions

* Hide action model controls until argument migration ships
2026-10-26 16:01:56 -07:00