Files
orca/mobile/src/platform/native-pdf-view.ts
NeilandKelvin Amoaba 5d61e00c6d build(mobile): upgrade to Expo SDK 58 and React Native 0.88 (#37935)
* build(mobile): upgrade to Expo SDK 58 and React Native 0.88

Expo 58 drops Zod from @expo/cli, which clears the last Zod 3 advisory
(GHSA-mrhx-c7xc-m3w5) in mobile along with its local patch and override.

- Expo 55 -> 58, React Native 0.83 -> 0.88, React 19.3, gesture-handler 3,
  webview 14, reanimated 4.7, worklets 0.13 (SDK 58 bundled versions,
  pinned below today's batch to respect minimumReleaseAge).
- Port the react-native and react-native-webview patches unchanged; drop
  expo-constants, expo-notifications, @expo/cli, expo-router, zod and
  query-string patches plus the zod/query-string/xcode>uuid overrides,
  which upstream fixed or no longer need.
- iOS minimum rises to 16.4 (Expo 58 / RN 0.88 requirement).
- Migrate to RN 0.88 strict types: instance ref types, NamedStyles,
  AppState.currentState, list header/footer nulls.
- Replace removed runtime APIs: InteractionManager -> idle callback with a
  macrotask fallback; StyleSheet.absoluteFillObject -> absoluteFill;
  FileHandle.readBytes -> readBytesSync (it became async).
- Resolve react-native/asset-registry for shared assets in Metro and alias
  the old registry path for react-native-svg in the desktop mobile-web bundle.
- Reduce the iOS scene plugin to the reconnect override; Expo 58's template
  now ships the scene delegate itself.

* fix(mobile): bridge react-native-svg web imports and libsodium runtime for RN 0.88

- Share react-native-svg web shims between the mobile-web build and its render
  checks: map the old asset-registry path to react-native-web's registry and stub
  the Android-only touch-sound TurboModule.
- Patch react-native-libsodium 1.7.0 to read the JSI runtime from the bridge proxy;
  RN 0.88 removed RCTCxxBridge.runtime.

* fix(mobile): use Expo 58's legacy promise resolver for audio permissions

* fix(mobile): skip null handles in the RPC recording timer shims for RN 0.88 types

* style(mobile): format MobilePRSidebar after rebase

* fix(mobile): name RN 0.88 text input refs for declarations; allow queued back in stack render check

- Type text input refs with an exported interface so declaration emit can name hook results
  (RN 0.88 aliases TextInputInstance to an unexported class).
- Expo Router 58 drains back() after a commit; check the interrupted push's exit from the
  frame it starts, bounded to three frames of lag.

* chore(mobile): justify the text input handle interface for React Doctor

* chore(mobile): use a nameable intersection alias for text input refs

* fix(mobile): use sync expo-file-system writes, copies and moves on Expo 58

Expo 58 made File.write/copy/move and FileHandle.writeBytes return promises.
Our callers never awaited them, so failures escaped their try/catch and the
store's tmp-then-move and PDF writes could race their close or rename.

* build(mobile): raise the page bundle budget to 10 MiB for Expo 58

Expo 58 adds about 310 KB to the page: expo-router (+258 KB, now carrying
React Navigation, net about +110 KB) and Reanimated 4.7 (+152 KB). Main had
85 KB of headroom left. 10 MiB still stays within the 10 MiB per-asset contract.

* fix(mobile): drop the window-metrics seed RN 0.88 removed from Android

RN 0.88 no longer holds window metrics: DeviceInfoModule reads the activity's
WindowMetrics on demand and setWindowDisplayMetrics is gone, so MainActivity
no longer compiled. Layout scale still comes from the screen metrics we reseed.

---------

Co-authored-by: Kelvin Amoaba <97001695+AmoabaKelvin@users.noreply.github.com>
2026-11-11 23:30:02 +00:00

108 lines
3.6 KiB
TypeScript

import { useCallback, useLayoutEffect, useMemo, useRef } from 'react'
import { Platform } from 'react-native'
import { File as FsFile } from 'expo-file-system'
import { useFocusEffect, useNavigation } from 'expo-router'
import { presentPdf } from '../../modules/orca-mobile-web-shell/src'
import { getRuntimePathBasename } from '../../../src/shared/cross-platform-path'
import { PDF_MIME_TYPE } from '../files/mobile-file-media'
import {
downloadMobileFileMedia,
MobileMediaHostOutdatedError,
type MobileMediaSink
} from '../files/mobile-file-media-download'
import {
pdfViewParamsSchema,
type BridgePdfOpenParams
} from '../mobile-web-shell/bridge/bridge-native-verbs'
import { BridgeNativeVerbRefusedError } from '../mobile-web-shell/bridge-host-errors'
import { scopeRpcClientToExecutionHost } from '../worktree/execution-host-scoped-rpc-client'
import { useHostClient } from '../transport/connection/host-client-hooks'
import { discardUnreturnedMediaFile, freshCacheFolder } from './native-media-device'
import type { RpcClient } from '../transport/rpc/rpc-client-contract'
function pdfFileSink(file: FsFile): MobileMediaSink {
file.create({ overwrite: true })
const handle = file.open()
return {
append: (bytes) => handle.writeBytesSync(bytes),
finish: () => {
handle.close()
return Platform.OS === 'android' ? file.contentUri : file.uri
},
dispose: () => {
handle.close()
discardUnreturnedMediaFile(file)
}
}
}
export function createNativePdfViewer(
readClient: () => RpcClient | null,
isFocused: () => boolean
) {
let current: AbortController | null = null
const open = async ({
worktreeId,
relativePath,
executionHost
}: BridgePdfOpenParams): Promise<Record<string, never>> => {
if (!isFocused()) {
throw new Error('the PDF page is not focused')
}
const client = readClient()
if (!client) {
throw new Error('no desktop connection to download the PDF from')
}
current?.abort()
const controller = new AbortController()
current = controller
const folder = freshCacheFolder('orca-pdf')
const uri = await downloadMobileFileMedia(
executionHost ? scopeRpcClientToExecutionHost(client, executionHost) : client,
{ worktreeId, relativePath, mimeType: PDF_MIME_TYPE },
pdfFileSink(new FsFile(folder, getRuntimePathBasename(relativePath))),
controller.signal,
() => {}
).catch((error: unknown) => {
throw error instanceof MobileMediaHostOutdatedError
? new BridgeNativeVerbRefusedError('native_pdf_host_outdated', error.message)
: error
})
if (controller.signal.aborted) {
throw new Error('the PDF open was cancelled')
}
await presentPdf(uri)
return {}
}
return {
serve: async (params: unknown): Promise<Record<string, never>> => {
const request = pdfViewParamsSchema.parse(params)
if (request.action === 'open') {
return open(request)
}
current?.abort()
return {}
},
dispose: () => current?.abort()
}
}
// A replaced, closed or covered shell must not have a viewer pop up over whatever screen comes next.
export function useNativePdfViewer(
hostId: string,
sessionId: string | null
): (params: unknown) => Promise<unknown> {
const { client } = useHostClient(hostId)
const navigation = useNavigation()
const clientRef = useRef(client)
useLayoutEffect(() => {
clientRef.current = client
}, [client])
const viewer = useMemo(
() => createNativePdfViewer(() => clientRef.current, navigation.isFocused),
[navigation, sessionId]
)
useFocusEffect(useCallback(() => () => viewer.dispose(), [viewer]))
return viewer.serve
}