mirror of
https://github.com/stablyai/orca.git
synced 2026-09-24 00:02:24 +00:00
Jinwoo-H
fc1836ede1
A second reviewer, working from the commit before the last two fixes, found the same holes independently and one new one: an insert shape the parser does not recognise matched no branch at all. `INSERT INTO relay_cells ... SELECT` fails the VALUES form, is not an UPDATE or DELETE, and is not a SELECT, so it produced no report, no stand-down, and no trace -- it simply vanished. For a guard whose whole product is the meaning of its silence, a statement that falls through every branch is the one failure it cannot have. Any insert into the table that the tuple parser does not read now reports, and a multi-row VALUES stands down rather than recording only its first tuple. That direction matters: on the insert path a missing `held` entry does not lose a report, it INVENTS one on the next write naming the row, which would put a false positive into the signal this ships to keep clean. Neither shape exists in relay today, and the census would flag a new INSERT site before it reached here.