orca/tests/e2e/ssh-config-host-picker.spec.ts

/**
 * E2E: Add SSH host → Fill from ~/.ssh/config picker (isolated HOME + real ssh -G).
 * Plan cases: P1, P2, P3, P4, P8 (+ N3 with P3). Bulk/import: ssh-config-host-import.spec.ts.
 */

import type { ElectronApplication } from '@stablyai/playwright-test'
import { expect, test } from './helpers/orca-app'
import { waitForSessionReady } from './helpers/store'
import {
  addSshHostFormFields,
  buildSshConfigBody,
  closeOpenDialogs,
  configHostRow,
  expectSshHostListedInSettings,
  hostEndpointSummary,
  makeSshConfigHostPrefix,
  openSshConfigHostPicker,
  openSshHostSettings,
  removeSshTargetsByPrefix,
  seedIsolatedSshConfig,
  type SeededSshConfigHost
} from './helpers/ssh-config-host-picker'

// Why: afterEach deletes every target carrying this prefix; workers loading the
// module in the same millisecond must not collide on a shared Date.now().
const HOST_PREFIX = makeSshConfigHostPrefix()

function pairHosts(prefix: string): { alpha: SeededSshConfigHost; bravo: SeededSshConfigHost } {
  return {
    alpha: {
      alias: `${prefix}-alpha`,
      hostname: `${prefix}-alpha.example.test`,
      user: 'deploy',
      port: 22
    },
    bravo: {
      alias: `${prefix}-bravo`,
      hostname: `${prefix}-bravo.example.test`,
      user: 'alice',
      port: 2222
    }
  }
}

async function seedPairConfig(
  electronApp: ElectronApplication,
  prefix: string
): Promise<{ alpha: SeededSshConfigHost; bravo: SeededSshConfigHost }> {
  const hosts = pairHosts(prefix)
  await seedIsolatedSshConfig(electronApp, buildSshConfigBody([hosts.alpha, hosts.bravo]))
  return hosts
}

test.describe('SSH config host picker', () => {
  test.beforeEach(async ({ orcaPage }) => {
    await waitForSessionReady(orcaPage)
  })

  test.afterEach(async ({ orcaPage }) => {
    await closeOpenDialogs(orcaPage).catch(() => undefined)
    await removeSshTargetsByPrefix(orcaPage, HOST_PREFIX).catch(() => undefined)
  })

  // ── P1 ─────────────────────────────────────────────────────────────
  test('P1: empty config shows empty state; Back returns to blank form', async ({ orcaPage }) => {
    // Isolated HOME has no ~/.ssh/config by default.
    const picker = await openSshConfigHostPicker(orcaPage)
    await expect(picker.getByRole('heading', { name: 'Choose from ~/.ssh/config' })).toBeVisible()
    await expect(picker.getByText('No hosts in ~/.ssh/config')).toBeVisible()
    await expect(
      picker.getByText('Add a Host entry there, or go back and type the details manually.')
    ).toBeVisible()
    await expect(picker.getByRole('button', { name: 'Add all to Orca' })).toBeDisabled()

    await picker.getByRole('button', { name: 'Back' }).click()
    const form = orcaPage.getByRole('dialog', { name: 'Add SSH host' })
    await expect(form.getByRole('heading', { name: 'Add SSH host' })).toBeVisible()
    const fields = addSshHostFormFields(form)
    await expect(fields.host).toHaveValue('')
    await expect(fields.username).toHaveValue('')
    await expect(fields.label).toHaveValue('')
  })

  // ── P2 ─────────────────────────────────────────────────────────────
  test('P2: seeded hosts list with summary lines and Add all enabled', async ({
    electronApp,
    orcaPage
  }) => {
    const hosts = await seedPairConfig(electronApp, HOST_PREFIX)
    const picker = await openSshConfigHostPicker(orcaPage)

    const hostList = picker.getByRole('list', { name: 'SSH config hosts' })
    await expect(hostList).toBeVisible()
    await expect(configHostRow(picker, hosts.alpha)).toBeVisible()
    await expect(configHostRow(picker, hosts.bravo)).toBeVisible()
    await expect(
      hostList.getByText(hostEndpointSummary(hosts.alpha), { exact: true })
    ).toBeVisible()
    await expect(
      hostList.getByText(hostEndpointSummary(hosts.bravo), { exact: true })
    ).toBeVisible()
    await expect(picker.getByRole('button', { name: 'Add all 2 to Orca' })).toBeEnabled()
  })

  // ── P3 + N3 ────────────────────────────────────────────────────────
  test('P3: select host prefills form; Save persists; N3 identity hint', async ({
    electronApp,
    orcaPage
  }) => {
    const prod: SeededSshConfigHost = {
      alias: `${HOST_PREFIX}-prod`,
      hostname: 'prod.example.test',
      user: 'deploy',
      port: 2222
    }
    await seedIsolatedSshConfig(electronApp, buildSshConfigBody([prod]))

    const picker = await openSshConfigHostPicker(orcaPage)
    await configHostRow(picker, prod).click()

    const form = orcaPage.getByRole('dialog', { name: 'Add SSH host' })
    await expect(form.getByRole('heading', { name: 'Add SSH host' })).toBeVisible({
      timeout: 10_000
    })
    const fields = addSshHostFormFields(form)
    await expect(fields.host).toHaveValue(prod.hostname, { timeout: 15_000 })
    await expect(fields.username).toHaveValue(prod.user)
    await expect(fields.port).toHaveValue(String(prod.port))
    await expect(fields.label).toHaveValue(prod.alias)
    await expect(fields.identityFile).toHaveValue('')
    // N3: empty Identity file explains multi-key resolve from config.
    await expect(
      form.getByText(new RegExp(`Left empty on purpose:.*${escapeRegExp(prod.alias)}`, 'i'))
    ).toBeVisible()
    await expect(
      orcaPage.getByText(new RegExp(`Filled from ${escapeRegExp(prod.alias)}`, 'i'))
    ).toBeVisible({ timeout: 5_000 })

    await form.getByRole('button', { name: 'Save' }).click()
    await expect(form).toBeHidden({ timeout: 10_000 })
    await expect(orcaPage.getByText('SSH host added.')).toBeVisible({ timeout: 5_000 })

    const sshSection = await openSshHostSettings(orcaPage)
    await expectSshHostListedInSettings(sshSection, prod)
  })

  // ── P4 ─────────────────────────────────────────────────────────────
  test('P4: filter narrows host list', async ({ electronApp, orcaPage }) => {
    const hosts = await seedPairConfig(electronApp, HOST_PREFIX)
    const picker = await openSshConfigHostPicker(orcaPage)

    await expect(configHostRow(picker, hosts.alpha)).toBeVisible()
    await expect(configHostRow(picker, hosts.bravo)).toBeVisible()

    const filter = picker.getByRole('textbox', { name: 'Filter hosts…' })
    await filter.fill('bravo')
    // Why: picker debounces filter IPC ~200ms.
    await expect(configHostRow(picker, hosts.bravo)).toBeVisible({ timeout: 5_000 })
    await expect(configHostRow(picker, hosts.alpha)).toHaveCount(0)

    await filter.fill('no-such-host-zzzz')
    await expect(picker.getByText('No matching hosts')).toBeVisible({ timeout: 5_000 })
    await expect(
      picker.getByText('Try another filter, or go back and type manually.')
    ).toBeVisible()
  })

  // ── P8 ─────────────────────────────────────────────────────────────
  test('P8: Back without select leaves form empty', async ({ electronApp, orcaPage }) => {
    const hosts = await seedPairConfig(electronApp, HOST_PREFIX)
    const picker = await openSshConfigHostPicker(orcaPage)
    await expect(configHostRow(picker, hosts.alpha)).toBeVisible()

    await picker.getByRole('button', { name: 'Back' }).click()
    const form = orcaPage.getByRole('dialog', { name: 'Add SSH host' })
    await expect(form.getByRole('heading', { name: 'Add SSH host' })).toBeVisible()
    const fields = addSshHostFormFields(form)
    await expect(fields.host).toHaveValue('')
    await expect(fields.username).toHaveValue('')
    await expect(fields.label).toHaveValue('')
    await expect(orcaPage.getByText(/Filled from /i)).toHaveCount(0)
  })
})

function escapeRegExp(value: string): string {
  return value.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')
}