mirror of
https://github.com/stablyai/orca.git
synced 2026-09-30 16:02:56 +00:00
Neil
77f23b013f
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as a re-export barrel so the import sites did not have to change. This removes the barrel: every consumer now imports from the module that actually declares the type, and `src/shared/types.ts` is deleted. Barrels hide where a type lives, make every consumer look like it depends on the whole domain, and let an unrelated edit invalidate a module that ~2,000 files transitively import. 2,323 import declarations across 2,321 files. Rewritten mechanically: each specifier was resolved to an absolute path via the TypeScript AST and recomputed, rather than string-substituted, so alias forms (`@/../../shared/ types`) and per-specifier `type` modifiers survive. Four cases the mechanical pass had to handle, each found by a gate rather than by reading the diff: - Modules inside `src/shared` import the barrel as `./types`, not `shared/types`. A pre-filter on the latter string skipped 176 of them and left imports dangling at a deleted file, which surfaced as confusing `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>` errors rather than "module not found". - The barrel RENAMED one type on the way through (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name in the owning module has to be re-aliased at each consumer. - Three test files put `;(globalThis as ...)` on the line after the import. TypeScript parses that `;` as the import statement's terminator, so replacing through `statement.getEnd()` deletes it and breaks ASI. The rewrite now stops at the module specifier. - A file that already imported directly from a module got a SECOND import from it, because the barrel re-exported those same names — which trips `import/no-duplicates` under `--deny-warnings`. A post-pass merges declarations sharing a specifier and type-only-ness; the `import type` plus `import` pair from one module is left alone, since that form is allowed. Splitting one barrel import into several genuinely adds lines, which pushed `terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character import must wrap, and neither local type collapses onto one line (101 and 116 characters). Rather than contort a type declaration to fit a line budget, `collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` — they are pure structural operations on the layout tree and independent of PTY ownership. `visible-worktrees.ts` similarly loses its own mini-barrel re-export of `isDefaultBranchWorkspace`, with the four real consumers repointed at the declaring module. No `max-lines` bypass added. Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted first — these projects are `composite: true` and reuse stale caches); the full `pnpm lint` green, not just bare oxlint — the narrower local check is what let the duplicate imports reach CI; max-lines ratchet OK at 344.
71 lines
2.4 KiB
TypeScript
71 lines
2.4 KiB
TypeScript
import { gitLabJobTraceToLogExcerpt } from './gitlab-job-log-excerpt'
|
|
import type { PRCheckDetail, PRCheckRunDetails } from './github/check-types'
|
|
|
|
export type GitLabJobTraceCheckDetailsStrings = {
|
|
/** Shown for a job with no log: never ran, waiting on a human, or log erased/expired. */
|
|
emptyTrace: string
|
|
}
|
|
|
|
/**
|
|
* Whether GitLab can have a trace for this job yet.
|
|
*
|
|
* Jobs that never started (`created`/`pending` -> queued) and jobs waiting on a human
|
|
* (`manual` -> neutral) or bypassed (`skipped`) have no trace, so skip the round trip.
|
|
* Other jobs may still lack a log (canceled before start, erased); main maps that 404
|
|
* to an empty trace rather than an error.
|
|
*/
|
|
export function gitLabJobCanHaveTrace(check: PRCheckDetail): boolean {
|
|
if (check.status === 'queued') {
|
|
return false
|
|
}
|
|
return check.conclusion !== 'neutral' && check.conclusion !== 'skipped'
|
|
}
|
|
|
|
/**
|
|
* Adapt a GitLab job trace to the provider-neutral check-details shape the Checks
|
|
* panel and the full-details tab already render. GitLab exposes one flat trace per
|
|
* job rather than GitHub's step/annotation breakdown, so it lands in a single job's
|
|
* `logTail`.
|
|
*/
|
|
export function gitLabJobTraceToCheckRunDetails(
|
|
check: PRCheckDetail,
|
|
trace: string,
|
|
strings: GitLabJobTraceCheckDetailsStrings
|
|
): PRCheckRunDetails {
|
|
// Re-slice defensively: an older remote runtime returns the raw trace because it
|
|
// does not understand the `logExcerpt` request flag.
|
|
const logTail = gitLabJobTraceToLogExcerpt(trace)
|
|
return {
|
|
name: check.name,
|
|
// Why: copying the row's own state keeps the panel's status/conclusion cache
|
|
// invalidation from evicting this entry on every poll tick.
|
|
status: check.status,
|
|
conclusion: check.conclusion,
|
|
url: check.url,
|
|
detailsUrl: check.url,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
title: null,
|
|
// Why: a job with no log still needs a distinct explanation, otherwise it falls
|
|
// back to the generic "no inline details" text this feature exists to remove.
|
|
summary: logTail ? null : strings.emptyTrace,
|
|
text: null,
|
|
annotations: [],
|
|
jobs: logTail
|
|
? [
|
|
{
|
|
id: check.gitlabJobId ?? null,
|
|
name: check.name,
|
|
status: check.status,
|
|
conclusion: check.conclusion,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
url: check.url,
|
|
logTail,
|
|
steps: []
|
|
}
|
|
]
|
|
: []
|
|
}
|
|
}
|