Files
orca/mobile/src/tasks/workspace-create-params.test.ts
Brennan BensonandBrennan Benson 53a09afbef feat(mobile): match desktop's Smart workspace source picker exactly (#7985)
* feat(mobile): start a workspace from a branch, issue/PR, or Linear ticket

Unify mobile workspace creation with desktop. The "+" Create Workspace
modal now has a primary "Start from" field that opens a tabbed search
drawer (Branch · GitHub · GitLab · Linear), letting a user start a
workspace from an existing/new git branch, a GitHub issue/PR, a GitLab
issue/MR, or a Linear ticket — in addition to the default blank workspace.

No new backend is required: the search RPCs (github.listWorkItems,
gitlab.listWorkItems, linear.searchIssues/listIssues, repo.searchRefs) and
the worktree.create linked-item params were already used by the mobile
Tasks screen. This surfaces them in the create flow, reusing the existing
pure modules (buildTaskWorkspaceCreateParams, shouldResolveHostedReviewStartPoint,
filterAvailableTaskProviders).

Details:
- New pure modules: workspace-source-selection, use-workspace-source-search,
  source-workspace-create, worktree-create-retry, blank-workspace-create
  (the blank/retry path extracted from the modal for reuse + line budget).
- New UI: WorkspaceSourcePickerDrawer (+ row) and SetupHookTrustDrawer
  (extracted from the modal).
- Older paired desktops (missing the mobile.tasks.v1 capability) degrade to
  Branch + Blank only; GitLab/Linear tabs appear only when available.
- GitHub/GitLab sources pin their repo; switching repos resets the source.
  PR/MR sources resolve their base branch at create time; SSH repos gate
  search until connected (Linear search is repo/SSH-independent).

* fix(mobile): hydrate settings/trust before availability probes settle

Review fixes for #7985: setTrustedOrcaHooks/setRuntimeSettings no longer
wait on status.get/preflight.check/linear.status (a first-open
preflight.check can take seconds, widening the spurious setup-trust
re-prompt window). Also adds param-parity tests for createBlankWorkspace
and a GitLab MR base-resolve test.

* feat(mobile): match desktop's Smart source picker exactly

Rework the mobile create-workspace source picker to be a faithful port of
desktop's Smart picker instead of the earlier divergent "Start from" drawer.

The mobile field is now the workspace-name input AND the source search, with the
exact desktop tabs — Smart · GitHub · Linear · GitLab · Branch · Name. "Smart"
fans out across GitHub + GitLab + Linear + branches, prepends a "Use '<name>'"
row, and resolves pasted URLs / #123 / STA-42 to exact items (with a cross-repo
switch prompt). Selecting a source shows a pill and moves the editable name into
Advanced. The invented "Blank workspace" concept is removed — the neutral state
is just a typed/empty name (blank submit still yields a creature name).

DRY: the pure desktop logic (smart-workspace-source-results, -command-value,
github-links, gitlab-links, work-item-link-query-bounds, github-work-item-identity)
moves to src/shared/new-workspace/ with re-export shims at the old renderer paths,
so both renderer and mobile share one implementation. composer-branch-selection
and workspace-name were already shared and are reused directly.

Two read-only lookup RPCs are allowlisted for mobile so pasted GitLab URLs and
cross-repo GitHub URLs resolve to exact items (github.workItemByOwnerRepo,
gitlab.workItemByPath).

New mobile modules are split for max-lines: use-mobile-composer-source (selection
state + desktop-parity handlers, PR/MR base resolve), use-smart-workspace-source
+ smart-source-fan-out/-search-requests/-paste-intent (RPC orchestration),
composer-linked-work-item / work-item-lookup-text / mobile-smart-source-modes
(pure logic), and SmartWorkspaceSourceField/Drawer/Row + SmartWorkspaceAdvancedFields.
Replaces WorkspaceSourcePickerDrawer/Row, workspace-source-selection,
use-workspace-source-search, and MobileWorkspaceNameInput.

Reviewed by three adversarial agents + re-reviewed after fixes: GitHub search now
returns issues AND PRs (not issues-only), Linear defaults to assigned, create-branch
preserves slashy names, cross-repo PR base resolves against the item's own repo,
displayName is suppressed for user-edited names, and the smart-mode GitHub fan-out
respects availability. tsc/oxlint/max-lines-ratchet clean; 1328 mobile tests pass.

* fix(mobile): keep smart source drawer fully visible

* refactor: share workspace creation behavior across clients

* fix: address workspace creation review findings

---------

Co-authored-by: Brennan Benson <brennanbenson@Brennans-MacBook-Pro.local>
2026-07-13 15:38:02 -07:00

154 lines
4.6 KiB
TypeScript

import { describe, expect, it } from 'vitest'
import { buildTaskWorkspaceCreateParams } from './workspace-create-params'
describe('task workspace create params', () => {
it('passes a GitHub PR URL as an agent draft and links the PR', () => {
expect(
buildTaskWorkspaceCreateParams({
item: {
provider: 'github',
source: {
type: 'pr',
repoId: 'repo-1',
number: 123,
title: 'Fix mobile tasks',
url: 'https://github.com/acme/app/pull/123'
}
},
targetRepoId: 'ignored-for-github',
setupDecision: 'run',
agent: 'codex',
workspaceName: ' mobile-tasks ',
hostedStartPoint: {
baseBranch: 'origin/main',
pushTarget: { remoteName: 'origin', branchName: 'feature/mobile-tasks' }
}
})
).toMatchObject({
repo: 'id:repo-1',
name: 'mobile-tasks',
displayName: 'Fix mobile tasks',
setupDecision: 'run',
activate: true,
startupDraft: 'https://github.com/acme/app/pull/123',
createdWithAgent: 'codex',
linkedPR: 123,
baseBranch: 'origin/main',
pushTarget: { remoteName: 'origin', branchName: 'feature/mobile-tasks' }
})
})
it('omits startup draft and agent when blank terminal is selected', () => {
const params = buildTaskWorkspaceCreateParams({
item: {
provider: 'github',
source: {
type: 'issue',
repoId: 'repo-1',
number: 88,
title: 'Investigate login',
url: 'https://github.com/acme/app/issues/88'
}
},
targetRepoId: 'ignored-for-github',
setupDecision: 'skip',
agent: 'blank'
})
expect(params).toMatchObject({
repo: 'id:repo-1',
name: 'issue-88',
displayName: 'Investigate login',
setupDecision: 'skip',
activate: true,
linkedIssue: 88
})
expect(params).not.toHaveProperty('startupDraft')
expect(params).not.toHaveProperty('createdWithAgent')
})
it('keeps the startup draft when no agent was provided so the host can auto-pick', () => {
const params = buildTaskWorkspaceCreateParams({
item: {
provider: 'github',
source: {
type: 'issue',
repoId: 'repo-1',
number: 89,
title: 'Auto-pick agent',
url: 'https://github.com/acme/app/issues/89'
}
},
targetRepoId: 'ignored-for-github',
setupDecision: 'inherit'
})
expect(params).toMatchObject({
startupDraft: 'https://github.com/acme/app/issues/89',
linkedIssue: 89
})
expect(params).not.toHaveProperty('createdWithAgent')
})
it('links GitLab merge requests and carries explicit base branch overrides', () => {
expect(
buildTaskWorkspaceCreateParams({
item: {
provider: 'gitlab',
source: {
type: 'mr',
repoId: 'repo-2',
number: 7,
title: 'Port drawer',
url: 'https://gitlab.com/acme/app/-/merge_requests/7'
}
},
targetRepoId: 'ignored-for-gitlab',
setupDecision: 'inherit',
agent: 'claude',
baseBranch: 'origin/release',
hostedStartPoint: { baseBranch: 'origin/main' },
branchNameOverride: 'port-drawer',
sparseCheckout: { directories: ['mobile'], presetId: 'preset-1' },
note: ' keep mobile parity '
})
).toMatchObject({
repo: 'id:repo-2',
name: 'mr-7',
displayName: 'Port drawer',
startupDraft: 'https://gitlab.com/acme/app/-/merge_requests/7',
createdWithAgent: 'claude',
linkedGitLabMR: 7,
baseBranch: 'origin/release',
branchNameOverride: 'port-drawer',
sparseCheckout: { directories: ['mobile'], presetId: 'preset-1' },
comment: 'keep mobile parity'
})
})
it('creates Linear workspaces in the selected repo and links the identifier', () => {
expect(
buildTaskWorkspaceCreateParams({
item: {
provider: 'linear',
source: {
identifier: 'ENG-42',
title: 'Ship Linear parity',
url: 'https://linear.app/acme/issue/ENG-42/ship-linear-parity'
}
},
targetRepoId: 'repo-linear',
setupDecision: 'inherit',
agent: 'grok'
})
).toMatchObject({
repo: 'id:repo-linear',
name: 'eng-42',
displayName: 'ENG-42 Ship Linear parity',
linkedLinearIssue: 'ENG-42',
startupDraft: 'https://linear.app/acme/issue/ENG-42/ship-linear-parity',
createdWithAgent: 'grok'
})
})
})