mirror of
https://github.com/stablyai/orca.git
synced 2026-10-18 16:03:17 +00:00
* feat(mobile): start a workspace from a branch, issue/PR, or Linear ticket Unify mobile workspace creation with desktop. The "+" Create Workspace modal now has a primary "Start from" field that opens a tabbed search drawer (Branch · GitHub · GitLab · Linear), letting a user start a workspace from an existing/new git branch, a GitHub issue/PR, a GitLab issue/MR, or a Linear ticket — in addition to the default blank workspace. No new backend is required: the search RPCs (github.listWorkItems, gitlab.listWorkItems, linear.searchIssues/listIssues, repo.searchRefs) and the worktree.create linked-item params were already used by the mobile Tasks screen. This surfaces them in the create flow, reusing the existing pure modules (buildTaskWorkspaceCreateParams, shouldResolveHostedReviewStartPoint, filterAvailableTaskProviders). Details: - New pure modules: workspace-source-selection, use-workspace-source-search, source-workspace-create, worktree-create-retry, blank-workspace-create (the blank/retry path extracted from the modal for reuse + line budget). - New UI: WorkspaceSourcePickerDrawer (+ row) and SetupHookTrustDrawer (extracted from the modal). - Older paired desktops (missing the mobile.tasks.v1 capability) degrade to Branch + Blank only; GitLab/Linear tabs appear only when available. - GitHub/GitLab sources pin their repo; switching repos resets the source. PR/MR sources resolve their base branch at create time; SSH repos gate search until connected (Linear search is repo/SSH-independent). * fix(mobile): hydrate settings/trust before availability probes settle Review fixes for #7985: setTrustedOrcaHooks/setRuntimeSettings no longer wait on status.get/preflight.check/linear.status (a first-open preflight.check can take seconds, widening the spurious setup-trust re-prompt window). Also adds param-parity tests for createBlankWorkspace and a GitLab MR base-resolve test. * feat(mobile): match desktop's Smart source picker exactly Rework the mobile create-workspace source picker to be a faithful port of desktop's Smart picker instead of the earlier divergent "Start from" drawer. The mobile field is now the workspace-name input AND the source search, with the exact desktop tabs — Smart · GitHub · Linear · GitLab · Branch · Name. "Smart" fans out across GitHub + GitLab + Linear + branches, prepends a "Use '<name>'" row, and resolves pasted URLs / #123 / STA-42 to exact items (with a cross-repo switch prompt). Selecting a source shows a pill and moves the editable name into Advanced. The invented "Blank workspace" concept is removed — the neutral state is just a typed/empty name (blank submit still yields a creature name). DRY: the pure desktop logic (smart-workspace-source-results, -command-value, github-links, gitlab-links, work-item-link-query-bounds, github-work-item-identity) moves to src/shared/new-workspace/ with re-export shims at the old renderer paths, so both renderer and mobile share one implementation. composer-branch-selection and workspace-name were already shared and are reused directly. Two read-only lookup RPCs are allowlisted for mobile so pasted GitLab URLs and cross-repo GitHub URLs resolve to exact items (github.workItemByOwnerRepo, gitlab.workItemByPath). New mobile modules are split for max-lines: use-mobile-composer-source (selection state + desktop-parity handlers, PR/MR base resolve), use-smart-workspace-source + smart-source-fan-out/-search-requests/-paste-intent (RPC orchestration), composer-linked-work-item / work-item-lookup-text / mobile-smart-source-modes (pure logic), and SmartWorkspaceSourceField/Drawer/Row + SmartWorkspaceAdvancedFields. Replaces WorkspaceSourcePickerDrawer/Row, workspace-source-selection, use-workspace-source-search, and MobileWorkspaceNameInput. Reviewed by three adversarial agents + re-reviewed after fixes: GitHub search now returns issues AND PRs (not issues-only), Linear defaults to assigned, create-branch preserves slashy names, cross-repo PR base resolves against the item's own repo, displayName is suppressed for user-edited names, and the smart-mode GitHub fan-out respects availability. tsc/oxlint/max-lines-ratchet clean; 1328 mobile tests pass. * fix(mobile): keep smart source drawer fully visible * refactor: share workspace creation behavior across clients * fix: address workspace creation review findings --------- Co-authored-by: Brennan Benson <brennanbenson@Brennans-MacBook-Pro.local>
163 lines
4.8 KiB
TypeScript
163 lines
4.8 KiB
TypeScript
import type {
|
|
CreateSparseCheckoutRequest,
|
|
GitPushTarget,
|
|
SetupDecision,
|
|
TuiAgent
|
|
} from '../../../src/shared/types'
|
|
import { getWorkspaceSourceName } from '../../../src/shared/new-workspace/workspace-source'
|
|
import { resolveMobileWorkspaceCreateName } from './mobile-workspace-name'
|
|
import type { WorkspaceAgentChoice } from './workspace-agent-selection'
|
|
|
|
export type WorkspaceCreateSetupDecision = SetupDecision
|
|
export type WorkspaceCreateSparseCheckout = CreateSparseCheckoutRequest
|
|
export type WorkspaceCreateGitPushTarget = GitPushTarget
|
|
|
|
export type WorkspaceCreateHostedStartPoint = {
|
|
baseBranch: string
|
|
pushTarget?: WorkspaceCreateGitPushTarget
|
|
}
|
|
|
|
type WorkspaceCreateGitHubItem = {
|
|
provider: 'github'
|
|
source: {
|
|
type: 'issue' | 'pr'
|
|
repoId: string
|
|
number: number
|
|
title: string
|
|
url: string
|
|
}
|
|
}
|
|
|
|
type WorkspaceCreateGitLabItem = {
|
|
provider: 'gitlab'
|
|
source: {
|
|
type: 'issue' | 'mr'
|
|
repoId: string
|
|
number: number
|
|
title: string
|
|
url: string
|
|
}
|
|
}
|
|
|
|
type WorkspaceCreateLinearItem = {
|
|
provider: 'linear'
|
|
source: {
|
|
identifier: string
|
|
title: string
|
|
url: string
|
|
workspaceId?: string
|
|
organizationUrlKey?: string
|
|
}
|
|
}
|
|
|
|
export type WorkspaceCreateTaskItem =
|
|
| WorkspaceCreateGitHubItem
|
|
| WorkspaceCreateGitLabItem
|
|
| WorkspaceCreateLinearItem
|
|
|
|
export type WorkspaceCreateParams = Record<string, unknown>
|
|
|
|
export function buildTaskWorkspaceCreateParams(args: {
|
|
item: WorkspaceCreateTaskItem
|
|
targetRepoId: string
|
|
setupDecision: WorkspaceCreateSetupDecision
|
|
agent?: WorkspaceAgentChoice
|
|
workspaceName?: string
|
|
note?: string
|
|
baseBranch?: string
|
|
compareBaseRef?: string
|
|
branchNameOverride?: string
|
|
pushTarget?: WorkspaceCreateGitPushTarget
|
|
sparseCheckout?: WorkspaceCreateSparseCheckout
|
|
hostedStartPoint?: WorkspaceCreateHostedStartPoint
|
|
nameIsAutoManaged?: boolean
|
|
}): WorkspaceCreateParams {
|
|
const {
|
|
item,
|
|
targetRepoId,
|
|
setupDecision,
|
|
agent,
|
|
workspaceName,
|
|
note,
|
|
baseBranch,
|
|
compareBaseRef,
|
|
branchNameOverride,
|
|
pushTarget,
|
|
sparseCheckout,
|
|
hostedStartPoint,
|
|
nameIsAutoManaged = true
|
|
} = args
|
|
const shouldLaunchAgent = agent !== 'blank'
|
|
const createdWithAgent = shouldLaunchAgent ? (agent as TuiAgent) : undefined
|
|
const comment = note?.trim()
|
|
const selectedBaseBranch = baseBranch || hostedStartPoint?.baseBranch
|
|
const selectedPushTarget = pushTarget ?? hostedStartPoint?.pushTarget
|
|
// Why: desktop only sends displayName while the name is still auto-derived; a
|
|
// user-edited name suppresses it so the runtime keeps the user's chosen name.
|
|
const sourceName =
|
|
item.provider === 'linear'
|
|
? getWorkspaceSourceName({
|
|
provider: 'linear',
|
|
type: 'issue',
|
|
number: 0,
|
|
title: item.source.title,
|
|
url: item.source.url,
|
|
linearIdentifier: item.source.identifier
|
|
})
|
|
: getWorkspaceSourceName({ provider: item.provider, ...item.source })
|
|
const displayName = nameIsAutoManaged ? { displayName: sourceName.displayName } : {}
|
|
const common = {
|
|
setupDecision,
|
|
activate: true,
|
|
...(shouldLaunchAgent ? { startupDraft: item.source.url } : {}),
|
|
...(createdWithAgent ? { createdWithAgent } : {}),
|
|
...(selectedBaseBranch ? { baseBranch: selectedBaseBranch } : {}),
|
|
...(compareBaseRef ? { compareBaseRef } : {}),
|
|
...(branchNameOverride ? { branchNameOverride } : {}),
|
|
...(selectedPushTarget ? { pushTarget: selectedPushTarget } : {}),
|
|
...(sparseCheckout ? { sparseCheckout } : {}),
|
|
...(comment ? { comment } : {})
|
|
}
|
|
|
|
if (item.provider === 'github') {
|
|
const fallback = `${item.source.type}-${item.source.number}`
|
|
return {
|
|
repo: `id:${item.source.repoId}`,
|
|
name: resolveMobileWorkspaceCreateName({ draft: workspaceName, fallback }),
|
|
...displayName,
|
|
...common,
|
|
...(item.source.type === 'issue'
|
|
? { linkedIssue: item.source.number }
|
|
: { linkedPR: item.source.number })
|
|
}
|
|
}
|
|
|
|
if (item.provider === 'gitlab') {
|
|
const fallback = `${item.source.type}-${item.source.number}`
|
|
return {
|
|
repo: `id:${item.source.repoId}`,
|
|
name: resolveMobileWorkspaceCreateName({ draft: workspaceName, fallback }),
|
|
...displayName,
|
|
...common,
|
|
...(item.source.type === 'issue'
|
|
? { linkedGitLabIssue: item.source.number }
|
|
: { linkedGitLabMR: item.source.number })
|
|
}
|
|
}
|
|
|
|
return {
|
|
repo: `id:${targetRepoId}`,
|
|
name: resolveMobileWorkspaceCreateName({
|
|
draft: workspaceName,
|
|
fallback: item.source.identifier.toLowerCase()
|
|
}),
|
|
...displayName,
|
|
linkedLinearIssue: item.source.identifier,
|
|
...(item.source.workspaceId ? { linkedLinearIssueWorkspaceId: item.source.workspaceId } : {}),
|
|
...(item.source.organizationUrlKey
|
|
? { linkedLinearIssueOrganizationUrlKey: item.source.organizationUrlKey }
|
|
: {}),
|
|
...common
|
|
}
|
|
}
|