mirror of
https://github.com/stablyai/orca.git
synced 2026-11-13 17:37:40 +00:00
* refactor(renderer): group launch, workspace, and browser owners * fix(renderer): restore workspace name Enter focus to agent picker
249 lines
9.4 KiB
TypeScript
249 lines
9.4 KiB
TypeScript
import { openSidebarWorkspaceComposer } from './helpers/sidebar-project-dialog'
|
|
import type { ElectronApplication, Page } from '@stablyai/playwright-test'
|
|
import { test, expect } from './helpers/orca-app'
|
|
import { waitForActiveWorktree, waitForSessionReady } from './helpers/store'
|
|
import type { LinearIssue } from '../../src/shared/linear/issue-types'
|
|
import type { LinearConnectionStatus } from '../../src/shared/linear/workspace-types'
|
|
|
|
const LINEAR_URL =
|
|
'https://linear.app/stably/issue/STA-4084/restore-osc-133-shell-integration-when-an-exec-in-user-rc-files-strips'
|
|
const EXPECTED_WORKSPACE_NAME = 'sta-4084-restore-osc-133-shell-integration-when'
|
|
|
|
const LINEAR_ISSUE: LinearIssue = {
|
|
id: 'linear-sta-4084',
|
|
workspaceId: 'workspace-1',
|
|
workspaceName: 'Stably',
|
|
identifier: 'STA-4084',
|
|
title: 'Restore OSC 133 shell integration when an exec in user rc files strips',
|
|
branchName: 'sta-4084-restore-osc-133-shell-integration',
|
|
url: LINEAR_URL,
|
|
state: { name: 'Todo', type: 'unstarted', color: '#999999' },
|
|
team: { id: 'team-sta', name: 'Stably', key: 'STA' },
|
|
labels: [],
|
|
labelIds: [],
|
|
priority: 2,
|
|
estimate: null,
|
|
updatedAt: '2026-08-12T00:00:00.000Z'
|
|
}
|
|
|
|
const LINEAR_STATUS: LinearConnectionStatus = {
|
|
connected: true,
|
|
viewer: null,
|
|
activeWorkspaceId: 'workspace-other',
|
|
selectedWorkspaceId: 'workspace-other',
|
|
workspaces: [
|
|
{
|
|
id: 'workspace-other',
|
|
displayName: 'Other User',
|
|
email: null,
|
|
organizationId: 'organization-other',
|
|
organizationName: 'Other',
|
|
organizationUrlKey: 'other'
|
|
},
|
|
{
|
|
id: 'workspace-1',
|
|
displayName: 'Stably User',
|
|
email: null,
|
|
organizationId: 'organization-stably',
|
|
organizationName: 'Stably',
|
|
organizationUrlKey: 'stably'
|
|
}
|
|
]
|
|
}
|
|
|
|
function pasteChord(): string {
|
|
return process.platform === 'darwin' ? 'Meta+V' : 'Control+V'
|
|
}
|
|
|
|
async function installLinearFixture(
|
|
electronApp: ElectronApplication,
|
|
page: Page,
|
|
issue: LinearIssue | null = LINEAR_ISSUE,
|
|
holdLookup = false
|
|
): Promise<void> {
|
|
await electronApp.evaluate(
|
|
({ ipcMain }, { resolvedIssue, holdLookup }) => {
|
|
// Main-only fixture signal: production preload/runtime and owned reads stay in the path.
|
|
ipcMain.removeAllListeners('pr34591-release-linear-lookup')
|
|
for (const method of ['linear:searchIssues', 'linear:listIssues', 'linear:getIssue']) {
|
|
ipcMain.removeHandler(method)
|
|
}
|
|
ipcMain.handle('linear:searchIssues', () => [])
|
|
ipcMain.handle('linear:listIssues', () => ({ items: [] }))
|
|
ipcMain.handle('linear:getIssue', async (_event, { workspaceId }) => {
|
|
if (holdLookup) {
|
|
await new Promise<void>((resolve) =>
|
|
ipcMain.once('pr34591-release-linear-lookup', () => resolve())
|
|
)
|
|
}
|
|
return resolvedIssue && workspaceId === resolvedIssue.workspaceId ? resolvedIssue : null
|
|
})
|
|
},
|
|
{ resolvedIssue: issue, holdLookup }
|
|
)
|
|
await page.evaluate((status) => {
|
|
if (!window.__store) {
|
|
throw new Error('window.__store is not available')
|
|
}
|
|
window.__store.setState({
|
|
linearStatus: status,
|
|
linearStatusObserved: true,
|
|
linearStatusChecked: true
|
|
})
|
|
}, LINEAR_STATUS)
|
|
}
|
|
|
|
async function releaseHeldLinearLookup(electronApp: ElectronApplication): Promise<void> {
|
|
await electronApp.evaluate(({ ipcMain }) => {
|
|
if (!ipcMain.emit('pr34591-release-linear-lookup')) {
|
|
throw new Error('Linear lookup is not held')
|
|
}
|
|
})
|
|
}
|
|
|
|
async function pasteLinearUrl(page: Page, input: ReturnType<Page['locator']>): Promise<void> {
|
|
await page.evaluate((text) => window.api.ui.writeClipboardText(text), LINEAR_URL)
|
|
// X selection ownership is async; pasting before it lands delivers stale text.
|
|
await expect
|
|
.poll(() => page.evaluate(() => window.api.ui.readClipboardText()), { timeout: 5_000 })
|
|
.toBe(LINEAR_URL)
|
|
await input.focus()
|
|
await page.keyboard.press(pasteChord())
|
|
}
|
|
|
|
async function openJumpPalette(electronApp: ElectronApplication): Promise<void> {
|
|
// Headless Playwright keys bypass Electron's before-input-event shortcut path.
|
|
await electronApp.evaluate(({ BrowserWindow }) => {
|
|
BrowserWindow.getAllWindows()[0]?.webContents.send('ui:toggleWorktreePalette')
|
|
})
|
|
}
|
|
|
|
test.describe('Linear URL workspace entry', () => {
|
|
test.beforeEach(async ({ electronApp, orcaPage }) => {
|
|
await waitForSessionReady(orcaPage)
|
|
await waitForActiveWorktree(orcaPage)
|
|
// Why: Create worktree reads Linear status from its repo's host, not the store.
|
|
await electronApp.evaluate(({ ipcMain }, status) => {
|
|
ipcMain.removeHandler('linear:status')
|
|
ipcMain.handle('linear:status', () => status)
|
|
}, LINEAR_STATUS)
|
|
await installLinearFixture(electronApp, orcaPage)
|
|
})
|
|
|
|
test('pasting into the composer selects the Linear issue without ArrowDown', async ({
|
|
electronApp,
|
|
orcaPage
|
|
}, testInfo) => {
|
|
await installLinearFixture(electronApp, orcaPage, LINEAR_ISSUE, true)
|
|
await openSidebarWorkspaceComposer(orcaPage)
|
|
const dialog = orcaPage.getByRole('dialog', { name: /Create (Workspace|Worktree)/i })
|
|
const input = dialog.locator('[data-workspace-name-input="true"]')
|
|
await expect(input).toBeVisible()
|
|
|
|
await pasteLinearUrl(orcaPage, input)
|
|
await expect
|
|
.poll(() =>
|
|
electronApp.evaluate(
|
|
({ ipcMain }) => ipcMain.listenerCount('pr34591-release-linear-lookup') > 0
|
|
)
|
|
)
|
|
.toBe(true)
|
|
await input.press('Enter')
|
|
await expect(input).toHaveValue(LINEAR_URL)
|
|
await expect(dialog.locator('[data-workspace-source-pill="true"]')).toHaveCount(0)
|
|
await releaseHeldLinearLookup(electronApp)
|
|
|
|
const issueRow = orcaPage.getByRole('option', {
|
|
name: `${LINEAR_ISSUE.identifier} ${LINEAR_ISSUE.title}`,
|
|
exact: true
|
|
})
|
|
const useNameRow = orcaPage.getByRole('option', {
|
|
name: `Use "${LINEAR_URL}" as workspace name`,
|
|
exact: true
|
|
})
|
|
await expect(useNameRow).toBeVisible()
|
|
await expect(useNameRow).not.toHaveAttribute('data-selected', 'true')
|
|
await expect(issueRow).toContainText(LINEAR_ISSUE.title)
|
|
await expect(issueRow).toHaveAttribute('data-selected', 'true')
|
|
await testInfo.attach('linear-url-smart-entry-selected.png', {
|
|
body: await dialog.screenshot(),
|
|
contentType: 'image/png'
|
|
})
|
|
|
|
await input.press('Enter')
|
|
const sourcePill = dialog.locator('[data-workspace-source-pill="true"]')
|
|
await expect(sourcePill).toContainText(LINEAR_ISSUE.title)
|
|
await expect(dialog.getByPlaceholder('Workspace name')).toHaveValue(EXPECTED_WORKSPACE_NAME)
|
|
await expect(dialog.getByRole('button', { name: /Create (Workspace|Worktree)/i })).toBeEnabled()
|
|
await testInfo.attach('linear-url-smart-entry-composer.png', {
|
|
body: await dialog.screenshot(),
|
|
contentType: 'image/png'
|
|
})
|
|
})
|
|
|
|
test('a Linear URL lookup miss falls back to an arbitrary workspace name', async ({
|
|
electronApp,
|
|
orcaPage
|
|
}) => {
|
|
await installLinearFixture(electronApp, orcaPage, null)
|
|
await openSidebarWorkspaceComposer(orcaPage)
|
|
const dialog = orcaPage.getByRole('dialog', { name: /Create (Workspace|Worktree)/i })
|
|
const input = dialog.locator('[data-workspace-name-input="true"]')
|
|
|
|
await pasteLinearUrl(orcaPage, input)
|
|
const useNameRow = orcaPage.getByRole('option', {
|
|
name: `Use "${LINEAR_URL}" as workspace name`,
|
|
exact: true
|
|
})
|
|
await expect(useNameRow).toHaveAttribute('data-selected', 'true')
|
|
await expect(input).not.toHaveAttribute('aria-busy', 'true')
|
|
|
|
await input.press('Enter')
|
|
await expect(input).toHaveValue(LINEAR_URL)
|
|
await expect(dialog.locator('[data-workspace-source-pill="true"]')).toHaveCount(0)
|
|
const suggestions = dialog.locator('[data-workspace-source-suggestions="true"]')
|
|
if (await suggestions.isVisible()) {
|
|
await input.press('Escape')
|
|
}
|
|
await expect(input).not.toHaveAttribute('aria-busy', 'true')
|
|
await input.press('Enter')
|
|
await expect(dialog.getByRole('button', { name: 'Select agent', exact: true })).toBeFocused()
|
|
})
|
|
|
|
test('pasting into Cmd+J previews the Linear issue and opens the linked composer', async ({
|
|
electronApp,
|
|
orcaPage
|
|
}, testInfo) => {
|
|
await openJumpPalette(electronApp)
|
|
const palette = orcaPage.getByRole('dialog', { name: 'Jump to...' })
|
|
const input = palette.getByPlaceholder(
|
|
'Search chats, terminals, workspaces, tasks, settings, and actions...'
|
|
)
|
|
await expect(input).toBeVisible()
|
|
|
|
await pasteLinearUrl(orcaPage, input)
|
|
|
|
const preview = palette.locator(
|
|
'[data-cmd-j-linear-issue-preview="true"][data-cmd-j-linear-issue-state="resolved"]'
|
|
)
|
|
await expect(preview).toContainText(LINEAR_ISSUE.identifier)
|
|
await expect(preview).toContainText(LINEAR_ISSUE.title)
|
|
await expect(preview).toHaveAttribute('data-selected', 'true')
|
|
await testInfo.attach('linear-url-cmd-j-preview.png', {
|
|
body: await palette.screenshot(),
|
|
contentType: 'image/png'
|
|
})
|
|
|
|
await input.press('Enter')
|
|
const dialog = orcaPage.getByRole('dialog', { name: /Create (Workspace|Worktree)/i })
|
|
const sourcePill = dialog.locator('[data-workspace-source-pill="true"]')
|
|
await expect(sourcePill).toContainText(LINEAR_ISSUE.title)
|
|
await expect(dialog.getByPlaceholder('Workspace name')).toHaveValue(EXPECTED_WORKSPACE_NAME)
|
|
await expect(dialog.getByRole('button', { name: /Create (Workspace|Worktree)/i })).toBeEnabled()
|
|
await testInfo.attach('linear-url-cmd-j-composer.png', {
|
|
body: await dialog.screenshot(),
|
|
contentType: 'image/png'
|
|
})
|
|
})
|
|
})
|