mirror of
https://github.com/stablyai/orca.git
synced 2026-11-13 09:27:29 +00:00
* Chat UI leaves Experimental: each agent's Chat | CLI choice decides launches Remove the experimentalNativeChat switch and every gate on it. The Chat settings page, Default Agent Chat | CLI choice, + menu Chat/CLI rows, source-control surface choice, Antigravity chat section and orchestration chat-error switch are always present. What a new launch opens comes only from the per-agent choice (no saved choice opens a chat) plus the existing support checks. - One lookup, nativeChatPreferenceFor, keyed by agent id so host-registered agents read the same way; unreadable settings still open a terminal. - A relayed desktop stamp (nativeChatDefault) maps onto the launched agent; an explicit surface still wins. Old phones' createSupport keeps admitting by the host's per-agent choice. - settings.get stops publishing the retired switch keys; nothing in the repo reads them from a host. - Startup chat sync and hydration run when some agent can open as a chat or the machine already holds chats. - The retired key is stripped on load. The one-time upgrade tip from the chat upgrade is retired with its audience record; a new record, captured once from the raw profile, marks which existing profiles had Chat UI off. - The window-side AI-button tab path, which only ran with the switch off, is deleted. * Keep profiles that had Chat UI off on the terminal Existing users who never turned Chat UI on would otherwise see new agent launches open as chats, since an agent without a saved choice now opens as a chat. The one-time load step that records the new audience also sets every known agent to CLI for those profiles, in the same save and only when the record was absent, overwriting saved chat choices the old switch masked. Profiles that had Chat UI on and new profiles are untouched. Browser profiles keep their own settings, so the web client does the same once: a stored switch that is not on seeds CLI choices, and dropping the key marks the step done. Agents first seen after this step open as chats. * Agents without a saved Chat | CLI choice open as their CLI An agent with no saved choice now opens in the terminal for everyone, including fresh installs and agents first seen later. The one-time load step carries what launches opened while Chat UI was experimental: with the switch on, every known agent without a saved choice is saved as chat; with it off, chat choices the switch masked are saved as CLI. Existing profiles join the launch tip audience whether the switch was on or off. Browser profiles get the same carry from their saved key. The startup chat restore and host agent list now run only when some agent is saved as chat or the runtime holds chats. * Preserve owned terminal launches and local chat choices * Clarify chat and terminal support * Explain worker CLI integration timeout budget * Use checked annotations for chat graduation test fixtures * Store agent surface default separately from per-agent overrides * Preserve explicit Chat intent across default changes * Preserve current browser settings during host replies * Correct browser settings factory and regression types * Name exported launch fixture mock types and clarify agent defaults * Preserve settings fallbacks and complete launch test lifecycles * Check allocated tab identity before launch fixture interpolation * Register combined integration project for compiler parity probes * Use checked settings in the launch test fixture * Preserve retired Chat preference data privately * Align chat E2E fixtures and capture pane lifecycle evidence * Use typed raw settings in retention contracts * Consolidate transcript diagnostic imports * test: align chat fixtures with live pane and native menu contracts * test: capture relay tab selection loss diagnostics * test: wait for owned shells before synthetic chat fixtures * test: preserve all-host visibility in SSH observer * test: bind synthetic transcript fixtures before provider seeding * test: assert selected chat owner after narrow image preview * ci: allow fifth compiler project to complete comparison * Type the web-terminal fixture's chat map without an assertion * Right-click the selection itself in the chat copy spec
189 lines
7.5 KiB
TypeScript
189 lines
7.5 KiB
TypeScript
import { randomUUID } from 'node:crypto'
|
|
import { copyFileSync, existsSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs'
|
|
import os from 'node:os'
|
|
import path from 'node:path'
|
|
import { test, expect } from './helpers/orca-app'
|
|
import { ensureTerminalVisible, waitForActiveWorktree, waitForSessionReady } from './helpers/store'
|
|
import {
|
|
waitForActivePaneHookDescriptor,
|
|
waitForActivePanePtyId,
|
|
waitForActiveTerminalManager,
|
|
waitForPaneIdentitySnapshot
|
|
} from './helpers/terminal'
|
|
import { waitForPtyShellEcho } from './terminal-pty-readiness'
|
|
import {
|
|
claudeTranscriptLines,
|
|
seedClaudeProviderSession,
|
|
toggleTerminalTabToChatView
|
|
} from './helpers/native-chat-transcript-fixture'
|
|
|
|
test.use({ orcaAppExtraEnv: { ORCA_BACKGROUND_LAUNCH: '1' } })
|
|
|
|
const sourceImage = path.resolve(
|
|
__dirname,
|
|
'..',
|
|
'..',
|
|
'docs',
|
|
'site',
|
|
'public',
|
|
'docs',
|
|
'ways-to-run-run-on.png'
|
|
)
|
|
|
|
function transcript(sessionId: string, imagePath: string): string {
|
|
return claudeTranscriptLines({
|
|
sessionId,
|
|
userText: 'Show the inline image preview.',
|
|
assistantText: [
|
|
'The table uses the actual local image source:',
|
|
'',
|
|
'| Preview | Details |',
|
|
'| --- | --- |',
|
|
`|  | [Ordinary file link](${imagePath}) |`
|
|
].join('\n')
|
|
})
|
|
}
|
|
|
|
test('opens a native-chat Markdown table image in the image dialog without a file popup', async ({
|
|
electronApp,
|
|
orcaPage,
|
|
testRepoPath
|
|
}, testInfo) => {
|
|
expect(existsSync(sourceImage)).toBe(true)
|
|
const imagePath = path.join(testRepoPath, `inline-chat-preview-${randomUUID()}.png`)
|
|
const sessionId = `e2e-inline-image-${randomUUID()}`
|
|
const scratchDir = mkdtempSync(path.join(os.tmpdir(), 'orca-e2e-inline-image-'))
|
|
const transcriptPath = path.join(scratchDir, `${sessionId}.jsonl`)
|
|
copyFileSync(sourceImage, imagePath)
|
|
|
|
try {
|
|
await waitForSessionReady(orcaPage)
|
|
await waitForActiveWorktree(orcaPage)
|
|
await ensureTerminalVisible(orcaPage)
|
|
await waitForActiveTerminalManager(orcaPage)
|
|
const boundPane = await waitForPaneIdentitySnapshot(orcaPage, 1)
|
|
const ptyId = await waitForActivePanePtyId(orcaPage)
|
|
await waitForPtyShellEcho(orcaPage, ptyId, 15_000)
|
|
const descriptor = await waitForActivePaneHookDescriptor(orcaPage)
|
|
expect(descriptor.paneKey).toBe(`${boundPane.tabId}:${boundPane.activeLeafId}`)
|
|
const [tabId] = descriptor.paneKey.split(':')
|
|
writeFileSync(transcriptPath, transcript(sessionId, imagePath))
|
|
await orcaPage.evaluate(async () => {
|
|
await window.__store?.getState().updateSettings({ terminalLinkClickBehavior: 'actions' })
|
|
})
|
|
await seedClaudeProviderSession(orcaPage, {
|
|
paneKey: descriptor.paneKey,
|
|
worktreeId: descriptor.worktreeId,
|
|
sessionId,
|
|
transcriptPath
|
|
})
|
|
await toggleTerminalTabToChatView(orcaPage, { tabId, worktreeId: descriptor.worktreeId })
|
|
|
|
const chat = orcaPage.locator('[data-native-chat-root="true"]')
|
|
const image = chat.getByRole('button', { name: 'View image: Inline chat screenshot' })
|
|
await expect(image).toBeVisible({ timeout: 30_000 })
|
|
const ordinaryFileLink = chat.getByRole('link', { name: 'Ordinary file link' })
|
|
await expect(ordinaryFileLink).toBeVisible()
|
|
await chat
|
|
.locator('table')
|
|
.screenshot({ path: testInfo.outputPath('01-table-image-light.png') })
|
|
|
|
await ordinaryFileLink.click()
|
|
const ordinaryFilePopup = orcaPage.locator('[data-link-action-popover]')
|
|
await expect(ordinaryFilePopup).toBeVisible()
|
|
await expect(ordinaryFilePopup).toContainText(imagePath)
|
|
await expect(ordinaryFilePopup.getByRole('button', { name: 'Open file' })).toBeVisible()
|
|
await ordinaryFilePopup.screenshot({
|
|
path: testInfo.outputPath('02-ordinary-file-popup-light.png')
|
|
})
|
|
await orcaPage.keyboard.press('Escape')
|
|
await expect(ordinaryFilePopup).toHaveCount(0)
|
|
await expect(ordinaryFileLink).toBeFocused()
|
|
|
|
await image.click()
|
|
const dialog = orcaPage.getByRole('dialog', { name: 'Inline chat screenshot' })
|
|
await expect(dialog).toBeVisible()
|
|
await expect(dialog.getByRole('img', { name: 'Inline chat screenshot' })).toBeVisible()
|
|
await expect(ordinaryFilePopup).toHaveCount(0)
|
|
await expect(orcaPage.getByRole('menu')).toHaveCount(0)
|
|
await dialog.screenshot({ path: testInfo.outputPath('03-image-dialog-light.png') })
|
|
|
|
const zoomIn = dialog.getByRole('button', { name: 'Zoom in' })
|
|
await expect(zoomIn).toBeEnabled()
|
|
await zoomIn.click()
|
|
await expect(dialog.getByRole('button', { name: 'Fit to screen' })).toBeEnabled()
|
|
const actions = dialog.getByRole('button', { name: 'File actions' })
|
|
await expect(actions).toBeVisible()
|
|
await actions.click()
|
|
await expect(orcaPage.getByRole('menu')).toBeVisible()
|
|
await dialog.screenshot({ path: testInfo.outputPath('04-image-dialog-actions-light.png') })
|
|
await orcaPage.keyboard.press('Escape')
|
|
await expect(orcaPage.getByRole('menu')).toHaveCount(0)
|
|
await expect(dialog).toBeVisible()
|
|
await dialog.getByRole('button', { name: 'Close', exact: true }).click()
|
|
await expect(dialog).toHaveCount(0)
|
|
await expect(image).toBeFocused()
|
|
|
|
await image.focus()
|
|
await orcaPage.keyboard.press('Enter')
|
|
await expect(dialog).toBeVisible()
|
|
await dialog.getByRole('button', { name: 'Close', exact: true }).click()
|
|
await expect(dialog).toHaveCount(0)
|
|
await expect(image).toBeFocused()
|
|
|
|
await image.focus()
|
|
await orcaPage.keyboard.press('Space')
|
|
await expect(dialog).toBeVisible()
|
|
await dialog.getByRole('button', { name: 'Close', exact: true }).click()
|
|
await expect(dialog).toHaveCount(0)
|
|
await expect(image).toBeFocused()
|
|
|
|
await orcaPage.evaluate(() => document.documentElement.classList.add('dark'))
|
|
await image.click()
|
|
await expect(dialog).toBeVisible()
|
|
await dialog.screenshot({ path: testInfo.outputPath('05-image-dialog-dark.png') })
|
|
await orcaPage.setViewportSize({ width: 480, height: 560 })
|
|
await expect(dialog).toBeVisible()
|
|
await dialog.screenshot({ path: testInfo.outputPath('06-image-dialog-dark-narrow.png') })
|
|
await orcaPage.keyboard.press('Escape')
|
|
await expect(dialog).toHaveCount(0)
|
|
|
|
const windows = await electronApp.evaluate(({ BrowserWindow }) =>
|
|
BrowserWindow.getAllWindows().map((window) => ({
|
|
visible: window.isVisible(),
|
|
focused: window.isFocused()
|
|
}))
|
|
)
|
|
expect(windows.length).toBeGreaterThan(0)
|
|
expect(windows.every((window) => !window.visible && !window.focused)).toBe(true)
|
|
const finalPane = await waitForPaneIdentitySnapshot(orcaPage, 1)
|
|
expect(finalPane.tabId).toBe(boundPane.tabId)
|
|
expect(finalPane.activeLeafId).toBe(boundPane.activeLeafId)
|
|
expect(finalPane.ptyIdsByLeafId).toEqual(boundPane.ptyIdsByLeafId)
|
|
expect(
|
|
await orcaPage.evaluate(
|
|
({ worktreeId, tabId, leafId }) => {
|
|
const state = window.__store?.getState()
|
|
const tab = state?.unifiedTabsByWorktree[worktreeId]?.find(
|
|
(candidate) => candidate.contentType === 'terminal' && candidate.entityId === tabId
|
|
)
|
|
return Boolean(
|
|
leafId &&
|
|
tab?.viewMode === 'chat' &&
|
|
state?.terminalLayoutsByTabId[tabId]?.chatLeafId === leafId
|
|
)
|
|
},
|
|
{
|
|
worktreeId: descriptor.worktreeId,
|
|
tabId: boundPane.tabId,
|
|
leafId: boundPane.activeLeafId
|
|
}
|
|
)
|
|
).toBe(true)
|
|
await expect(chat).toBeAttached()
|
|
} finally {
|
|
rmSync(imagePath, { force: true })
|
|
rmSync(scratchDir, { recursive: true, force: true })
|
|
}
|
|
})
|