Files
orca/tests/e2e/global-teardown.ts
NeilandOrca 46646d7ff1 chore(lint): upgrade oxlint to 1.71 + enable 7 new rules (autofixed backlog) (#6841)
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules

Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day
minimum-release-age supply-chain guard; nothing here needs it). The
bump is a no-op on the existing config.

Enable 3 error rules (backlog autofixed to zero in this commit) and
4 warn rules (surface signal without gating CI):

error (autofixed, behavior-preserving):
- unicorn/prefer-node-protocol        (~1531 sites: bare builtin -> node:)
- typescript/no-import-type-side-effects (~36: all-inline-type -> import type)
- unicorn/no-array-reverse            (19: copy-then-reverse -> toReversed)

warn (real signal, current fires are test-only/correct):
- unicorn/no-array-fill-with-reference-type  (aliasing footgun guard)
- typescript/no-unsafe-function-type         (bans bare Function type)
- unicorn/prefer-array-flat-map              (map().flat() -> flatMap())
- unicorn/prefer-regexp-test                 (.match() in bool ctx -> .test())

mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix
ran from root and covered mobile/ too.

Verification (all green): oxlint 0 errors (root+mobile+aux configs),
oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed,
builds (electron-vite + web + cli) succeed. node: rewrites confirmed to
skip embedded SSH/CLI string payloads (AST-only); all toReversed sites
verified to operate on fresh copies or write-once locals.

* chore(lint): bump mobile oxlint to 1.71 so inherited rules parse

mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which
lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since
mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile &&
oxlint' failed to parse the new rule. Bump mobile to match root (1.71).

Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit
pass, vitest 978 passed / 0 failed.

Co-authored-by: Orca <help@stably.ai>

---------

Co-authored-by: Orca <help@stably.ai>
2026-06-29 22:38:29 -07:00

40 lines
1.3 KiB
TypeScript

/**
* Playwright globalTeardown: cleans up the test git repo and worktrees.
*
* Why: the temp repo created by globalSetup should be removed after the
* test run so we don't litter the user's /tmp with test directories.
*/
import { readFileSync, existsSync, rmSync, readdirSync } from 'node:fs'
import path from 'node:path'
import { TEST_REPO_PATH_FILE } from './global-setup'
export default function globalTeardown(): void {
if (!existsSync(TEST_REPO_PATH_FILE)) {
return
}
const testRepoDir = readFileSync(TEST_REPO_PATH_FILE, 'utf-8').trim()
if (testRepoDir && existsSync(testRepoDir)) {
// Why: git worktree add creates directories as siblings. Clean up any
// seeded or test-created worktrees in the same parent so reruns remain
// idempotent and do not leak temp repos into /tmp.
const parentDir = path.dirname(testRepoDir)
try {
const siblings = readdirSync(parentDir)
for (const name of siblings) {
if (name.startsWith('orca-e2e-worktree-') || name.startsWith('e2e-test-')) {
rmSync(path.join(parentDir, name), { recursive: true, force: true })
}
}
} catch {
// Best-effort cleanup of worktrees
}
rmSync(testRepoDir, { recursive: true, force: true })
console.log(`[e2e] Cleaned up test repo at ${testRepoDir}`)
}
rmSync(TEST_REPO_PATH_FILE, { force: true })
}