Files
orca/docs/automated-setup-tab-astra-review.md
Jinjing 005f06bbc7 Run automated workspace setup in a dedicated Setup tab (#29819)
* Run automated workspace setup in a dedicated tab

* Preserve native-chat setup route coverage after placement retirement

* Preserve Setup tab design and independent review evidence

* Classify activation test fixtures consistently for routing checks

* Sync runtime English catalog after removing setup preferences

* Update listener savings model after retiring setup action
2026-10-16 14:05:50 -07:00

29 KiB
Raw Permalink Blame History

Independent review: automated Setup tab

Current review verdict

Reviewed product source head d96ae2ca6afdca919b4d7f8d85308363abe8b28b, based on the merged PR 1 commit 7f9b51cf5cc1de8769baa646b40c0c93af76be81, then the documentation-only head and CI corrections described in Rounds 6–8. P0: none found. P1: none unresolved. Design and actual source diff have converged, with concrete existing paths and no known smaller adequate implementation. Review only; this report is my only edited file. The numbered rounds below are historical checkpoints, including questions and pending checks that were subsequently resolved.

The implementation retains the existing Setup-tab creation paths and removes only automated setup split placement and its unreachable state. It retires the setting through the existing settings stripper, accepts old-host layouts, preserves manual/issue splits and generic lifecycle behavior, and leaves PR 1's native-chat provisioning change intact. No publication, sibling reattachment, generalized retry, or ownership repair was added.

Product-behavior local validation is complete. Lead's consolidated post-rebase run reports 34 Node suites / 1816 passing tests, two retained expected-failure cases, and two skips on the reviewed source; node/web typechecks and the changed-code gate passed. Rebuilt hidden paired probes passed setup output, independent Setup tab placement, background selection, manual splitting, actual native-chat surface creation, fixture terminal-agent output, and hidden/unfocused host/client windows. I inspected the proof assertions and before/after/native-chat screenshots; I did not independently rerun tests under the lead's exclusive runtime lease. The E2E typecheck comparison reports 261 baseline and 261 final errors, with no new or removed file/error-code pairs; that project remains non-clean. CI subsequently found a fixture-naming ratchet failure; its reviewed correction changes no product behavior, and lead reports both affected ratchets, 23 focused consumer suites (187 passing tests plus two retained expected failures), repeated node/web typechecks and the changed-code gate all passed.

Accepted P2 limitations: automatic side-by-side setup placement is removed by design; old hosts can still return splits; the conditional ownership fixture does not prove the incident root cause or a publication/reattachment fix; native-chat proof submits no prompt, the terminal agent is a fixture CLI, and platform construction tests do not prove Windows/WSL/SSH execution. The generated English catalog conservatively retains 20 removed-callsite strings (1,136 uncompressed bytes), without restoring settings/search UI. Its remaining nonnative preflight checks passed per the Round 7 receipt. No unresolved source-review question or local correction-validation item remains. The correction commit, exact-head full PR workflow aggregate, and parent merge decision remain separate gates; this report is not merge authorization. Worker settlement awaits the lead's explicit request.

The latest CI correction changes only a stale counterfactual listener-count expectation: the actual 15-listener budget already passed and remains unchanged. The lead reproduced the failing arithmetic under the CI Bun test path, then all four tests and the changed-code gate passed after correction. Round 8 records the independent code/history evidence; no product behavior or performance limit was changed.

Round 1 — historical design and control-flow review

Reviewed 2026-10-16 in this worktree at 54bb885bbd391642adecdaef262e87c3424f46e6. Review only; this report is my only owned file. Implementation/final-diff approval is outstanding. Tests and native builds were not run: the coordinator explicitly reserves the shared native-runtime lease for PR 1.

P0: none found. P1: no demonstrated unresolved design defect in the scoped tab-only approach. This is not approval of an implementation or proof of the incident's cause. The changes below need concrete checks after PR 1 is merged and this branch is rebased onto that baseline.

Evidence and scope

  • src/shared/worktree-first-surface.ts:11–17 explicitly seeds a primary shell for either split setting, even with callerProvidesSurface. Removing these two conditions removes a real split-anchor dependency without changing startup or issue-command requirements.
  • Existing tab implementations are sufficient: renderer worktree-setup-issue-command-queue.ts:27–45, host runtime-worktree-terminal-provisioning.ts:155–197, and IPC worktree-remote.ts:368–411. Keep these command/env/wrapper/handle paths; do not invent a coordinator, ownership store, or retry mechanism.
  • The IPC function is actually spawnLocalStartupAndSetupTerminals (worktree-remote.ts:298), not spawnCreatedWorktreeStartup. It is invoked in the local worktree flow at line 1697 despite the filename. Its no-startup/default-tabs early return at lines 308–310 matters when asserting reachability. Label this surface accurately in the design.
  • Host success suppresses fallback: runtime-local-worktree-terminal-startup.ts:203–214 omits returned setup after provisioning, while worktree-remote.ts:1741–1749 returns only unconsumed setup. Preserving this control flow is smaller and safer than command deduplication. A failed wrapped setup retains command at worktree-remote.ts:421–428; the renderer prioritizes it at worktree-setup-issue-command-queue.ts:28–32.
  • setup-split-activation-single-owner.test.ts:13–18 describes a conditional reconstruction, and its host fixture deliberately returns no session tabs at lines 103–114 while terminal census returns two orphan records at 117–123. That establishes behavior under those premises, not the original missing-binding cause. Keep manual/saved or old-host split coverage without advertising this policy change as a binding/publication repair.

Native-chat reachability: do not inflate the first-terminal concern

The desktop structured route sets backendStartup to undefined (worktree-creation-flow-execute.ts:63–68), routes explicit setup through the background seeding branch (244–269), and only then launches structured chat (289–302). IPC's early return above therefore returns setup for renderer execution. On the ordinary local route, resolveWorkspaceTerminalHostAuthority returns none (workspace-terminal-host-authority.ts:124–127), so it does not enter the first-terminal wait at worktree-initial-terminal-seeding.ts:136–169. It can use the existing null-primary Setup-tab branch at lines 172–196.

The host-authority branch really does couple returned setup to a first terminal. However, the host native-chat route normally consumes setup (runtime-local-worktree-terminal-startup.ts:174–187,203–214), and the paired agent.launch test already exercises a real request (worktree-agent-first-surface.test.ts:155–180). A P1 claim needs a request that actually returns fallback setup while host authority is live and no terminal will arrive. A constructed ensureWorktreeHasInitialTerminal call alone is insufficient. Keep generic delayed delivery unchanged in PR 2 unless PR 1's actual merged route demonstrates that necessity; ask the parent to resolve any overlap first.

Settings compatibility

Delete the live setting and type; add only a retired-key entry/destructure to stripRetiredGlobalSettings (terminal-settings-migrations.ts:59–91). The existing function covers loading (normalize-loaded-global-settings.ts:68), updates (settings-update.ts:62), and serialization (state-serialization-secret-handling.ts:262). A separate settings migration/normalization layer has no demonstrated need.

Current paired read/write types omit this key (runtime-client-settings-shape.ts:7–40,52–75), and strict RPC SettingsUpdate omits it (client-settings-params.ts:87–131). Independent bounded named-path history found:

  1. b1973657ea6 introduces SettingsUpdate in src/main/runtime/rpc/methods/client-ui.ts on 2026-05-21. Its explicit strict allowlist and getClientSettings/updateClientSettings projection in orca-runtime.ts:1142–1193 exclude setup location; the same revision uses setup location privately in host provisioning at lines 7006–7009.
  2. c84007c541d^ predates the generated RPC parameter move. rpc/methods/client-settings-schemas.ts:81–129 remains a strict allowlist without the key, and the then-inline types/projection in runtime-client-settings.ts omit it.
  3. Targeted git log -SsetupScriptLaunchMode over the current/previous schema and client-settings paths found no introduction of the key into those schemas. Historical matches in orca-runtime.ts are host provisioning uses, not paired settings fields.

This supports removal without an ignored paired field or wire-schema relaxation. Old hosts still own their placement: accept their returned split layouts without replay, flattening, migration, or interpreting a missing new preference as proof of unexecuted setup.

Explicit P2 items and acceptance details

  • P2 product tradeoff: automatic side-by-side placement disappears. Manual and issue splits remain. Users of old hosts can still receive split layouts until that host updates.
  • P2 design precision: fix the IPC function name and distinguish local IPC from actual remote-host ownership. Replace the missing Electron-skill claim with the coordinator's discovered agent-browser skills get core / electron capability and pending hidden-CDP validation.
  • P2 coverage retention: do not delete generic remount/restore/purge/PTY ownership assertions just because their fixtures mention setup. Convert them to manual/issue/old-host splits. Preserve startup identity consumption. Remove only setup-specific geometry gating (terminal-pane-mount-preparation.ts:222–225, pty-resize-geometry.ts:219–226,242–244); the visible startup-grid settle at lines 211–218 and 228 onward is broader than setup.
  • P2 selection precision: renderer Setup creation restores the primary only when activation is allowed (worktree-setup-issue-command-queue.ts:35–43). Host createTerminal does not default to focused: orca-runtime-core.ts:240–251 and terminal/launch/terminal-create.ts:252–279 distinguish focus from selection-if-empty. Missing activate:false in the host's existing tab branch is not itself proof of focus theft. Assert primary/background selection through the real route instead of changing generic focus machinery.
  • P2 setup-only/templates: simplify the mode predicate in both worktree-creation-flow-execute.ts:173–177 and runtime-worktree-terminal-provisioning.ts:129–138, while preserving explicit setupOnly intent and no-setup fallback. Do not suppress templates for ordinary blank/native-chat creation. The existing failure fallback at provisioning lines 204–221 remains necessary when Setup was the only owed surface.

Smaller alternatives and convergence

A default-only change is already inadequate: the default is already new-tab, while persisted split values still enter three separate branches and create an anchor shell. Ignoring the setting but retaining queues and geometry leaves dead lifecycle state and fails the requested removal. Replacing the three setup placement branches with their existing tab arm, removing only now-unreachable setup plumbing, and retiring the setting through the existing stripper is the smallest adequate design found.

Before declaring design convergence, lead should confirm the corrected route labels, the historical-settings evidence above, and that no first-terminal or publication/reattach work will slip into PR 2 without actual post-PR-1 reachability evidence. No unresolved P0/P1 is currently demonstrated. Final convergence remains conditional on reviewing actual code and meaningful tests, including old-host no-replay, remount one-shot execution, setup-only/defaults, native-chat/terminal/background routes, sequencing failure fallback, and preserved manual/issue splits. Windows/WSL/SSH command tests establish construction behavior only; do not claim those platforms were executed unless they were.

Round 2 — design convergence

Re-read the revised design after durable message msg_bf91c03835ff. The lead incorporated the correct local-IPC function/route, historical paired-schema evidence, first-terminal reachability qualification, and the PR 1/publication/reattachment boundaries. The design retains generic startup-grid settling and requires retargeting generic split fixtures. The Electron capability statement now identifies the installed specialization and keeps validation pending.

Design converged: no unresolved P0/P1, concrete implementation paths identified, and no known smaller adequate design. The P2 product tradeoff and old-host behavior are explicit and accepted within scope. This permits scoped source implementation; it does not approve unreviewed code, tests, or merging. Re-evaluate against PR 1's exact merged baseline before final review.

Implementation review

At this historical checkpoint, lead revision, PR 1 baseline, actual final diff and test results were pending; their resolution appears in the later rounds and current verdict above. Do not interpret this report as a merge authorization.

Interim fixture review

At the lead's request (msg_76639d99e47e), inspected the retargeted delayed-primary/sibling-fallback test in pty-connection-split-spawn.spec.ts:235–338. Its CWD promise is a real generic delay (run-deferred-connect.ts:74–103), but then it waits for visible startup-grid settling; 20 shared animation callbacks are not necessarily 12 primary settle ticks when the sibling has its own resize callbacks. Recommended making both explicit-startup panes hidden, retaining the CWD gate and shared transport registry, then asserting sibling-first ownership before resolving the primary CWD. Existing pty-connection-deliberate-sleep-guard.spec.ts:183–213 demonstrates this hidden CWD gate. This preserves the ownership regression purpose without changing production reattachment or restoring removed setup geometry. Lead must verify the proposed fixture correction; reviewer did not run tests or edit source.

Round 3 — implementation review before PR 1 rebase

Reviewed the restored working diff after msg_065efb1f75ff (base remains 54bb885bbd391642adecdaef262e87c3424f46e6). No production P0/P1 found. A final post-PR-1-baseline verdict remains outstanding.

  • All three placement changes retain the existing tab arm. Runtime retains completion-token registration, default-tab dressing, explicit setup-only suppression and failed-Setup fallback. IPC retains its wrapper, platform/shell builder, env, inactive/background options, and consumed-result behavior. No setup execution authority or retry mechanism was introduced.
  • The removed state is setup-specific. Issue-command queues/consumption remain; terminal-pane-mount-bootstrap.test.ts checks the surviving primary-anchor split, env, focus policy and one-shot command clearing. terminal-pane-pane-created.ts still passes the captured raw startup identity to createQueuedStartupConsumer after removal of the setup-wait copy.
  • terminal-startup-grid-settle.ts removes only the now-unused readiness predicate and its frame counter. With no predicate, old readyFrame and frame advanced together, and usesReadinessGate was false; the remaining algorithm therefore preserves the former generic branch. Grid stability/cap/cancellation tests and hidden-window start tests remain.
  • Compared old and new PTY test-case names: only the obsolete setup-geometry case was deleted; delayed-primary was retargeted, and remount, resize/mobile locks, hidden startup, and replay cases remain. The final hidden-CWD delayed-primary fixture explicitly proves sibling ownership before release and then asserts a distinct primary PTY; lead reports 78/78 passing.
  • Existing old-host first-activation reconstruction retains its layout/ownership assertions and now asserts an empty pending-startup map. Its expected-failure branch remains an acknowledged existing limitation, not a claimed fix. Purge/sleep tests retain issue-queue and generic startup coverage while removing only the deleted map's assertions.
  • Stale settings are removed on load, update and save/reload by meaningful persistence tests; remaining setup-location references are deliberate stale-profile test input or the stripper. No paired RPC schema change or saved-layout migration was introduced.
  • Inspected setup-before.png and setup-after.png directly in .bench-fixtures/setup-split-removal-proof: before has a split inside one terminal tab, after has Terminal 1 and Setup tabs with one visible Setup pane; both display the setup completion marker. Screenshots alone do not prove hidden/focus state; the proof's explicit BrowserWindow assertions and lead's execution receipt cover that separately.

P2 correction requested (msg_ce3248db323b): host-split-and-sleep-journeys.ts:56 calls public terminal.split, whose RPC handler (terminal-lifecycle-methods.ts:96–101) does not forward inactive options; terminal-split-surface.ts:129,169 defaults activation to true. Thus the renamed host-split-first-activation journey can activate during fixture creation and overstates its coverage. Preserve inactive-first-open through an existing internal test seam, or explicitly navigate away and label this a reactivation fixture, retaining genuine old-host first-open coverage in the unit test. Do not broaden production RPC for the fixture. Also asked the lead to format/check the new proof spec and replace its unchecked result cast.

Validation reported by lead: 34 Node files / 1799 tests with two existing expected-fail cases and two skipped; a separate 78-test PTY fixture run; node/web typechecks; changed-file quality gate. Reviewer has not independently executed these under the lead's exclusive native lease. Final logs/results, E2E typecheck baseline comparison, corrected P2 fixture, PR 1 merged-base adaptation, and exact-head workflow gates remain to be assessed.

Round 3 follow-up: verified the P2 fixture correction after msg_b7784f689bca: host-split-and-sleep-journeys.ts:57 returns to the seeded workspace and the oracle scenario is now host-split-reactivation. The old-host first-activation unit assertions remain. This resolves the misleading-coverage finding without broadening production scope. The lead will keep the one-off before/after probe under ignored proof artifacts, not in the PR. Lead also reports both hidden before/after probes passed output, tab/pane count, retained manual split, background-selection and hidden/unfocused-window assertions. No unresolved P0/P1 in the currently reviewed PR 2 diff; post-PR-1 review is still required.

Round 4 — exact PR 1 merged baseline

Verified locally that merge-base(64fbb53d8a4c92e17c5aa19a8aa86cd1869979bc, 7f9b51cf5cc1de8769baa646b40c0c93af76be81) is the exact PR 1 merge 7f9b51cf5cc1de8769baa646b40c0c93af76be81. The PR 2 diff does not modify PR 1's production runtime-local-worktree-terminal-startup.ts: its shared callerProvidesInitialSurface predicate still supplies the host's background agent ownership decision, and host success still suppresses returned setup at lines 202–209.

Reviewed the only uncommitted overlap adaptation, src/main/runtime/orca-runtime-tests/worktree-native-chat-setup.spec.ts. It retains renderer payload construction → strict RPC parse → runtime argument builder → actual managed-worktree create (lines 72–91), and expands the Claude/Codex setup-only-host assertion across both stale split values, new-tab, and absent settings (95–113). It checks command/env, running setup receipt, consumed setup and absence of an invented startup terminal. Former split-anchor controls now request a real startup and verify distinct startup/Setup tab identities (132–143). Blank, activating attribution, run-hooks, skipped setup and default-command controls remain. The stale field is fixture-only and no deleted live type remains.

Post-rebase semantic review: no unresolved P0/P1, no duplicated PR 1 production change, and no smaller adequate alternative identified. The accepted P2 product/old-host limitations remain as documented. Final post-rebase checks/proof and the eventual exact-head CI/merge authorization are still separate gates; reviewer is awaiting their receipts and the lead's explicit settlement request.

Round 5 — committed-head confirmation

Verified the clean tracked worktree at d96ae2ca6afdca919b4d7f8d85308363abe8b28b. Its only change from the Round 4 checkpoint is the already-reviewed native-chat setup test adaptation above; no additional production changes were introduced. P0: none found. P1: none unresolved. The actual PR 2 diff has converged, with no known smaller adequate implementation.

Post-rebase validation receipt from lead (msg_87e2f64711ef): 1443 focused/runtime tests passed with one existing skip; node/web typechecks and the changed-code gate passed; the rebuilt paired hidden placement proof passed two tabs/one Setup pane, actual setup output, retained background selection, manual splitting, and hidden/unfocused BrowserWindow assertions. These are lead-executed results under the exclusive runtime lease, not independently rerun tests. The extra native-chat agent.launch probe and final E2E typecheck comparison remain pending and must not be described as passed yet.

Accepted P2 limitations remain: automatic side-by-side setup placement is intentionally removed; old hosts may still publish split layouts; the preserved conditional ownership fixture is not incident root-cause proof or a publication/reattachment fix; Windows/WSL/SSH construction tests do not establish execution on those platforms. The E2E typecheck has a reported baseline of 261 pre-existing file/code failures, with the final comparison still outstanding. This confirms source review on the named head, not exact-head CI or merge authorization. Worker settlement remains pending the lead's explicit request.

Round 5 validation follow-up (msg_b865b628c0e7): lead reports the additional final-baseline hidden probe passed. Independently read its actual paired agent.launch calls and assertions: background Claude creates a structured chat, the rendered workspace contains exactly one agent-session and one terminal, and the terminal-agent route creates two terminal tabs and displays the fixture CLI marker. Directly inspected native-chat-after.png, which shows Setup and Claude Chat with an empty composer. This proves native-chat surface creation, not a model turn; no prompt was submitted. The terminal-agent check uses a fixture CLI, not a real Codex session. The probe asserts every host/client BrowserWindow is hidden and unfocused.

Read e2e-typecheck-comparison.json: baseline and final each have 261 errors, with empty new/removed file-and-TypeScript-code lists. Thus no new errors were found by that comparison, while the E2E project itself is not typecheck-clean. These receipts resolve the two pending validation items above. Final source-review verdict on d96ae2ca6afdca919b4d7f8d85308363abe8b28b: no unresolved P0/P1; accepted P2 limitations are explicit; no known smaller adequate design. Awaiting explicit settlement or any CI-driven source revision.

Final consolidated receipt (msg_6734645deb90): the lead reran all 34 selected Node suites after rebasing, reporting 1816 passing tests, two retained expected failures and two skips on the same source head. This supersedes the earlier focused-test counts as the final consolidated local result. All requested local validation items are resolved with the limitations stated in the current verdict; exact-head PR CI and parent merge approval remain outstanding.

Round 6 — CI fixture classification correction

Verified documentation-only head c6cdb67aaaf1cc7e0a2b5befa7e6e8b7cbb8cab2 preserved the reviewed product source. CI then rejected two fixture calls to getDefaultSettings under the focus-read ratchet. These calls replaced incomplete asserted settings during the setup preference removal; they did not add production execution-host routing.

Independently inspected both fixtures and all repository references before and after the staged correction. Both modules import Vitest, and every discovered consumer is a .test.ts file. check-focus-read-ratchet.mjs:357–359 already excludes .test-fixture.ts, with direct coverage at check-focus-read-ratchet.test.mjs:244. Renaming to worktree-activation-created-agent.test-fixture.ts and worktree-activation.test-fixture.ts therefore applies the existing test/product distinction. The staged renames are 100% content-identical; every import edit is test-only. The existing layout detector also excludes fixtures (check-layout-writer-ratchets.mjs:161–165), so the correction deletes the one obsolete 21-writer baseline row for the old filename. Neither detector nor any allowance was expanded.

No new P0/P1/P2 finding in this correction; prior accepted P2 limitations remain. Conventional fixture naming is smaller and more accurate than a detector change, a suppression, duplicating defaults, restoring unchecked settings casts, or adding baseline allowances. Final correction receipt (msg_b98097cf4ff3): both ratchets passed, 23 focused consumer suites passed 187 tests with two retained expected failures, node/web typechecks passed, and the changed-code gate against the exact PR 1 baseline passed. Existing product-behavior and rendered proof receipts remain applicable; a hidden-app rebuild is unnecessary for content-identical fixture renames and test import changes. No local correction-validation item remains pending. Fresh exact-head full PR CI and parent merge approval are still required.

Round 7 — generated English catalog correction

Verified clean committed fixture-correction head fe855b8c97ddf90c0d2ad273f1355cf711ee5d8e exactly matched Round 6. CI then failed catalog verification: removing the Setup UI/search callsites leaves English catalog entries without literal defaults. The existing collectRuntimeRequiredKeys contract (generate-runtime-required-english-catalog.mjs:45–82) conservatively retains such entries because they may be dynamically referenced; it does not attempt dead-key reachability analysis. The verifier prescribes the existing sync:localization-runtime-catalog generator.

Independently compared flattened JSON before/after generation and the deleted callsites: exactly 20 added entries, zero removed or changed entries, all 20 keys present in the removed setup UI/search code. The uncompressed generated file grows by 1,136 bytes. There is no unrelated generator churn and no restored UI or search registration. Regenerating this single derived catalog is the smallest conservative correction; pruning locale translations requires a broader dynamic-key/locale audit, and changing the verifier would weaken an unrelated contract.

No new P0/P1; accepted P2: some obsolete English text remains in the boot catalog under its existing conservative policy. This does not restore setup split behavior. Lead's final receipt (msg_83f4e9157231) reports the remaining nonnative gates passed: localization catalogs/extraction/coverage using the CI Bun commands, feature-wall budget, macOS entitlements, and preload/shared declaration guard. The unit-plan script completed its local full-reference fallback, which is not itself proof of the CI plan; lead separately reports the actual CI plan and all static steps preceding catalog verification, including Typecheck, had passed. No local correction-validation item remains pending. Fresh exact-head full PR CI and parent merge approval remain required after the correction commit.

Round 8 — stale listener-savings arithmetic

Verified committed catalog head 35f132ba2547422cb6e11e00d1b631528fdab424 matched Round 7. A required unit shard then failed terminal-pane-store-subscription-budget.test.tsx. Independently traced the exact assertions: the live per-pane budget remains 15 and its assertion passes; the failure is the later equation 45 - 15 = actionKeys.length + 6, where the action list is now 23, making the right side 29 rather than 30. It is not a measured increase to 30 live subscriptions.

PR 2 removed consumeTabSetupSplit from the stable useMemo/getState action binding and removed a useState initializer that reads pendingSetupSplitByTabId through getState. Neither opened a subscription. The PRE_FOLD_LISTENERS_PER_PANE comment defines a counterfactual current mount with one listener per bound action, not an immutable historical observation. Bounded history corroborates its intended updates: 3e25fe70f6b lowered 46 to 45 for removal of readTerminalPaneOnInput; 93baa828be9 lowered 50 to 46 for four removed actions. Both retained the actual live budget.

The reviewed correction changes only PRE_FOLD_LISTENERS_PER_PANE from 45 to 44 and makes the stale action-count comment count-neutral. The exact 15-listener assertion, linear scaling, zero-listener stable-action binding and action identity assertions remain unchanged. This is smaller than introducing a retired-action offset or changing the test model, and does not loosen any live performance limit. No new P0/P1/P2; prior accepted P2 limitations remain.

Lead's receipt (msg_278eaae4e38e): the exact Bun path reproduced one savings-equation failure with three tests passing before the change; all four passed afterward, and the changed-code gate against the exact PR 1 baseline passed. No product source changed. Existing product validation remains applicable; fresh exact-head full CI and parent merge approval remain separate pending gates.