mirror of
https://github.com/stablyai/orca.git
synced 2026-11-16 02:47:34 +00:00
* [comment audit] Align legacy failure-read counts with cached display * [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci] * [comment audit] Condense shared generation, path and preview comments [skip ci] * [comment audit] Condense host, file and Git contract rationale [skip ci] * [comment audit] Tighten Git lifecycle and provider contract comments [skip ci] * [comment audit] Clarify shared host authority and launch isolation [skip ci] * [comment audit] simplify local access mobile and native chat contracts [skip ci] * [comment audit] simplify native chat presentation and state contracts [skip ci] * [comment audit] simplify native runtime and provider contracts [skip ci] * [comment audit] simplify migration and orchestration contracts [skip ci] * [comment audit] simplify plugin trust and process capture rationale [skip ci] * [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci] * [comment audit] clarify remote recovery and launch wire rationale [skip ci] * [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci] * [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci] * [comment audit] clarify sidebar, skill and SSH invariants [skip ci] * [comment audit] condense structured chat delivery and timing rationale [skip ci] * [comment audit] condense terminal replay and telemetry invariants [skip ci] * [comment audit] clarify launch permission and terminal delivery rationale [skip ci] * [comment audit] clarify workspace ownership and layout contracts [skip ci] * [comment audit] wait for fitted and painted SSH terminal links * [comment audit] clarify layout persistence and session ownership [skip ci] * [comment audit] clarify host routing and workspace lifecycle contracts [skip ci] * [comment audit] clarify startup persistence and app lifetime comments [skip ci] * [comment audit] clarify recovery and activity boundaries [skip ci] * [comment audit] condense activity and artifact invariants [skip ci] * [comment audit] condense automation authority contracts [skip ci] * [comment audit] simplify automation scheduling and history contracts [skip ci] * [comment audit] clarify browser chrome and annotation lifecycles [skip ci] * [comment audit] clarify browser routing and retained guest ownership [skip ci] * [comment audit] clarify browser recovery and document ownership comments [skip ci] * [comment audit] restore hosted runners required by native IME fixtures * [comment audit] shorten preview, palette and dashboard invariants [skip ci] * [comment audit] clarify terminal preview, dashboard and retention comments [skip ci] * [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci] * [comment audit] shorten rich-text and combined-diff ownership comments [skip ci] * [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci] * [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci] * [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci] * [comment audit] clarify rich Markdown source and selection safeguards [skip ci] * [comment audit] clarify editor loading and emulator stream lifetimes [skip ci] * [comment audit] trim emulator and feature tour narration [skip ci] * [comment audit] clarify floating workspace and GitHub cache ownership [skip ci] * [comment audit] trim provider controls and Linear filter explanations [skip ci] * [comment audit] clarify pairing and chat resume lifetimes [skip ci] * [comment audit] clarify chat delivery and transcript lifetimes [skip ci] * [comment audit] clarify session options and host-owned status [skip ci] * [comment audit] clarify draft durability and live-status precedence [skip ci] * [comment audit] Trim chat send and model ownership explanations [skip ci] * [comment audit] Shorten transcript ownership and send recovery comments [skip ci] * [comment audit] Simplify native chat composer and transcript hook comments [skip ci] * [comment audit] Shorten native chat scroll and structured session explanations [skip ci] * [comment audit] Trim workspace picker and onboarding commentary [skip ci] * [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci] * [comment audit] Trim sidebar and session history explanations [skip ci] * [comment audit] Condense session resume and review checks comments [skip ci] * [comment audit] Shorten checks state and file explorer refresh comments [skip ci] * [comment audit] Trim plugin bridge and source-control action rationale [skip ci] * [comment audit] Trim source-control listing and review rationale [skip ci] * [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci] * [comment audit] Condense Settings account and appearance rationale [skip ci] * [comment audit] Trim pairing and repository Settings explanations [skip ci] * [comment audit] Condense Settings search SSH and terminal safeguards [skip ci] * [comment audit] Shorten Settings voice and provider ownership comments [skip ci] * [comment audit] Condense Settings draft persistence and host-state rationale [skip ci] * [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci] * [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci] * [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci] * [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci] * [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci] * [comment audit] Prune focus-read baseline after comment cleanup * [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci] * [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci] * [comment audit] Clarify viewport geometry and skill update safeguards [skip ci] * [comment audit] Tighten skill inventory, usage and host status comments [skip ci] * [comment audit] Clarify usage ownership and resource kill safeguards [skip ci] * [comment audit] Tighten tab selection, rename and search contracts [skip ci] * [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci] * [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci] * [comment audit] Tighten provider loading and terminal recovery comments [skip ci] * [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci] * [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci] * [comment audit] Tighten PTY startup and replay explanations [skip ci] * [comment audit] Clarify PTY identity and delivery ownership [skip ci] * [comment audit] Shorten remote reconnect and input replay rationale [skip ci] * [comment audit] Condense terminal parking clipboard and file link comments [skip ci] * [comment audit] Clarify IME ownership and trim trace history [skip ci] * [comment audit] Shorten pane recovery and parked watcher explanations [skip ci] * [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci] * [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci] * [comment audit] Trim renderer lifecycle and menu rationale [skip ci] * [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci] * [comment audit] Clarify renderer hook evidence and source ownership [skip ci] * [comment audit] Tighten IPC ownership and reconnect explanations [skip ci] * [comment audit] Trim renderer focus, paste and attention comments [skip ci] * [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci] * [comment audit] Trim agent launch, resume and ownership commentary [skip ci] * [comment audit] Shorten account, browser and editor comments [skip ci] * [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci] * [comment audit] Condense launch recovery and editor tokenization comments [skip ci] * [comment audit] Condense workspace selection and terminal pane rationale [skip ci] * [comment audit] Condense terminal fitting and rendering recovery comments [skip ci] * [comment audit] Condense terminal input and host routing explanations [skip ci] * [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci] * [comment audit] Condense structured launch and terminal link explanations [skip ci] * [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci] * [comment audit] Condense session persistence and workspace activation rationale [skip ci] * [comment audit] Condense workspace routing and browser ownership rationale [skip ci] * [comment audit] Condense mirror recovery and layout authority rationale [skip ci] * [comment audit] Condense runtime transport and file safety rationale [skip ci] * [comment audit] Condense runtime graph and structured session rationale [skip ci] * [comment audit] Condense browser creation and remote tab recovery rationale [skip ci] * [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci] * [comment audit] Condense frame, startup and provider cache rationale [skip ci] * [comment audit] Condense host twin and agent lifecycle rationale [skip ci] * [comment audit] Condense browser authority and editor cleanup rationale [skip ci] * [comment audit] Condense editor buffer identity and review cache rationale [skip ci] * [comment audit] Condense provider lifetime and repository ownership rationale [skip ci] * [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci] * [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci] * [comment audit] Condense cleanup ownership and listing admission rationale [skip ci] * [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci] * [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci] * [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci] * [comment audit] Condense cloud rollout and assignment safety rationale [skip ci] * [comment audit] Condense relay session and database recovery rationale [skip ci] * [comment audit] Condense relay placement and protocol compatibility rationale [skip ci] * [comment audit] Condense build and packaging constraints [skip ci] * [comment audit] Condense CI gates and validation isolation rationale [skip ci] * [comment audit] Condense catalog identity and browser validation rationale [skip ci] * [comment audit] Condense mobile browser and frame-budget rationale [skip ci] * [comment audit] Shorten mobile route and browser test explanations [skip ci] * [comment audit] Condense editor and session seam test rationale [skip ci] * [comment audit] Trim session and terminal closure history [skip ci] * [comment audit] Shorten terminal browser and census explanations [skip ci] * [comment audit] Preserve root-only E2E diagnostic baseline * [comment audit] Condense mobile seam and HTML preview test rationale [skip ci] * [comment audit] Condense preview instrumentation and render harness rationale [skip ci] * [comment audit] Condense bundle contracts and native-build constraints [skip ci] * [comment audit] Shorten native packaging and CI routing rationale [skip ci] * [comment audit] Condense release tooling and benchmark constraints [skip ci] * [comment audit] Condense packaging and platform gate rationale [skip ci] * [comment audit] Shorten mobile route and history rationale [skip ci] * [comment audit] Condense mobile browser and component rationale [skip ci] * [comment audit] Shorten drawer and workspace-form rationale [skip ci] * [comment audit] Trim mobile review and editor-document explanations [skip ci] * [comment audit] Condense editor lifecycle and Markdown explanations [skip ci] * [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci] * [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci] * [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci] * [comment audit] Condense bridge stream, native request and audio rationale [skip ci] * [comment audit] Reduce bridge schema and page-client commentary [skip ci] * [comment audit] Tighten mobile page bridge contracts [skip ci] * [comment audit] Clarify mobile cache and session constraints [skip ci] * [comment audit] Condense mobile route and lifecycle rationale [skip ci] * [comment audit] Tighten mobile shell hook timing rationale [skip ci] * [comment audit] Clarify route handoff and notification compatibility [skip ci] * [comment audit] Clarify push registration and dictation cleanup constraints [skip ci] * [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci] * [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci] * [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci] * [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci] * [comment audit] Tighten stream replay and queued session ownership rationale [skip ci] * [comment audit] Condense mobile composer and reply-schema constraints [skip ci] * [comment audit] Clarify mobile transcript recovery and session ownership [skip ci] * [comment audit] Clarify mobile queue and source-control compatibility [skip ci] * [comment audit] Condense storage and task launch constraints [skip ci] * [comment audit] Clarify task schemas and terminal document ownership [skip ci] * [comment audit] Tighten terminal input and viewport rationale [skip ci] * [comment audit] Shorten terminal and RPC recorder contracts [skip ci] * [comment audit] Condense recorder engine and connection contracts [skip ci] * [comment audit] Shorten host credential and relay recovery comments [skip ci] * [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci] * [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci] * [comment audit] Condense catalog and relay entry contracts [skip ci] * [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci] * [comment audit] Condense WSL relay and E2E regression rationale [skip ci] * [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci] * [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci] * [comment audit] Shorten layout oracle and regression explanations [skip ci] * [comment audit] Condense paired recovery and ownership regression contracts [skip ci] * [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci] * [comment audit] Condense terminal rendering and IME regression rationale [skip ci] * [comment audit] Shorten terminal recovery and benchmark contracts [skip ci] * [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci] * [comment audit] Condense workflow routing and release rationale [skip ci] * [comment audit] Condense mobile security and installer contracts [skip ci] * [comment audit] Shorten native rationale and stylesheet workarounds [skip ci] * [comment audit] Shorten Windows visibility probe rationale [skip ci] * [comment audit] Condense embedded release and signing rationale [skip ci] * [comment audit] Retain current main test behavior in final reconciliation [skip ci] * [comment audit] Complete final comment review across current source inventory * [comment audit] Handle consolidated audit reports before final CI * [comment audit] Preserve credential storage census detail [skip ci] * [comment audit] Scale broad changed E2E selections with verified timing shards * [comment audit] Align E2E assertions with browser close and settled session metadata * [comment audit] Match existing E2Es to current resource and windowing contracts * [comment audit] Observe the shared server outage notice in reconnect coverage * [comment audit] Make existing renderer probes measure settled tab and PTY work * [comment audit] Align palette E2E selector with task search * [comment audit] Refresh remaining palette search selectors * [comment audit] Keep selector correction within selected audit specs * [comment audit] Await emoji fixture settings inside renderer evaluation * [comment audit] Cancel fixture fit retries between terminal tests --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
322 lines
14 KiB
TypeScript
322 lines
14 KiB
TypeScript
// With ORCA_SIDEBAR_INPUTS=main, follow main’s feed while window drag/create/open/collapse changes still commit immediately.
|
||
import type { Page } from '@stablyai/playwright-test'
|
||
import { expect, test } from './helpers/orca-app'
|
||
import { removeWorktreeViaStore } from './helpers/dead-terminal'
|
||
import { SIDEBAR_INPUTS_BUILD } from './helpers/sidebar-inputs-build'
|
||
import { openSidebarWorkspaceComposer } from './helpers/sidebar-project-dialog'
|
||
import { waitForActiveWorktree, waitForSessionReady } from './helpers/store'
|
||
|
||
test.skip(!SIDEBAR_INPUTS_BUILD, 'the window reads main only in an ORCA_SIDEBAR_INPUTS=main build')
|
||
|
||
const ROWS = '[data-worktree-sidebar] [role="option"][data-worktree-id]'
|
||
|
||
function renderedOrder(page: Page): Promise<string[]> {
|
||
return page.locator(ROWS).evaluateAll((elements) =>
|
||
elements
|
||
.map((element) => ({
|
||
id: element.getAttribute('data-worktree-id') ?? '',
|
||
top: element.getBoundingClientRect().top
|
||
}))
|
||
.sort((left, right) => left.top - right.top)
|
||
.map((entry) => entry.id)
|
||
)
|
||
}
|
||
|
||
/** One committed sidebar DOM state. `afterInput`: committed once the first input began.
|
||
* `inInputTask`: committed within the task of an input, before any later task could run. */
|
||
type DomState = {
|
||
ids: string[]
|
||
shows: boolean
|
||
current: string | null
|
||
afterInput: boolean
|
||
inInputTask: boolean
|
||
}
|
||
|
||
type DomLog = { stop: () => Promise<{ states: DomState[]; inputs: string[] }> }
|
||
|
||
// Record every committed DOM state within the input task: local changes can commit there, main IPC replies cannot.
|
||
// Use committed DOM rather than paint because hidden windows may never paint.
|
||
async function startDomLog(page: Page, text = ''): Promise<DomLog> {
|
||
const handle = await page.evaluateHandle(
|
||
({ selector, wanted }) => {
|
||
const states: (Omit<DomState, 'afterInput' | 'inInputTask'> & { at: number })[] = []
|
||
const inputs: { type: string; at: number; nextTaskAt: number }[] = []
|
||
// Use event time because React may commit before this listener; posted messages close the observation window next task.
|
||
const onInput = (event: Event): void => {
|
||
const input = { type: event.type, at: event.timeStamp, nextTaskAt: Infinity }
|
||
inputs.push(input)
|
||
const channel = new MessageChannel()
|
||
channel.port1.onmessage = () => {
|
||
input.nextTaskAt = performance.now()
|
||
channel.port1.close()
|
||
}
|
||
channel.port2.postMessage(null)
|
||
}
|
||
// Why drop and dragend: a native drag ends in them, with no mouseup on Linux.
|
||
const events = ['pointerup', 'mouseup', 'click', 'drop', 'dragend']
|
||
for (const type of events) {
|
||
window.addEventListener(type, onInput, true)
|
||
}
|
||
const sidebar = document.querySelector('[data-worktree-sidebar]')
|
||
const record = (): void => {
|
||
const rows = [...document.querySelectorAll<HTMLElement>(selector)].sort(
|
||
(a, b) => a.getBoundingClientRect().top - b.getBoundingClientRect().top
|
||
)
|
||
states.push({
|
||
ids: rows.map((row) => row.dataset.worktreeId ?? ''),
|
||
shows: wanted !== '' && (sidebar?.textContent ?? '').includes(wanted),
|
||
current:
|
||
rows.find((row) => row.getAttribute('aria-current') === 'page')?.dataset.worktreeId ??
|
||
null,
|
||
at: performance.now()
|
||
})
|
||
}
|
||
// A mutation callback runs after each commit, so it sees every state React commits.
|
||
const observer = new MutationObserver(record)
|
||
if (sidebar) {
|
||
observer.observe(sidebar, {
|
||
subtree: true,
|
||
childList: true,
|
||
attributes: true,
|
||
characterData: true
|
||
})
|
||
}
|
||
record()
|
||
return () => {
|
||
observer.disconnect()
|
||
for (const type of events) {
|
||
window.removeEventListener(type, onInput, true)
|
||
}
|
||
const firstInputAt = inputs[0]?.at ?? Infinity
|
||
return {
|
||
states: states.map(({ at, ...state }) => ({
|
||
...state,
|
||
afterInput: at >= firstInputAt,
|
||
inInputTask: inputs.some((input) => input.at <= at && at <= input.nextTaskAt)
|
||
})),
|
||
inputs: inputs.map((input) => input.type)
|
||
}
|
||
}
|
||
},
|
||
{ selector: ROWS, wanted: text }
|
||
)
|
||
return { stop: () => handle.evaluate((stop) => stop()) }
|
||
}
|
||
|
||
/** The index of the first state after the input that satisfies `reached`, or -1. */
|
||
function firstAfterInput(states: DomState[], reached: (state: DomState) => boolean): number {
|
||
return states.findIndex((state) => state.afterInput && reached(state))
|
||
}
|
||
|
||
async function dragBefore(page: Page, sourceId: string, targetId: string): Promise<void> {
|
||
const source = page.locator(`${ROWS}[data-worktree-id=${JSON.stringify(sourceId)}]`).first()
|
||
const target = page.locator(`${ROWS}[data-worktree-id=${JSON.stringify(targetId)}]`).first()
|
||
const sourceBox = await source.boundingBox()
|
||
const targetBox = await target.boundingBox()
|
||
if (!sourceBox || !targetBox) {
|
||
throw new Error('drag geometry unavailable')
|
||
}
|
||
await page.mouse.move(sourceBox.x + sourceBox.width / 2, sourceBox.y + sourceBox.height / 2)
|
||
await page.mouse.down()
|
||
await page.mouse.move(targetBox.x + targetBox.width / 2, targetBox.y + 3, { steps: 8 })
|
||
await page.mouse.up()
|
||
}
|
||
|
||
test('the sidebar lists main’s inputs and keeps drag, create, open and collapse instant', async ({
|
||
orcaPage
|
||
}, testInfo) => {
|
||
test.setTimeout(180_000)
|
||
await waitForSessionReady(orcaPage)
|
||
await waitForActiveWorktree(orcaPage)
|
||
const created = await orcaPage.evaluate(async () => {
|
||
const state = window.__store!.getState()
|
||
state.setGroupBy('none')
|
||
state.setSortBy('manual')
|
||
state.setShowSleepingWorkspaces(true)
|
||
const repoId = state.allWorktrees()[0]!.repoId
|
||
const ids: string[] = []
|
||
for (const name of ['reads-main-a', 'reads-main-b', 'reads-main-c']) {
|
||
ids.push((await state.createWorktree(repoId, name, undefined, 'skip')).worktree.id)
|
||
}
|
||
return ids
|
||
})
|
||
try {
|
||
const ours = async (): Promise<string[]> =>
|
||
(await renderedOrder(orcaPage)).filter((id) => created.includes(id))
|
||
await expect.poll(async () => (await ours()).length, { timeout: 30_000 }).toBe(3)
|
||
await orcaPage.screenshot({ path: testInfo.outputPath(`list.png`) })
|
||
|
||
// Empty local catalog for one task; main-owned rows must remain before any refetch reply.
|
||
const listedWhileEmptied = await orcaPage.evaluate(async (selector) => {
|
||
window.__store!.setState({ worktreesByRepo: {} })
|
||
await new Promise((resolve) => setTimeout(resolve, 0))
|
||
return document.querySelectorAll(selector).length
|
||
}, ROWS)
|
||
expect(listedWhileEmptied).toBeGreaterThan(0)
|
||
await orcaPage.evaluate(() => window.__store!.getState().fetchAllWorktrees())
|
||
await expect.poll(async () => (await ours()).length).toBe(3)
|
||
|
||
// Drag: the new order shows in the drop's own task, and no later state snaps back.
|
||
const before = await ours()
|
||
const source = before[2]!
|
||
const dragLog = await startDomLog(orcaPage)
|
||
await dragBefore(orcaPage, source, before[0]!)
|
||
const expected = [source, before[0]!, before[1]!]
|
||
await expect.poll(ours).toEqual(expected)
|
||
await orcaPage.waitForTimeout(400)
|
||
const drag = await dragLog.stop()
|
||
const oursIn = (state: DomState): string =>
|
||
state.ids.filter((id) => created.includes(id)).join()
|
||
const dropShown = firstAfterInput(drag.states, (state) => oursIn(state) === expected.join())
|
||
expect(dropShown, `inputs seen: ${drag.inputs.join() || 'none'}`).toBeGreaterThanOrEqual(0)
|
||
expect(drag.states[dropShown]!.inInputTask).toBe(true)
|
||
expect(
|
||
drag.states
|
||
.slice(dropShown)
|
||
.map(oursIn)
|
||
.filter((order) => order !== expected.join())
|
||
).toEqual([])
|
||
await orcaPage.screenshot({ path: testInfo.outputPath(`after-drag.png`) })
|
||
|
||
// Open: the clicked row is highlighted in the click's own task.
|
||
const openId = expected[1]!
|
||
const openLog = await startDomLog(orcaPage)
|
||
await orcaPage
|
||
.locator(`${ROWS}[data-worktree-id=${JSON.stringify(openId)}]`)
|
||
.first()
|
||
.click()
|
||
await expect(
|
||
orcaPage.locator(`${ROWS}[data-worktree-id=${JSON.stringify(openId)}][aria-current="page"]`)
|
||
).toHaveCount(1)
|
||
const openStates = (await openLog.stop()).states
|
||
const opened = firstAfterInput(openStates, (state) => state.current === openId)
|
||
expect(opened).toBeGreaterThanOrEqual(0)
|
||
expect(openStates[opened]!.inInputTask).toBe(true)
|
||
|
||
// Cmd/Ctrl+1–9 number the rendered rows.
|
||
const rendered = await renderedOrder(orcaPage)
|
||
const modifier = process.platform === 'darwin' ? 'Meta' : 'Control'
|
||
await orcaPage.keyboard.press(`${modifier}+2`)
|
||
await expect
|
||
.poll(() => orcaPage.evaluate(() => window.__store!.getState().activeWorktreeId))
|
||
.toBe(rendered[1])
|
||
|
||
// Collapse: the section's rows leave in the click's own task, without waiting for main.
|
||
await orcaPage.evaluate(() => window.__store!.getState().setGroupBy('repo'))
|
||
await expect.poll(async () => (await ours()).length).toBe(3)
|
||
const header = orcaPage.locator('[data-worktree-sidebar] [data-repo-header-id][aria-expanded]')
|
||
const collapseLog = await startDomLog(orcaPage)
|
||
await header.first().click()
|
||
await expect.poll(async () => (await ours()).length).toBe(0)
|
||
const collapseStates = (await collapseLog.stop()).states
|
||
const collapsed = firstAfterInput(
|
||
collapseStates,
|
||
(state) => !state.ids.some((id) => created.includes(id))
|
||
)
|
||
expect(collapsed).toBeGreaterThanOrEqual(0)
|
||
expect(collapseStates[collapsed]!.inInputTask).toBe(true)
|
||
await header.first().click()
|
||
await expect.poll(async () => (await ours()).length).toBe(3)
|
||
|
||
// Create: the pending row hands over to the new row with no state showing neither.
|
||
await orcaPage.evaluate(() => window.__store!.getState().setGroupBy('none'))
|
||
const name = `reads-main-new-${Date.now()}`
|
||
const createLog = await startDomLog(orcaPage, name)
|
||
await openSidebarWorkspaceComposer(orcaPage)
|
||
const dialog = orcaPage.getByRole('dialog', { name: /Create (Workspace|Worktree)/i })
|
||
await dialog.getByPlaceholder(/Type a name/i).fill(name)
|
||
await dialog.getByRole('button', { name: /Create (Workspace|Worktree)/i }).click()
|
||
const idOf = (wanted: string): Promise<string | null> =>
|
||
orcaPage.evaluate(
|
||
(suffix) =>
|
||
window
|
||
.__store!.getState()
|
||
.allWorktrees()
|
||
.find((worktree) => worktree.path.endsWith(suffix))?.id ?? null,
|
||
wanted
|
||
)
|
||
await expect.poll(() => idOf(name), { timeout: 30_000 }).not.toBeNull()
|
||
const newId = (await idOf(name))!
|
||
created.push(newId)
|
||
await expect.poll(async () => (await renderedOrder(orcaPage)).includes(newId)).toBe(true)
|
||
await orcaPage.waitForTimeout(300)
|
||
const createStates = (await createLog.stop()).states
|
||
const pendingShown = createStates.findIndex(({ shows }) => shows)
|
||
expect(pendingShown).toBeGreaterThanOrEqual(0)
|
||
// The name shows as the pending row before the new row exists.
|
||
expect(createStates[pendingShown]!.ids).not.toContain(newId)
|
||
// The create click's own task lists the pending row, without waiting for main.
|
||
expect(createStates[pendingShown]!.inInputTask).toBe(true)
|
||
const handover = createStates.slice(pendingShown)
|
||
expect(handover.filter(({ ids, shows }) => !shows && !ids.includes(newId))).toEqual([])
|
||
const appeared = handover.findIndex(({ ids }) => ids.includes(newId))
|
||
expect(handover.slice(appeared).every(({ ids }) => ids.includes(newId))).toBe(true)
|
||
await orcaPage.screenshot({ path: testInfo.outputPath(`after-create.png`) })
|
||
|
||
// Virtualized scroll and reveal over a list taller than the sidebar.
|
||
const many = await orcaPage.evaluate(async () => {
|
||
const state = window.__store!.getState()
|
||
const repoId = state.allWorktrees()[0]!.repoId
|
||
const ids: string[] = []
|
||
for (let index = 0; index < 30; index += 1) {
|
||
ids.push(
|
||
(await state.createWorktree(repoId, `reads-main-many-${index}`, undefined, 'skip'))
|
||
.worktree.id
|
||
)
|
||
}
|
||
return ids
|
||
})
|
||
created.push(...many)
|
||
const scroller = orcaPage.locator('[data-worktree-sidebar]')
|
||
await expect
|
||
.poll(async () => many.every((id) => created.includes(id)) && (await ours()).length, {
|
||
timeout: 30_000
|
||
})
|
||
.toBeGreaterThan(0)
|
||
// Scrolled to the end, the last row mounts; back at the top it is not mounted: virtualized.
|
||
let height = -1
|
||
await expect
|
||
.poll(
|
||
async () => {
|
||
const previous = height
|
||
height = await scroller.evaluate((element) => element.scrollHeight)
|
||
return height === previous
|
||
},
|
||
{ intervals: [500], timeout: 30_000 }
|
||
)
|
||
.toBe(true)
|
||
await scroller.evaluate((element) => element.scrollTo({ top: element.scrollHeight }))
|
||
// Wait for post-scroll row mounting; initial overscan can still leave the last mounted row mid-viewport.
|
||
const lastRowAtBottom = (): Promise<string> =>
|
||
scroller.evaluate((element, selector) => {
|
||
const box = element.getBoundingClientRect()
|
||
const last = [...element.querySelectorAll<HTMLElement>(selector)]
|
||
.map((row) => ({ row, rect: row.getBoundingClientRect() }))
|
||
.sort((left, right) => left.rect.top - right.rect.top)
|
||
.at(-1)
|
||
if (!last || last.rect.top < box.top || last.rect.bottom > box.bottom + 1) {
|
||
return ''
|
||
}
|
||
return box.bottom - last.rect.bottom < last.rect.height
|
||
? (last.row.dataset.worktreeId ?? '')
|
||
: ''
|
||
}, ROWS)
|
||
await expect.poll(lastRowAtBottom).not.toBe('')
|
||
const bottomId = await lastRowAtBottom()
|
||
const bottomRow = orcaPage.locator(`${ROWS}[data-worktree-id=${JSON.stringify(bottomId)}]`)
|
||
await expect(bottomRow).toBeInViewport()
|
||
await scroller.evaluate((element) => element.scrollTo({ top: 0 }))
|
||
await expect(bottomRow).toHaveCount(0)
|
||
await orcaPage.evaluate(
|
||
(id) => window.__store!.getState().revealWorktreeInSidebar(id),
|
||
bottomId
|
||
)
|
||
await expect(bottomRow).toBeInViewport()
|
||
await orcaPage.screenshot({ path: testInfo.outputPath(`after-reveal.png`) })
|
||
} finally {
|
||
for (const id of created) {
|
||
await removeWorktreeViaStore(orcaPage, id).catch(() => {})
|
||
}
|
||
}
|
||
})
|