mirror of
https://github.com/stablyai/orca.git
synced 2026-11-16 19:07:41 +00:00
* [comment audit] Align legacy failure-read counts with cached display * [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci] * [comment audit] Condense shared generation, path and preview comments [skip ci] * [comment audit] Condense host, file and Git contract rationale [skip ci] * [comment audit] Tighten Git lifecycle and provider contract comments [skip ci] * [comment audit] Clarify shared host authority and launch isolation [skip ci] * [comment audit] simplify local access mobile and native chat contracts [skip ci] * [comment audit] simplify native chat presentation and state contracts [skip ci] * [comment audit] simplify native runtime and provider contracts [skip ci] * [comment audit] simplify migration and orchestration contracts [skip ci] * [comment audit] simplify plugin trust and process capture rationale [skip ci] * [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci] * [comment audit] clarify remote recovery and launch wire rationale [skip ci] * [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci] * [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci] * [comment audit] clarify sidebar, skill and SSH invariants [skip ci] * [comment audit] condense structured chat delivery and timing rationale [skip ci] * [comment audit] condense terminal replay and telemetry invariants [skip ci] * [comment audit] clarify launch permission and terminal delivery rationale [skip ci] * [comment audit] clarify workspace ownership and layout contracts [skip ci] * [comment audit] wait for fitted and painted SSH terminal links * [comment audit] clarify layout persistence and session ownership [skip ci] * [comment audit] clarify host routing and workspace lifecycle contracts [skip ci] * [comment audit] clarify startup persistence and app lifetime comments [skip ci] * [comment audit] clarify recovery and activity boundaries [skip ci] * [comment audit] condense activity and artifact invariants [skip ci] * [comment audit] condense automation authority contracts [skip ci] * [comment audit] simplify automation scheduling and history contracts [skip ci] * [comment audit] clarify browser chrome and annotation lifecycles [skip ci] * [comment audit] clarify browser routing and retained guest ownership [skip ci] * [comment audit] clarify browser recovery and document ownership comments [skip ci] * [comment audit] restore hosted runners required by native IME fixtures * [comment audit] shorten preview, palette and dashboard invariants [skip ci] * [comment audit] clarify terminal preview, dashboard and retention comments [skip ci] * [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci] * [comment audit] shorten rich-text and combined-diff ownership comments [skip ci] * [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci] * [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci] * [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci] * [comment audit] clarify rich Markdown source and selection safeguards [skip ci] * [comment audit] clarify editor loading and emulator stream lifetimes [skip ci] * [comment audit] trim emulator and feature tour narration [skip ci] * [comment audit] clarify floating workspace and GitHub cache ownership [skip ci] * [comment audit] trim provider controls and Linear filter explanations [skip ci] * [comment audit] clarify pairing and chat resume lifetimes [skip ci] * [comment audit] clarify chat delivery and transcript lifetimes [skip ci] * [comment audit] clarify session options and host-owned status [skip ci] * [comment audit] clarify draft durability and live-status precedence [skip ci] * [comment audit] Trim chat send and model ownership explanations [skip ci] * [comment audit] Shorten transcript ownership and send recovery comments [skip ci] * [comment audit] Simplify native chat composer and transcript hook comments [skip ci] * [comment audit] Shorten native chat scroll and structured session explanations [skip ci] * [comment audit] Trim workspace picker and onboarding commentary [skip ci] * [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci] * [comment audit] Trim sidebar and session history explanations [skip ci] * [comment audit] Condense session resume and review checks comments [skip ci] * [comment audit] Shorten checks state and file explorer refresh comments [skip ci] * [comment audit] Trim plugin bridge and source-control action rationale [skip ci] * [comment audit] Trim source-control listing and review rationale [skip ci] * [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci] * [comment audit] Condense Settings account and appearance rationale [skip ci] * [comment audit] Trim pairing and repository Settings explanations [skip ci] * [comment audit] Condense Settings search SSH and terminal safeguards [skip ci] * [comment audit] Shorten Settings voice and provider ownership comments [skip ci] * [comment audit] Condense Settings draft persistence and host-state rationale [skip ci] * [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci] * [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci] * [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci] * [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci] * [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci] * [comment audit] Prune focus-read baseline after comment cleanup * [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci] * [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci] * [comment audit] Clarify viewport geometry and skill update safeguards [skip ci] * [comment audit] Tighten skill inventory, usage and host status comments [skip ci] * [comment audit] Clarify usage ownership and resource kill safeguards [skip ci] * [comment audit] Tighten tab selection, rename and search contracts [skip ci] * [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci] * [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci] * [comment audit] Tighten provider loading and terminal recovery comments [skip ci] * [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci] * [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci] * [comment audit] Tighten PTY startup and replay explanations [skip ci] * [comment audit] Clarify PTY identity and delivery ownership [skip ci] * [comment audit] Shorten remote reconnect and input replay rationale [skip ci] * [comment audit] Condense terminal parking clipboard and file link comments [skip ci] * [comment audit] Clarify IME ownership and trim trace history [skip ci] * [comment audit] Shorten pane recovery and parked watcher explanations [skip ci] * [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci] * [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci] * [comment audit] Trim renderer lifecycle and menu rationale [skip ci] * [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci] * [comment audit] Clarify renderer hook evidence and source ownership [skip ci] * [comment audit] Tighten IPC ownership and reconnect explanations [skip ci] * [comment audit] Trim renderer focus, paste and attention comments [skip ci] * [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci] * [comment audit] Trim agent launch, resume and ownership commentary [skip ci] * [comment audit] Shorten account, browser and editor comments [skip ci] * [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci] * [comment audit] Condense launch recovery and editor tokenization comments [skip ci] * [comment audit] Condense workspace selection and terminal pane rationale [skip ci] * [comment audit] Condense terminal fitting and rendering recovery comments [skip ci] * [comment audit] Condense terminal input and host routing explanations [skip ci] * [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci] * [comment audit] Condense structured launch and terminal link explanations [skip ci] * [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci] * [comment audit] Condense session persistence and workspace activation rationale [skip ci] * [comment audit] Condense workspace routing and browser ownership rationale [skip ci] * [comment audit] Condense mirror recovery and layout authority rationale [skip ci] * [comment audit] Condense runtime transport and file safety rationale [skip ci] * [comment audit] Condense runtime graph and structured session rationale [skip ci] * [comment audit] Condense browser creation and remote tab recovery rationale [skip ci] * [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci] * [comment audit] Condense frame, startup and provider cache rationale [skip ci] * [comment audit] Condense host twin and agent lifecycle rationale [skip ci] * [comment audit] Condense browser authority and editor cleanup rationale [skip ci] * [comment audit] Condense editor buffer identity and review cache rationale [skip ci] * [comment audit] Condense provider lifetime and repository ownership rationale [skip ci] * [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci] * [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci] * [comment audit] Condense cleanup ownership and listing admission rationale [skip ci] * [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci] * [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci] * [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci] * [comment audit] Condense cloud rollout and assignment safety rationale [skip ci] * [comment audit] Condense relay session and database recovery rationale [skip ci] * [comment audit] Condense relay placement and protocol compatibility rationale [skip ci] * [comment audit] Condense build and packaging constraints [skip ci] * [comment audit] Condense CI gates and validation isolation rationale [skip ci] * [comment audit] Condense catalog identity and browser validation rationale [skip ci] * [comment audit] Condense mobile browser and frame-budget rationale [skip ci] * [comment audit] Shorten mobile route and browser test explanations [skip ci] * [comment audit] Condense editor and session seam test rationale [skip ci] * [comment audit] Trim session and terminal closure history [skip ci] * [comment audit] Shorten terminal browser and census explanations [skip ci] * [comment audit] Preserve root-only E2E diagnostic baseline * [comment audit] Condense mobile seam and HTML preview test rationale [skip ci] * [comment audit] Condense preview instrumentation and render harness rationale [skip ci] * [comment audit] Condense bundle contracts and native-build constraints [skip ci] * [comment audit] Shorten native packaging and CI routing rationale [skip ci] * [comment audit] Condense release tooling and benchmark constraints [skip ci] * [comment audit] Condense packaging and platform gate rationale [skip ci] * [comment audit] Shorten mobile route and history rationale [skip ci] * [comment audit] Condense mobile browser and component rationale [skip ci] * [comment audit] Shorten drawer and workspace-form rationale [skip ci] * [comment audit] Trim mobile review and editor-document explanations [skip ci] * [comment audit] Condense editor lifecycle and Markdown explanations [skip ci] * [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci] * [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci] * [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci] * [comment audit] Condense bridge stream, native request and audio rationale [skip ci] * [comment audit] Reduce bridge schema and page-client commentary [skip ci] * [comment audit] Tighten mobile page bridge contracts [skip ci] * [comment audit] Clarify mobile cache and session constraints [skip ci] * [comment audit] Condense mobile route and lifecycle rationale [skip ci] * [comment audit] Tighten mobile shell hook timing rationale [skip ci] * [comment audit] Clarify route handoff and notification compatibility [skip ci] * [comment audit] Clarify push registration and dictation cleanup constraints [skip ci] * [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci] * [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci] * [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci] * [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci] * [comment audit] Tighten stream replay and queued session ownership rationale [skip ci] * [comment audit] Condense mobile composer and reply-schema constraints [skip ci] * [comment audit] Clarify mobile transcript recovery and session ownership [skip ci] * [comment audit] Clarify mobile queue and source-control compatibility [skip ci] * [comment audit] Condense storage and task launch constraints [skip ci] * [comment audit] Clarify task schemas and terminal document ownership [skip ci] * [comment audit] Tighten terminal input and viewport rationale [skip ci] * [comment audit] Shorten terminal and RPC recorder contracts [skip ci] * [comment audit] Condense recorder engine and connection contracts [skip ci] * [comment audit] Shorten host credential and relay recovery comments [skip ci] * [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci] * [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci] * [comment audit] Condense catalog and relay entry contracts [skip ci] * [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci] * [comment audit] Condense WSL relay and E2E regression rationale [skip ci] * [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci] * [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci] * [comment audit] Shorten layout oracle and regression explanations [skip ci] * [comment audit] Condense paired recovery and ownership regression contracts [skip ci] * [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci] * [comment audit] Condense terminal rendering and IME regression rationale [skip ci] * [comment audit] Shorten terminal recovery and benchmark contracts [skip ci] * [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci] * [comment audit] Condense workflow routing and release rationale [skip ci] * [comment audit] Condense mobile security and installer contracts [skip ci] * [comment audit] Shorten native rationale and stylesheet workarounds [skip ci] * [comment audit] Shorten Windows visibility probe rationale [skip ci] * [comment audit] Condense embedded release and signing rationale [skip ci] * [comment audit] Retain current main test behavior in final reconciliation [skip ci] * [comment audit] Complete final comment review across current source inventory * [comment audit] Handle consolidated audit reports before final CI * [comment audit] Preserve credential storage census detail [skip ci] * [comment audit] Scale broad changed E2E selections with verified timing shards * [comment audit] Align E2E assertions with browser close and settled session metadata * [comment audit] Match existing E2Es to current resource and windowing contracts * [comment audit] Observe the shared server outage notice in reconnect coverage * [comment audit] Make existing renderer probes measure settled tab and PTY work * [comment audit] Align palette E2E selector with task search * [comment audit] Refresh remaining palette search selectors * [comment audit] Keep selector correction within selected audit specs * [comment audit] Await emoji fixture settings inside renderer evaluation * [comment audit] Cancel fixture fit retries between terminal tests --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
266 lines
9.8 KiB
TypeScript
266 lines
9.8 KiB
TypeScript
// Assert byte-exact Hangul input across row wraps; short CJK runs never reach the wide-glyph boundary.
|
||
// #15066’s extra LF/spaces were shell output from prompt escapes missing readline’s \[ \] wrappers; a plain prompt rendered cleanly.
|
||
// The Node reader records PTY input, separating renderer-manufactured bytes from shell echo/output.
|
||
import type { CDPSession, Page } from '@stablyai/playwright-test'
|
||
import { expect, test } from './helpers/orca-app'
|
||
import { ensureTerminalVisible, waitForActiveWorktree, waitForSessionReady } from './helpers/store'
|
||
import {
|
||
splitActiveTerminalPane,
|
||
waitForActiveTerminalManager,
|
||
waitForPaneCount
|
||
} from './helpers/terminal'
|
||
import { closeTerminalImePaneArena, openTerminalImePaneArena } from './terminal-ime-pane-arena'
|
||
import {
|
||
commitImeText,
|
||
composeHangulSyllable,
|
||
dispatchImeProcessKey,
|
||
dispatchImeRewrittenPrintableKey,
|
||
dispatchPlainEnter,
|
||
setImeComposition,
|
||
type ImeKeyIdentity
|
||
} from './terminal-ime-cdp-composition'
|
||
import {
|
||
createTerminalImeByteReader,
|
||
removeTerminalImeByteReader,
|
||
startTerminalImeByteReader,
|
||
waitForTerminalImeBytes
|
||
} from './terminal-ime-byte-reader'
|
||
import {
|
||
applyImePlatformPolicy,
|
||
expectImePlatformPolicy,
|
||
type ImePlatformPolicy
|
||
} from './terminal-ime-platform-policy'
|
||
|
||
type JamoKey = { jamo: string; code: string; index: number }
|
||
|
||
/** 2-Set Korean: the physical key each jamo sits on, plus its index in the Hangul syllable formula. */
|
||
const CHOSEONG: readonly JamoKey[] = [
|
||
{ jamo: 'ㄱ', code: 'KeyR', index: 0 },
|
||
{ jamo: 'ㄴ', code: 'KeyS', index: 2 },
|
||
{ jamo: 'ㄷ', code: 'KeyE', index: 3 },
|
||
{ jamo: 'ㄹ', code: 'KeyF', index: 5 },
|
||
{ jamo: 'ㅁ', code: 'KeyA', index: 6 },
|
||
{ jamo: 'ㅂ', code: 'KeyQ', index: 7 },
|
||
{ jamo: 'ㅅ', code: 'KeyT', index: 9 },
|
||
{ jamo: 'ㅇ', code: 'KeyD', index: 11 }
|
||
]
|
||
|
||
const JUNGSEONG: readonly JamoKey[] = [
|
||
{ jamo: 'ㅏ', code: 'KeyK', index: 0 },
|
||
{ jamo: 'ㅓ', code: 'KeyJ', index: 4 },
|
||
{ jamo: 'ㅗ', code: 'KeyH', index: 8 },
|
||
{ jamo: 'ㅜ', code: 'KeyN', index: 13 }
|
||
]
|
||
|
||
/** IME preedit keystrokes carry no text payload, so every jamo key is a VK_PROCESSKEY. */
|
||
function jamoIdentity(key: JamoKey): ImeKeyIdentity {
|
||
return { key: key.jamo, code: key.code, keyCode: 229 }
|
||
}
|
||
|
||
/** A plain printable keydown, used to push the run one cell out of phase with the row. */
|
||
const OFFSET_KEY: ImeKeyIdentity = { key: 'x', code: 'KeyX', keyCode: 88 }
|
||
|
||
type HangulSyllable = {
|
||
text: string
|
||
frames: readonly { jamoKey: ImeKeyIdentity; preedit: string }[]
|
||
}
|
||
|
||
/** Every syllable is two keystrokes: consonant, then vowel, which assembles the precomposed glyph. */
|
||
function buildHangulRun(length: number): HangulSyllable[] {
|
||
return Array.from({ length }, (_unused, position) => {
|
||
const choseong = CHOSEONG[position % CHOSEONG.length]
|
||
const jungseong = JUNGSEONG[Math.floor(position / CHOSEONG.length) % JUNGSEONG.length]
|
||
const text = String.fromCharCode(0xac00 + (choseong.index * 21 + jungseong.index) * 28)
|
||
return {
|
||
text,
|
||
frames: [
|
||
{ jamoKey: jamoIdentity(choseong), preedit: choseong.jamo },
|
||
{ jamoKey: jamoIdentity(jungseong), preedit: text }
|
||
]
|
||
}
|
||
})
|
||
}
|
||
|
||
type PaneGrid = { cols: number; cursorRow: number }
|
||
|
||
async function readPaneGrid(page: Page, ptyId: string): Promise<PaneGrid> {
|
||
return page.evaluate((targetPtyId) => {
|
||
for (const manager of window.__paneManagers?.values?.() ?? []) {
|
||
const pane = manager
|
||
.getPanes?.()
|
||
.find((candidate) => candidate.container.dataset.ptyId === targetPtyId)
|
||
if (pane) {
|
||
const buffer = pane.terminal.buffer.active
|
||
return { cols: pane.terminal.cols, cursorRow: buffer.baseY + buffer.cursorY }
|
||
}
|
||
}
|
||
return { cols: 0, cursorRow: 0 }
|
||
}, ptyId)
|
||
}
|
||
|
||
// Split to narrow the container: direct terminal.resize is overwritten by the next fit pass.
|
||
async function narrowPaneBySplitting(page: Page, splits: number): Promise<void> {
|
||
await waitForSessionReady(page)
|
||
await waitForActiveWorktree(page)
|
||
await ensureTerminalVisible(page)
|
||
await waitForActiveTerminalManager(page, 30_000)
|
||
for (let split = 0; split < splits; split += 1) {
|
||
await splitActiveTerminalPane(page, 'vertical')
|
||
await waitForPaneCount(page, split + 2)
|
||
}
|
||
}
|
||
|
||
async function waitForSettledCols(page: Page, ptyId: string): Promise<number> {
|
||
let settled = 0
|
||
await expect
|
||
.poll(
|
||
async () => {
|
||
const observed = (await readPaneGrid(page, ptyId)).cols
|
||
const stable = observed === settled && observed > 0
|
||
settled = observed
|
||
return stable
|
||
},
|
||
{ timeout: 10_000, message: 'terminal width never settled' }
|
||
)
|
||
.toBe(true)
|
||
return settled
|
||
}
|
||
|
||
/** `pauseMs` is the gap between keystrokes; each syllable commits before the next one starts. */
|
||
async function typeHangulRun(
|
||
session: CDPSession,
|
||
page: Page,
|
||
run: readonly HangulSyllable[],
|
||
pauseMs: number
|
||
): Promise<void> {
|
||
for (const syllable of run) {
|
||
await composeHangulSyllable(session, page, syllable.frames, pauseMs)
|
||
await commitImeText(session, syllable.text)
|
||
}
|
||
}
|
||
|
||
/** One composition session whose preedit grows one syllable at a time, then commits whole. */
|
||
async function composeThenCommitPhrase(
|
||
session: CDPSession,
|
||
page: Page,
|
||
run: readonly HangulSyllable[],
|
||
pauseMs: number
|
||
): Promise<void> {
|
||
let preedit = ''
|
||
for (const syllable of run) {
|
||
preedit += syllable.text
|
||
await dispatchImeProcessKey(session, syllable.frames[0].jamoKey)
|
||
await setImeComposition(session, preedit)
|
||
if (pauseMs > 0) {
|
||
await page.waitForTimeout(pauseMs)
|
||
}
|
||
}
|
||
await commitImeText(session, preedit)
|
||
}
|
||
|
||
const KEYSTROKE_PAUSE_MS = 16
|
||
|
||
// Compare decoded text for readable inserted LF/space diffs and hex for byte exactness.
|
||
function expectExactPtyInput(received: readonly string[], expectedText: string): void {
|
||
const decoded = received.map((hex) => Buffer.from(hex, 'hex').toString('utf8'))
|
||
expect(decoded).toEqual([`${expectedText}\n`])
|
||
expect(received).toEqual([Buffer.from(`${expectedText}\n`).toString('hex')])
|
||
}
|
||
|
||
type WrapScenario = {
|
||
name: string
|
||
/** Shifts the run one cell out of phase, so the boundary falls mid-syllable at even widths. */
|
||
offsetByOneCell: boolean
|
||
/** Derived from the width the pane actually has, never from an assumed 80. */
|
||
syllableCount: (observedCols: number) => number
|
||
drive: (session: CDPSession, page: Page, run: readonly HangulSyllable[]) => Promise<void>
|
||
policies: readonly ImePlatformPolicy[]
|
||
}
|
||
|
||
const SCENARIOS: readonly WrapScenario[] = [
|
||
{
|
||
name: '42 syllables',
|
||
offsetByOneCell: false,
|
||
syllableCount: () => 42,
|
||
drive: (session, page, run) => typeHangulRun(session, page, run, KEYSTROKE_PAUSE_MS),
|
||
policies: ['mac', 'windows', 'linux']
|
||
},
|
||
{
|
||
// Shift one cell to cover both clean wraps and a wide glyph that cannot fit the final cell, regardless of pane-width parity.
|
||
name: '42 syllables offset by one cell',
|
||
offsetByOneCell: true,
|
||
syllableCount: () => 42,
|
||
drive: (session, page, run) => typeHangulRun(session, page, run, KEYSTROKE_PAUSE_MS),
|
||
policies: ['mac']
|
||
},
|
||
{
|
||
// Leave deferred wrap pending when Enter arrives.
|
||
name: 'a run that ends on the wrap boundary',
|
||
offsetByOneCell: false,
|
||
syllableCount: (observedCols) => Math.floor(observedCols / 2) * 2,
|
||
drive: (session, page, run) => typeHangulRun(session, page, run, KEYSTROKE_PAUSE_MS),
|
||
policies: ['mac']
|
||
},
|
||
{
|
||
// Grow one preedit past the boundary before committing.
|
||
name: 'a composition that straddles the wrap boundary',
|
||
offsetByOneCell: false,
|
||
syllableCount: (observedCols) => Math.floor(observedCols / 2) + 8,
|
||
drive: (session, page, run) => composeThenCommitPhrase(session, page, run, KEYSTROKE_PAUSE_MS),
|
||
policies: ['mac']
|
||
}
|
||
]
|
||
|
||
test.describe('Terminal Hangul wrap-boundary byte exactness', () => {
|
||
for (const scenario of SCENARIOS) {
|
||
for (const policy of scenario.policies) {
|
||
test(`sends ${scenario.name} unaltered to the pty (${policy})`, async ({
|
||
orcaPage,
|
||
testRepoPath
|
||
}, testInfo) => {
|
||
await applyImePlatformPolicy(orcaPage, policy)
|
||
await expectImePlatformPolicy(orcaPage, policy)
|
||
await narrowPaneBySplitting(orcaPage, 2)
|
||
|
||
const arena = await openTerminalImePaneArena(orcaPage)
|
||
const reader = createTerminalImeByteReader(testRepoPath, 1)
|
||
let completed = false
|
||
try {
|
||
await startTerminalImeByteReader(orcaPage, arena.ptyId, reader)
|
||
|
||
const observedCols = await waitForSettledCols(orcaPage, arena.ptyId)
|
||
const run = buildHangulRun(scenario.syllableCount(observedCols))
|
||
const prefix = scenario.offsetByOneCell ? OFFSET_KEY.key : ''
|
||
const expectedText = prefix + run.map((syllable) => syllable.text).join('')
|
||
testInfo.annotations.push({
|
||
type: 'wrap-regime',
|
||
description: `${observedCols} cols, ${run.length} syllables, offset ${prefix.length}`
|
||
})
|
||
|
||
const startRow = (await readPaneGrid(orcaPage, arena.ptyId)).cursorRow
|
||
if (scenario.offsetByOneCell) {
|
||
await dispatchImeRewrittenPrintableKey(arena.session, OFFSET_KEY)
|
||
}
|
||
await scenario.drive(arena.session, orcaPage, run)
|
||
// Require cursor movement to a later row so a run that never wraps cannot pass.
|
||
await expect
|
||
.poll(async () => (await readPaneGrid(orcaPage, arena.ptyId)).cursorRow, {
|
||
timeout: 10_000,
|
||
message: `run of ${run.length} syllables never wrapped at ${observedCols} cols`
|
||
})
|
||
.toBeGreaterThan(startRow)
|
||
|
||
await dispatchPlainEnter(arena.session)
|
||
|
||
const received = await waitForTerminalImeBytes(orcaPage, reader, 20_000)
|
||
expectExactPtyInput(received, expectedText)
|
||
completed = true
|
||
} finally {
|
||
await closeTerminalImePaneArena(arena, testInfo, 'hangul-wrap-boundary-bytes', !completed)
|
||
removeTerminalImeByteReader(reader)
|
||
}
|
||
})
|
||
}
|
||
}
|
||
})
|