Files
orca/tests/e2e/terminal-ime-clause-selection.spec.ts
Takuya AkiyaandNeil 176852ad5a fix(terminal): highlight the active IME conversion range (#27903)
Japanese IMEs convert one clause at a time, but the terminal's preedit overlay
painted the whole composition uniformly, so the clause the candidate window
targets was invisible. Read the IME's selection from xterm's textarea on the
insertCompositionText input event (Chromium only updates it there) and paint
that range of the preedit in the theme's selection colors. Cell-grid advance
corrections are unchanged and nothing reaches the PTY; a collapsed caret or a
range outside the preedit highlights nothing.

Fixes #27873

Co-authored-by: Neil <neil@stably.ai>
2026-10-27 04:51:06 -07:00

64 lines
2.7 KiB
TypeScript
Raw Permalink Blame History

This file contains invisible Unicode characters
This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
import { expect, test } from './helpers/orca-app'
import { closeTerminalImePaneArena, openTerminalImePaneArena } from './terminal-ime-pane-arena'
import { setImeComposition } from './terminal-ime-cdp-composition'
import { writeToActiveTerminal } from './terminal-ime-midline-occlusion-probe'
/** Every preedit code unit's left edge, then the preedit width, relative to the preedit. */
function measurePreeditEdges(): number[] {
const preedit = document.querySelector<HTMLElement>(
'.composition-view.active .xterm-composition-preedit'
)!
const bounds = preedit.getBoundingClientRect()
const edges: number[] = []
const walker = document.createTreeWalker(preedit, NodeFilter.SHOW_TEXT)
for (let node = walker.nextNode(); node; node = walker.nextNode()) {
for (let offset = 0; offset < node.textContent!.length; offset++) {
const range = document.createRange()
range.setStart(node, offset)
range.setEnd(node, offset + 1)
edges.push(range.getBoundingClientRect().left - bounds.left)
}
}
return [...edges, bounds.width]
}
test('paints the selected clause in the theme selection colors without moving any cell', async ({
orcaPage
}, testInfo) => {
const arena = await openTerminalImePaneArena(orcaPage)
let completed = false
try {
await orcaPage.evaluate(() => {
const state = window.__store!.getState()
const terminal = window.__paneManagers!.get(state.activeTabId!)!.getActivePane()!.terminal
terminal.options.theme = {
...terminal.options.theme,
selectionBackground: '#7357d9',
selectionForeground: '#ffffff'
}
})
await writeToActiveTerminal(orcaPage, '\x1b[2J\x1b[H')
const text = '今日はいい天気です'
await setImeComposition(arena.session, text)
await expect(
orcaPage.locator('.composition-view.active .xterm-composition-preedit')
).toHaveText(`‎${text}‎`)
const unselected = await orcaPage.evaluate(measurePreeditEdges)
await setImeComposition(arena.session, text, { start: 3, end: 9 })
const clause = orcaPage.locator('.xterm-composition-preedit-selected')
await expect(clause).toHaveText('いい天気です')
await expect(clause).toHaveCSS('background-color', 'rgb(115, 87, 217)')
await expect(clause).toHaveCSS('color', 'rgb(255, 255, 255)')
const selected = await orcaPage.evaluate(measurePreeditEdges)
// Chromium snaps each inline box the selection adds to 1/64px layout units.
expect(selected).toHaveLength(unselected.length)
selected.forEach((edge, index) => expect(edge).toBeCloseTo(unselected[index], 1))
await setImeComposition(arena.session, '')
completed = true
} finally {
await closeTerminalImePaneArena(arena, testInfo, 'ime-clause-selection', !completed)
}
})