mirror of
https://github.com/stablyai/orca.git
synced 2026-11-16 02:47:34 +00:00
* [comment audit] Align legacy failure-read counts with cached display * [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci] * [comment audit] Condense shared generation, path and preview comments [skip ci] * [comment audit] Condense host, file and Git contract rationale [skip ci] * [comment audit] Tighten Git lifecycle and provider contract comments [skip ci] * [comment audit] Clarify shared host authority and launch isolation [skip ci] * [comment audit] simplify local access mobile and native chat contracts [skip ci] * [comment audit] simplify native chat presentation and state contracts [skip ci] * [comment audit] simplify native runtime and provider contracts [skip ci] * [comment audit] simplify migration and orchestration contracts [skip ci] * [comment audit] simplify plugin trust and process capture rationale [skip ci] * [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci] * [comment audit] clarify remote recovery and launch wire rationale [skip ci] * [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci] * [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci] * [comment audit] clarify sidebar, skill and SSH invariants [skip ci] * [comment audit] condense structured chat delivery and timing rationale [skip ci] * [comment audit] condense terminal replay and telemetry invariants [skip ci] * [comment audit] clarify launch permission and terminal delivery rationale [skip ci] * [comment audit] clarify workspace ownership and layout contracts [skip ci] * [comment audit] wait for fitted and painted SSH terminal links * [comment audit] clarify layout persistence and session ownership [skip ci] * [comment audit] clarify host routing and workspace lifecycle contracts [skip ci] * [comment audit] clarify startup persistence and app lifetime comments [skip ci] * [comment audit] clarify recovery and activity boundaries [skip ci] * [comment audit] condense activity and artifact invariants [skip ci] * [comment audit] condense automation authority contracts [skip ci] * [comment audit] simplify automation scheduling and history contracts [skip ci] * [comment audit] clarify browser chrome and annotation lifecycles [skip ci] * [comment audit] clarify browser routing and retained guest ownership [skip ci] * [comment audit] clarify browser recovery and document ownership comments [skip ci] * [comment audit] restore hosted runners required by native IME fixtures * [comment audit] shorten preview, palette and dashboard invariants [skip ci] * [comment audit] clarify terminal preview, dashboard and retention comments [skip ci] * [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci] * [comment audit] shorten rich-text and combined-diff ownership comments [skip ci] * [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci] * [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci] * [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci] * [comment audit] clarify rich Markdown source and selection safeguards [skip ci] * [comment audit] clarify editor loading and emulator stream lifetimes [skip ci] * [comment audit] trim emulator and feature tour narration [skip ci] * [comment audit] clarify floating workspace and GitHub cache ownership [skip ci] * [comment audit] trim provider controls and Linear filter explanations [skip ci] * [comment audit] clarify pairing and chat resume lifetimes [skip ci] * [comment audit] clarify chat delivery and transcript lifetimes [skip ci] * [comment audit] clarify session options and host-owned status [skip ci] * [comment audit] clarify draft durability and live-status precedence [skip ci] * [comment audit] Trim chat send and model ownership explanations [skip ci] * [comment audit] Shorten transcript ownership and send recovery comments [skip ci] * [comment audit] Simplify native chat composer and transcript hook comments [skip ci] * [comment audit] Shorten native chat scroll and structured session explanations [skip ci] * [comment audit] Trim workspace picker and onboarding commentary [skip ci] * [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci] * [comment audit] Trim sidebar and session history explanations [skip ci] * [comment audit] Condense session resume and review checks comments [skip ci] * [comment audit] Shorten checks state and file explorer refresh comments [skip ci] * [comment audit] Trim plugin bridge and source-control action rationale [skip ci] * [comment audit] Trim source-control listing and review rationale [skip ci] * [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci] * [comment audit] Condense Settings account and appearance rationale [skip ci] * [comment audit] Trim pairing and repository Settings explanations [skip ci] * [comment audit] Condense Settings search SSH and terminal safeguards [skip ci] * [comment audit] Shorten Settings voice and provider ownership comments [skip ci] * [comment audit] Condense Settings draft persistence and host-state rationale [skip ci] * [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci] * [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci] * [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci] * [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci] * [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci] * [comment audit] Prune focus-read baseline after comment cleanup * [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci] * [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci] * [comment audit] Clarify viewport geometry and skill update safeguards [skip ci] * [comment audit] Tighten skill inventory, usage and host status comments [skip ci] * [comment audit] Clarify usage ownership and resource kill safeguards [skip ci] * [comment audit] Tighten tab selection, rename and search contracts [skip ci] * [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci] * [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci] * [comment audit] Tighten provider loading and terminal recovery comments [skip ci] * [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci] * [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci] * [comment audit] Tighten PTY startup and replay explanations [skip ci] * [comment audit] Clarify PTY identity and delivery ownership [skip ci] * [comment audit] Shorten remote reconnect and input replay rationale [skip ci] * [comment audit] Condense terminal parking clipboard and file link comments [skip ci] * [comment audit] Clarify IME ownership and trim trace history [skip ci] * [comment audit] Shorten pane recovery and parked watcher explanations [skip ci] * [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci] * [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci] * [comment audit] Trim renderer lifecycle and menu rationale [skip ci] * [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci] * [comment audit] Clarify renderer hook evidence and source ownership [skip ci] * [comment audit] Tighten IPC ownership and reconnect explanations [skip ci] * [comment audit] Trim renderer focus, paste and attention comments [skip ci] * [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci] * [comment audit] Trim agent launch, resume and ownership commentary [skip ci] * [comment audit] Shorten account, browser and editor comments [skip ci] * [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci] * [comment audit] Condense launch recovery and editor tokenization comments [skip ci] * [comment audit] Condense workspace selection and terminal pane rationale [skip ci] * [comment audit] Condense terminal fitting and rendering recovery comments [skip ci] * [comment audit] Condense terminal input and host routing explanations [skip ci] * [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci] * [comment audit] Condense structured launch and terminal link explanations [skip ci] * [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci] * [comment audit] Condense session persistence and workspace activation rationale [skip ci] * [comment audit] Condense workspace routing and browser ownership rationale [skip ci] * [comment audit] Condense mirror recovery and layout authority rationale [skip ci] * [comment audit] Condense runtime transport and file safety rationale [skip ci] * [comment audit] Condense runtime graph and structured session rationale [skip ci] * [comment audit] Condense browser creation and remote tab recovery rationale [skip ci] * [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci] * [comment audit] Condense frame, startup and provider cache rationale [skip ci] * [comment audit] Condense host twin and agent lifecycle rationale [skip ci] * [comment audit] Condense browser authority and editor cleanup rationale [skip ci] * [comment audit] Condense editor buffer identity and review cache rationale [skip ci] * [comment audit] Condense provider lifetime and repository ownership rationale [skip ci] * [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci] * [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci] * [comment audit] Condense cleanup ownership and listing admission rationale [skip ci] * [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci] * [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci] * [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci] * [comment audit] Condense cloud rollout and assignment safety rationale [skip ci] * [comment audit] Condense relay session and database recovery rationale [skip ci] * [comment audit] Condense relay placement and protocol compatibility rationale [skip ci] * [comment audit] Condense build and packaging constraints [skip ci] * [comment audit] Condense CI gates and validation isolation rationale [skip ci] * [comment audit] Condense catalog identity and browser validation rationale [skip ci] * [comment audit] Condense mobile browser and frame-budget rationale [skip ci] * [comment audit] Shorten mobile route and browser test explanations [skip ci] * [comment audit] Condense editor and session seam test rationale [skip ci] * [comment audit] Trim session and terminal closure history [skip ci] * [comment audit] Shorten terminal browser and census explanations [skip ci] * [comment audit] Preserve root-only E2E diagnostic baseline * [comment audit] Condense mobile seam and HTML preview test rationale [skip ci] * [comment audit] Condense preview instrumentation and render harness rationale [skip ci] * [comment audit] Condense bundle contracts and native-build constraints [skip ci] * [comment audit] Shorten native packaging and CI routing rationale [skip ci] * [comment audit] Condense release tooling and benchmark constraints [skip ci] * [comment audit] Condense packaging and platform gate rationale [skip ci] * [comment audit] Shorten mobile route and history rationale [skip ci] * [comment audit] Condense mobile browser and component rationale [skip ci] * [comment audit] Shorten drawer and workspace-form rationale [skip ci] * [comment audit] Trim mobile review and editor-document explanations [skip ci] * [comment audit] Condense editor lifecycle and Markdown explanations [skip ci] * [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci] * [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci] * [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci] * [comment audit] Condense bridge stream, native request and audio rationale [skip ci] * [comment audit] Reduce bridge schema and page-client commentary [skip ci] * [comment audit] Tighten mobile page bridge contracts [skip ci] * [comment audit] Clarify mobile cache and session constraints [skip ci] * [comment audit] Condense mobile route and lifecycle rationale [skip ci] * [comment audit] Tighten mobile shell hook timing rationale [skip ci] * [comment audit] Clarify route handoff and notification compatibility [skip ci] * [comment audit] Clarify push registration and dictation cleanup constraints [skip ci] * [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci] * [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci] * [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci] * [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci] * [comment audit] Tighten stream replay and queued session ownership rationale [skip ci] * [comment audit] Condense mobile composer and reply-schema constraints [skip ci] * [comment audit] Clarify mobile transcript recovery and session ownership [skip ci] * [comment audit] Clarify mobile queue and source-control compatibility [skip ci] * [comment audit] Condense storage and task launch constraints [skip ci] * [comment audit] Clarify task schemas and terminal document ownership [skip ci] * [comment audit] Tighten terminal input and viewport rationale [skip ci] * [comment audit] Shorten terminal and RPC recorder contracts [skip ci] * [comment audit] Condense recorder engine and connection contracts [skip ci] * [comment audit] Shorten host credential and relay recovery comments [skip ci] * [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci] * [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci] * [comment audit] Condense catalog and relay entry contracts [skip ci] * [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci] * [comment audit] Condense WSL relay and E2E regression rationale [skip ci] * [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci] * [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci] * [comment audit] Shorten layout oracle and regression explanations [skip ci] * [comment audit] Condense paired recovery and ownership regression contracts [skip ci] * [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci] * [comment audit] Condense terminal rendering and IME regression rationale [skip ci] * [comment audit] Shorten terminal recovery and benchmark contracts [skip ci] * [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci] * [comment audit] Condense workflow routing and release rationale [skip ci] * [comment audit] Condense mobile security and installer contracts [skip ci] * [comment audit] Shorten native rationale and stylesheet workarounds [skip ci] * [comment audit] Shorten Windows visibility probe rationale [skip ci] * [comment audit] Condense embedded release and signing rationale [skip ci] * [comment audit] Retain current main test behavior in final reconciliation [skip ci] * [comment audit] Complete final comment review across current source inventory * [comment audit] Handle consolidated audit reports before final CI * [comment audit] Preserve credential storage census detail [skip ci] * [comment audit] Scale broad changed E2E selections with verified timing shards * [comment audit] Align E2E assertions with browser close and settled session metadata * [comment audit] Match existing E2Es to current resource and windowing contracts * [comment audit] Observe the shared server outage notice in reconnect coverage * [comment audit] Make existing renderer probes measure settled tab and PTY work * [comment audit] Align palette E2E selector with task search * [comment audit] Refresh remaining palette search selectors * [comment audit] Keep selector correction within selected audit specs * [comment audit] Await emoji fixture settings inside renderer evaluation * [comment audit] Cancel fixture fit retries between terminal tests --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
340 lines
12 KiB
TypeScript
340 lines
12 KiB
TypeScript
// Capture settled renderer topology and saved sessions for fixed journeys; run-terminal-layout-parity.mjs diffs two builds (see tests/e2e/AGENTS.md).
|
|
|
|
import { mkdirSync, writeFileSync } from 'node:fs'
|
|
import path from 'node:path'
|
|
import type { ElectronApplication, Page, TestInfo } from '@stablyai/playwright-test'
|
|
import { test, expect } from './helpers/orca-app'
|
|
import { createRestartSession } from './helpers/orca-restart'
|
|
import { readPersistedProfileState } from './helpers/persisted-profile-state'
|
|
import {
|
|
moveTerminalPaneByLeafId,
|
|
readTerminalPaneDomLeafOrder,
|
|
splitActiveTerminalPane,
|
|
waitForActiveTerminalManager
|
|
} from './helpers/terminal'
|
|
import {
|
|
bootstrapFirstLaunch,
|
|
bootstrapRestoredLaunch,
|
|
seededRepoPathOrSkip
|
|
} from './helpers/terminal-restart-persistence'
|
|
import { createTerminalTabFromMenu, SORTABLE_TAB } from './helpers/terminal-tab-menu'
|
|
import {
|
|
addFolderWorkspace,
|
|
closeActivePaneFromKeyboard,
|
|
dragPaneOutToTabStrip,
|
|
waitForBoundPanes
|
|
} from './helpers/terminal-layout-journeys'
|
|
import { RuntimeClient } from '../../src/cli/runtime/client'
|
|
import type { RuntimeTerminalListResult } from '../../src/shared/runtime-types'
|
|
import {
|
|
TERMINAL_LAYOUT_PARITY_OUT_ENV,
|
|
type RawParityCheckpoint,
|
|
type RawParityCapture
|
|
} from './terminal-layout-parity-snapshot'
|
|
|
|
test.describe.configure({ mode: 'serial' })
|
|
|
|
type Journey = {
|
|
page: Page
|
|
worktreeId: string
|
|
userDataDir: string
|
|
}
|
|
|
|
/** Renderer topology for every worktree that has terminal tabs, plus mounted PaneManager DOM order. */
|
|
function readRendererLayout(page: Page): Promise<unknown> {
|
|
return page.evaluate(() => {
|
|
const state = window.__store!.getState()
|
|
const worktreeIds = Object.keys(state.tabsByWorktree).filter(
|
|
(id) => (state.tabsByWorktree[id] ?? []).length > 0
|
|
)
|
|
const pick = <T>(map: Record<string, T>): Record<string, T> =>
|
|
Object.fromEntries(worktreeIds.filter((id) => id in map).map((id) => [id, map[id]]))
|
|
const tabIds = worktreeIds.flatMap((id) => state.tabsByWorktree[id]!.map((tab) => tab.id))
|
|
const mountedPanesByTabId = Object.fromEntries(
|
|
tabIds.flatMap((tabId) => {
|
|
const manager = window.__paneManagers?.get(tabId)
|
|
if (!manager) {
|
|
return []
|
|
}
|
|
const containers = new Set(manager.getPanes().map((pane) => pane.container))
|
|
const leafOrder = Array.from(document.querySelectorAll<HTMLElement>('.pane[data-leaf-id]'))
|
|
.filter((element) => containers.has(element))
|
|
.map((element) => element.dataset.leafId ?? '')
|
|
const active = manager.getActivePane()
|
|
return [[tabId, { leafOrder, activeLeafId: active ? manager.getLeafId(active.id) : null }]]
|
|
})
|
|
)
|
|
return {
|
|
activeWorktreeId: state.activeWorktreeId,
|
|
activeTabId: state.activeTabId,
|
|
activeTabType: state.activeTabType,
|
|
tabsByWorktree: pick(state.tabsByWorktree),
|
|
terminalLayoutsByTabId: Object.fromEntries(
|
|
tabIds.map((tabId) => [tabId, state.terminalLayoutsByTabId[tabId] ?? null])
|
|
),
|
|
ptyIdsByTabId: Object.fromEntries(tabIds.map((tabId) => [tabId, state.ptyIdsByTabId[tabId]])),
|
|
unifiedTabsByWorktree: pick(state.unifiedTabsByWorktree),
|
|
groupsByWorktree: pick(state.groupsByWorktree),
|
|
layoutByWorktree: pick(state.layoutByWorktree),
|
|
activeTabIdByWorktree: pick(state.activeTabIdByWorktree),
|
|
activeGroupIdByWorktree: pick(state.activeGroupIdByWorktree),
|
|
mountedPanesByTabId
|
|
}
|
|
})
|
|
}
|
|
|
|
/** Host pacing: quit only after main lists exactly the terminals the renderer shows. */
|
|
async function waitForHostTerminals(journey: Journey): Promise<void> {
|
|
const client = new RuntimeClient(journey.userDataDir, 30_000)
|
|
const shown = await journey.page.evaluate((worktreeId) => {
|
|
const state = window.__store!.getState()
|
|
return (state.tabsByWorktree[worktreeId] ?? []).reduce((count, tab) => {
|
|
const leafIds = state.terminalLayoutsByTabId[tab.id]?.ptyIdsByLeafId ?? {}
|
|
return count + Math.max(1, Object.keys(leafIds).length)
|
|
}, 0)
|
|
}, journey.worktreeId)
|
|
await expect
|
|
.poll(
|
|
async () => {
|
|
const listed = await client
|
|
.call<RuntimeTerminalListResult>('terminal.list', {
|
|
worktree: `id:${journey.worktreeId}`
|
|
})
|
|
.catch(() => null)
|
|
return listed?.result.terminals.length ?? -1
|
|
},
|
|
{ timeout: 30_000, message: 'Host terminal list never matched the renderer' }
|
|
)
|
|
.toBe(shown)
|
|
}
|
|
|
|
/** Quiescence: the same layout on three consecutive reads, so a late echo cannot land after capture. */
|
|
async function readSettledRendererLayout(page: Page): Promise<unknown> {
|
|
let previous = ''
|
|
let stableReads = 0
|
|
let latest: unknown = null
|
|
await expect
|
|
.poll(
|
|
async () => {
|
|
latest = await readRendererLayout(page)
|
|
const serialized = JSON.stringify(latest)
|
|
stableReads = serialized === previous ? stableReads + 1 : 0
|
|
previous = serialized
|
|
return stableReads
|
|
},
|
|
{ timeout: 20_000, intervals: [300], message: 'Renderer layout never settled' }
|
|
)
|
|
.toBeGreaterThanOrEqual(2)
|
|
return latest
|
|
}
|
|
|
|
function readPersistedSessions(userDataDir: string): unknown {
|
|
const root = readPersistedProfileState(userDataDir)
|
|
return { local: root.workspaceSession, byHostId: root.workspaceSessionsByHostId ?? {} }
|
|
}
|
|
|
|
function writeCapture(testInfo: TestInfo, capture: RawParityCapture): void {
|
|
const outDir = process.env[TERMINAL_LAYOUT_PARITY_OUT_ENV] ?? testInfo.outputPath('parity')
|
|
mkdirSync(outDir, { recursive: true })
|
|
writeFileSync(
|
|
path.join(outDir, `${capture.scenario}.json`),
|
|
`${JSON.stringify(capture, null, 2)}\n`
|
|
)
|
|
}
|
|
|
|
type ScenarioSetup = {
|
|
worktreeId: string
|
|
pathLabels?: Record<string, string>
|
|
cleanup?: () => void
|
|
}
|
|
|
|
type ParityScenario = {
|
|
id: string
|
|
setup?: (page: Page) => Promise<ScenarioSetup>
|
|
journey: (journey: Journey) => Promise<void>
|
|
/** Relaunch (`times`, default once) and capture each restored renderer and the next save. */
|
|
restart?: { expectedPaneCount: number; times?: number }
|
|
}
|
|
|
|
/** Quit through the shared helper and report how the process ended; a forced kill skips the final save. */
|
|
async function quitAndReadExit(
|
|
session: ReturnType<typeof createRestartSession>,
|
|
app: ElectronApplication
|
|
): Promise<{ code: number | null; signal: string | null }> {
|
|
const proc = app.process()
|
|
const exited = new Promise<{ code: number | null; signal: string | null }>((resolve) => {
|
|
if (proc.exitCode !== null || proc.signalCode !== null) {
|
|
resolve({ code: proc.exitCode, signal: proc.signalCode })
|
|
}
|
|
proc.once('exit', (code, signal) => resolve({ code, signal }))
|
|
})
|
|
await session.close(app)
|
|
return exited
|
|
}
|
|
|
|
/** Launch on a fresh profile, run the journey, capture the settled renderer, quit and read the save. */
|
|
async function runScenario(testInfo: TestInfo, scenario: ParityScenario): Promise<void> {
|
|
const repoPath = seededRepoPathOrSkip()
|
|
const session = createRestartSession(testInfo)
|
|
const checkpoints: RawParityCheckpoint[] = []
|
|
let app: ElectronApplication | null = null
|
|
let setup: ScenarioSetup | null = null
|
|
try {
|
|
const first = await session.launch()
|
|
app = first.app
|
|
setup = scenario.setup
|
|
? await scenario.setup(first.page)
|
|
: await bootstrapFirstLaunch(first.page, repoPath)
|
|
await waitForBoundPanes(first.page, 1)
|
|
const journey = {
|
|
page: first.page,
|
|
worktreeId: setup.worktreeId,
|
|
userDataDir: session.userDataDir
|
|
}
|
|
await scenario.journey(journey)
|
|
await waitForHostTerminals(journey)
|
|
const renderer = await readSettledRendererLayout(first.page)
|
|
const exit = await quitAndReadExit(session, app)
|
|
app = null
|
|
const persisted = readPersistedSessions(session.userDataDir)
|
|
checkpoints.push({ label: 'after-quit', renderer, persisted, exit })
|
|
|
|
const { expectedPaneCount = 0, times: restarts = 1 } = scenario.restart ?? { times: 0 }
|
|
for (let restart = 1; restart <= restarts; restart += 1) {
|
|
const next = await session.launch()
|
|
app = next.app
|
|
await bootstrapRestoredLaunch(next.page, setup.worktreeId)
|
|
await waitForBoundPanes(next.page, expectedPaneCount)
|
|
const restored = await readSettledRendererLayout(next.page)
|
|
const restartExit = await quitAndReadExit(session, app)
|
|
app = null
|
|
checkpoints.push({
|
|
label: restart === 1 ? 'after-restart' : `after-restart-${restart}`,
|
|
renderer: restored,
|
|
persisted: readPersistedSessions(session.userDataDir),
|
|
exit: restartExit
|
|
})
|
|
}
|
|
writeCapture(testInfo, {
|
|
scenario: scenario.id,
|
|
pathLabels: {
|
|
[repoPath]: '<repo>',
|
|
[session.userDataDir]: '<userData>',
|
|
...setup.pathLabels
|
|
},
|
|
checkpoints
|
|
})
|
|
} finally {
|
|
if (app) {
|
|
await session.close(app)
|
|
}
|
|
await session.dispose()
|
|
setup?.cleanup?.()
|
|
}
|
|
}
|
|
|
|
async function splitTwice(page: Page): Promise<void> {
|
|
await splitActiveTerminalPane(page, 'vertical')
|
|
await waitForBoundPanes(page, 2)
|
|
await splitActiveTerminalPane(page, 'horizontal')
|
|
await waitForBoundPanes(page, 3)
|
|
}
|
|
|
|
async function splitThenNewTab(page: Page): Promise<void> {
|
|
await splitActiveTerminalPane(page, 'vertical')
|
|
await waitForBoundPanes(page, 2)
|
|
await createTerminalTabFromMenu(page)
|
|
await waitForActiveTerminalManager(page)
|
|
await waitForBoundPanes(page, 1)
|
|
}
|
|
|
|
const SCENARIOS: ParityScenario[] = [
|
|
{
|
|
id: 'create-tab',
|
|
journey: async ({ page }) => {
|
|
await createTerminalTabFromMenu(page)
|
|
await waitForActiveTerminalManager(page)
|
|
await waitForBoundPanes(page, 1)
|
|
}
|
|
},
|
|
{ id: 'split-right-down', journey: ({ page }) => splitTwice(page) },
|
|
{
|
|
id: 'close-pane',
|
|
journey: async ({ page }) => {
|
|
await splitTwice(page)
|
|
await closeActivePaneFromKeyboard(page, 3)
|
|
await waitForBoundPanes(page, 2)
|
|
}
|
|
},
|
|
{
|
|
id: 'close-tab',
|
|
journey: async ({ page }) => {
|
|
await createTerminalTabFromMenu(page)
|
|
await waitForActiveTerminalManager(page)
|
|
await expect(page.locator(SORTABLE_TAB)).toHaveCount(2)
|
|
const firstTab = page.locator(SORTABLE_TAB).first()
|
|
await firstTab.getByRole('button', { name: /^Close tab /i }).click()
|
|
await expect(page.locator(SORTABLE_TAB)).toHaveCount(1)
|
|
await waitForActiveTerminalManager(page)
|
|
}
|
|
},
|
|
{
|
|
id: 'reorder-panes',
|
|
journey: async ({ page }) => {
|
|
await splitActiveTerminalPane(page, 'vertical')
|
|
await waitForBoundPanes(page, 2)
|
|
const [firstLeaf, secondLeaf] = await readTerminalPaneDomLeafOrder(page)
|
|
await moveTerminalPaneByLeafId(page, secondLeaf!, firstLeaf!, 'left')
|
|
await expect.poll(() => readTerminalPaneDomLeafOrder(page)).toEqual([secondLeaf, firstLeaf])
|
|
}
|
|
},
|
|
{
|
|
// Main-originated: the runtime RPC the CLI uses, not a renderer gesture.
|
|
id: 'cli-split',
|
|
journey: async ({ page, worktreeId, userDataDir }) => {
|
|
const client = new RuntimeClient(userDataDir, 30_000)
|
|
let handle: string | null = null
|
|
await expect
|
|
.poll(async () => {
|
|
const listed = await client
|
|
.call<RuntimeTerminalListResult>('terminal.list', { worktree: `id:${worktreeId}` })
|
|
.catch(() => null)
|
|
handle = listed?.result.terminals[0]?.handle ?? null
|
|
return handle
|
|
})
|
|
.not.toBeNull()
|
|
await client.call('terminal.split', { terminal: handle, direction: 'horizontal' })
|
|
await waitForBoundPanes(page, 2)
|
|
}
|
|
},
|
|
{
|
|
id: 'drag-out-to-tab',
|
|
journey: async (journey) => {
|
|
const { page } = journey
|
|
await splitActiveTerminalPane(page, 'vertical')
|
|
await waitForBoundPanes(page, 2)
|
|
const [, secondLeaf] = await readTerminalPaneDomLeafOrder(page)
|
|
await dragPaneOutToTabStrip(page, journey.worktreeId, secondLeaf!)
|
|
await expect(page.locator(SORTABLE_TAB)).toHaveCount(2)
|
|
await waitForActiveTerminalManager(page)
|
|
await waitForBoundPanes(page, 1)
|
|
},
|
|
restart: { expectedPaneCount: 1, times: 2 }
|
|
},
|
|
{
|
|
id: 'restart-restore',
|
|
journey: ({ page }) => splitThenNewTab(page),
|
|
restart: { expectedPaneCount: 1 }
|
|
},
|
|
{
|
|
id: 'folder-workspace',
|
|
setup: addFolderWorkspace,
|
|
journey: ({ page }) => splitThenNewTab(page)
|
|
}
|
|
]
|
|
|
|
for (const scenario of SCENARIOS) {
|
|
// oxlint-disable-next-line no-empty-pattern -- Each scenario owns its launches through createRestartSession.
|
|
test(`parity: ${scenario.id}`, async ({}, testInfo) => runScenario(testInfo, scenario))
|
|
}
|