mirror of
https://github.com/stablyai/orca.git
synced 2026-11-16 19:07:41 +00:00
* [comment audit] Align legacy failure-read counts with cached display * [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci] * [comment audit] Condense shared generation, path and preview comments [skip ci] * [comment audit] Condense host, file and Git contract rationale [skip ci] * [comment audit] Tighten Git lifecycle and provider contract comments [skip ci] * [comment audit] Clarify shared host authority and launch isolation [skip ci] * [comment audit] simplify local access mobile and native chat contracts [skip ci] * [comment audit] simplify native chat presentation and state contracts [skip ci] * [comment audit] simplify native runtime and provider contracts [skip ci] * [comment audit] simplify migration and orchestration contracts [skip ci] * [comment audit] simplify plugin trust and process capture rationale [skip ci] * [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci] * [comment audit] clarify remote recovery and launch wire rationale [skip ci] * [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci] * [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci] * [comment audit] clarify sidebar, skill and SSH invariants [skip ci] * [comment audit] condense structured chat delivery and timing rationale [skip ci] * [comment audit] condense terminal replay and telemetry invariants [skip ci] * [comment audit] clarify launch permission and terminal delivery rationale [skip ci] * [comment audit] clarify workspace ownership and layout contracts [skip ci] * [comment audit] wait for fitted and painted SSH terminal links * [comment audit] clarify layout persistence and session ownership [skip ci] * [comment audit] clarify host routing and workspace lifecycle contracts [skip ci] * [comment audit] clarify startup persistence and app lifetime comments [skip ci] * [comment audit] clarify recovery and activity boundaries [skip ci] * [comment audit] condense activity and artifact invariants [skip ci] * [comment audit] condense automation authority contracts [skip ci] * [comment audit] simplify automation scheduling and history contracts [skip ci] * [comment audit] clarify browser chrome and annotation lifecycles [skip ci] * [comment audit] clarify browser routing and retained guest ownership [skip ci] * [comment audit] clarify browser recovery and document ownership comments [skip ci] * [comment audit] restore hosted runners required by native IME fixtures * [comment audit] shorten preview, palette and dashboard invariants [skip ci] * [comment audit] clarify terminal preview, dashboard and retention comments [skip ci] * [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci] * [comment audit] shorten rich-text and combined-diff ownership comments [skip ci] * [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci] * [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci] * [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci] * [comment audit] clarify rich Markdown source and selection safeguards [skip ci] * [comment audit] clarify editor loading and emulator stream lifetimes [skip ci] * [comment audit] trim emulator and feature tour narration [skip ci] * [comment audit] clarify floating workspace and GitHub cache ownership [skip ci] * [comment audit] trim provider controls and Linear filter explanations [skip ci] * [comment audit] clarify pairing and chat resume lifetimes [skip ci] * [comment audit] clarify chat delivery and transcript lifetimes [skip ci] * [comment audit] clarify session options and host-owned status [skip ci] * [comment audit] clarify draft durability and live-status precedence [skip ci] * [comment audit] Trim chat send and model ownership explanations [skip ci] * [comment audit] Shorten transcript ownership and send recovery comments [skip ci] * [comment audit] Simplify native chat composer and transcript hook comments [skip ci] * [comment audit] Shorten native chat scroll and structured session explanations [skip ci] * [comment audit] Trim workspace picker and onboarding commentary [skip ci] * [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci] * [comment audit] Trim sidebar and session history explanations [skip ci] * [comment audit] Condense session resume and review checks comments [skip ci] * [comment audit] Shorten checks state and file explorer refresh comments [skip ci] * [comment audit] Trim plugin bridge and source-control action rationale [skip ci] * [comment audit] Trim source-control listing and review rationale [skip ci] * [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci] * [comment audit] Condense Settings account and appearance rationale [skip ci] * [comment audit] Trim pairing and repository Settings explanations [skip ci] * [comment audit] Condense Settings search SSH and terminal safeguards [skip ci] * [comment audit] Shorten Settings voice and provider ownership comments [skip ci] * [comment audit] Condense Settings draft persistence and host-state rationale [skip ci] * [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci] * [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci] * [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci] * [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci] * [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci] * [comment audit] Prune focus-read baseline after comment cleanup * [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci] * [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci] * [comment audit] Clarify viewport geometry and skill update safeguards [skip ci] * [comment audit] Tighten skill inventory, usage and host status comments [skip ci] * [comment audit] Clarify usage ownership and resource kill safeguards [skip ci] * [comment audit] Tighten tab selection, rename and search contracts [skip ci] * [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci] * [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci] * [comment audit] Tighten provider loading and terminal recovery comments [skip ci] * [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci] * [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci] * [comment audit] Tighten PTY startup and replay explanations [skip ci] * [comment audit] Clarify PTY identity and delivery ownership [skip ci] * [comment audit] Shorten remote reconnect and input replay rationale [skip ci] * [comment audit] Condense terminal parking clipboard and file link comments [skip ci] * [comment audit] Clarify IME ownership and trim trace history [skip ci] * [comment audit] Shorten pane recovery and parked watcher explanations [skip ci] * [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci] * [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci] * [comment audit] Trim renderer lifecycle and menu rationale [skip ci] * [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci] * [comment audit] Clarify renderer hook evidence and source ownership [skip ci] * [comment audit] Tighten IPC ownership and reconnect explanations [skip ci] * [comment audit] Trim renderer focus, paste and attention comments [skip ci] * [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci] * [comment audit] Trim agent launch, resume and ownership commentary [skip ci] * [comment audit] Shorten account, browser and editor comments [skip ci] * [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci] * [comment audit] Condense launch recovery and editor tokenization comments [skip ci] * [comment audit] Condense workspace selection and terminal pane rationale [skip ci] * [comment audit] Condense terminal fitting and rendering recovery comments [skip ci] * [comment audit] Condense terminal input and host routing explanations [skip ci] * [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci] * [comment audit] Condense structured launch and terminal link explanations [skip ci] * [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci] * [comment audit] Condense session persistence and workspace activation rationale [skip ci] * [comment audit] Condense workspace routing and browser ownership rationale [skip ci] * [comment audit] Condense mirror recovery and layout authority rationale [skip ci] * [comment audit] Condense runtime transport and file safety rationale [skip ci] * [comment audit] Condense runtime graph and structured session rationale [skip ci] * [comment audit] Condense browser creation and remote tab recovery rationale [skip ci] * [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci] * [comment audit] Condense frame, startup and provider cache rationale [skip ci] * [comment audit] Condense host twin and agent lifecycle rationale [skip ci] * [comment audit] Condense browser authority and editor cleanup rationale [skip ci] * [comment audit] Condense editor buffer identity and review cache rationale [skip ci] * [comment audit] Condense provider lifetime and repository ownership rationale [skip ci] * [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci] * [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci] * [comment audit] Condense cleanup ownership and listing admission rationale [skip ci] * [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci] * [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci] * [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci] * [comment audit] Condense cloud rollout and assignment safety rationale [skip ci] * [comment audit] Condense relay session and database recovery rationale [skip ci] * [comment audit] Condense relay placement and protocol compatibility rationale [skip ci] * [comment audit] Condense build and packaging constraints [skip ci] * [comment audit] Condense CI gates and validation isolation rationale [skip ci] * [comment audit] Condense catalog identity and browser validation rationale [skip ci] * [comment audit] Condense mobile browser and frame-budget rationale [skip ci] * [comment audit] Shorten mobile route and browser test explanations [skip ci] * [comment audit] Condense editor and session seam test rationale [skip ci] * [comment audit] Trim session and terminal closure history [skip ci] * [comment audit] Shorten terminal browser and census explanations [skip ci] * [comment audit] Preserve root-only E2E diagnostic baseline * [comment audit] Condense mobile seam and HTML preview test rationale [skip ci] * [comment audit] Condense preview instrumentation and render harness rationale [skip ci] * [comment audit] Condense bundle contracts and native-build constraints [skip ci] * [comment audit] Shorten native packaging and CI routing rationale [skip ci] * [comment audit] Condense release tooling and benchmark constraints [skip ci] * [comment audit] Condense packaging and platform gate rationale [skip ci] * [comment audit] Shorten mobile route and history rationale [skip ci] * [comment audit] Condense mobile browser and component rationale [skip ci] * [comment audit] Shorten drawer and workspace-form rationale [skip ci] * [comment audit] Trim mobile review and editor-document explanations [skip ci] * [comment audit] Condense editor lifecycle and Markdown explanations [skip ci] * [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci] * [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci] * [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci] * [comment audit] Condense bridge stream, native request and audio rationale [skip ci] * [comment audit] Reduce bridge schema and page-client commentary [skip ci] * [comment audit] Tighten mobile page bridge contracts [skip ci] * [comment audit] Clarify mobile cache and session constraints [skip ci] * [comment audit] Condense mobile route and lifecycle rationale [skip ci] * [comment audit] Tighten mobile shell hook timing rationale [skip ci] * [comment audit] Clarify route handoff and notification compatibility [skip ci] * [comment audit] Clarify push registration and dictation cleanup constraints [skip ci] * [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci] * [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci] * [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci] * [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci] * [comment audit] Tighten stream replay and queued session ownership rationale [skip ci] * [comment audit] Condense mobile composer and reply-schema constraints [skip ci] * [comment audit] Clarify mobile transcript recovery and session ownership [skip ci] * [comment audit] Clarify mobile queue and source-control compatibility [skip ci] * [comment audit] Condense storage and task launch constraints [skip ci] * [comment audit] Clarify task schemas and terminal document ownership [skip ci] * [comment audit] Tighten terminal input and viewport rationale [skip ci] * [comment audit] Shorten terminal and RPC recorder contracts [skip ci] * [comment audit] Condense recorder engine and connection contracts [skip ci] * [comment audit] Shorten host credential and relay recovery comments [skip ci] * [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci] * [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci] * [comment audit] Condense catalog and relay entry contracts [skip ci] * [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci] * [comment audit] Condense WSL relay and E2E regression rationale [skip ci] * [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci] * [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci] * [comment audit] Shorten layout oracle and regression explanations [skip ci] * [comment audit] Condense paired recovery and ownership regression contracts [skip ci] * [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci] * [comment audit] Condense terminal rendering and IME regression rationale [skip ci] * [comment audit] Shorten terminal recovery and benchmark contracts [skip ci] * [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci] * [comment audit] Condense workflow routing and release rationale [skip ci] * [comment audit] Condense mobile security and installer contracts [skip ci] * [comment audit] Shorten native rationale and stylesheet workarounds [skip ci] * [comment audit] Shorten Windows visibility probe rationale [skip ci] * [comment audit] Condense embedded release and signing rationale [skip ci] * [comment audit] Retain current main test behavior in final reconciliation [skip ci] * [comment audit] Complete final comment review across current source inventory * [comment audit] Handle consolidated audit reports before final CI * [comment audit] Preserve credential storage census detail [skip ci] * [comment audit] Scale broad changed E2E selections with verified timing shards * [comment audit] Align E2E assertions with browser close and settled session metadata * [comment audit] Match existing E2Es to current resource and windowing contracts * [comment audit] Observe the shared server outage notice in reconnect coverage * [comment audit] Make existing renderer probes measure settled tab and PTY work * [comment audit] Align palette E2E selector with task search * [comment audit] Refresh remaining palette search selectors * [comment audit] Keep selector correction within selected audit specs * [comment audit] Await emoji fixture settings inside renderer evaluation * [comment audit] Cancel fixture fit retries between terminal tests --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
239 lines
9.3 KiB
TypeScript
239 lines
9.3 KiB
TypeScript
// #29145: the managed SSH host’s real CLI may create/navigate/open desktop browser tabs only while its control setting is enabled.
|
||
// Require remote-only origin egress through the host and immediate named refusal when the setting turns off.
|
||
import type { ElectronApplication, Page } from '@stablyai/playwright-test'
|
||
import { z } from 'zod'
|
||
import { expect, forwardElectronProcessLogs, test } from './helpers/orca-app'
|
||
import { createRestartSession } from './helpers/orca-restart'
|
||
import { waitForSessionReady } from './helpers/store'
|
||
import {
|
||
cleanupDockerSshHostTarget,
|
||
DOCKER_SSH_HOST_REMOTE_REPO_PATH,
|
||
execDockerSshHostTargetCommand,
|
||
startDockerSshHostTarget,
|
||
type DockerSshHostTarget
|
||
} from './helpers/docker-ssh-host-target'
|
||
import { seedRelayEraProfile } from './helpers/orcad-upgrade-profile'
|
||
import {
|
||
readSshRemoteOnlyRequests,
|
||
SSH_REMOTE_ONLY_ORIGIN,
|
||
startSshRemoteOnlyBrowserFixture
|
||
} from './helpers/ssh-remote-only-browser-fixture'
|
||
import { convertAndRetain } from './helpers/orcad-convert-flow'
|
||
import {
|
||
activateManagedWorkspace,
|
||
expectPaneText,
|
||
managedEnvironmentId,
|
||
openTerminalTab,
|
||
ORCAD_TEMPLATE,
|
||
skipUnlessManagedDockerHost,
|
||
typeInTerminal
|
||
} from './helpers/orcad-managed-workspace'
|
||
import { DESKTOP_BROWSER_BRIDGE_SETTING_LABEL } from '../../src/shared/desktop-browser-bridge-protocol'
|
||
|
||
skipUnlessManagedDockerHost()
|
||
|
||
const CliResult = z.object({
|
||
ok: z.boolean(),
|
||
result: z.record(z.string(), z.unknown()).optional(),
|
||
error: z.object({ code: z.string(), message: z.string() }).optional()
|
||
})
|
||
type CliResult = z.infer<typeof CliResult>
|
||
|
||
let step = 0
|
||
|
||
/** Runs an `orca` command in the host's terminal, as an agent there would, and reads its JSON. */
|
||
async function hostCli(
|
||
page: Page,
|
||
target: DockerSshHostTarget,
|
||
tabId: string,
|
||
command: string
|
||
): Promise<CliResult> {
|
||
step += 1
|
||
const out = `/tmp/bridge-cli-${step}.json`
|
||
const marker = `BRIDGE_${step}_DONE`
|
||
// Split so the typed line never contains the marker the wait looks for.
|
||
await typeInTerminal(
|
||
page,
|
||
tabId,
|
||
`${command} --json > ${out} 2>&1; printf '%s_%s\\n' BRIDGE_${step} DONE`
|
||
)
|
||
await expectPaneText(page, tabId, marker, 90_000)
|
||
return CliResult.parse(JSON.parse(execDockerSshHostTargetCommand(target, `cat ${out}`)))
|
||
}
|
||
|
||
/** Retries until the desktop has attached its bridge, since the attach follows the setting change. */
|
||
async function hostCliUntilOk(
|
||
page: Page,
|
||
target: DockerSshHostTarget,
|
||
tabId: string,
|
||
command: string
|
||
): Promise<CliResult> {
|
||
const results: CliResult[] = []
|
||
try {
|
||
await expect
|
||
.poll(
|
||
async () => {
|
||
const result = await hostCli(page, target, tabId, command)
|
||
results.push(result)
|
||
return result.ok
|
||
},
|
||
{ timeout: 120_000, intervals: [2_000], message: 'the host CLI never reached the desktop' }
|
||
)
|
||
.toBe(true)
|
||
} catch (error) {
|
||
throw new Error(`${String(error)}\nlast CLI result: ${JSON.stringify(results.at(-1))}`)
|
||
}
|
||
return results.at(-1)!
|
||
}
|
||
|
||
function setRemoteCliControl(page: Page, targetId: string, enabled: boolean): Promise<unknown> {
|
||
return page.evaluate(
|
||
({ targetId, enabled }) =>
|
||
window.api.ssh.updateTarget({ id: targetId, updates: { allowRemoteCliControl: enabled } }),
|
||
{ targetId, enabled }
|
||
)
|
||
}
|
||
|
||
function browserTabUrls(page: Page, worktreeId: string): Promise<string[]> {
|
||
return page.evaluate((id) => {
|
||
const state = window.__store?.getState()
|
||
return (state?.browserTabsByWorktree[id] ?? []).flatMap((tab) =>
|
||
(state?.browserPagesByWorkspace[tab.id] ?? []).map((entry) => entry.url)
|
||
)
|
||
}, worktreeId)
|
||
}
|
||
|
||
test('a managed SSH host drives the desktop browser by default until its CLI control setting is turned off', async (// oxlint-disable-next-line no-empty-pattern -- Owns app launch.
|
||
{}, testInfo) => {
|
||
test.setTimeout(8 * 60_000)
|
||
const target = startDockerSshHostTarget(testInfo)
|
||
const session = createRestartSession(testInfo, { ORCA_ORCAD_TEMPLATE_PATH: ORCAD_TEMPLATE! })
|
||
let app: ElectronApplication | null = null
|
||
try {
|
||
startSshRemoteOnlyBrowserFixture(target)
|
||
// The first launch only creates the profile the SSH host is saved into.
|
||
const first = await session.launch()
|
||
app = first.app
|
||
await waitForSessionReady(first.page)
|
||
await session.close(first.app)
|
||
app = null
|
||
const seeded = seedRelayEraProfile(
|
||
session.userDataDir,
|
||
{
|
||
label: `desktop browser bridge E2E ${Date.now()}`,
|
||
host: target.host,
|
||
port: target.port,
|
||
username: 'root',
|
||
identityFile: target.identityFile,
|
||
identitiesOnly: true,
|
||
relayGracePeriodSeconds: 1
|
||
},
|
||
{ repoPath: DOCKER_SSH_HOST_REMOTE_REPO_PATH, folderPath: '/tmp' }
|
||
)
|
||
const launched = await session.launch()
|
||
app = launched.app
|
||
forwardElectronProcessLogs(app, testInfo)
|
||
const page = launched.page
|
||
await waitForSessionReady(page)
|
||
await convertAndRetain(page, session.userDataDir, seeded)
|
||
const environmentId = await managedEnvironmentId(page, seeded.targetId)
|
||
await activateManagedWorkspace(page, seeded.worktreeId, environmentId)
|
||
const tabId = await openTerminalTab(page, seeded.worktreeId)
|
||
|
||
// No saved value: on by default.
|
||
const createdUrl = `${SSH_REMOTE_ONLY_ORIGIN}/echo/bridge-created`
|
||
const created = await hostCliUntilOk(page, target, tabId, `orca tab create --url ${createdUrl}`)
|
||
const browserPageId = String(created.result?.browserPageId ?? '')
|
||
expect(browserPageId).not.toBe('')
|
||
await expect
|
||
.poll(() => browserTabUrls(page, seeded.worktreeId), { timeout: 30_000 })
|
||
.toContain(createdUrl)
|
||
// Only the SSH host resolves this origin, so the request proves the desktop page egressed there.
|
||
await expect
|
||
.poll(() => readSshRemoteOnlyRequests(target).map((request) => request.path), {
|
||
timeout: 60_000,
|
||
message: 'the desktop tab the host opened never loaded through the host'
|
||
})
|
||
.toContain('/echo/bridge-created')
|
||
// Like an agent: navigate the tab it opened, then read it back.
|
||
const navigatedUrl = `${SSH_REMOTE_ONLY_ORIGIN}/echo/bridge-navigated`
|
||
await hostCliUntilOk(
|
||
page,
|
||
target,
|
||
tabId,
|
||
`orca goto --url ${navigatedUrl} --page ${browserPageId}`
|
||
)
|
||
await expect
|
||
.poll(() => readSshRemoteOnlyRequests(target).map((request) => request.path), {
|
||
timeout: 60_000,
|
||
message: 'the desktop tab the host drove never loaded through the host'
|
||
})
|
||
.toContain('/echo/bridge-navigated')
|
||
const snapshot = await hostCliUntilOk(
|
||
page,
|
||
target,
|
||
tabId,
|
||
`orca snapshot --page ${browserPageId}`
|
||
)
|
||
expect(JSON.stringify(snapshot.result)).toContain('cookie:')
|
||
const listed = await hostCli(page, target, tabId, 'orca tab list')
|
||
expect(listed.ok).toBe(true)
|
||
expect(JSON.stringify(listed.result)).toContain(browserPageId)
|
||
// `orca open-url` reaches the desktop the same way, as a tab in the host's workspace.
|
||
const openedUrl = `${SSH_REMOTE_ONLY_ORIGIN}/echo/bridge-open-url`
|
||
const opened = await hostCliUntilOk(page, target, tabId, `orca open-url --url ${openedUrl}`)
|
||
const openedPageId = String(opened.result?.browserPageId ?? '')
|
||
expect(openedPageId).not.toBe('')
|
||
await expect
|
||
.poll(() => browserTabUrls(page, seeded.worktreeId), { timeout: 30_000 })
|
||
.toContain(openedUrl)
|
||
await expect
|
||
.poll(() => readSshRemoteOnlyRequests(target).map((request) => request.path), {
|
||
timeout: 60_000,
|
||
message: 'the desktop tab open-url opened never loaded through the host'
|
||
})
|
||
.toContain('/echo/bridge-open-url')
|
||
expect((await hostCli(page, target, tabId, `orca tab close --page ${openedPageId}`)).ok).toBe(
|
||
true
|
||
)
|
||
await page.screenshot({ path: testInfo.outputPath('desktop-browser-bridge-on.png') })
|
||
// A desktop file is never reachable, even through a tab the host may drive.
|
||
const fileRead = await hostCli(
|
||
page,
|
||
target,
|
||
tabId,
|
||
`orca goto --url file:///etc/hosts --page ${browserPageId}`
|
||
)
|
||
expect(fileRead.error?.code).toBe('invalid_argument')
|
||
const closed = await hostCli(page, target, tabId, `orca tab close --page ${browserPageId}`)
|
||
expect(closed.ok).toBe(true)
|
||
await expect
|
||
.poll(() => browserTabUrls(page, seeded.worktreeId), { timeout: 30_000 })
|
||
.not.toContain(navigatedUrl)
|
||
|
||
// Explicitly off: the bridge detaches at once and the host is refused with the setting's name.
|
||
await setRemoteCliControl(page, seeded.targetId, false)
|
||
await expect
|
||
.poll(async () => (await hostCli(page, target, tabId, 'orca tab list')).error?.code ?? 'ok', {
|
||
timeout: 60_000,
|
||
intervals: [1_000]
|
||
})
|
||
.toBe('desktop_browser_bridge_unavailable')
|
||
const refused = await hostCli(page, target, tabId, 'orca tab list')
|
||
expect(refused.error?.message).toContain(DESKTOP_BROWSER_BRIDGE_SETTING_LABEL)
|
||
// open-url names the same setting, not a desktop that is "offline".
|
||
const openRefused = await hostCli(page, target, tabId, `orca open-url --url ${openedUrl}`)
|
||
expect(openRefused.error?.code).toBe('desktop_browser_bridge_unavailable')
|
||
expect(openRefused.error?.message).toContain(DESKTOP_BROWSER_BRIDGE_SETTING_LABEL)
|
||
} finally {
|
||
try {
|
||
if (app) {
|
||
await session.close(app)
|
||
}
|
||
await session.dispose()
|
||
} finally {
|
||
cleanupDockerSshHostTarget(target)
|
||
}
|
||
}
|
||
})
|