mirror of
https://github.com/stablyai/orca.git
synced 2026-10-24 00:04:01 +00:00
* refactor(tests): split oversized test files off the max-lines suppression list Every `*.test.ts`/`*.spec.ts` that carried an `eslint/oxlint-disable max-lines` directive is now split into focused, behavior-scoped suites that fit the 800-line test budget, with shared setup extracted into co-located `*-test-harness.ts` / `*-test-fixtures.ts` modules (300-line budget). 83 files became ~930; the largest output is 797 effective lines. `orca-runtime.test.ts` is intentionally untouched. Test bodies were moved by scripted line-range slicing rather than retyped, so assertions are byte-identical. The only permitted body edits were mechanical rebinding where a shared value moved into a harness (e.g. `tmpHome` -> `homes.tmpHome`). Registries that enumerate test files were updated in lockstep: - config/max-lines-baseline.txt: pruned 341 -> 258 entries (all 83 removed). - config/reliability-gates.jsonc: 33 gates repointed at the split files, with assertionRefs split per file where a gate's coverage now spans several. - .github/workflows/pr.yml: the real-zsh lane now lists the 4 split files that actually exercise zsh, so they keep running in the dedicated shell lane. Also renamed agent-hooks `server-test-fixtures.ts` to `server.test-fixtures.ts` so the global-fetch call-site audit keeps skipping it, and added `.js` extensions to the CLI suites' dynamic harness imports (node16 resolution) to unbreak `build:cli`. Verification: full suite 52,449 passing vs 52,448 at baseline with zero assertions lost; `pnpm lint`, `pnpm typecheck`, and `pnpm build:cli` all exit 0; the terminal-pane e2e spec runs 31/31 headless. * refactor(tests): split hook-idle arbitration suite that oxfmt pushed over budget The pre-commit oxfmt pass reflowed pty-connection-hook-idle-arbitration.test.ts to 811 effective lines, 11 over the test budget. Split the hook-completion side effect and replacement-agent veto cases into their own suite; both files now sit well under the cap and the 15 tests are unchanged. * test: port upstream test changes into the split files after rebase Rebasing onto main surfaced 27 tests that main had added to files this branch deleted, plus edits to tests that had already moved. Taking the deletion side of those modify/delete conflicts would have dropped that coverage silently, so each upstream change is ported into the split file that now owns the behavior — for example main's six orchestration mailbox tests land across orchestration-runs, -send, and -check. Also repoints `orchestration.notification-mailbox-consistency`, a gate main added after this branch's gate remap, at those same three split files, and re-prunes the max-lines baseline against main's (257 entries). Verified: all 27 upstream test titles present; full suite 52,761 passing with the only diff vs baseline being 12 tests main itself removed and 3 that moved from skipped to passing; lint and typecheck exit 0. * fix(test): flush pending continuations before tearing down terminal test globals CI shard 5/16 failed on both Node 24 and 26 with `ReferenceError: window is not defined` from pty-connection.ts, surfacing through pty-connection-daemon-snapshot-replay.test.ts. The reattach/settle chains `await` a real promise and then touch `window.api`. Under fake timers those continuations cannot run, so they only become schedulable once restoreTerminalTestGlobals() switches back to real timers — which previously happened immediately before `delete globalThis.window`, so a late continuation threw and failed the whole file. Flush async ticks in that window instead. This is latent in the source rather than new: the pre-split 25k-line file kept running other tests after these, which gave the chains time to settle before teardown. Splitting the file moved teardown directly behind them. * fix(test): keep an inert window after terminal test teardown instead of deleting it The async-tick flush was not enough: the reattach/settle chain can resolve after teardown regardless of how long we drain, so CI shard 5/16 still failed with `ReferenceError: window is not defined` from pty-connection.ts. A real renderer never loses `window`, so deleting it was the artificial part. Swap in an inert proxy whose properties resolve to callables and whose calls resolve to undefined, making a late `window.api.pty.*` call a harmless no-op. The next test replaces it wholesale via installTerminalTestGlobals(), and no test asserts that `window` is absent.
146 lines
5.3 KiB
TypeScript
146 lines
5.3 KiB
TypeScript
/**
|
|
* E2E tests for terminal pane scrollback retention.
|
|
*
|
|
* User Prompt:
|
|
* - terminal panes retain state when switching tabs and when you make / close a pane / switch worktrees
|
|
*/
|
|
|
|
import { test, expect } from './helpers/orca-app'
|
|
import {
|
|
discoverActivePtyId,
|
|
execInTerminal,
|
|
closeActiveTerminalPane,
|
|
countVisibleTerminalPanes,
|
|
focusLastTerminalPane,
|
|
splitActiveTerminalPane,
|
|
waitForTerminalOutput,
|
|
waitForPaneCount,
|
|
getTerminalContent
|
|
} from './helpers/terminal'
|
|
import {
|
|
getActiveWorktreeId,
|
|
getActiveTabType,
|
|
getWorktreeTabs,
|
|
getAllWorktreeIds,
|
|
switchToOtherWorktree,
|
|
switchToWorktree,
|
|
ensureTerminalVisible
|
|
} from './helpers/store'
|
|
import { pressShortcut } from './helpers/shortcuts'
|
|
import { registerTerminalPaneMountReadiness } from './helpers/terminal-pane-mount-readiness'
|
|
|
|
// Why: keep the suite serial so the headful pane tests never ask Playwright to
|
|
// open multiple visible Electron windows at once.
|
|
test.describe.configure({ mode: 'serial' })
|
|
test.describe('Terminal Panes', () => {
|
|
registerTerminalPaneMountReadiness()
|
|
|
|
/**
|
|
* User Prompt:
|
|
* - terminal panes retain state when switching tabs and when you make / close a pane / switch worktrees
|
|
*/
|
|
test('terminal pane retains content when switching tabs and back', async ({ orcaPage }) => {
|
|
// Write a unique marker to the current terminal
|
|
const ptyId = await discoverActivePtyId(orcaPage)
|
|
const marker = `RETAIN_TEST_${Date.now()}`
|
|
await execInTerminal(orcaPage, ptyId, `echo ${marker}`)
|
|
await waitForTerminalOutput(orcaPage, marker)
|
|
|
|
// Create a new terminal tab (Cmd/Ctrl+T) to switch away
|
|
const worktreeId = (await getActiveWorktreeId(orcaPage))!
|
|
await pressShortcut(orcaPage, 't')
|
|
|
|
// Wait for the new tab to appear
|
|
await expect
|
|
.poll(async () => (await getWorktreeTabs(orcaPage, worktreeId)).length, { timeout: 5_000 })
|
|
.toBeGreaterThanOrEqual(2)
|
|
|
|
// Verify we're still on a terminal tab
|
|
const activeType = await getActiveTabType(orcaPage)
|
|
expect(activeType).toBe('terminal')
|
|
|
|
// Switch back to the previous tab with Cmd/Ctrl+Shift+[
|
|
await pressShortcut(orcaPage, 'BracketLeft', { shift: true })
|
|
|
|
// Verify the marker is still present
|
|
await expect
|
|
.poll(async () => (await getTerminalContent(orcaPage)).includes(marker), { timeout: 5_000 })
|
|
.toBe(true)
|
|
|
|
// Clean up the extra tab
|
|
await pressShortcut(orcaPage, 'BracketRight', { shift: true })
|
|
await pressShortcut(orcaPage, 'w')
|
|
})
|
|
|
|
/**
|
|
* User Prompt:
|
|
* - terminal panes retain state when switching tabs and when you make / close a pane / switch worktrees
|
|
*/
|
|
test('terminal pane retains content when splitting and closing a pane', async ({ orcaPage }) => {
|
|
// Write a unique marker to the current terminal
|
|
const ptyId = await discoverActivePtyId(orcaPage)
|
|
const marker = `SPLIT_RETAIN_${Date.now()}`
|
|
await execInTerminal(orcaPage, ptyId, `echo ${marker}`)
|
|
await waitForTerminalOutput(orcaPage, marker)
|
|
|
|
const panesBefore = await countVisibleTerminalPanes(orcaPage)
|
|
|
|
// Split the terminal right
|
|
await splitActiveTerminalPane(orcaPage, 'vertical')
|
|
await waitForPaneCount(orcaPage, panesBefore + 1)
|
|
|
|
await focusLastTerminalPane(orcaPage)
|
|
await closeActiveTerminalPane(orcaPage)
|
|
await waitForPaneCount(orcaPage, panesBefore)
|
|
|
|
// The original pane should still have our marker
|
|
await expect
|
|
.poll(async () => (await getTerminalContent(orcaPage)).includes(marker), { timeout: 5_000 })
|
|
.toBe(true)
|
|
})
|
|
|
|
/**
|
|
* User Prompt:
|
|
* - terminal panes retain state when switching tabs and when you make / close a pane / switch worktrees
|
|
*/
|
|
test('terminal pane retains content when switching worktrees and back', async ({ orcaPage }) => {
|
|
const allWorktreeIds = await getAllWorktreeIds(orcaPage)
|
|
if (allWorktreeIds.length < 2) {
|
|
test.skip(true, 'Need at least 2 worktrees to test worktree switching')
|
|
return
|
|
}
|
|
|
|
const worktreeId = (await getActiveWorktreeId(orcaPage))!
|
|
|
|
// Write a unique marker to the current terminal
|
|
const ptyId = await discoverActivePtyId(orcaPage)
|
|
const marker = `WT_RETAIN_${Date.now()}`
|
|
await execInTerminal(orcaPage, ptyId, `echo ${marker}`)
|
|
await waitForTerminalOutput(orcaPage, marker)
|
|
|
|
// Switch to a different worktree via the store
|
|
const otherId = await switchToOtherWorktree(orcaPage, worktreeId)
|
|
expect(otherId).not.toBeNull()
|
|
await expect.poll(async () => getActiveWorktreeId(orcaPage), { timeout: 5_000 }).toBe(otherId)
|
|
|
|
// Switch back to the original worktree
|
|
await switchToWorktree(orcaPage, worktreeId)
|
|
await expect
|
|
.poll(async () => getActiveWorktreeId(orcaPage), { timeout: 5_000 })
|
|
.toBe(worktreeId)
|
|
|
|
// Why: after a worktree round-trip, the split-group container transitions
|
|
// from hidden back to visible. In headful Electron runs the terminal tree
|
|
// can take longer than a single render turn to rebind its serialize addon
|
|
// after the worktree activation cascade. Waiting directly for the retained
|
|
// marker proves the user-visible behavior without failing early on the
|
|
// intermediate manager-remount timing.
|
|
await ensureTerminalVisible(orcaPage)
|
|
|
|
// The terminal should still contain our marker
|
|
await expect
|
|
.poll(async () => (await getTerminalContent(orcaPage)).includes(marker), { timeout: 20_000 })
|
|
.toBe(true)
|
|
})
|
|
})
|