Files
orca/src/shared/host-setting-overrides.test.ts
Neil 77f23b013f refactor(shared): drop the shared/types barrel and import from the real modules (#14447)
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as
a re-export barrel so the import sites did not have to change. This removes
the barrel: every consumer now imports from the module that actually declares
the type, and `src/shared/types.ts` is deleted.

Barrels hide where a type lives, make every consumer look like it depends on
the whole domain, and let an unrelated edit invalidate a module that ~2,000
files transitively import.

2,323 import declarations across 2,321 files. Rewritten mechanically: each
specifier was resolved to an absolute path via the TypeScript AST and
recomputed, rather than string-substituted, so alias forms (`@/../../shared/
types`) and per-specifier `type` modifiers survive.

Four cases the mechanical pass had to handle, each found by a gate rather than
by reading the diff:

- Modules inside `src/shared` import the barrel as `./types`, not
  `shared/types`. A pre-filter on the latter string skipped 176 of them and
  left imports dangling at a deleted file, which surfaced as confusing
  `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>`
  errors rather than "module not found".
- The barrel RENAMED one type on the way through
  (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name
  in the owning module has to be re-aliased at each consumer.
- Three test files put `;(globalThis as ...)` on the line after the import.
  TypeScript parses that `;` as the import statement's terminator, so
  replacing through `statement.getEnd()` deletes it and breaks ASI. The
  rewrite now stops at the module specifier.
- A file that already imported directly from a module got a SECOND import
  from it, because the barrel re-exported those same names — which trips
  `import/no-duplicates` under `--deny-warnings`. A post-pass merges
  declarations sharing a specifier and type-only-ness; the `import type` plus
  `import` pair from one module is left alone, since that form is allowed.

Splitting one barrel import into several genuinely adds lines, which pushed
`terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character
import must wrap, and neither local type collapses onto one line (101 and 116
characters). Rather than contort a type declaration to fit a line budget,
`collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` —
they are pure structural operations on the layout tree and independent of PTY
ownership. `visible-worktrees.ts` similarly loses its own mini-barrel
re-export of `isDefaultBranchWorkspace`, with the four real consumers
repointed at the declaring module. No `max-lines` bypass added.

Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted
first — these projects are `composite: true` and reuse stale caches); the full
`pnpm lint` green, not just bare oxlint — the narrower local check is what let
the duplicate imports reach CI; max-lines ratchet OK at 344.
2026-08-13 22:48:24 -07:00

145 lines
5.5 KiB
TypeScript

import { describe, expect, it } from 'vitest'
import {
clearHostSettingOverride,
getEffectiveHostSetting,
getHostDisplayLabelOverrides,
getHostSettingOverride,
setHostSettingOverride
} from './host-setting-overrides'
import type { GlobalSettings } from './global-settings-types'
function settingsWith(
overrides: GlobalSettings['hostSettingOverrides']
): Pick<GlobalSettings, 'hostSettingOverrides'> {
return { hostSettingOverrides: overrides }
}
describe('getEffectiveHostSetting', () => {
it('prefers a host override over the client default', () => {
const settings = settingsWith({ 'ssh:box': { defaultWorktreeLocation: '/remote/work' } })
expect(
getEffectiveHostSetting(settings, 'ssh:box', 'defaultWorktreeLocation', '/local/work')
).toBe('/remote/work')
})
it('falls back to the client default when no override exists', () => {
const settings = settingsWith({})
expect(
getEffectiveHostSetting(settings, 'ssh:box', 'defaultWorktreeLocation', '/local/work')
).toBe('/local/work')
})
it('falls back for an unknown host', () => {
const settings = settingsWith({ 'ssh:other': { defaultWorktreeLocation: '/x' } })
expect(
getEffectiveHostSetting(settings, 'runtime:env', 'defaultWorktreeLocation', '/local/work')
).toBe('/local/work')
})
it('treats a whitespace override as absent and falls back', () => {
const settings = settingsWith({ 'ssh:box': { defaultWorktreeLocation: ' ' } })
expect(
getEffectiveHostSetting(settings, 'ssh:box', 'defaultWorktreeLocation', '/local/work')
).toBe('/local/work')
})
it('allows local-host overrides', () => {
const settings = settingsWith({ local: { defaultWorktreeLocation: '/local/override' } })
expect(
getEffectiveHostSetting(settings, 'local', 'defaultWorktreeLocation', '/local/work')
).toBe('/local/override')
})
it('falls back when settings are null/undefined', () => {
expect(getEffectiveHostSetting(null, 'ssh:box', 'displayLabel', 'Default')).toBe('Default')
expect(getEffectiveHostSetting(undefined, 'ssh:box', 'displayLabel', 'Default')).toBe('Default')
})
})
describe('getHostSettingOverride', () => {
it('returns the override when present', () => {
const settings = settingsWith({ 'ssh:box': { displayLabel: 'My Box' } })
expect(getHostSettingOverride(settings, 'ssh:box', 'displayLabel')).toBe('My Box')
})
it('returns undefined when missing', () => {
expect(getHostSettingOverride(settingsWith({}), 'ssh:box', 'displayLabel')).toBeUndefined()
})
})
describe('setHostSettingOverride', () => {
it('adds an override for a new host', () => {
const next = setHostSettingOverride(settingsWith({}), 'ssh:box', 'displayLabel', 'Box')
expect(next).toEqual({ 'ssh:box': { displayLabel: 'Box' } })
})
it('merges into an existing host without clobbering other keys', () => {
const settings = settingsWith({ 'ssh:box': { displayLabel: 'Box' } })
const next = setHostSettingOverride(settings, 'ssh:box', 'defaultWorktreeLocation', '/w')
expect(next).toEqual({ 'ssh:box': { displayLabel: 'Box', defaultWorktreeLocation: '/w' } })
})
it('does not mutate the input map', () => {
const overrides = { 'ssh:box': { displayLabel: 'Box' } }
const settings = settingsWith(overrides)
setHostSettingOverride(settings, 'ssh:box', 'displayLabel', 'Renamed')
expect(overrides).toEqual({ 'ssh:box': { displayLabel: 'Box' } })
})
it('clears the key when given an empty value', () => {
const settings = settingsWith({
'ssh:box': { displayLabel: 'Box', defaultWorktreeLocation: '/w' }
})
const next = setHostSettingOverride(settings, 'ssh:box', 'displayLabel', ' ')
expect(next).toEqual({ 'ssh:box': { defaultWorktreeLocation: '/w' } })
})
})
describe('clearHostSettingOverride', () => {
it('removes a single key but keeps remaining overrides', () => {
const settings = settingsWith({
'ssh:box': { displayLabel: 'Box', defaultWorktreeLocation: '/w' }
})
expect(clearHostSettingOverride(settings, 'ssh:box', 'displayLabel')).toEqual({
'ssh:box': { defaultWorktreeLocation: '/w' }
})
})
it('drops the host entry when no overrides remain', () => {
const settings = settingsWith({ 'ssh:box': { displayLabel: 'Box' } })
expect(clearHostSettingOverride(settings, 'ssh:box', 'displayLabel')).toEqual({})
})
it('is a no-op for an unknown host', () => {
const settings = settingsWith({ 'ssh:other': { displayLabel: 'Other' } })
expect(clearHostSettingOverride(settings, 'ssh:box', 'displayLabel')).toEqual({
'ssh:other': { displayLabel: 'Other' }
})
})
it('does not mutate the input map', () => {
const overrides = { 'ssh:box': { displayLabel: 'Box' } }
const settings = settingsWith(overrides)
clearHostSettingOverride(settings, 'ssh:box', 'displayLabel')
expect(overrides).toEqual({ 'ssh:box': { displayLabel: 'Box' } })
})
})
describe('getHostDisplayLabelOverrides', () => {
it('collects non-empty display labels keyed by host id', () => {
const settings = settingsWith({
'ssh:box': { displayLabel: 'Box' },
'runtime:env': { defaultWorktreeLocation: '/w' },
local: { displayLabel: ' ' }
})
const map = getHostDisplayLabelOverrides(settings)
expect(map.get('ssh:box')).toBe('Box')
expect(map.has('runtime:env')).toBe(false)
expect(map.has('local')).toBe(false)
})
it('returns an empty map when no overrides exist', () => {
expect(getHostDisplayLabelOverrides(null).size).toBe(0)
})
})