mirror of
https://github.com/stablyai/orca.git
synced 2026-09-23 00:02:29 +00:00
Neil
77f23b013f
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as a re-export barrel so the import sites did not have to change. This removes the barrel: every consumer now imports from the module that actually declares the type, and `src/shared/types.ts` is deleted. Barrels hide where a type lives, make every consumer look like it depends on the whole domain, and let an unrelated edit invalidate a module that ~2,000 files transitively import. 2,323 import declarations across 2,321 files. Rewritten mechanically: each specifier was resolved to an absolute path via the TypeScript AST and recomputed, rather than string-substituted, so alias forms (`@/../../shared/ types`) and per-specifier `type` modifiers survive. Four cases the mechanical pass had to handle, each found by a gate rather than by reading the diff: - Modules inside `src/shared` import the barrel as `./types`, not `shared/types`. A pre-filter on the latter string skipped 176 of them and left imports dangling at a deleted file, which surfaced as confusing `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>` errors rather than "module not found". - The barrel RENAMED one type on the way through (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name in the owning module has to be re-aliased at each consumer. - Three test files put `;(globalThis as ...)` on the line after the import. TypeScript parses that `;` as the import statement's terminator, so replacing through `statement.getEnd()` deletes it and breaks ASI. The rewrite now stops at the module specifier. - A file that already imported directly from a module got a SECOND import from it, because the barrel re-exported those same names — which trips `import/no-duplicates` under `--deny-warnings`. A post-pass merges declarations sharing a specifier and type-only-ness; the `import type` plus `import` pair from one module is left alone, since that form is allowed. Splitting one barrel import into several genuinely adds lines, which pushed `terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character import must wrap, and neither local type collapses onto one line (101 and 116 characters). Rather than contort a type declaration to fit a line budget, `collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` — they are pure structural operations on the layout tree and independent of PTY ownership. `visible-worktrees.ts` similarly loses its own mini-barrel re-export of `isDefaultBranchWorkspace`, with the four real consumers repointed at the declaring module. No `max-lines` bypass added. Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted first — these projects are `composite: true` and reuse stale caches); the full `pnpm lint` green, not just bare oxlint — the narrower local check is what let the duplicate imports reach CI; max-lines ratchet OK at 344.
102 lines
3.0 KiB
TypeScript
102 lines
3.0 KiB
TypeScript
import type { ProviderCheckSummary } from './github/pull-request-types'
|
|
|
|
export type CheckOutcome = 'passed' | 'failed' | 'pending' | 'neutral'
|
|
|
|
export type CheckOutcomeInput = { status?: string | null; conclusion?: string | null }
|
|
|
|
// Why: a skipped job is a deliberate "not applicable", not an unresolved signal — every surface
|
|
// must count it as passing or the same PR reads green on desktop and grey on mobile.
|
|
const PASSED_CONCLUSIONS = new Set(['success', 'skipped'])
|
|
|
|
// Why: these block the merge. GitLab `manual` is deliberately absent — it waits on a human.
|
|
const FAILED_CONCLUSIONS = new Set([
|
|
'failure',
|
|
'error',
|
|
'startup_failure',
|
|
'timed_out',
|
|
'cancelled',
|
|
'action_required'
|
|
])
|
|
|
|
/** The single provider-neutral verdict for one check; every check surface must route through it. */
|
|
export function classifyCheckOutcome(check: CheckOutcomeInput): CheckOutcome {
|
|
const conclusion = (check.conclusion ?? '').toLowerCase()
|
|
const status = (check.status ?? '').toLowerCase()
|
|
if (FAILED_CONCLUSIONS.has(conclusion)) {
|
|
return 'failed'
|
|
}
|
|
if (PASSED_CONCLUSIONS.has(conclusion)) {
|
|
return 'passed'
|
|
}
|
|
// Why: anything that has not reached a terminal status is still running, whatever it calls itself.
|
|
if (conclusion === 'pending' || status !== 'completed') {
|
|
return 'pending'
|
|
}
|
|
return 'neutral'
|
|
}
|
|
|
|
/** Rolls up counted outcomes; passing checks win over neutral ones so one neutral cannot demote a green PR. */
|
|
export function resolveProviderCheckState(
|
|
counts: Pick<ProviderCheckSummary, 'total' | 'passed' | 'failed' | 'pending'>
|
|
): ProviderCheckSummary['state'] {
|
|
if (counts.total === 0) {
|
|
return 'none'
|
|
}
|
|
if (counts.failed > 0) {
|
|
return 'failure'
|
|
}
|
|
if (counts.pending > 0) {
|
|
return 'pending'
|
|
}
|
|
return counts.passed > 0 ? 'success' : 'neutral'
|
|
}
|
|
|
|
export function summarizeProviderChecks(
|
|
checks: readonly CheckOutcomeInput[]
|
|
): ProviderCheckSummary {
|
|
let passed = 0
|
|
let failed = 0
|
|
let pending = 0
|
|
let neutral = 0
|
|
for (const check of checks) {
|
|
const outcome = classifyCheckOutcome(check)
|
|
if (outcome === 'passed') {
|
|
passed += 1
|
|
} else if (outcome === 'failed') {
|
|
failed += 1
|
|
} else if (outcome === 'pending') {
|
|
pending += 1
|
|
} else {
|
|
neutral += 1
|
|
}
|
|
}
|
|
const total = checks.length
|
|
return {
|
|
state: resolveProviderCheckState({ total, passed, failed, pending }),
|
|
total,
|
|
passed,
|
|
failed,
|
|
pending,
|
|
neutral
|
|
}
|
|
}
|
|
|
|
/** The one checks-pill label; it keys off `state` so the text can never contradict the pill's tone or icon. */
|
|
export function getProviderChecksLabel(summary: ProviderCheckSummary | undefined): string {
|
|
if (!summary) {
|
|
return 'Checks'
|
|
}
|
|
if (summary.total === 0) {
|
|
return 'No checks'
|
|
}
|
|
if (summary.failed > 0) {
|
|
return `${summary.failed} failing`
|
|
}
|
|
if (summary.pending > 0) {
|
|
return `${summary.pending} pending`
|
|
}
|
|
return summary.state === 'neutral'
|
|
? 'Unresolved checks'
|
|
: `${summary.passed}/${summary.total} passed`
|
|
}
|