Files
Neil 231e805b1e fix(lint): enable anti-slop/no-shape-in-symbol-names (#20785)
Flip `anti-slop/no-shape-in-symbol-names` from "off" to "error" and clear
every violation under src, config, tests and mobile.

What the rule bans
------------------
The case-insensitive substring "shape" in any JS/TS identifier: variables,
functions, parameters, types, type parameters, class members, private names,
object-literal keys and JSX identifiers. The one exemption is a statically
accessed member read owned by another value (`zodObject.shape` is fine), so
third-party APIs stay readable without a suppression.

"Shape" names a value's structure rather than its domain role. `UserShape`,
`validateArgShape` and `errorShape` all tell you the symbol is "an object
with some fields" -- which is already what a type says -- while saying
nothing about what the value is for or who owns it. The rule forces the
name to carry the domain instead.

Violations fixed
----------------
689 violations across 109 files at baseline (verified by re-running the
audit against the pre-change tree with the rule set to "error").

Fix pattern
-----------
Rename for the domain role, not the structure:

  -type FieldShape = 'list' | 'map' | 'whole'
  -const FIELD_SHAPES = { ... } satisfies Record<keyof Observation, FieldShape>
  +type FieldEncoding = 'list' | 'map' | 'whole'
  +const FIELD_ENCODINGS = { ... } satisfies Record<keyof Observation, FieldEncoding>

  -function assertGitPushTargetShape(target: unknown): void
  +function assertValidGitPushTarget(target: unknown): void

  -function describeReadDirPathShape(p: string): ReadDirPathKind
  +function classifyReadDirPath(p: string): ReadDirPathKind

Predicates became statements about the value (`isDeltaShapedProviderFrameKind`
-> `isDeltaProviderFrameKind`, `isDeleteShapedDiscardEntry` ->
`discardDeletesEntryFile`, `isSkillsCliAgentKeyShaped` ->
`isUsableSkillsCliAgentKey`). Type aliases dropped the suffix where the
remaining name was already unambiguous (`GhGraphqlErrorShape` ->
`GhGraphqlError`).

No wire-visible name was renamed: no IPC or RPC channel, stream opcode,
request/response param, persisted field, or i18n key. The `--shape=symlink|copy`
CLI flag read by .github/workflows/skill-update-roundtrip.yml is unchanged --
only the local variable holding it was renamed.

Exemptions
----------
They are file-scoped entries in config/oxlint-anti-slop.json, not inline
`oxlint-disable` comments. An inline directive naming an anti-slop rule reads
back as an UNUSED directive under the root lint scan, which does not load this
plugin -- the changed-code quality gate counts that warning, so the comment form
cannot be used for a rule that lives only in this config.

* src/renderer/src/components/browser-pane/annotate/**:
  in the screenshot annotator a "shape" is the drawn geometry -- pen, arrow,
  rect, ellipse, highlight. That is a genuine domain noun, and it pervades
  every symbol in the module.
* repo-icon.tsx, repo-header-project-actions.tsx, mobile MobileRepoIcon.tsx:
  lucide exports the icon component as `Shapes`. The name is theirs, and the
  matching REPO_LUCIDE_ICONS key is the persisted icon name shared with the
  desktop picker -- renaming it would orphan saved repo icons.
* src/shared/onboarding-state-types.ts, src/shared/constants.ts:
  `shapedSidebar` is a persisted onboarding-checklist field and a telemetry
  enum member; renaming it would orphan saved state.
* src/shared/rpc-contract/rpc-send-params.ts: matching zod's own literal `shape`
  property is what selects the ZodObject branch of the conditional type.

No exemption was added merely to avoid a rename. Eight symbols initially
suppressed as "a cross-module refactor outside this change" were proven to have
zero non-TypeScript references repo-wide and renamed instead.

Zod's `ZodRawShape` needed no exemption at all: `Readonly<Record<string,
z.ZodType>>` is its definition, so repo-update-params.ts and
ui-update-value-tolerance-params.ts spell it out instead. Likewise
telemetry-event-classification.ts now reads `.shape` through an `in` narrowing,
which also retires two pre-existing type assertions; three more assertions the
rename had dragged onto changed lines (two `JSON.parse` sites, one node:sqlite
row read) became annotations and an explicit row mapping.

Verified
--------
* Audit reports zero violations; confirmed the rule genuinely fires by
  planting a probe violation.
* node config/scripts/run-typecheck-projects-in-parallel.mjs exits 0.
* Vitest over src/shared, src/main/github/project-view, the annotate module,
  the repo-icon components and the Chromium SameSite electron spec: all green.
* All 66 removed "shape" identifiers grepped repo-wide across every file type;
  none survive.
* node config/scripts/generate-rpc-params-catalog.mjs --check exits 0.
* node --check on every changed .mjs; oxfmt clean on all changed files.
* `pnpm run check:code-quality:changed` reports 0 findings.

Not machine-verified: the 3 mobile/ files (its Vitest run cannot resolve
`expo/tsconfig.base.json` in this worktree), and the WSL- and Playwright-gated
specs. All are rename- or comment-only hunks, read in full.
2026-09-15 02:00:27 -07:00

131 lines
5.0 KiB
JavaScript

// Argument parsing for `node run.mjs` (crash-survival harness).
//
// Unlike win-update-e2e, this harness installs nothing: it drives an ALREADY
// installed, packaged Orca.exe. So its only source is `--exe-path` (defaulting
// to the per-user install location). Exactly one profile (--expect) is required.
import { existsSync } from 'node:fs'
import path from 'node:path'
import { locateInstalledExe } from '../win-update-e2e/installer-steps.mjs'
const VALID_PROFILES = new Set(['survival', 'orphaned'])
const VALUE_FLAGS = new Set(['--expect', '--exe-path', '--soak-seconds'])
const BOOLEAN_FLAGS = new Set(['--keep-profile'])
const USAGE = `
win-crash-survival-e2e — packaged crash-survival proof harness (Windows only)
Proves that force-killing ONLY Orca's main process (a real crash, no tree-kill)
leaves the detached terminal daemon + its pwsh shell alive, with no pwsh FailFast
(0xE9 "No process is on the other end of the pipe"), and that a relaunch ADOPTS
the surviving daemon instead of forking a new one. See #7742.
Usage:
node tests/tools/win-crash-survival-e2e/run.mjs --expect <profile> [--exe-path <Orca.exe>] [options]
Required:
--expect <profile> Assertion profile:
survival = the fixed behavior (daemon + shell survive
the main crash, zero pwsh FailFast, relaunch adopts
the same daemon PID). This is what must keep passing.
orphaned = the OLD broken #7742 behavior (daemon dies
with main, pwsh FailFasts). Directional inverse used
to prove the harness actually catches a regression;
on a fixed build this profile is EXPECTED to fail.
Options:
--exe-path <path> Installed Orca.exe to drive (default: the per-user
install under %LOCALAPPDATA%\\Programs\\Orca). The
harness NEVER installs/uninstalls — it only launches
this exe against an isolated userData dir.
--soak-seconds <n> Post-crash observation window before relaunch (default: 8)
--keep-profile Skip temp-profile cleanup at teardown (for debugging)
-h, --help Show this help
`
export function parseArgs(argv) {
if (argv.includes('-h') || argv.includes('--help')) {
return { help: true, usage: USAGE }
}
const exePathFlagPresent = argv.includes('--exe-path')
const opts = {
// Only auto-locate on win32: off-win32 this would needlessly spawn powershell,
// and run.mjs asserts win32 first so the platform message wins over any
// "no Orca.exe found" default-resolution error.
exePath:
takeValue(argv, '--exe-path') ??
(process.platform === 'win32' ? locateInstalledExe() : undefined) ??
undefined,
expect: takeValue(argv, '--expect'),
soakSeconds: Number(takeValue(argv, '--soak-seconds') ?? '8'),
keepProfile: argv.includes('--keep-profile'),
usage: USAGE
}
const errors = validate(opts, exePathFlagPresent, argv)
return { ...opts, errors }
}
function validate(opts, exePathFlagPresent, argv) {
const errors = []
errors.push(...validateArgSyntax(argv))
if (!opts.expect) {
errors.push('Missing --expect <survival|orphaned>')
} else if (!VALID_PROFILES.has(opts.expect)) {
errors.push(`Invalid --expect "${opts.expect}" (expected survival or orphaned)`)
}
// Distinguish "--exe-path omitted" (fall back to auto-locate) from
// "--exe-path with no value" (a mistake that must fail, not silently default).
if (exePathFlagPresent && takeValue(argv, '--exe-path') === undefined) {
errors.push('--exe-path requires a path value')
} else if (!opts.exePath) {
errors.push(
'No installed Orca.exe found under %LOCALAPPDATA%\\Programs — pass --exe-path <Orca.exe>'
)
} else if (!existsSync(opts.exePath)) {
errors.push(`--exe-path does not exist: ${opts.exePath}`)
} else if (!path.isAbsolute(opts.exePath)) {
errors.push(`--exe-path must be an absolute path (got "${opts.exePath}")`)
}
if (!Number.isFinite(opts.soakSeconds) || opts.soakSeconds < 0) {
errors.push('--soak-seconds must be a non-negative number')
}
return errors
}
function validateArgSyntax(argv) {
const errors = []
const seen = new Set()
for (let index = 0; index < argv.length; index++) {
const arg = argv[index]
if (!VALUE_FLAGS.has(arg) && !BOOLEAN_FLAGS.has(arg)) {
errors.push(`Unknown argument: ${arg}`)
continue
}
if (seen.has(arg)) {
errors.push(`Duplicate argument: ${arg}`)
}
seen.add(arg)
if (VALUE_FLAGS.has(arg)) {
const value = argv[index + 1]
if (value !== undefined && !value.startsWith('--')) {
index++
}
}
}
return errors
}
function takeValue(argv, flag) {
const idx = argv.indexOf(flag)
if (idx === -1) {
return undefined
}
const value = argv[idx + 1]
if (value === undefined || value.startsWith('--')) {
return undefined
}
return value
}