mirror of
https://github.com/stablyai/orca.git
synced 2026-09-22 16:02:32 +00:00
Jinwoo Hong
dd9eaa9585
* fix(cloud): retry the committed-winner collision codes in relay schema startup `CREATE TABLE IF NOT EXISTS` only checks the name before the catalog inserts, so the loser of a concurrent CREATE fails in one of two ways depending on timing: on the catalog unique index (23505, which the startup retry already handled) or, when the winner has committed by the time the loser reaches TypeCreate / heap_create_with_catalog, on the name check those routines repeat (42710 duplicate type, 42P07 duplicate relation). The predicate treated the latter as fatal, so a director could fail startup on a table it was about to find present. This is what turned `postgres-schema-concurrency-postgres.test.ts` red on main and on every relay PR (CI's shared runner loses the race more often than a dev box): a throwaway diagnostic run in CI reported 42710 from TypeCreate and 42P07 from heap_create_with_catalog as the only rejection reasons. Treat 42710/42P07 as retryable for `CREATE TABLE IF NOT EXISTS` and 42P07 for `CREATE [UNIQUE] INDEX IF NOT EXISTS`; every other statement shape still fails fast. The concurrency test now runs ten rounds and reports the loser's SQLSTATE instead of a bare boolean. * chore(cloud): allowlist the RFC 6455 example Sec-WebSocket-Key for upgrade tests Cloud Verify's Secret scan runs gitleaks over --all refs, so the raw-socket upgrade test on fix/relay-upgrade-malformed-uri (#18547) trips every cloud PR's scan until its allowlist reaches main. Land the allowlist here first.
23 lines
955 B
TOML
23 lines
955 B
TOML
[extend]
|
|
useDefault = true
|
|
|
|
[[allowlists]]
|
|
description = "Explicit Relay test signing key"
|
|
regexTarget = "secret"
|
|
regexes = ['''^test-assignment-key-with-at-least-32-bytes$''']
|
|
|
|
# The Cloud SQL rollout lease records `owner/repo/run_id` as the holder of a lease. The action's
|
|
# unit tests build fixture holders from that shape, which the generic key rule reads as a secret.
|
|
[[allowlists]]
|
|
description = "Cloud SQL rollout lease holder keys in the action's unit tests"
|
|
regexTarget = "secret"
|
|
paths = ['''\.github/actions/cloud-sql-rollout-lease/[a-z-]+\.test\.mjs$''']
|
|
regexes = ['''^[A-Za-z0-9_.-]+/[A-Za-z0-9_.-]+/[0-9]+$''']
|
|
|
|
# RFC 6455 §1.3 example handshake nonce ("the sample nonce" in base64), sent by the raw-socket
|
|
# upgrade tests; the generic key rule reads any base64 header value as a secret.
|
|
[[allowlists]]
|
|
description = "RFC 6455 example Sec-WebSocket-Key in upgrade tests"
|
|
regexTarget = "secret"
|
|
regexes = ['''^dGhlIHNhbXBsZSBub25jZQ==$''']
|