mirror of
https://github.com/stablyai/orca.git
synced 2026-09-26 00:02:34 +00:00
Neil
fdfe354045
A control-handshake test that expects a timeout was instead getting
'Unexpected server response: 401' about once in fourteen runs. A slow machine
cannot turn a timeout into a 401 -- that needs a real HTTP response, so the
connection was reaching a different server.
new WebSocketServer({ port: 0 }) binds the wildcard address while the client
dials 127.0.0.1. On macOS those differ, and with SO_REUSEADDR a foreign process
can hold the more specific 127.0.0.1:P and win the connection. Caught live: a
wildcard bind took port 52584, which a running Orca app already held on
loopback, and Orca answered the probe. A listener that checks a token answers
401.
Ten constructions across seven files now pass host: '127.0.0.1', so the
reservation covers the address the client dials and a duplicate bind is refused.
Adds a ratchet, because this is not authors forgetting a convention: all 30+
.listen(0, ...) sites already pass '127.0.0.1', while 7 of 7 ws constructions
did not. ws accepts { port } alone and binds the wildcard silently, so nothing
told them. The guard pins the wildcard count, and pins separately at zero the
option shapes it cannot read -- spreads and variable option objects fail rather
than being exempted, and a recognized-construction floor catches the matcher
going blind, which otherwise reads exactly like a clean tree.
mobile/scripts/mock-server.ts stays on the wildcard deliberately: a phone
reaches it over the LAN.
15 lines
765 B
Plaintext
15 lines
765 B
Plaintext
# Files allowed to construct a `ws` server that binds a port without pinning `host`.
|
|
#
|
|
# `ws` accepts `{ port }` alone and silently binds the wildcard address. A server
|
|
# reached over 127.0.0.1 must pin `host: '127.0.0.1'`, or a foreign loopback
|
|
# listener can hold the same port and answer in its place -- which is how
|
|
# relay-control-client.test.ts came to fail with a real HTTP 401 in a test that
|
|
# was simulating silence.
|
|
#
|
|
# This list only shrinks. Adding a line also requires raising the pin in
|
|
# websocket-server-loopback-bind.test.ts, which is deliberate friction.
|
|
|
|
# Deliberate, not drift: this mock is dialled by a phone on the LAN, so it has to
|
|
# be reachable on a real interface. A loopback bind would make it unreachable.
|
|
mobile/scripts/mock-server.ts
|