Files
orca/tests/e2e/agent-workspace-trust-first-launch.spec.ts
Neil 090945007b Ask once per repo before pre-trusting agent folders (#38946)
* Ask once per repo before pre-trusting agent folders

* Route the trust prompt's repo lookup by the launch host; use dialog primitives as designed

* Bound the first-launch trust hold and honour the answer for the launch

* Move agent folder trust settings into their own settings group
2026-11-06 17:02:46 -08:00

85 lines
3.4 KiB
TypeScript

import type { Page } from '@stablyai/playwright-test'
import { expect, test } from './helpers/orca-app'
import {
configureGoldenStubAgent,
getGoldenStubAgentLaunchEnv,
GOLDEN_STUB_READY_MARKER
} from './helpers/golden-stub-agent'
import { addRepoWithWorkspaces } from './helpers/repo-with-workspaces'
import { ensureTerminalVisible, switchToWorktree, waitForSessionReady } from './helpers/store'
import { focusActiveTerminalInput, waitForTerminalOutput } from './helpers/terminal'
test.use({ launchEnv: getGoldenStubAgentLaunchEnv() })
const CLAUDE_MENU_ITEM = /^Claude(?:\s|$)/i
async function startClaudeFromNewTab(page: Page): Promise<void> {
await page.getByRole('button', { name: 'New tab' }).click({ force: true })
const launchOption = page.getByRole('menuitem', { name: CLAUDE_MENU_ITEM }).first()
await expect(launchOption).toBeVisible({ timeout: 15_000 })
await launchOption.click({ force: true })
}
async function waitForAgentReady(page: Page): Promise<void> {
await focusActiveTerminalInput(page)
await waitForTerminalOutput(page, GOLDEN_STUB_READY_MARKER, 20_000)
}
async function readRepoDecision(page: Page, repoId: string): Promise<string | null> {
return page.evaluate(
(id) =>
window.__store?.getState().repos.find((repo) => repo.id === id)?.agentWorkspaceTrust ?? null,
repoId
)
}
test('the first agent launch in a new repo asks once, and its worktrees share the answer', async ({
orcaPage
}, testInfo) => {
await waitForSessionReady(orcaPage)
await configureGoldenStubAgent(orcaPage, { agent: 'claude' })
// A repo added now has no stored answer, like a fresh clone after the upgrade.
const { repoId, mainId, ids } = await addRepoWithWorkspaces(orcaPage, testInfo, 1)
await switchToWorktree(orcaPage, mainId)
await ensureTerminalVisible(orcaPage)
await startClaudeFromNewTab(orcaPage)
const prompt = orcaPage.getByRole('dialog', { name: /for agents\?$/ })
await expect(prompt).toBeVisible({ timeout: 15_000 })
await orcaPage.screenshot({ path: testInfo.outputPath('first-launch-prompt.png') })
expect(await readRepoDecision(orcaPage, repoId)).toBeNull()
await prompt.getByRole('button', { name: 'Let agents ask', exact: true }).click()
await expect(prompt).toBeHidden()
await waitForAgentReady(orcaPage)
expect(await readRepoDecision(orcaPage, repoId)).toBe('agent-asks')
// Another worktree of the same repo reuses the stored answer.
const [sibling] = ids
if (!sibling) {
throw new Error('the repo needs a second worktree')
}
await switchToWorktree(orcaPage, sibling)
await ensureTerminalVisible(orcaPage)
await startClaudeFromNewTab(orcaPage)
await waitForAgentReady(orcaPage)
await expect(prompt).toHaveCount(0)
await orcaPage.evaluate((id) => {
const state = window.__store?.getState()
state?.setSettingsSearchQuery('')
state?.openSettingsTarget({ pane: 'repo', repoId: id })
state?.openSettingsPage()
}, repoId)
const trustControl = orcaPage.getByRole('radiogroup', { name: 'Agent Folder Trust' })
await trustControl.scrollIntoViewIfNeeded()
await expect(trustControl.getByRole('radio', { name: 'Let agents ask' })).toHaveAttribute(
'aria-checked',
'true'
)
await orcaPage.screenshot({ path: testInfo.outputPath('repo-setting.png') })
await trustControl.getByRole('radio', { name: 'Trust repository' }).click()
await expect.poll(() => readRepoDecision(orcaPage, repoId)).toBe('pre-trust')
})