mirror of
https://github.com/stablyai/orca.git
synced 2026-09-22 08:02:28 +00:00
Neil
77f23b013f
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as a re-export barrel so the import sites did not have to change. This removes the barrel: every consumer now imports from the module that actually declares the type, and `src/shared/types.ts` is deleted. Barrels hide where a type lives, make every consumer look like it depends on the whole domain, and let an unrelated edit invalidate a module that ~2,000 files transitively import. 2,323 import declarations across 2,321 files. Rewritten mechanically: each specifier was resolved to an absolute path via the TypeScript AST and recomputed, rather than string-substituted, so alias forms (`@/../../shared/ types`) and per-specifier `type` modifiers survive. Four cases the mechanical pass had to handle, each found by a gate rather than by reading the diff: - Modules inside `src/shared` import the barrel as `./types`, not `shared/types`. A pre-filter on the latter string skipped 176 of them and left imports dangling at a deleted file, which surfaced as confusing `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>` errors rather than "module not found". - The barrel RENAMED one type on the way through (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name in the owning module has to be re-aliased at each consumer. - Three test files put `;(globalThis as ...)` on the line after the import. TypeScript parses that `;` as the import statement's terminator, so replacing through `statement.getEnd()` deletes it and breaks ASI. The rewrite now stops at the module specifier. - A file that already imported directly from a module got a SECOND import from it, because the barrel re-exported those same names — which trips `import/no-duplicates` under `--deny-warnings`. A post-pass merges declarations sharing a specifier and type-only-ness; the `import type` plus `import` pair from one module is left alone, since that form is allowed. Splitting one barrel import into several genuinely adds lines, which pushed `terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character import must wrap, and neither local type collapses onto one line (101 and 116 characters). Rather than contort a type declaration to fit a line budget, `collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` — they are pure structural operations on the layout tree and independent of PTY ownership. `visible-worktrees.ts` similarly loses its own mini-barrel re-export of `isDefaultBranchWorkspace`, with the four real consumers repointed at the declaring module. No `max-lines` bypass added. Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted first — these projects are `composite: true` and reuse stale caches); the full `pnpm lint` green, not just bare oxlint — the narrower local check is what let the duplicate imports reach CI; max-lines ratchet OK at 344.
144 lines
4.4 KiB
TypeScript
144 lines
4.4 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import { buildGitHubCheckSummary, type GitHubCheckLike } from './github-check-summary'
|
|
import { buildGitLabCheckSummary } from './gitlab-check-summary'
|
|
import { summarizeProviderChecks } from '../../../src/shared/provider-check-summary'
|
|
import type { ProviderCheckSummary } from '../../../src/shared/github/pull-request-types'
|
|
|
|
describe('buildGitHubCheckSummary', () => {
|
|
it('returns none for empty check lists', () => {
|
|
expect(buildGitHubCheckSummary([])).toEqual({
|
|
state: 'none',
|
|
total: 0,
|
|
passed: 0,
|
|
failed: 0,
|
|
pending: 0,
|
|
neutral: 0
|
|
})
|
|
})
|
|
|
|
it('prioritizes failed checks over pending checks', () => {
|
|
expect(
|
|
buildGitHubCheckSummary([
|
|
{ status: 'completed', conclusion: 'success' },
|
|
{ status: 'queued', conclusion: null },
|
|
{ status: 'completed', conclusion: 'timed_out' }
|
|
])
|
|
).toEqual({
|
|
state: 'failure',
|
|
total: 3,
|
|
passed: 1,
|
|
failed: 1,
|
|
pending: 1,
|
|
neutral: 0
|
|
})
|
|
})
|
|
|
|
it('keeps neutral and unknown terminal conclusions out of passed without demoting the PR', () => {
|
|
expect(
|
|
buildGitHubCheckSummary([
|
|
{ status: 'completed', conclusion: 'success' },
|
|
{ status: 'completed', conclusion: 'neutral' }
|
|
])
|
|
).toEqual({
|
|
state: 'success',
|
|
total: 2,
|
|
passed: 1,
|
|
failed: 0,
|
|
pending: 0,
|
|
neutral: 1
|
|
})
|
|
})
|
|
|
|
it('rolls up GitLab jobs with unknown terminal statuses as neutral', () => {
|
|
expect(buildGitLabCheckSummary([{ status: 'success' }, { status: 'future_status' }])).toEqual({
|
|
state: 'success',
|
|
total: 2,
|
|
passed: 1,
|
|
failed: 0,
|
|
pending: 0,
|
|
neutral: 1
|
|
})
|
|
})
|
|
})
|
|
|
|
type ParityCase = {
|
|
name: string
|
|
checks: GitHubCheckLike[]
|
|
expected: Omit<ProviderCheckSummary, 'total'>
|
|
}
|
|
|
|
const completed = (conclusion: string): GitHubCheckLike => ({ status: 'completed', conclusion })
|
|
|
|
const PARITY_CASES: ParityCase[] = [
|
|
{
|
|
name: 'all success',
|
|
checks: [completed('success'), completed('success')],
|
|
expected: { state: 'success', passed: 2, failed: 0, pending: 0, neutral: 0 }
|
|
},
|
|
{
|
|
name: 'success plus skipped',
|
|
checks: [completed('success'), completed('skipped')],
|
|
expected: { state: 'success', passed: 2, failed: 0, pending: 0, neutral: 0 }
|
|
},
|
|
{
|
|
name: 'all skipped',
|
|
checks: [completed('skipped'), completed('skipped')],
|
|
expected: { state: 'success', passed: 2, failed: 0, pending: 0, neutral: 0 }
|
|
},
|
|
{
|
|
name: 'success plus neutral',
|
|
checks: [completed('success'), completed('neutral')],
|
|
expected: { state: 'success', passed: 1, failed: 0, pending: 0, neutral: 1 }
|
|
},
|
|
{
|
|
name: 'all neutral',
|
|
checks: [completed('neutral')],
|
|
expected: { state: 'neutral', passed: 0, failed: 0, pending: 0, neutral: 1 }
|
|
},
|
|
{
|
|
name: 'success plus failure',
|
|
checks: [completed('success'), completed('failure')],
|
|
expected: { state: 'failure', passed: 1, failed: 1, pending: 0, neutral: 0 }
|
|
},
|
|
{
|
|
name: 'success plus running',
|
|
checks: [completed('success'), { status: 'in_progress', conclusion: null }],
|
|
expected: { state: 'pending', passed: 1, failed: 0, pending: 1, neutral: 0 }
|
|
},
|
|
{
|
|
name: 'genuine action_required',
|
|
checks: [completed('success'), completed('action_required')],
|
|
expected: { state: 'failure', passed: 1, failed: 1, pending: 0, neutral: 0 }
|
|
}
|
|
]
|
|
|
|
describe('mobile / desktop check classification parity', () => {
|
|
it.each(PARITY_CASES)('$name matches the shared desktop classifier', ({ checks, expected }) => {
|
|
const summary = { ...expected, total: checks.length }
|
|
expect(buildGitHubCheckSummary(checks)).toEqual(summary)
|
|
expect(summarizeProviderChecks(checks)).toEqual(summary)
|
|
})
|
|
|
|
it.each([
|
|
{
|
|
name: 'GitLab manual gate only',
|
|
statuses: ['manual'],
|
|
expected: { state: 'neutral', passed: 0, failed: 0, pending: 0, neutral: 1 }
|
|
},
|
|
{
|
|
name: 'GitLab manual gate alongside a green pipeline',
|
|
statuses: ['manual', 'success'],
|
|
expected: { state: 'success', passed: 1, failed: 0, pending: 0, neutral: 1 }
|
|
}
|
|
] satisfies {
|
|
name: string
|
|
statuses: string[]
|
|
expected: Omit<ProviderCheckSummary, 'total'>
|
|
}[])('$name never reads as failing', ({ statuses, expected }) => {
|
|
expect(buildGitLabCheckSummary(statuses.map((status) => ({ status })))).toEqual({
|
|
...expected,
|
|
total: statuses.length
|
|
})
|
|
})
|
|
})
|